From: Robert Varga <robert.varga@pantheon.tech>
Date: Thu, 28 Jul 2022 18:24:50 +0000 (+0200)
Subject: Turn NetconfMessageConstants into a final class
X-Git-Tag: v4.0.0~8
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=netconf.git;a=commitdiff_plain;h=4c49398a85911278e3a5ac5a6ce3d5f3261b65a6

Turn NetconfMessageConstants into a final class

Keeping constants in an interface is an antipattern, correct that.

Change-Id: I71a49126ec05107dc09ff05e47d16ba461d92e9d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/netconf/netconf-util/src/main/java/org/opendaylight/netconf/util/messages/NetconfMessageConstants.java b/netconf/netconf-util/src/main/java/org/opendaylight/netconf/util/messages/NetconfMessageConstants.java
index df5b4bc8d3..db2387530d 100644
--- a/netconf/netconf-util/src/main/java/org/opendaylight/netconf/util/messages/NetconfMessageConstants.java
+++ b/netconf/netconf-util/src/main/java/org/opendaylight/netconf/util/messages/NetconfMessageConstants.java
@@ -5,25 +5,29 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.netconf.util.messages;
 
-public interface NetconfMessageConstants {
+import org.eclipse.jdt.annotation.NonNullByDefault;
 
+@NonNullByDefault
+public final class NetconfMessageConstants {
     /**
-     * The NETCONF 1.0 old-style message separator. This is framing mechanism
-     * is used by default.
+     * The NETCONF 1.0 old-style message separator. This is framing mechanism is used by default.
      */
-    String END_OF_MESSAGE = "]]>]]>";
+    public static final String END_OF_MESSAGE = "]]>]]>";
 
     // bytes
-
-    int MIN_HEADER_LENGTH = 4;
+    @Deprecated(since = "3.0.6", forRemoval = true)
+    public static final int MIN_HEADER_LENGTH = 4;
 
     // bytes
+    @Deprecated(since = "3.0.6", forRemoval = true)
+    public static final int MAX_HEADER_LENGTH = 13;
 
-    int MAX_HEADER_LENGTH = 13;
+    public static final String START_OF_CHUNK = "\n#";
+    public static final String END_OF_CHUNK = "\n##\n";
 
-    String START_OF_CHUNK = "\n#";
-    String END_OF_CHUNK = "\n##\n";
+    private NetconfMessageConstants() {
+        // Hidden on purpose
+    }
 }