From: Robert Varga <robert.varga@pantheon.tech>
Date: Mon, 28 Oct 2019 12:45:05 +0000 (+0100)
Subject: Do not use toString() in looging messages
X-Git-Tag: release/neon-sr3~5
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=netconf.git;a=commitdiff_plain;h=4e5846ad7c1f8bf452fa89e0f9409ac648fccd90

Do not use toString() in looging messages

This eliminates unnecessary toString() calls, as logging implementation
will call it when necessary.

Change-Id: Ic3b45b9ae34c29951ed6eea94cae39c423b6ec26
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9be412d7d6acf298a740e8325f1382422e32afa1)
---

diff --git a/netconf/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSession.java b/netconf/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSession.java
index bb0964bb58..a08f52d1ca 100644
--- a/netconf/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSession.java
+++ b/netconf/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSession.java
@@ -69,7 +69,7 @@ public final class NetconfServerSession extends AbstractNetconfSession<NetconfSe
         super(sessionListener, channel, sessionId);
         this.header = header;
         this.sessionListener = sessionListener;
-        LOG.debug("Session {} created", toString());
+        LOG.debug("Session {} created", this);
     }
 
     @Override
diff --git a/netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/AbstractNetconfSession.java b/netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/AbstractNetconfSession.java
index 045b6d6d3e..aab5b6d0c0 100644
--- a/netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/AbstractNetconfSession.java
+++ b/netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/AbstractNetconfSession.java
@@ -88,7 +88,7 @@ public abstract class AbstractNetconfSession<S extends NetconfSession,L extends
     }
 
     protected void endOfInput() {
-        LOG.debug("Session {} end of input detected while session was in state {}", toString(), isUp() ? "up"
+        LOG.debug("Session {} end of input detected while session was in state {}", this, isUp() ? "up"
                 : "initialized");
         if (isUp()) {
             this.sessionListener.onSessionDown(thisInstance(),
@@ -97,7 +97,7 @@ public abstract class AbstractNetconfSession<S extends NetconfSession,L extends
     }
 
     protected void sessionUp() {
-        LOG.debug("Session {} up", toString());
+        LOG.debug("Session {} up", this);
         sessionListener.onSessionUp(thisInstance());
         this.up = true;
     }
diff --git a/netconf/netconf-util/src/main/java/org/opendaylight/netconf/util/NetconfConfigurationImpl.java b/netconf/netconf-util/src/main/java/org/opendaylight/netconf/util/NetconfConfigurationImpl.java
index 42c7b58871..d541979ec6 100644
--- a/netconf/netconf-util/src/main/java/org/opendaylight/netconf/util/NetconfConfigurationImpl.java
+++ b/netconf/netconf-util/src/main/java/org/opendaylight/netconf/util/NetconfConfigurationImpl.java
@@ -63,7 +63,7 @@ public class NetconfConfigurationImpl implements NetconfConfiguration, ManagedSe
                 sshServerAddress,
                 (String) dictionaryConfig.get(SSH_PK_PATH_PROP));
 
-        LOG.debug("CSS netconf server configuration was updated: {}", dictionaryConfig.toString());
+        LOG.debug("CSS netconf server configuration was updated: {}", dictionaryConfig);
     }
 
     @Override
@@ -80,4 +80,4 @@ public class NetconfConfigurationImpl implements NetconfConfiguration, ManagedSe
     public String getPrivateKeyPath() {
         return netconfConfiguration.getPrivateKeyPath();
     }
-}
\ No newline at end of file
+}