BUG-8923: eliminate another reference to bcprov

bouncy castle is provided by the platform, we should not be pulling
it in.

Change-Id: Icdce53c7b876b9ef834c194c3263ca2268c674a4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-8923: do not install bouncycastle

These bundles are provided by odlparent's substrate, hence we should
not be mentioning them.

Change-Id: I4435629686d31cf7d84c8bd768389dc518193fe5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge changes from topic 'protocol-framework'

* changes:
  Activate protocol-framework artifacts
  Cleanup build system

Merge "Bug 5825: Migrate restconf to the new XML parser #2"

Merge "Bug 5824: Migrate netconf to the new XML parser #2"

Avoid spurious WARN in NetconfClientConfiguration

Change-Id: I7b010183de605f207451de975fb1cde238460d1e
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Bump all Odlparent dependencies to 2.0.2

Change-Id: I1b51dce8036333ca4562219e7f586048c98e9b8a
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Bug 5825: Migrate restconf to the new XML parser #2

Migrate restconf components to the new XML parser from YANG tools

Change-Id: I2011904cb30f69fdb798f735292a8383049cda6b
Signed-off-by: Igor Foltin <igor.foltin@pantheon.tech>

BUG-7891: Remove odl-netconf-ssh feature prerequisites

This works in my setup. After removing the prerequisite dependency
I do not see anymore the server unhealthy issue.

Change-Id: I54eac80cd987474747ea47f652414245a893470c
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Bug 5824: Migrate netconf to the new XML parser #2

Migrate netconf components to the new XML parser from YANG tools.

Change-Id: I0cd30ea671239fad986d173bd4be845701d6e968
Signed-off-by: Igor Foltin <igor.foltin@pantheon.tech>

Activate protocol-framework artifacts

This adds protocol-framework to compilation

Change-Id: I979961389495d1c7ea0ac045f94576307a170697
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup build system

Clean up pom.xmls, to eliminate dupliciate aggragator
functions, properly import upstream artifacts and correct
relativePath declarations.

Change-Id: I0786e5fdf207ad544a7bb5c72e035be78b867b5e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove logback related stuff

as discussed on https://lists.opendaylight.org/pipermail/odlparent-dev/2017-July/001262.html

tools/netconf-testtool doesn't seem to really require logback-config

netconf-it appears to be completely broken anyway, and is not in build

Change-Id: Ia7fde3529b3b4f5940fe2d143d35230a12b072af
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Cleanup unused config subsystem dependencies

Change-Id: I25816dd6ed2b0dd11b40d6dd68549a061380a6ae
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

More migration to odlparent 2.0.2

Some odlparent artifacts were missed in the original migration to
odlparent 2, and were still on 1.9.0. This patch fixes that.

Change-Id: I2a74a7f7b97135e9f149896dbd13e5ab6c7e19d9
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add 'features/protocol-framework/' from commit 'cb42405784db97d0ce2c5991d12a89b46d185949'

Change-Id: I60f397e609aa0f26dbb39c4c5bab17a6b0d8b447
git-subtree-dir: features/protocol-framework
git-subtree-mainline: 6d7e12bf3ef64e5004703a1d540e7e26f30a9595
git-subtree-split: cb42405784db97d0ce2c5991d12a89b46d185949
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add 'protocol-framework/' from commit '5d015c2c5f800d136406c15fcb64fd531d4ffc26'

Change-Id: I206dca66b860abaa9bc25615d42703c638bf5b3f
git-subtree-dir: protocol-framework
git-subtree-mainline: 21588aadb96699b6f4f87e2cbbbb08fe1e38ed78
git-subtree-split: 5d015c2c5f800d136406c15fcb64fd531d4ffc26
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge changes I6575ddd8,I4b78f51d,I0a0441e6

* changes:
  Cleanup Precondtions in singleton
  Cleanup Throwable catches
  Cleanup NetconfDevice

Cleanup Precondtions in singleton

Use Verify when appropirate.
Use Assert in UT.

Change-Id: I6575ddd8d4292a0e2b71048a9939abb420aeccba
Signed-off-by: Tomas Cere <tcere@cisco.com>

Cleanup Throwable catches

Change-Id: I4b78f51d13b5cd027451f1a62ff90642ed39ef0f
Signed-off-by: Tomas Cere <tcere@cisco.com>

Cleanup NetconfDevice

Change-Id: I0a0441e662ca78e8d6d6841cc48279b293422d1b
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Bug 5824: Migrate netconf to the new XML parser"

Merge "Bug 8745: Migrate EditConfig to the new XML parser"

Bug 5825: Migrate restconf to the new XML parser

Migrate restconf components to the new XML parser from YANG tools

Change-Id: I87aa8df157ca5cba953852415c49806f2c61ff7b
Signed-off-by: Igor Foltin <igor.foltin@pantheon.tech>

Bug 5824: Migrate netconf to the new XML parser

Migrate netconf components to the new XML parser from YANG tools.

Change-Id: I42899d4d07cb2f917c50fa862cd6453bb0a8764d
Signed-off-by: Igor Foltin <igor.foltin@pantheon.tech>

Bug 8745: Migrate EditConfig to the new XML parser

Switch EditConfig class to use the new XML parser from YANG tools.

Introduce EditOperationNormalizedNodeStreamWriter as a replacement
of the old XML parser extension EditOperationStrategyProvider which
has been used for tracking edit-config data tree operations defined
in the parsed XML source.

Remove EditOperationStrategyProvider as it is not needed anymore.

Change-Id: I737b134805120368a352568fde3f19517a9871df
Signed-off-by: Igor Foltin <igor.foltin@pantheon.tech>

Bug 8824 - NETCONF request hangs when rpc-rply has invalid xml

The decoder handler is blindly throwing the SAXException but
nobody is there to intercept it. Also, as we're in the netty
world, to be able to propagate the exception, we're using the
NetconfMessage POJO.
That latest has been modified to accept either the decoded message
or an exception, if exception is thrown.

Change-Id: I62af5a885cc4e9f459c4aa71871b7d9331c4b946
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>

Bug 8832 - rpc-error in keepalive rpc-reply shouldn't bounce the session

Change-Id: I2ef4153b5910e56c3401c08d57465741f1002691
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>

Do not pull in yang-maven-plugin

This plugin is not used and pollutes the build environment with
incorrect version.

Change-Id: I55512253dc8a034274c79b095906b017190f0dfa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove JSON restconf-service config yang and Module classes

The module provides a service but it isn't widely used and most
likely any consumers have been converted to blueprint. Otherwise
a consumer still using CSS would need to be converted to
blueprint which is the future direction anyway.

Change-Id: I7e821df7e7a3efb48e75cea9d6ead3d45929c9b7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Merge "Remove rest-connector config yang and Module classes"

Merge "Add JSONRestconfService impl for the restconf Draft18 impl"

Merge "Remove <Embed-Dependency> in netconf-config pom"

Remove rest-connector config yang and Module classes

The rest-connector has been converted to blueprint so the config
yang is no longer needed.

Change-Id: I1fb107c7eec3699b53eb2109afb6d13573c14b88
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Remove <Embed-Dependency> in netconf-config pom

The pom embeds the threadpool-config-impl dependency. Not sure exactly
why this was done but I suspect as a work around for the java imports from
the blueprint XML not being included in <Import-Package>. We should not
embed the dependency. The maven-bundle-plugin can scan blueprint XML files
but there is an issue with using it so we can instead add the necessary
packages to <Import-Package>.

Change-Id: Ice33dd0e7b7f75f9d277d83ab05e6c8303867ed4
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Upgrade to odlparent 2.0.2

Change-Id: I9660748964bf09f3db84481c62e7cce7843ef7bd
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Simplify RC4 removal

Change-Id: Ib26c8c7a7bad5e156f33c444593db0c161af0b59
Signed-off-by: Tomas Cere <tcere@cisco.com>

Use RSA for ssh server

The bouncy-castle bump increased the default size of DSA to 2048 which
some clients can choke on. We shouldn't use DSA anyhow so switch it up
to 4096 RSA everywhere.

Change-Id: I936eb240a534367fff550d25dcedc3de069c6654
Signed-off-by: Tomas Cere <tcere@cisco.com>

Upgrade to odlparent 2.0.2

Change-Id: I748830e39c108056ecd81809a0556e8c43d251f4
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Upgrade to odlparent 2.0.2

Change-Id: I748830e39c108056ecd81809a0556e8c43d251f4
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Bug 8725: Remove netconf device mounting via the config system"

Merge "Skip SFT in features-netconf-connector"

Add JSONRestconfService impl for the restconf Draft18 impl

Added a JSONRestconfServiceDraft18 implementation class that uses the
restconf Draft18 impl and the blueprint wiring to instantiate and advertise
it. The original Draft02 JSONRestconfServiceImpl remains.

Change-Id: Ieab9c606ff40659bfe9d1a62ced7bf80891aa01a
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Bug 8725: Remove netconf device mounting via the config system

Change-Id: Ida7a236f0bd75978e07a64b38497ccf8aa75fea8
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Bump odlparent dependency to 2.0.1

Bumps odlparent to latest release.

Change-Id: Ifaf36c6539206ec5c35663717b691a0d962d1744
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent dependency to 2.0.1

Bumps odlparent to latest release.

Change-Id: Ifaf36c6539206ec5c35663717b691a0d962d1744
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-8752: apidoc explorer show/hide and list operations no longer works

This patch fixes the APIdoc explorer after change from
org.json to jackson

Change-Id: I9168c5aa08b820df38ac9a2413abba08a567cccf
Signed-off-by: Yrineu Rodrigues <yrineu.rodrigues@serro.com>

Skip SFT in features-netconf-connector

odl-netconf-clustered-topology and odl-netconf-topology are mutually
exclusive so running SFT may fail intermittently due to timing. This
will be addressed in a future release of odlparent to disable SFT
for feature-repo-parent by default and we can revert this later
although it doesn't hurt to disable locally.

Change-Id: Id91e36ea857179beba0e4a862ca9ab1821735025
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Merge "Use final field as lock in AsyncSshHandlerWriter"

Merge "Bug 8071 - Do not fail on modules with invalid revision during            resolution of ietf-netconf-yang-library/modules-state node"

Use final field as lock in AsyncSshHandlerWriter

Change-Id: I355e626b90e5cd27dfb5da96ef76c13a36f77dde
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>

Bug 8124 - get-schema rpc fails to send error message

Change-Id: If2d87beec2dd8c1b3579d10ddcb008d35effa289
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>

Merge "Remove the need for synthetic methods"

Merge "Make netconf utilize encrypted passwords only"

Merge "Convert yanglib project to blueprint"

Make netconf utilize encrypted passwords only

Change-Id: I5c178c4e3865e374f39e326ceb9c4e24be269590
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Signed-off-by: Atul Gosain <agosain@brocade.com>
Signed-off-by: Colin Dixon <colin@colindixon.com>

Merge "Use lambdas to remove references to Function"

Use lambdas to remove references to Function

Change-Id: I8e45aca6ce8c3af4845502784ade1d859b375f09
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Add blueprint wiring for restconf connector"

Merge "Don't loose cause when reporting parsing errors."

BUG-8697: select correct transformer for schemaless netconf mounts

Getting or editing the configuration of a schemaless-mounted netconf device
from the code of an ODL application results in a NullPointerException.

This patch fixes the NetconfBaseOps constructor so that the RPC structure
transformer dedicated to schemaless mount points is actually selected.

Change-Id: Ib0b2d1c9910613f4354bdcb4f1c56e9be36a95b2
Signed-off-by: Gwenael Lambrouin <gwenael.lambrouin@b-com.com>
(cherry picked from commit 32621d57701de889651097ce5c1bfc3bb5f43ce9)

Convert yanglib project to blueprint

Added blueprint XML to instatiate the YangLibProvider. The yanglib
yang module was converted to a container that is stored in the DS and
provided via the clustered-app-config element. The CSS YangLibModule
was removed.

Change-Id: Ie45fb8261665fea38a4153c01484986d8a0272c4
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Don't loose cause when reporting parsing errors.

Change-Id: I5e5a07c00f29784a6289aa1ed24187ed6f42e833
Signed-off-by: Tomas Cere <tcere@cisco.com>

Add blueprint wiring for restconf connector

Added the blueprint XML wiring and deprecated the CSS config yang
and modules. The CSS Module classes are essentially no-ops but
remain for backwards compatibility until CSS is completely
removed.

Change-Id: I6f5e7f369958ead9ce00a7fc6c8afe551738f195
Signed-off-by: matthieu <mcauffiez@inocybe.com>
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Build features-... instead of features4-...

The directories were renamed, but not the artifacts.

Change-Id: I4abe486b54c6ff2220ee83ee3a6c274914932e43
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump odlparent dependency to 2.0.0

This updates odlparent dependency to 2.0.0 version. Furthermore, karaf 3
features are eliminated.

Change-Id: I8e18e032ea9cfb36f3913dcbfa7c3d1d6cd9ee59
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent 2.0.0

This takes odlparent 2.0.0, adjusts for guava update and feature
movement. Since jenkins is failing on the distro run, that is
disabled and a follow-up patch will re-enable it to get us going
again.

Change-Id: If3e1289ed7f73a79a5a47428c634bda9702e824d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent 2.0.0

This takes odlparent 2.0.0, adjusts for guava update and feature
movement. Since jenkins is failing on the distro run, that is
disabled and a follow-up patch will re-enable it to get us going
again.

Change-Id: If3e1289ed7f73a79a5a47428c634bda9702e824d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge changes I0d93e3c4,I34aca892,I74162d9a,Icd48e366

* changes:
  Remove netconf-auth service-type config yang
  Remove netconf-mapping-api service-type config yang
  Remove netconf-notifications-api service-type config yang
  Remove netconf-api service-type config yang

Merge "Switch from config-parent in pom files"

Merge "Remove import-package declaration"

Merge "Get rid of stale prerequisite for maven"

Merge "Migrate XML output to yang-data-codec-xml"

Merge "Run NormalizedNode parsing inline if possible"

Get rid of stale prerequisite for maven

It is commonly accepted that ODL requires maven 3.3.9+ now.  This
change removes a stale prerequisite for maven so that it is more
consistent with project guidelines.

Change-Id: Idd3bbe1c7ecbbc9b790fe50b7b29d8a263d98bd5
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Merge "Bug 5995: remove org.json"

Merge "Bug 8622: convert sal-rest-docgen to Jackson"

Remove import-package declaration

Maven exclusions should not be necessary.

Change-Id: I32c843efcd965624797a61ceff1b1ed4ce80d2e6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove the need for synthetic methods

Using private methods from anonymous classes forces javac to create
synthetics. Lower isolation to package-private to call them directly.

Change-Id: I52a5d641f275d5a2e9924e60910641ccdce42281
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Use SimpleSchemaContext instead of EffectiveSchemaContext"

Remove netconf-auth service-type config yang

The service-type identities aren't used so remove them.

Change-Id: I0d93e3c46e93db31d4515c55296c937f4f7a4d19
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Remove netconf-mapping-api service-type config yang

The service-type identities aren't used so remove them.

Change-Id: I34aca892bdd88f6ffa50c63a933a6cd6266cd75c
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Remove netconf-notifications-api service-type config yang

The service-type identities aren't used so remove them.

Change-Id: I74162d9a055c9d2757a3781b19de5d9dc4054f85
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Remove netconf-api service-type config yang

The service-type identities aren't used so remove them.

Change-Id: Icd48e3666773ca65a3f08a65b2377c0eaf830992
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Switch from config-parent in pom files

Most netconf bundles don't or no longer use the CSS so they
don't need to use config-parent.

Change-Id: I59757e8e81709f4904615b0e3829bc5ef569000b
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Remove UriInfo from JSONRestconfService API methods

https://git.opendaylight.org/gerrit/#/c/48369/ added a UriInfo parameter
to several JSONRestconfService API methods in Carbon. However this was an
undocumented API change which will break downstream users. Further,
there is no available implementation of UriInfo so each user would have
to provide an implementation which would pretty much render the API
unusable. We do not need to expose UriInfo in this API so I've remove the
parameters.

We'll need to cherry-pick to stable/carbon for SR1 to minimize breakage.

Change-Id: I74285413c2a3a92510398a57ea82567b646c6d27
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Bug 5995: remove org.json

This switches sal-rest-connector to Jackson and Gson and cleans up the
features.

Change-Id: I587ab4638374fccb344e9a769ee2793e16863fef
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug 8622: convert sal-rest-docgen to Jackson

This removes the requirement for org.json in sal-rest-docgen, which
causes bundle wiring issues in Karaf 4 (sal-rest-docgen ends up
exporting org.json, which Jackson’s compatibility layer consumes,
creating a dependency loop which causes refreshes anytime anything
touches the sal-rest-docgen).

Change-Id: I877f3e567fdeba3258a19a40f1f9e31bb19df24d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use SimpleSchemaContext instead of EffectiveSchemaContext

EffectiveSchemaContext is an implementation detail of the parser,
SimpleSchemeContext is a beta-level API from yang-model-util.

Change-Id: I524f9e91562b5fa8d6d942f40bf957ec97e40e88
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate to odlparent 1.9.0

Change-Id: I7d4af74e7713d48dd6ad8431229c4963423abbf6
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Migrate to odlparent 1.9.0

Change-Id: I7d4af74e7713d48dd6ad8431229c4963423abbf6
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Migrate to odlparent 1.9.0

Change-Id: Ib0dfd4ded0c67e04ae7e4f4d4cc537cf2c632486
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Migrate XML output to yang-data-codec-xml

The codecs provided yang-data-impl are superseded by those in
codec-xml. This patch provides the first part of migration.

Change-Id: If777defcc6218faf5597289956b800d68dcb5e5a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Run NormalizedNode parsing inline if possible

While JSON does not guarantee object ordering, we do not have to
fall back to building internal string if we have the target node
set.

If the target has been set, we call directly to parser with our
current parser, which will be moved forward -- which is more
efficient.

Change-Id: I311cc3525944fd2327183c200b3ed9dbee9e915a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Adjust to EffectiveSchemaContext movement

This code depends directly on parser internals. Adjust the import,
but really this should be fixed by subclassing AbstractSchemaContext
from yang-model-util.

Change-Id: I57c84ec7e721bf0bd1e6a6eef1d8ccd0562f8b74
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove protocol-framework config yang

The protocol-framework config yang modules aren't used, ie aren't
instantiated in any config XML file, so remove them.

Change-Id: I8cc8c8c8666ef731a2e7da20a3046300ce5aad45
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Fix checkstyle problems not detected by the current version

This change is required for overall move to new Checkstyle version, see
https://git.opendaylight.org/gerrit/#/q/topic:bumpCheckstyle

Change-Id: I4fac148d693e5de5c96485243a5469a22f1a8237
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

BUG-8085: create missing parent augmentation node

Augmentation nodes do not exist in serialized form
(e.g. in edit-config message), but are required by DataTree-based
DOMDataBroker implementations, so should be created if data from
augment is present.

This patch creates missing augment nodes by issuing merge on augmentation
before put operation (based on current behaviour for ListSchemaNodes).

Change-Id: If657ae96e914fc46617099042a833c7d4d5883b7
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>

Migrate to odlparent 1.8.0-Carbon

Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.

Jira: RELENG-159
RT: 41406
Change-Id: I69e9fab9531b1127286ca3f4467b9a046ce25a51
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate to odlparent 1.8.0-Carbon

Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.

Jira: RELENG-159
RT: 41406
Change-Id: Ib81afe4e0e7eb5587044bade9d50d00bc98906e1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>