netconf.git
7 years agoBug 8115: Change URI decoding from ISO-8859-1 to UTF-8 14/54114/2 stable/beryllium
lbeles [Thu, 30 Mar 2017 15:36:24 +0000 (17:36 +0200)]
Bug 8115: Change URI decoding from ISO-8859-1 to UTF-8

Change-Id: I3bcc7cae197aa267a43c8598f54050e987712c9a
Signed-off-by: lbeles <lbeles@frinx.io>
7 years agoBumping versions by 0.0.1 for next dev cycle 74/47274/1
Anil Belur [Fri, 21 Oct 2016 04:13:59 +0000 (14:13 +1000)]
Bumping versions by 0.0.1 for next dev cycle

Change-Id: I1d417745693597385d8a5570b94f5261371e4368
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
7 years agoMerge "Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes" into stable/beryllium
Tomas Cere [Mon, 10 Oct 2016 15:41:13 +0000 (15:41 +0000)]
Merge "Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes" into stable/beryllium

7 years agoMerge "Bug 6256 - OpenDaylight RESTCONF XML selects wrong YANG model for southbound...
Tomas Cere [Mon, 10 Oct 2016 15:39:48 +0000 (15:39 +0000)]
Merge "Bug 6256 - OpenDaylight RESTCONF XML selects wrong YANG model for southbound NETCONF" into stable/beryllium

7 years agoDo a proper disconnect when deleting a connector. 68/46668/1
Tomas Cere [Fri, 7 Oct 2016 11:36:06 +0000 (13:36 +0200)]
Do a proper disconnect when deleting a connector.

Change-Id: I1abba51e331eb1f019e5f2fe741f3836f840aae1
Signed-off-by: Tomas Cere <tcere@cisco.com>
(cherry picked from commit fc129a55005ce9d0c1cacfb2538e71fbe56ddd2a)

7 years agoBug 6272 - support RESTCONF PATCH for mounted NETCONF nodes 33/46533/5
Ivan Hrasko [Fri, 2 Sep 2016 14:01:32 +0000 (16:01 +0200)]
Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes

- adaptation for beryllium
- distinguish between operation on server or on mount point
- when operates on server then use global schema context and
data broker
- when operates on mount point then use schema context and
broker from mount point
- if broker on mount point is missing then PATCH operation fails
with global error
- contains unit tests

Change-Id: I97135a467209fcb4a5782d1c2677f482b842ff8a
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBug 6256 - OpenDaylight RESTCONF XML selects wrong YANG model for southbound NETCONF 30/46530/2
Ivan Hrasko [Tue, 27 Sep 2016 12:32:33 +0000 (14:32 +0200)]
Bug 6256 - OpenDaylight RESTCONF XML selects wrong YANG model for southbound NETCONF

- dataSchemaNode can contains multiple childs with the same name,
thus when looking for child also namespace has to be compared
- added unit tests

Change-Id: I922e96fd2aea686c27ad4683ef7366c6718486c3
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBug 6797 - Fix deadlock on cached schema-changed notifications 70/46270/3
ykq [Thu, 29 Sep 2016 03:36:54 +0000 (11:36 +0800)]
Bug 6797 - Fix deadlock on cached schema-changed notifications

Add an atomic state in NetconfDeviceCommunicator to improve the state
transition of close operation, to avoid deadlock while multiple threads
are doing the close.

Change-Id: I2f2c41b86b724eba78a74bfb96c0b499dc7f79a3
Signed-off-by: ykq <yin.kangqian@zte.com.cn>
7 years agoAdd unit tests for sal-netconf-connector 73/34473/5
Andrej Mak [Wed, 10 Feb 2016 08:21:19 +0000 (09:21 +0100)]
Add unit tests for sal-netconf-connector

Change-Id: I3bf4981042e61587bcec6e9ac122a5a7a9bba99c
Signed-off-by: Andrej Mak <andmak@cisco.com>
7 years agoMerge "Bug 6198 - Use sal-netconf-connector to connet device costs too much time...
Tomas Cere [Thu, 11 Aug 2016 08:31:14 +0000 (08:31 +0000)]
Merge "Bug 6198 - Use sal-netconf-connector to connet device costs too much time" into stable/beryllium

7 years agoBumping versions by 0.0.1 for next dev cycle 74/43174/1
Thanh Ha [Thu, 4 Aug 2016 22:26:05 +0000 (18:26 -0400)]
Bumping versions by 0.0.1 for next dev cycle

Change-Id: Ie3c6d789e4e4c9b9630db998c586b6e1d7652167
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoMerge "Remove obsolete FIXMEs" into stable/beryllium
Tomas Cere [Tue, 26 Jul 2016 10:44:13 +0000 (10:44 +0000)]
Merge "Remove obsolete FIXMEs" into stable/beryllium

7 years agoBug 6198 - Use sal-netconf-connector to connet device costs too much time 33/42133/7
Rong Xu [Tue, 19 Jul 2016 13:16:44 +0000 (21:16 +0800)]
Bug 6198 - Use sal-netconf-connector to connet device costs too much time

Filter missing sources Identifiers before createSchemaContext in class RecursiveSchemaSetup.

Change-Id: Ic41d4803df0807d799a1e80ceb6639877f006e42
Signed-off-by: Rong Xu <xu.rong4@zte.com.cn>
7 years agoBug 3959 - support netconf notification 59/42159/8
Ivan Hrasko [Wed, 20 Jul 2016 15:21:28 +0000 (17:21 +0200)]
Bug 3959 - support netconf notification

  *cherry-pick from master (boron)
  *added dependency for converting JSON to XML
  *created new notification listener adapter extended
   by DOMNotificationListener
  *added augment for sal-remote to add new param
   for input of create-notification-stream rpc to
   make a choice between JSON or XML output of
   notification (not mandatory - default is XML)
  *added unit tests

Change-Id: Ia79ce7f36a292db4b51140126d3bdbbe7877b478
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 6037 - Check if delete request was successful 14/41714/20
Ivan Hrasko [Tue, 12 Jul 2016 13:33:19 +0000 (15:33 +0200)]
Bug 6037 - Check if delete request was successful

- waiting for result on mount point devices
- checking if data to delete exists, if not return error 404

Change-Id: I0f4c11cb3dd9c7fc560a4fee06df0d398c0c4f61
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoRemove obsolete FIXMEs 36/34236/2
Robert Varga [Sat, 30 Jan 2016 02:57:39 +0000 (03:57 +0100)]
Remove obsolete FIXMEs

The aaa project has been spun out, no circular dependencies anymore.

Change-Id: Idb758a3d1c6337360380f856ac5c9d23df9d01cf
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 370aa978b837d4ba86ab3e70d4b31d2a2ec2e9bf)

7 years agoBug 5909 - PATCH does not report 409 on OptimisticLockFailedException 03/41703/13
Ivan Hrasko [Tue, 12 Jul 2016 10:51:30 +0000 (12:51 +0200)]
Bug 5909 - PATCH does not report 409 on OptimisticLockFailedException

- wait for transaction to be finished

Change-Id: I5440b866eada07ee6540c6b93d2e9174e62a37ce
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5897 - PATCH merge operation does nothing 36/41636/20
Ivan Hrasko [Mon, 11 Jul 2016 08:48:13 +0000 (10:48 +0200)]
Bug 5897 - PATCH merge operation does nothing

- added merge patch operation processing

Change-Id: Ic3f5908c5f016a0680779ed12b4bc26b7b840d9a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5915 - PATCH with "target":"/" error 91/40991/24
Ivan Hrasko [Wed, 29 Jun 2016 07:54:38 +0000 (09:54 +0200)]
Bug 5915 - PATCH with "target":"/" error

- fixed bug + added unit test (example of usage)
for json and xml
- improved solution of bug5730

Change-Id: I0d8042ffdced97918ff936817513fc30163be577
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5509 - HTTP Patch in Restconf doesn't support general absolute or relative target... 95/38195/44
Ivan Hrasko [Thu, 28 Apr 2016 14:23:53 +0000 (16:23 +0200)]
Bug 5509 - HTTP Patch in Restconf doesn't support general absolute or relative target xpath

- yang patch for xml media now supports relative or absolute xpaths
- only create, merge, replace and insert operations require value to be present
- if value is not present with create, merge, replace or insert operation
then error 400 is returned
- if value is used with other operations then error 400 is returned
- deleting sublist values instead of full parent
- support for multiple values
- added unit tests

Change-Id: I9828ceb7368760642b22b3a336884b949f0edfcc
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBug 5509 - HTTP Patch in Restconf doesn't support general absolute or relative target... 93/41193/6
Ivan Hrasko [Fri, 1 Jul 2016 06:56:14 +0000 (08:56 +0200)]
Bug 5509 - HTTP Patch in Restconf doesn't support general absolute or relative target xpath

- dependencies shared between XML and JSON PATCH implementations

Change-Id: Ia649763379fab03019ddfd16eac564da576cb35b
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5898 - PATCH success "ok" field has wrong JSON value 23/41123/1
Ivan Hrasko [Thu, 30 Jun 2016 08:54:05 +0000 (10:54 +0200)]
Bug 5898 - PATCH success "ok" field has wrong JSON value

- empty value is represented as an array with value null

Change-Id: Ie8315d5a18756fd12d3b7a7de693dfd1c569945a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoImprove logging in netconf test tool 19/40219/6
Jakub Morvay [Mon, 13 Jun 2016 08:30:50 +0000 (10:30 +0200)]
Improve logging in netconf test tool

This adds debug logs to TesttoolNegotiationFactory to help distinguish
cached operation service from newly created one. Also logs passed
parameters to netconf test tool.

Change-Id: I52dbc86a926724f97490ef2d939da22e71a3925a
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 5730 - Delete subset of list items using PATCH? 22/38022/19
Ivan Hrasko [Fri, 22 Apr 2016 14:04:01 +0000 (16:04 +0200)]
Bug 5730 - Delete subset of list items using PATCH?

- fix: edit is not ignored when end of input is reached
- fix: only create, merge, replace and insert operations require value to be present
- fix: if value is not present with create, merge, replace or insert operation then error 400 is returned
- fix: if value is used with other operations error 400 is returned
- fix: deleting sublist values instead of full parent
- fix: order of patch edit fields is not important anymore (target, value)
- move class StringModuleInstanceIdentifierCodec to own file

Change-Id: I4c3f407858034b49795034da6c93b41f9d891b62
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBumping versions by 0.0.1 for next dev cycle 10/38710/1
Thanh Ha [Thu, 12 May 2016 04:07:40 +0000 (00:07 -0400)]
Bumping versions by 0.0.1 for next dev cycle

Change-Id: I756f65ba37f7c745d41eee890f46ed473c0cd9d7
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoRelease Beryllium-SR2 09/38709/1 release/beryllium-sr2
Thanh Ha [Thu, 12 May 2016 04:07:39 +0000 (00:07 -0400)]
Release Beryllium-SR2

Change-Id: I20bb6ebd124e49076a613dceddbd22010aa437ca
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
8 years agoUse mounted device schema context when resolving mounted device rpc path 61/37961/1
Andrej Mak [Thu, 21 Apr 2016 09:28:07 +0000 (11:28 +0200)]
Use mounted device schema context when resolving mounted device rpc path

It wasn't possible to invoke rpcs on device, which were not present
also in controller schema context, so only rpcs like get-schema and
create-subscription worked. Now, device schema context is used to
lookup rpc definition during parsing path, so rpcs defined by device works.

Change-Id: I1046bad566260c804ce0f786c56c74afe3d7f723
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoMerge "Bug 5509: HTTP Patch in Restconf doesn't support general absolute or relative...
Tomas Cere [Wed, 20 Apr 2016 08:41:27 +0000 (08:41 +0000)]
Merge "Bug 5509: HTTP Patch in Restconf doesn't support general absolute or relative target xpath" into stable/beryllium

8 years agoBug 4577 Allow specification of a distinct schema cache directory per netconf device 89/34189/10
adetalhouet [Thu, 10 Mar 2016 13:23:39 +0000 (08:23 -0500)]
Bug 4577 Allow specification of a distinct schema cache directory per netconf device

First iteration done here https://git.opendaylight.org/gerrit/#/c/30163 introduce a BUG:
sideloaded schemas, manually added in cache/schema, and specified in the netconf connector,
where not being taking in account in the specified cache folder.

This path add the capability to register the sideloaded schema in the new FilesystemSchemaSourceCache

Change-Id: I6a5a6b23fc56bcc507734a99e48de88597b7ae2a
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>
8 years agoBug 3708 - APIdoc explorer URLs contain extra 'node' in REST calls 31/37731/2
Ryan Goulding [Thu, 14 Apr 2016 15:30:33 +0000 (11:30 -0400)]
Bug 3708 - APIdoc explorer URLs contain extra 'node' in REST calls

* fixed mount point path builder that added each list qname twice

Manually cherry picked from controller patch to netconf patch:
https://git.opendaylight.org/gerrit/#/c/25531

Change-Id: I631961f3b0d791c6e8ab2921ef6eb163e68e7753
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoadd partial match for non-module capabilities - to enable deviations in base capabilities 47/37547/1
Giles Heron [Thu, 7 Apr 2016 08:49:41 +0000 (09:49 +0100)]
add partial match for non-module capabilities - to enable deviations in base capabilities

Change-Id: I06fbeaeb63cca9ad8b2e7b9aa8c75b3a1ce40334
Signed-off-by: Giles Heron <giheron@cisco.com>
8 years agoImplement SchemaLocationBuilder for ietf-netconf-monitoring 99/37499/1
Maros Marsalek [Tue, 12 Apr 2016 14:52:47 +0000 (16:52 +0200)]
Implement SchemaLocationBuilder for ietf-netconf-monitoring

Change-Id: I0442ec831126f3d4657f9cd3191c6d518dc7cc48
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
8 years agoMerge "Bug 5580 - RestPerfClient: Invalid requests rate reported when a thread times...
Tomas Cere [Mon, 11 Apr 2016 10:38:47 +0000 (10:38 +0000)]
Merge "Bug 5580 - RestPerfClient: Invalid requests rate reported when a thread times out" into stable/beryllium

8 years agoBug 5509: HTTP Patch in Restconf doesn't support general absolute or relative target... 77/36177/6
Martin Ciglan [Mon, 14 Mar 2016 08:17:57 +0000 (09:17 +0100)]
Bug 5509: HTTP Patch in Restconf doesn't support general absolute or relative target xpath

Absolute or relative input URI and PATCH target JSON support

Change-Id: I86821e59581968cef5f11ec34ce98757909f7c36
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
8 years agoBug 4940 - correctly implement default-request-timeout-millis 09/37109/5
Alexis de Talhouët [Mon, 4 Apr 2016 21:38:59 +0000 (17:38 -0400)]
Bug 4940 - correctly implement default-request-timeout-millis

This is a follow up patch of this one https://git.opendaylight.org/gerrit/#/c/33209/
This revert 2a301c41e506c834c63b53aa62df68cd83385553

The implementation made in previous patch was blocking transaction for a given timeout,
but the blocking wasn't handled at the right place, ending up blocking restconf/user thread.

Change-Id: Ide2f24890d6b9fa577bba793d0b1f0b8ea85a222
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoBug 5580 - RestPerfClient: Invalid requests rate reported when a thread times out 95/36995/1
Jakub Morvay [Fri, 1 Apr 2016 08:57:25 +0000 (10:57 +0200)]
Bug 5580 - RestPerfClient: Invalid requests rate reported when a thread times out

If some threads sending requests fail or time out, skip calculation of
requests per second value and do not log it.

Change-Id: Icec9cec729999d82671f47f383a6839aeaef6444
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
8 years agoBug 5638 switch netconf to use odl-aaa-shiro isntead of odl-aaa-authn 69/36969/1
Ryan Goulding [Thu, 31 Mar 2016 14:13:09 +0000 (10:13 -0400)]
Bug 5638 switch netconf to use odl-aaa-shiro isntead of odl-aaa-authn

odl-aaa-authn has very limited uses now, since odl-aaa-shiro has
included most of its features by default.  Switch netconf to use
odl-aaa-shiro instead of odl-aaa-authn, to get most up to date
aaa implementation.  odl-aaa-authn should be deprecated in a
separate patch.

Change-Id: Id8281d352583d1d2ad8cf37a62ceb5a9431be3c0
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoNetconf-topology module unit tests 43/34343/2
Jakub Morvay [Tue, 9 Feb 2016 10:32:26 +0000 (11:32 +0100)]
Netconf-topology module unit tests

Change-Id: I8258ce4973758ef20d503712147e34ee78a1cd95
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
(cherry picked from commit 32e6bedfee7fa221f28aea8694ed36965c9b905b)

8 years agoMerge "BUG 5413 - RestPerfClient: Hang on java.util.concurrent.CancellationException...
Tomas Cere [Tue, 29 Mar 2016 14:21:22 +0000 (14:21 +0000)]
Merge "BUG 5413 -  RestPerfClient: Hang on java.util.concurrent.CancellationException." into stable/beryllium

8 years agoMerge "Bug 5475 - File descriptor leak on netconf connector reconnects" into stable...
Tomas Cere [Tue, 29 Mar 2016 12:54:56 +0000 (12:54 +0000)]
Merge "Bug 5475 - File descriptor leak on netconf connector reconnects" into stable/beryllium

8 years agoBumping versions by 0.0.1 for next dev cycle 15/36615/1
Thanh Ha [Wed, 23 Mar 2016 15:44:34 +0000 (11:44 -0400)]
Bumping versions by 0.0.1 for next dev cycle

Change-Id: I4b2e0eaae93dd58449b712f4483e5efd1bf9dfb0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
8 years agoRelease Beryllium-SR1 14/36614/1 release/beryllium-sr1
Thanh Ha [Wed, 23 Mar 2016 15:44:33 +0000 (11:44 -0400)]
Release Beryllium-SR1

Change-Id: I9cbba03941d57eb03c583179c19aa6ac8ecbee72
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
8 years agoBug 5475 - File descriptor leak on netconf connector reconnects 56/36156/5
adetalhouet [Thu, 17 Mar 2016 23:11:32 +0000 (19:11 -0400)]
Bug 5475 - File descriptor leak on netconf connector reconnects

Do not start the SshClient each time the AsyncSshHandler is instantiated.

http://mail-archives.apache.org/mod_mbox/mina-users/201603.mbox/%3CCAA66TprZd754Ry8wMYgS7kOJc8%3DvZNP3MA41VYZyVi_oQSv6yw%40mail.gmail.com%3E

Change-Id: I6c70fa669dfceadeaa0b388894f7042bb44fc586
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>
8 years agoBUG 5413 - RestPerfClient: Hang on java.util.concurrent.CancellationException. 80/35980/3
Jakub Morvay [Wed, 9 Mar 2016 10:35:51 +0000 (11:35 +0100)]
BUG 5413 -  RestPerfClient: Hang on java.util.concurrent.CancellationException.

Make timeout for executing requests customizable via parameter --timeout.
Check for cancelled tasks.

Change-Id: I73256bb52d8056f3345621b9a57a0dd3b9cbdfb5
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
8 years agoBug 3866: Support for Restconf HTTP Patch 63/36163/1
Martin Ciglan [Sun, 13 Mar 2016 17:29:21 +0000 (18:29 +0100)]
Bug 3866: Support for Restconf HTTP Patch

- JSON body reader/writer in place
- XML body reader/writer in place
- refactored BrokerFacade and RestconfImpl code to apply HTTP Patch within transaction
        in order to be able to rollback in case of error(s)
- review comments implemented

Change-Id: Ib66b6d0e49fc32709f1163e517240ec0bddd0a60
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
8 years agoBug 5345: Unable to use get-schema RPC due to unsafe class casting 92/35992/2
Martin Ciglan [Wed, 9 Mar 2016 13:55:11 +0000 (14:55 +0100)]
Bug 5345: Unable to use get-schema RPC due to unsafe class casting

This patch represents class cast fix for Beryllium SR1 code base only
due to using of deprecated structures.

Change-Id: If1eaf60d78d2fec32979895ca07f13db55918780
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
8 years agoReplace mdsal model bundles with feature 00/36000/1
Tomas Cere [Wed, 9 Mar 2016 14:54:35 +0000 (15:54 +0100)]
Replace mdsal model bundles with feature

Change-Id: I118a5adef486ba652f293c4bfbad09de6ab63080
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoAuto create mixin list-parent nodes from netconf northbound 80/35580/2
Maros Marsalek [Tue, 1 Mar 2016 14:00:24 +0000 (15:00 +0100)]
Auto create mixin list-parent nodes from netconf northbound

Change-Id: I61ecccc0631bb3a2fbaea4611fad37de6dc8a7f4
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
8 years agoMerge "Sal-rest-connector unit tests switch to new yang parser." into stable/beryllium
Tony Tkacik [Mon, 29 Feb 2016 14:52:38 +0000 (14:52 +0000)]
Merge "Sal-rest-connector unit tests switch to new yang parser." into stable/beryllium

8 years agoAPI Doc Explorer crashes if a yang file on a mounted resource does not have a version 44/34944/2
Balaji Varadaraju [Thu, 18 Feb 2016 23:15:14 +0000 (17:15 -0600)]
API Doc Explorer crashes if a yang file on a mounted resource does not have a version

The fix for bug 3782  was checking for dates less than 1970 ( default date when there is no version).
The fix is to check for less than or equal to 1970. The existing code works fine for US time zones
because all US time zones are behind GMT and hence the local time for EPOCH date results in year 1969.
However when in other time zones such as in Europe the year part of the EPOCH date results in 1970.
This is a simple fix to correct that.

Change-Id: I671e602cc5f99cdc3f940073609028b8f2349de9
Signed-off-by: Balaji Varadaraju <bvaradar@brocade.com>
8 years agoMerge "BUG 5269: Allow capability override in topology" into stable/beryllium
Tony Tkacik [Tue, 23 Feb 2016 10:05:34 +0000 (10:05 +0000)]
Merge "BUG 5269: Allow capability override in topology" into stable/beryllium

8 years agoMerge "Bug 4114 - netconf connector replace causes transaction chain failure" into...
Tony Tkacik [Tue, 23 Feb 2016 10:04:20 +0000 (10:04 +0000)]
Merge "Bug 4114 - netconf connector replace causes transaction chain failure" into stable/beryllium

8 years agoSal-rest-connector unit tests switch to new yang parser. 50/33950/2
Peter Kajsa [Tue, 2 Feb 2016 16:08:36 +0000 (17:08 +0100)]
Sal-rest-connector unit tests switch to new yang parser.

Change-Id: I4efa8e265ca2827033cb0cd3f0b8be3924616842
Signed-off-by: Peter Kajsa <pkajsa@cisco.com>
(cherry picked from commit 2dd8dce2a8260edb330a7ade345e42b06538a414)

8 years agoBumping versions by 0.0.1 for next dev cycle 57/34957/1
Thanh Ha [Thu, 18 Feb 2016 23:40:33 +0000 (18:40 -0500)]
Bumping versions by 0.0.1 for next dev cycle

Change-Id: I738fcc7b2bd45b91921282a9018f2ce379e51491
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
8 years agoRelease Beryllium 56/34956/1 release/beryllium
Thanh Ha [Thu, 18 Feb 2016 23:40:33 +0000 (18:40 -0500)]
Release Beryllium

Change-Id: I94ed921f16c34ce35b8b6d4437071d7782d79787
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
8 years agoBug 5346: Add odl-config-netty to odl-netconf-client 75/34675/2
Vratko Polak [Mon, 15 Feb 2016 14:12:46 +0000 (15:12 +0100)]
Bug 5346: Add odl-config-netty to odl-netconf-client

Feature odl-netconf-client applies 01-netconf.xml config file,
which expects capabilities provided by config file 00-netty.xml
from odl-config-netty feature. But odl-config-netty is not part of
odl-config-all feature, so it needs to be specified directly.

Also, added more specific capability dependency to 01-netconf.xml
and updated dependencies for netconf features pom.xml

Change-Id: Idb8aa24e7adeecd1d6a7d9bee8fb0d8006828831
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
8 years agoBUG 5269: Allow capability override in topology 67/34667/1
Tomas Cere [Mon, 15 Feb 2016 13:06:29 +0000 (14:06 +0100)]
BUG 5269: Allow capability override in topology

Previous patch was for cfg subsystem configuration only,
this adds the ability to override devices capabilites
to netconf connectors configured through topology.

Also fix typo in UserPreferences.

Change-Id: Icea2ab162424e4490c7c33be16f4ab14cc4ae1ab
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoBug 4114 - netconf connector replace causes transaction chain failure 69/34569/1
adetalhouet [Thu, 14 Jan 2016 13:53:41 +0000 (08:53 -0500)]
Bug 4114 - netconf connector replace causes transaction chain failure

In order to avoid race condition when txChain perform delete then write
transactions in a row to the same path, perfom the delete as a blocking
transaction so once done, write can be perform without any race condition

Also reset the txChain after a failure.

Change-Id: If0c51be8fe80106a6722abb93dbe4b47548fce1b
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>
(cherry picked from commit 76cce56c2bf85efde7f360f2af779a75b57141ee)

8 years agoMerge "Add ietf-netconf-monitoring-extension to base schema" into stable/beryllium
Tomas Cere [Fri, 12 Feb 2016 14:03:34 +0000 (14:03 +0000)]
Merge "Add ietf-netconf-monitoring-extension to base schema" into stable/beryllium

8 years agoMerge "BUG-3934 Don't omit updated data from notification" into stable/beryllium
Tony Tkacik [Fri, 12 Feb 2016 13:33:37 +0000 (13:33 +0000)]
Merge "BUG-3934 Don't omit updated data from notification" into stable/beryllium

8 years agoAdd ietf-netconf-monitoring-extension to base schema 48/34548/1
Andrej Mak [Fri, 12 Feb 2016 11:08:38 +0000 (12:08 +0100)]
Add ietf-netconf-monitoring-extension to base schema

Monitoring extension must be present in base schema context
to be able to call get-schema to download models from device.

Change-Id: Idcfa7295dd0b5fe29cb26b560f6d058ee6a08f70
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoMerge "Bug 2806 - Immediate and infinite reconnect attempts during negotiation" into...
Maros Marsalek [Thu, 11 Feb 2016 18:49:50 +0000 (18:49 +0000)]
Merge "Bug 2806 - Immediate and infinite reconnect attempts during negotiation" into stable/beryllium

8 years agoMerge "Move NetconfHelloMessage to netconf-api" into stable/beryllium
Maros Marsalek [Thu, 11 Feb 2016 18:49:43 +0000 (18:49 +0000)]
Merge "Move NetconfHelloMessage to netconf-api" into stable/beryllium

8 years agoMerge "bug 5096 Clean up transaction in case of failure" into stable/beryllium
Maros Marsalek [Thu, 11 Feb 2016 18:44:53 +0000 (18:44 +0000)]
Merge "bug 5096 Clean up transaction in case of failure" into stable/beryllium

8 years agoMerge "Fix tests according to review comments." into stable/beryllium
Maros Marsalek [Thu, 11 Feb 2016 18:42:52 +0000 (18:42 +0000)]
Merge "Fix tests according to review comments." into stable/beryllium

8 years agoBug 2806 - Immediate and infinite reconnect attempts during negotiation 76/34476/3
Jakub Morvay [Thu, 4 Feb 2016 10:19:09 +0000 (11:19 +0100)]
Bug 2806 - Immediate and infinite reconnect attempts during negotiation

Set connection to success, after successful netconf negotiation.

Change-Id: Id044b618c3f996d4e93df2a2537ea7e905717477
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
8 years agoMove NetconfHelloMessage to netconf-api 77/34477/2
Andrej Mak [Mon, 25 Jan 2016 14:11:30 +0000 (15:11 +0100)]
Move NetconfHelloMessage to netconf-api

Make sessionPreferences return NetconfHelloMessage.
Move NetconfHelloMessage and NetconfHelloMessageAdditionalHeader test to netconf-api.

Change-Id: I8f619954b2ae1428791d1161cba2b4c238083b42
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agobug 5096 Clean up transaction in case of failure 74/34474/1
Andrej Mak [Thu, 4 Feb 2016 15:03:54 +0000 (16:03 +0100)]
bug 5096 Clean up transaction in case of failure

In case of transaction fail, clean up failed transaction,
so it is posible to start new. Add more detailed error message.

Change-Id: I2ea39cc37994175974108cbf8e1afdbd9a3a2282
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoBug 4100 - Extend sal-netconf-connector base schema context 59/33759/3
Andrej Mak [Fri, 29 Jan 2016 10:09:35 +0000 (11:09 +0100)]
Bug 4100 - Extend sal-netconf-connector base schema context

In case, that device supports notifications, but doesn't provide
model for them, model from BaseSchema in NetconfMessageTransformer
will be used as fallback.

Change-Id: Ib058ea07a8a457dd83ed98c6d91e21976a0d8ffb
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoBUG-3934 Don't omit updated data from notification 04/34404/1
Maros Marsalek [Wed, 10 Feb 2016 15:08:51 +0000 (16:08 +0100)]
BUG-3934 Don't omit updated data from notification

Change-Id: Ifa17cbe53084ee3e6d6357bd7805bfd1bf1a5b8a
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
8 years agoFix tests according to review comments. 30/34330/1
Andrej Mak [Tue, 9 Feb 2016 13:39:15 +0000 (14:39 +0100)]
Fix tests according to review comments.

https://git.opendaylight.org/gerrit/#/c/33949/
https://git.opendaylight.org/gerrit/#/c/33972/
https://git.opendaylight.org/gerrit/#/c/33849/

Change-Id: I4c9119bfe19d1c60ca61e0e40832bcf444b7463d
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoBUG 5089: Fix incorrect slave schema repo behaviour 21/34321/1
Tomas Cere [Mon, 8 Feb 2016 12:49:11 +0000 (13:49 +0100)]
BUG 5089: Fix incorrect slave schema repo behaviour

Need to use the correct schema repo in slave schema providers.
Introduced by the patch for BUG 4577.

Change-Id: Iba64841ba0f2f875f4da455cb3025266cf7b6c5e
Signed-off-by: Tomas Cere <tcere@cisco.com>
(cherry picked from commit 0dbc2a1f8597733e72086b0e9dfa191089e3eeab)

8 years agoMerge changes Ib7024e5e,I1b1003c1 into stable/beryllium
Maros Marsalek [Tue, 9 Feb 2016 12:51:45 +0000 (12:51 +0000)]
Merge changes Ib7024e5e,I1b1003c1 into stable/beryllium

* changes:
  Ignore netconf tools from sonar report
  Topology node writer UnitTests

8 years agoBUG-5269 Enable device capabilities override 55/33455/5
Maros Marsalek [Wed, 6 Jan 2016 14:49:19 +0000 (15:49 +0100)]
BUG-5269 Enable device capabilities override

So far, merge was the dafult strategy. From now on, override
is also possible.

Useful when it's necessary to completely replace device models
with user/app models.

Change-Id: I4b1bb68b8257e4a6889f54f7be0e6baee5d7617d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
8 years agoBug 5175: RPC called on mount point not being correctly handled when multiple revisio... 82/33982/1
adetalhouet [Wed, 3 Feb 2016 14:04:40 +0000 (09:04 -0500)]
Bug 5175: RPC called on mount point not being correctly handled when multiple revision-date coexist

 The ControllerContext#toQname was just looking for module using the module name. In scenarios where you have multiple revision for the same module, the method was returning the latest schema. This fix is to retreive the schema based on the revision date

Change-Id: Ie1f3ae1b6c4e6fd7133f64f3f5e7c8899c42db5a
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>
8 years agoBug 4948: Catch RuntimeException from ensureParentByMerge 59/33659/6
Balaji Varadaraju [Wed, 27 Jan 2016 20:17:49 +0000 (14:17 -0600)]
Bug 4948: Catch RuntimeException from ensureParentByMerge

Made the calls to PUT and POST more robust. Caught the RuntimeException from
 the merge call in the EnsureParentsByMerge. If this fails then started
a new transaction and continue with the original PUT. This ensures when a device
is unable to handle the empty list/container merge it will still succeed with the
original request. Similar change has been made for POST.
This bug was fixed in stable Lithium. I am pushing the same fix on Beryllium.

Added FIXME statements to figure out and catch specific Runtime exceptions
thrown by Netconf instead of RuntimeException.

Change-Id: Id18a97857e46f44014dbd61cbfa86285457a2905
Signed-off-by: Balaji Varadaraju <bvaradar@brocade.com>
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoBUG 5125: Fix NPE on module's with unknown namespace 08/33908/1
Tomas Cere [Tue, 2 Feb 2016 14:11:26 +0000 (15:11 +0100)]
BUG 5125: Fix NPE on module's with unknown namespace

Change-Id: I9e7db1f3aa36bf6def6318442bb2559cc698dd2c
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoBug 3934: Websockets: Scope ONE doesn't work correctly 61/33761/4
Martin Ciglan [Fri, 29 Jan 2016 11:08:36 +0000 (12:08 +0100)]
Bug 3934: Websockets: Scope ONE doesn't work correctly

Bug fix for vcmts system manager.

Change-Id: I4b7d934ace1ba60afd166dd62aacdc855cd7a9df
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
8 years agoBUG-5019: adjust to changed NormalizedNodeStreamWriter API 50/33650/3
Robert Varga [Thu, 21 Jan 2016 17:32:32 +0000 (18:32 +0100)]
BUG-5019: adjust to changed NormalizedNodeStreamWriter API

This patch just provides the information which is readily available.

Change-Id: Ie56c880c6480d6be750d4efdeeceea6036509bb8
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 0ddfd274ee0274d2a3e5e5a883fa3cbdc3df1916)

8 years agoBug 3934: Websockets: Scope ONE doesn't work correctly 22/33622/1
Martin Ciglan [Wed, 27 Jan 2016 10:26:37 +0000 (11:26 +0100)]
Bug 3934: Websockets: Scope ONE doesn't work correctly

Make sure data in data-change-event is wrapped in data element
per sal-remote.yang specification

Change-Id: Iaac2005a249f53664824ebe99bcfff02fbdd3097
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
8 years agoBug 3934: Websockets: Scope ONE doesn't work correctly 07/33607/1
Martin Ciglan [Tue, 19 Jan 2016 22:42:06 +0000 (23:42 +0100)]
Bug 3934: Websockets: Scope ONE doesn't work correctly

When processing an event which contains a capture of changes in a data subtree,
path and operation are captured to DOM Element, but data itself is ignored.

Change-Id: I11e6a5be5f5f4a025cf3edeb181140c573227a94
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 898916bcccbae02956efa6175118c7521080a2d2)

8 years agoAdd more context when data parsing fails 60/33460/2
Robert Varga [Fri, 22 Jan 2016 18:15:51 +0000 (19:15 +0100)]
Add more context when data parsing fails

This adds information about the XML element which failed to parse. Also
cleans up some eclipse warnings.

Change-Id: I8accc396bc166de26a9a1efe3678e648ac17b28e
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
8 years agoMerge "BUG 5014 - init topology for config datastore" into stable/beryllium
Tony Tkacik [Fri, 22 Jan 2016 12:36:23 +0000 (12:36 +0000)]
Merge "BUG 5014 - init topology for config datastore" into stable/beryllium

8 years agoIgnore netconf tools from sonar report 49/33349/1
Tomas Cere [Fri, 22 Jan 2016 12:17:08 +0000 (13:17 +0100)]
Ignore netconf tools from sonar report

No need to include these.

Change-Id: Ib7024e5e80bd2c307fdd3e9fed7a06883ca21db6
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoTopology node writer UnitTests 48/33348/2
Tomas Cere [Fri, 22 Jan 2016 10:16:52 +0000 (11:16 +0100)]
Topology node writer UnitTests

Change-Id: I1b1003c15a7595cbe32f7a6fa0f2cafb0812d826
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoMerge "Bug 4577 Allow specification of a distinct schema cache directory per netconf...
Tony Tkacik [Fri, 22 Jan 2016 08:34:22 +0000 (08:34 +0000)]
Merge "Bug 4577 Allow specification of a distinct schema cache directory per netconf device" into stable/beryllium

8 years agoBug 4940 - correctly implement default-request-timeout-millis 09/33209/1
adetalhouet [Thu, 21 Jan 2016 13:30:19 +0000 (08:30 -0500)]
Bug 4940 - correctly implement default-request-timeout-millis

Change-Id: I5eadfdaff9f67ef79b4fae47135012865f40a9eb
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>
8 years agoBUG 5014 - init topology for config datastore 96/33196/2
Tomas Cere [Thu, 21 Jan 2016 09:16:07 +0000 (10:16 +0100)]
BUG 5014 - init topology for config datastore

this adds initialization for both clustered and non-clustered version
of the feature.

Change-Id: Ia0bd0226853bdcaf9b1510a9a7ff3281209e2c33
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoBug 4577 Allow specification of a distinct schema cache directory per netconf device 13/33013/5
Ryan Goulding [Mon, 11 Jan 2016 20:02:18 +0000 (15:02 -0500)]
Bug 4577 Allow specification of a distinct schema cache directory per netconf device

A leaf is added to odl-sal-netconf-connector-cfg.yang to allow specification of
a schema cache directory relative to the "cache" directory.  The leaf defaults to
"schema", so the default directory for loaded yang files is "cache/schema".  It
is useful to specify a distinct cache directory per netconf mount to avoid potential
model conflicts caused by revisionless import statements.

Change-Id: Id930932aa4ff17a7338ddf96e87557b3949b4204
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoStop failing netconf connection on revision mismatch 54/32954/3
Tomas Cere [Mon, 18 Jan 2016 17:08:02 +0000 (18:08 +0100)]
Stop failing netconf connection on revision mismatch

When there's a mismatch between model revision and what the device
reports we should omit this model and not fail the whole connection.

Change-Id: I642406a4a9d10c00da947825b0f9b7933dda72c6
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoBump scala version to match version bump in controller. 37/32937/2
Tomas Cere [Mon, 18 Jan 2016 10:19:56 +0000 (11:19 +0100)]
Bump scala version to match version bump in controller.

Should only be merged after the version bump in controller.

Change-Id: I8df0c07b5373ec6506d445b1c061be0cdc169416
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoMerge "BUG 4968: Clear transaction after proxy tx is submitted." into stable/beryllium
Tony Tkacik [Tue, 19 Jan 2016 08:41:02 +0000 (08:41 +0000)]
Merge "BUG 4968: Clear transaction after proxy tx is submitted." into stable/beryllium

8 years agoMerge "Fix netconf-config-connector NetconfMappingTest" into stable/beryllium
Tony Tkacik [Tue, 19 Jan 2016 08:39:19 +0000 (08:39 +0000)]
Merge "Fix netconf-config-connector NetconfMappingTest" into stable/beryllium

8 years agoMerge "Init topology-netconf when clustered topology starts" into stable/beryllium
Tony Tkacik [Mon, 18 Jan 2016 17:04:12 +0000 (17:04 +0000)]
Merge "Init topology-netconf when clustered topology starts" into stable/beryllium

8 years agoFix netconf-config-connector NetconfMappingTest 39/32939/1
Jakub Morvay [Thu, 14 Jan 2016 16:19:49 +0000 (17:19 +0100)]
Fix netconf-config-connector NetconfMappingTest

Since commit operation does not fail when no transaction is
present, remove test expecting exception in such case.

Change-Id: Ib6b94570979b7821fede39a23240463c6524e04e
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
8 years agoBug 4455 - Inconsistent COMMIT operation handling when no transactions are present 38/32938/1
Jakub Morvay [Thu, 14 Jan 2016 12:39:01 +0000 (13:39 +0100)]
Bug 4455 - Inconsistent COMMIT operation handling when no transactions are present

Return positive response for commit operation in netconf mdsal
northbound even if no candidate transaction is open for session.

Change-Id: I2483a1e4da533566ce318bab0858af2a4fb3c6d3
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
(cherry picked from commit 5a7a791d64aa5de004dd526c2cb6331fc0d58522)

8 years agoBUG 4968: Clear transaction after proxy tx is submitted. 35/32935/2
Tomas Cere [Mon, 18 Jan 2016 13:48:42 +0000 (14:48 +0100)]
BUG 4968: Clear transaction after proxy tx is submitted.

Change-Id: I2038a25cdd0ae17e6517a1f0ac375850a3c17479
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoInit topology-netconf when clustered topology starts 36/32936/1
Tomas Cere [Mon, 18 Jan 2016 12:23:58 +0000 (13:23 +0100)]
Init topology-netconf when clustered topology starts

Change-Id: I527de936aeb88d58de5efa7dbd8463c38034dd2e
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoBUG 4930: Make keepalive executor definition actually non-mandatory 66/32766/1
Tomas Cere [Tue, 12 Jan 2016 16:14:03 +0000 (17:14 +0100)]
BUG 4930: Make keepalive executor definition actually non-mandatory

Yangtools started enforcing mandatory statements and keepalive
executor was not actually non-mandatory since name still inherited
mandatory true from the config model.

While we're here cleanup netconf connector module from leftovers
of the old topology-netconf connector design.

Change-Id: Ia2872f557f3cbc61df3130c7e55135148d29fde3
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoUpdate .gitreview for stable/beryllium 48/32648/1
Thanh Ha [Thu, 14 Jan 2016 21:47:01 +0000 (16:47 -0500)]
Update .gitreview for stable/beryllium

Change-Id: Ifc8f47f76f33348c54c73686982f1719827cdf98
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>