From 7e1c9a3ba9211a98027bd9da7dc84a4b2136eb84 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Fri, 5 Apr 2019 20:54:50 +0200 Subject: [PATCH] Fix logging arguments These are pointed out by upgraded spotbugs, fix them up. Change-Id: I766f1f26444fd10cc6858e5f064209fcf3d9860a Signed-off-by: Robert Varga (cherry picked from commit d41edebb31eda9b92e1d00a054472322e1da7d0a) --- .../netconf/sal/connect/netconf/sal/tx/WriteCandidateTx.java | 2 +- .../netconf/sal/connect/util/NetconfSalKeystoreService.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/WriteCandidateTx.java b/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/WriteCandidateTx.java index f99e765436..1eb47c9775 100644 --- a/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/WriteCandidateTx.java +++ b/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/WriteCandidateTx.java @@ -77,7 +77,7 @@ public class WriteCandidateTx extends AbstractWriteTx { @Override public void onFailure(final Throwable throwable) { - LOG.warn("Lock candidate operation failed. {}", throwable); + LOG.warn("Lock candidate operation failed", throwable); discardChanges(); } }; diff --git a/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/util/NetconfSalKeystoreService.java b/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/util/NetconfSalKeystoreService.java index 55b72d3a68..6608f21e6e 100644 --- a/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/util/NetconfSalKeystoreService.java +++ b/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/util/NetconfSalKeystoreService.java @@ -104,7 +104,7 @@ public class NetconfSalKeystoreService implements NetconfKeystoreService { writeTransaction.commit().addCallback(new FutureCallback() { @Override public void onSuccess(final CommitInfo result) { - LOG.debug("remove-key-pair success. Input: {}"); + LOG.debug("remove-key-pair success. Input: {}", input); rpcResult.set(RpcResultBuilder.success(new RemoveKeystoreEntryOutputBuilder().build()).build()); } @@ -139,7 +139,7 @@ public class NetconfSalKeystoreService implements NetconfKeystoreService { writeTransaction.commit().addCallback(new FutureCallback() { @Override public void onSuccess(final CommitInfo result) { - LOG.debug("add-key-pair success. Input: {}"); + LOG.debug("add-key-pair success. Input: {}", input); rpcResult.set(RpcResultBuilder.success(new AddKeystoreEntryOutputBuilder().build()).build()); } -- 2.36.6