From 9110c5921ba8f05ceafefb784bf95b1b1655d6d2 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 28 Jul 2022 20:00:15 +0200 Subject: [PATCH] MessageParts should be a class Using interface to hold constants is an antipattern, ditch it. Change-Id: I4b77c5d1ca6021f4381a17245ac3286ea36a08ac Signed-off-by: Robert Varga --- .../netconf/nettyutil/handler/MessageParts.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/handler/MessageParts.java b/netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/handler/MessageParts.java index 3db8ca6af0..a077671c7f 100644 --- a/netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/handler/MessageParts.java +++ b/netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/handler/MessageParts.java @@ -16,8 +16,12 @@ import org.opendaylight.netconf.util.messages.NetconfMessageConstants; * * @author Thomas Pantelis */ -interface MessageParts { - byte[] END_OF_MESSAGE = NetconfMessageConstants.END_OF_MESSAGE.getBytes(UTF_8); - byte[] START_OF_CHUNK = NetconfMessageConstants.START_OF_CHUNK.getBytes(UTF_8); - byte[] END_OF_CHUNK = NetconfMessageConstants.END_OF_CHUNK.getBytes(UTF_8); +final class MessageParts { + static final byte[] END_OF_MESSAGE = NetconfMessageConstants.END_OF_MESSAGE.getBytes(UTF_8); + static final byte[] START_OF_CHUNK = NetconfMessageConstants.START_OF_CHUNK.getBytes(UTF_8); + static final byte[] END_OF_CHUNK = NetconfMessageConstants.END_OF_CHUNK.getBytes(UTF_8); + + private MessageParts() { + // Hidden on purpose + } } -- 2.36.6