Jozef Gloncak [Wed, 21 Jan 2015 15:57:35 +0000 (16:57 +0100)]
BUG-2613: Migrating Openflow Specific models from controller project to openflowplugin project
Following changes are done:
*.* Moved all the bundle to openflowplugin/model directory
*.* Fixed all the relavent pom files to successfully build the projects
*.* Did not change bundle version of any of the project, just to avoid breaking any dependent project
changed model to model-parent under the same group as underlying models
As of now all the bundles moved to openflowplugin contains all the commit that is pushed till
following commit
$ git log -1
commit
6340a32c44b6a423d52fd98ce3c66bc480ab9246
Merge:
94d7e66 4c90ff7
Author: Tony Tkacik <ttkacik@cisco.com>
Date: Fri Jan 16 12:50:26 2015 +0000
Change-Id: If689af7878164bf460115d53691bb8dbae490c04
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
ary [Wed, 17 Dec 2014 16:19:07 +0000 (11:19 -0500)]
bug 2493 - eliminate the use of xtend and remove dependecies
Signed-off-by: ary <jatoth@cisco.com>
Change-Id: I2b2c49d93daf90c90e024d3af727f87957a8427e
michal rehak [Wed, 21 Jan 2015 09:39:58 +0000 (09:39 +0000)]
Merge "Revert "BUG-2613: Migrating Openflow Specific NSF from controller project to openflowplugin project""
Ed Warnicke [Wed, 21 Jan 2015 08:34:06 +0000 (08:34 +0000)]
Revert "BUG-2613: Migrating Openflow Specific NSF from controller project to openflowplugin project"
This reverts commit
7508539dcab1db1d5476baaf0200a322df7596b6.
Change-Id: I6068036341c51b110674080b2f56eed70916e319
Signed-off-by: Ed Warnicke <eaw@cisco.com>
michal rehak [Tue, 20 Jan 2015 21:46:02 +0000 (21:46 +0000)]
Merge "BUG-2613: Migrating Openflow Specific NSF from controller project to openflowplugin project"
Anil Vishnoi [Sun, 28 Dec 2014 17:16:52 +0000 (22:46 +0530)]
BUG-2613: Migrating Openflow Specific NSF from controller project to openflowplugin project
Following changes are done:
*.* Moved all the bundle to openflowplugin/application directory
*.* Fixed all the relavent pom files to successfully build the projects
*.* Did not change bundle version of any of the project, just to avoid breaking any dependent project
*.* Instead changed the bundle version in application pom.xml to 1.2.0 from 0.1.0, because all the
dependenct child project is offset two bundles.
Todo:
*.* Change the package name of models and source code according to new location
*.* Adapt downstream project in order to use these model projects
*.* remove models from controller repository
As of now all the bundles moved to openflowplugin contains all the commit that is pushed till
following commit
$ git log -1
commit
6340a32c44b6a423d52fd98ce3c66bc480ab9246
Merge:
94d7e66 4c90ff7
Author: Tony Tkacik <ttkacik@cisco.com>
Date: Fri Jan 16 12:50:26 2015 +0000
Merge "Fixed missing dependencies in netconf-netty-util."
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Ed Warnicke [Tue, 20 Jan 2015 18:33:49 +0000 (18:33 +0000)]
Merge "Adding feature odl-openflowplugin-nxm-extensions and configs."
Srini Seetharaman [Sun, 30 Nov 2014 05:29:10 +0000 (21:29 -0800)]
Adding feature odl-openflowplugin-nxm-extensions and configs.
This is part of the effort to move of-extensions from
ovsdb project to the openflowplugin project.
- moved nicira extensions into seaparate fatures depending on
ofplugin features
- renamed openflowplugin-extension-config to
openflowplugin-extension-nicira-config
- cleaned unused dependencies in ofplugin features
- suqashed configSubsystem config files into one
Change-Id: I1f11f0dc87fef340f13e9e012e003fbda3124b04
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
ary [Tue, 20 Jan 2015 13:06:11 +0000 (14:06 +0100)]
The high priority queue containing control messages is processed first(before data queue) in PollableQueuesPriorityZipper, if it is not queue with high priority then is used addSource in PollableQueuesPriorityZipper for use the PollableQueuesZipper.
Signed-off-by: ary <jatoth@cisco.com>
Prasanna Huddar [Tue, 20 Jan 2015 05:06:09 +0000 (05:06 +0000)]
Merge "BUG2608: Using the right buffer id for no buffer"
Colin Dixon [Mon, 19 Jan 2015 15:34:26 +0000 (09:34 -0600)]
BUG2608: Using the right buffer id for no buffer
Using OFConstants.OFP_NO_BUFFER everywhere I could find. Also, fixing
some whitespace issues where I encountered them.
Change-Id: I0a1447d460981941ebce8a5f9db697eec7599b58
Signed-off-by: Colin Dixon <colin@colindixon.com>
Srini Seetharaman [Fri, 31 Oct 2014 17:01:23 +0000 (10:01 -0700)]
Adding Nicira actions and match for NSH Index and path fields.
match.nsi, match.nsp, action.set_nsi and action.set_nsp.
This is part of the consolidation of Nicira OF extensions from
the OVSDB project.
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>
Srini Seetharaman [Thu, 30 Oct 2014 18:00:53 +0000 (11:00 -0700)]
Porting over the Nicira extension actions MULTIPATH and RESUBMIT from
the OVSDB project of-extensions folder to the OpenFlowPlugin project.
This is part of a consolidation effort.
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>
Tony Tkacik [Fri, 16 Jan 2015 09:21:59 +0000 (10:21 +0100)]
Bug 868: Replaced use of toInstance() for build().
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Ed Warnicke [Tue, 13 Jan 2015 15:09:48 +0000 (09:09 -0600)]
Remove deprecated BindingAwareProvider methods
https://git.opendaylight.org/gerrit/#/c/13806/
will remove deprecated BindingAwareProvider methods.
This patch simply removes them from openflowplugins
implmementation of that interface so when 13806 is
merged we can merge this to fix OFplugin.
Change-Id: I968d8df6f04732b84e1f93a7610394433547756b
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Thanh Ha [Fri, 9 Jan 2015 20:49:05 +0000 (15:49 -0500)]
Set root pom.xml <name> for Sonar
As mentioned on the mailing list Sonar uses the <name> field of the
pom.xml that is passed to the mvn command as the name of the project in
Sonar. In most cases this is the root pom.xml file in a project. This
patch sets the name to the project shortname.
https://lists.opendaylight.org/pipermail/discuss/2014-November/004024.html
Change-Id: I3a2f8d9cbc32decaed710aa55fa98f0df94c2b9f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
michal rehak [Thu, 8 Jan 2015 14:38:04 +0000 (14:38 +0000)]
Merge "Bug 2525 : remove zombie registrations of notification listener"
Martin Bobak [Mon, 8 Dec 2014 13:35:00 +0000 (14:35 +0100)]
Bug 2280 - MatchConvertorImpl bugs found during test creation
- changed PbbIsid mask byte[] legnth to 3
Change-Id: I7f6eb71bc9a2ea03778835f8232f8f5057a93296
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 18 Dec 2014 15:38:56 +0000 (16:38 +0100)]
Bug 2394 - ConnectionConductorImpl and HandshakeManagerImpl leak threads on exception paths
- added onHandshakeFailure method for proper handshake failure handling
- conductor's threadpool is shut down on handshake failure
- conductor's state changed to RIP on handshake failure
- introduced close method to handle necessary closing operations
Change-Id: I2fb19c5021620e3f3f4f98f7efec1d63120c11b4
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 17 Dec 2014 08:22:42 +0000 (09:22 +0100)]
Bug 2525 : remove zombie registrations of notification listener
Change-Id: I2863fa74cd7b287d760cf55e190dbceb4df629f4
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Anil Vishnoi [Mon, 5 Jan 2015 10:45:24 +0000 (16:15 +0530)]
Bug 2552 - Fix statistics manager log messages
Changed following log message :
org.opendaylight.openflowplugin - 0.1.0.SNAPSHOT | Session for the cookie null is invalid
To:
org.opendaylight.openflowplugin - 0.1.0.SNAPSHOT | No valid connection found for the node [datapath-id : [XXXX]]
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Vaclav Demcak [Tue, 9 Dec 2014 16:44:30 +0000 (17:44 +0100)]
Fix bug 1941 - Deleting of flows very slow with large number of flows
in data store and controller connected to the network
Flow mod flag OFPFF_SEND_FLOW_REM (send flow removed msg when flow
expires or is deleted) can not be set to "false" without this patch.
Old way to set flow mod flags contains value (e.g. _sENDFLOWREM=true)
but new implementation checks only a flag occurrence for set boolean
value to true. No occurence means false but FlowConventor set a defalut
true value without explicit own value.
+ patch2 - fix FlowModFlags TESTS
+ fixed FlowConvertorTest
(cherry picked from commit
0fa45756d6ef2810a42b08fef917a36509f1bfd8)
Change-Id: I777eceefe64535825ac258d9ab52d7bee3f83a0c
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Martin Bobak [Tue, 2 Dec 2014 10:14:16 +0000 (11:14 +0100)]
Bug 2407 - learning switch fails to install learnt flows
Change-Id: Ifdc121ffd9fa01bec2e6ce56c4054435a316e8d5
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Mon, 1 Dec 2014 09:29:26 +0000 (10:29 +0100)]
Bug 2452 - Topology incomplete (half of the links)
- initial operational status set to RUN
Change-Id: I22ff6863391405348b5937efa997fb7248809b23
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Anil Vishnoi [Fri, 28 Nov 2014 21:23:15 +0000 (02:53 +0530)]
Bug 2442 - UDP matching flow adds a match on dst port=0 (only occurs with OF10)
Existing code was incorrectly setting the wildcard flag for source port and destination port.
It was setting the flag if user specified source/destination IP address in match, so even if
user did not specified source/destination port, flag is getting set and thats why switch
thinks that port is not wildcarded and it set the port to default short value (0).
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Martin Bobak [Fri, 21 Nov 2014 10:13:42 +0000 (11:13 +0100)]
Bug 2428 - add rpc method for LLDP speaker to configure its operational status
Change-Id: I91e0246b47ad74e94b2bd3c14ed521b29607d43d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Shigeru Yasuda [Wed, 12 Nov 2014 17:13:25 +0000 (02:13 +0900)]
Bug 2369: Fixed NPE in update-flow RPC.
- Need to check whether match in update-flow input is null.
- Interpret null priority in update-flow input as default priority.
- Original flow should be removed if any of the following fields is
changed.
- idle-timeout
- hard-timeout
- flags
- cookie
Change-Id: I64c4ff66ce4965cbd8c9e9a608082ef2b5a84439
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Martin Bobak [Wed, 26 Nov 2014 14:59:14 +0000 (15:59 +0100)]
Bug 1953 - fix of this bugs impact on OFP
- fixed errors where Ipv4Prefix was instantiated without mask
- fixed errors where Ipv4Address was instantiated using mask
- fixed failing tests
Change-Id: I3a9270fc75128ab5fa7ee12bf92ad9a1cb324fc0
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Martin Bobak [Mon, 24 Nov 2014 14:52:42 +0000 (15:52 +0100)]
fix broken build
- updated config subsystem configuration for integration tests
Change-Id: I70054caaad8a91d1e676a6332ff40c24f84fde6a
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Shigeru Yasuda [Fri, 14 Nov 2014 07:48:49 +0000 (16:48 +0900)]
Bug 2388: Set node reference into OFPT_ERROR notification.
Change-Id: I5b7f23c4029e8cf2c6458086c6cadc5ff22912ed
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Martin Bobak [Tue, 11 Nov 2014 01:09:09 +0000 (02:09 +0100)]
BUG 2392 - learning switch listener registration fix
- WakeUpNode has to listen for operationl datastore changes
Change-Id: I5130c232fe52e688e6dbb007fa84d975a4d17c01
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Sun, 9 Nov 2014 20:27:39 +0000 (21:27 +0100)]
learning switch shifted to new data broker API
Change-Id: Ib74861c69490a5dc259bfe94c2c03c10ec91cb57
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Michal Rehak [Fri, 7 Nov 2014 11:49:29 +0000 (12:49 +0100)]
bug-2242: separating ofp applications
- created feature per app
(of-switch-config-pusher, lldp-speaker, tableMissEnforcer)
- added essential apps to odl-openflowplugin-flow-service
(of-switch-config-pusher, lldp-speaker)
Change-Id: I25f6595b9e6af47cf12ae05c7d4c76b0469222fa
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Fri, 7 Nov 2014 11:41:13 +0000 (12:41 +0100)]
BUG-1764: default config for OF switch - fix
- added routed registration
- added missing version property
Change-Id: I1ddfaa08672b7f9492b3951a44ab22513074c925
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Marian Adamjak [Mon, 3 Nov 2014 09:26:18 +0000 (10:26 +0100)]
BUG-2315: Remove dependency to OFJava-impl
- PacketInV10TranslatorTest switched to mocks
- code tidyup
Change-Id: I448d5354300f1b2e85503c9cc7445968ea2c8a4e
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Tue, 4 Nov 2014 14:16:02 +0000 (15:16 +0100)]
BUG-2242: separate apps
- added missing dependencies to config subsystem xml files
(type=xml, classifier=config)
Change-Id: I0b12fac8bc490983bc20b667bdf898abe64e31f4
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Colin Dixon [Mon, 13 Oct 2014 23:47:47 +0000 (18:47 -0500)]
Bug 2181: Switches now properly populate IP addresses
- removed session validity check when reading address
(session validity should be relevant for consumers and
not for internal processes)
- added unit test
- replaced deprecated ListenerRegistry class
- fixed imports, rebased
We now mark the switch context as valid <s>before</s>after notifying people.
Change-Id: I743b430c0d55e007f0ab18326f149ac46b3d4f66
Signed-off-by: Colin Dixon <colin@colindixon.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Anton Frolov [Sat, 4 Oct 2014 15:02:12 +0000 (19:02 +0400)]
BUG-2242: LLDP speaker as separate application.
* Remove LLDPSpeaker and all related classes and methods from openflowplugin
* Create separate LLDPSpeaker application
* Replace usage of Timer with ScheduledExecutorService which use monotonic
timer for delays instead of system time.
* Decomposed LLDPSpeaker into several classes to improve unit testabilty
* added lldp app to base distro
Change-Id: I997c74203af7461840c1c711355120b415995c06
Signed-off-by: Anton Frolov <anton.frolov@pacnet.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Martin Bobak [Thu, 30 Oct 2014 12:50:05 +0000 (13:50 +0100)]
Bug 2065 - Unset fields in MeterStatsResponseConvertor
- this commit needs this one to be merged https://git.opendaylight.org/gerrit/12381
Change-Id: Idb01266d87c45d9894b513b6299d9c1da07a5615
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Michal Rehak [Wed, 29 Oct 2014 17:36:17 +0000 (18:36 +0100)]
BUG-837: IT unstable
IT keep running forever because of change in OFJava + old change in OFPlugin-IT.
- fixed scenario for 2 hello handshake test (OFPluginToLibraryTest)
- fixed threading for scenario execution
Change-Id: I5af8248fd9c92f3bc2e02cac169c4f34599519d7
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Timotej Kubas [Fri, 19 Sep 2014 15:37:36 +0000 (17:37 +0200)]
BUG-1491: handle SET_TP_SRC/SET_TP_DST actions
- set_tp_src/set_tp_dst action corrected for setting of different protocols
(UDP,TCP, ICMPv4, ICMPv6)
- fixed tests
Change-Id: Ia53caaccc57b13d05d9a4ce18e4bf9354e81b69b
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Martin Bobak [Thu, 23 Oct 2014 10:42:49 +0000 (12:42 +0200)]
Bug 1764 - fixed features configuration for os-switch-config-pusher
Change-Id: Iaa1d0af3b2b8d5f5e9ec3ea8ef535ce084922155
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Michal Rehak [Thu, 16 Oct 2014 10:54:00 +0000 (12:54 +0200)]
BUG-1254: fix concurrent add/remove session test
- replaced executor service with logging impl
- mock tidy up
- ipaddress mockery added
- feature replaced for real object
- introduced action waiting mechanism based on future results
- added cleanUp of sessionManager singletons (SalRegistrationManagerTest)
- extended close functionality of SalRegistrationManagerOFImpl
- rebased
Change-Id: I2e3c26eb37b8f80f85a79b8fed63933eb62ccb96
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Martin Bobak [Thu, 16 Oct 2014 11:51:20 +0000 (13:51 +0200)]
Bug 1764 - added karaf settings for os-switch-config-pusher
Change-Id: I1d2739329ae346c58cb0d9370c01fe57fc926b08
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 15 Oct 2014 08:32:36 +0000 (10:32 +0200)]
Bug 1764 - implementation of default config pusher
Change-Id: I6f910c3b68f6e50fb3de2e12b01fc33bb28eb80c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 14 Oct 2014 12:35:38 +0000 (14:35 +0200)]
Bug 1764 - moved Session related interfaces to openflowplugin-api
- session related interfaces moved from implementation to api
- Extension related methods erradicated from SessionManager and
moved to extension-api's ExtensionSessionManager
- openflowplugin-api SessionManager and openflowplugin-extension-api ExtensionSessionManager
joined for openflowplugin neeeds in ConjuctSessionManager to provide functionality
of both apis
Change-Id: I947a59714900cb7e6d2fb7376c4d743e1764ac7b
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 14 Oct 2014 11:44:59 +0000 (13:44 +0200)]
Bug 1764 - created new bundle responsible for default OF switch configuration
Change-Id: Ie8f987be79dad4263d1e597efad2635e1460451a
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 14 Oct 2014 11:47:43 +0000 (13:47 +0200)]
Bug 1254 - corrected path for jacoco excluded classes
Change-Id: I1784235a516489b26c37423c9e0f6a50b7ee04e1
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Michal Rehak [Tue, 7 Oct 2014 14:53:44 +0000 (16:53 +0200)]
BUG-1680: default table-miss-entry feature
- added table-miss-entry-enforcer to features in order to have
it accessible in karaf
Change-Id: I5d58aad04d991d0a110cef0cd9b436ba9933d9d8
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Martin Bobak [Mon, 13 Oct 2014 07:13:01 +0000 (09:13 +0200)]
Bug 1254 - removed unused utility class
Change-Id: Iebcf340c09061251026a6357719d383de599c4d1
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Michal Polkorab [Tue, 7 Oct 2014 09:41:58 +0000 (11:41 +0200)]
Bug 1254 - Added unit tests for FlowConvertor, NotificationQueueWrapper and OpenflowPluginProvider
- also fixed OFToMDSalFlowConvertorTest - instruction type in testToSALInstruction()
was not set correctly
Change-Id: I3fb7a1a4d3c94d3c01ebf707d0d0d9431f56a17b
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Fri, 3 Oct 2014 12:03:48 +0000 (14:03 +0200)]
Bug 1254 - Added unit tests for ActionConvertor
- contains FIXME for SetNwSrc and SetNwDst ip address translation
Change-Id: If6c617e5b2d5452ca19c92b9a7dd632e07cda932
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Martin Bobak [Tue, 7 Oct 2014 11:21:51 +0000 (13:21 +0200)]
Bug 1254 - enhanced InventoryDataServiceUtilTest
Change-Id: I1b5833d6d2f02c6357e1ced4fef567a0e1bbd7ea
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Kamal Rameshan [Mon, 29 Sep 2014 04:22:01 +0000 (21:22 -0700)]
Bug-2098- Multipart Request flow was not set to the flow case
Change-Id: I64e286fb6a23c9c11966cc0287f85bc1c5192526
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Martin Bobak [Mon, 6 Oct 2014 11:50:24 +0000 (13:50 +0200)]
Bug 1254 - added test method for AbstractErrorTranslator#translate
Change-Id: I90d8a79051417b085827b7cdfc033826218927c9
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Mon, 6 Oct 2014 10:52:12 +0000 (12:52 +0200)]
Bug 1254 - added test of basic funcionality for ErrorHandlerSimpleImpl
Change-Id: Ide8c121d0bef3807aa707eafa36a8de156fe7522
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 30 Sep 2014 07:33:43 +0000 (09:33 +0200)]
Bug 1254 - added basic functionality test for OFRpcTaskUtil
- removed unused method OFRpcTaskUtil#wrapBarrierErrors
Change-Id: I6ad9cfdf22f12fd00fd6d8727e8cad730d788dae
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Fri, 26 Sep 2014 08:56:59 +0000 (10:56 +0200)]
Bug 1254 - added basic functionality test for TableFeaturesConvertor
Change-Id: Idd990ad4e479f4f67945e053a77ecc2de0ffe261
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Jakub [Fri, 3 Oct 2014 19:20:08 +0000 (21:20 +0200)]
BUG 1254 - test for PacketInV10Translator.java
Signed-off-by: Jakub <jatoth@cisco.com>
Michal Polkorab [Thu, 25 Sep 2014 12:25:29 +0000 (14:25 +0200)]
Bug 1254 - Added MatchConvertorImpl unit tests
- FIXME - mask computation of PbbIsid match entry (both ways)
- FIXME - add mask computation for ArpSpa and ArpTpa match entries
- TODO - finish implementation of vlan vid match entry - isVlanIdPresent() is not set
Change-Id: I9ba5da086584db2e678a79486376a0f9de4b30f0
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 30 Sep 2014 13:29:53 +0000 (15:29 +0200)]
Bug 1254 - Added NotificationPlainTranslator and TypeVersionKey unit tests
Change-Id: I3d2f6f52eaa4082660bc452f7d1160799d849359
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Rehak [Fri, 10 Oct 2014 07:48:19 +0000 (09:48 +0200)]
Switched back on dlux circular dependency for post-helium master
Change-Id: Ie0725cd0f5bccbec3c8a4867d22c99fdbf24b623
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Tue, 7 Oct 2014 11:43:25 +0000 (13:43 +0200)]
Incrementing versions by 0.1.0 for post-helium master branch
+ temporarily disabled dlux in features (pom.xml, features.xml) in order
to avoid cyrcular dependency during release
Change-Id: Ibc5c80c3252e1e3e52816b3ffc25ac3e5559e250
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Shigeru Yasuda [Wed, 1 Oct 2014 14:24:10 +0000 (23:24 +0900)]
Bug 2128: Send SET_CONFIG message to OF10 switch.
Change-Id: I8c596d0f2969ea054829955c2ca90fbeaab4e954
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Shigeru Yasuda [Wed, 1 Oct 2014 13:13:52 +0000 (22:13 +0900)]
Bug 2127: Fixed bugs in MatchConvertorImpl.fromOFMatchV10ToSALMatch().
* TOS value in NW_TOS match field needs to be converted into
IP DSCP value.
* DSCP match field should be configured into a MD-SAL match unless
NW_TOS wildcard bit is set in OF10 match.
Change-Id: Ie4d5dbf8a9db564a0e6785fea880b0d78cc1f499
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Shigeru Yasuda [Wed, 1 Oct 2014 10:37:42 +0000 (19:37 +0900)]
Bug 2126: Fixed bugs in MatchConvertorImpl.OfMatchToSALMatchConvertor().
* Convert IN_PORT match field value into URI of the specified
switch port.
* Copy CFI bit in VLAN_VID field into MD-SAL match.
Change-Id: I7098b99e20538bbaaab391b45b2c87b4157f7d90
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Ed Warnicke [Tue, 30 Sep 2014 19:59:32 +0000 (12:59 -0700)]
Bug 2103: Fix hash collisions preventing some switches from registering
Change-Id: I3131f80ebd2c6731febd600d3701f1de2bd23cd8
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Michal Rehak [Mon, 29 Sep 2014 13:40:46 +0000 (15:40 +0200)]
BUG-1994: IP ToS bits match field for OF 1.0
- fixed TOS conversion for match by OF-1.0
Change-Id: I57449e4b8413801e890e8add31819dbc39dc6190
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Ed Warnicke [Sat, 27 Sep 2014 21:29:24 +0000 (14:29 -0700)]
Bug:2103 Insure that we start the InventoryManager and friends first
If the InventoryManager and friends are not started before
the openflowplugin begins accepting connections, they may not
be informed and thus not record whole nodes.
Change-Id: I24be7991d3ee9022ca95b2e85bb8eb445cdf7dc9
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Martin Bobak [Thu, 25 Sep 2014 10:34:06 +0000 (12:34 +0200)]
Bug 1254 - added basic functionality tests for FeaturesV10ToNodeConnectorUpdatedTranslator
Change-Id: Ie4e6c31e1409387176993389521fee3618b098c7
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Jakub [Tue, 23 Sep 2014 10:50:06 +0000 (12:50 +0200)]
BUG 1254 - Test for PacketOutConvertor
Signed-off-by: Jakub <jatoth@cisco.com>
Change-Id: I45a8445966a3265eb86429eea666c86ee629b5d2
Abhijit Kumbhare [Fri, 26 Sep 2014 02:48:24 +0000 (02:48 +0000)]
Merge "BUG-2091: notification NodeRemoved and processing queue"
Martin Bobak [Wed, 24 Sep 2014 14:34:00 +0000 (16:34 +0200)]
Bug 1254 - yet another attempt to exclude yang generated files from sonar report
Change-Id: Ie9fc66fb359df518d716f8fc440a50c4b1577caf
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 24 Sep 2014 13:27:24 +0000 (15:27 +0200)]
Bug 1254 - added basic functionality test for FlowRemovedTranslator
Change-Id: I4f71f75575c5f43908c2ebd21996cacc98157bdc
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Abhijit Kumbhare [Thu, 25 Sep 2014 17:04:16 +0000 (17:04 +0000)]
Merge "Bug 2071: Check to see if we still have the switch in LLDPSpeaker"
Michal Rehak [Thu, 25 Sep 2014 16:32:18 +0000 (18:32 +0200)]
BUG-2091: notification NodeRemoved and processing queue
- NodeRemoved notification is now enqueued in the same way
as other notifications so that original order will be preserved
and "homeless" messages eliminated
- NodeUpdated must use the same way of delivery to MD-SAL in order
to preclude state where during reconnect nodeAdded would arrive
before nodeRemoved
Change-Id: Iede472870fac9ce12e7e5817c9b21967a2a43173
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Ed Warnicke [Thu, 25 Sep 2014 03:02:39 +0000 (22:02 -0500)]
Bug 2071: Check to see if we still have the switch in LLDPSpeaker
It can sometimes happen that we can loose our connection to a Node
Connector while we still have NodeConnectorUpdates to process.
When this happens, we will get a null md in LLDPSpeaker, and should
just drop the messages there.
Change-Id: Ie5810c5c00fbaeb7022f2496da7166edf109678d
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Michal Polkorab [Wed, 24 Sep 2014 13:45:10 +0000 (15:45 +0200)]
Bug 1254 - added unit tests for MultiPartReplyPortToNodeConnectorUpdatedTranslator
and MultipartReplyTableFeaturesToTableUpdatedTranslator
Change-Id: I3648eeb8ec37f93f53c1c3a93fc0853e4ed7ad5b
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 23 Sep 2014 15:56:00 +0000 (17:56 +0200)]
Bug 1254 - Added MultiPartMessageDescToNodeUpdatedTranslatorTest
Change-Id: Ic66f0a63f0634888d838b4d503817f7b42a00661
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 23 Sep 2014 14:39:24 +0000 (16:39 +0200)]
Bug 1254 - Finished MultipartReplyTranslator tests
- added tested method in javadoc
- renamed existing MultipartReplyTranslator tests with name ending with number
as those tests were not included in Sonar analysis
- contains TODO for MeterConfig case - missing flags translation and also
prec_level for DscpRemark band type
Change-Id: I72610f31bc0ba8991564e90b142f19d4b54ef65f
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Ed Warnicke [Thu, 25 Sep 2014 02:06:46 +0000 (21:06 -0500)]
Bug 2071: Improved Null checking and logging in LLDPSpeaker
Change-Id: Ic2717fd5f5abd163f334ef668e6027b525315dd1
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Ed Warnicke [Wed, 24 Sep 2014 20:06:39 +0000 (15:06 -0500)]
Bug 2068: Fix NPE in OFRPCUtil$1.onSuccess, improve logging.
Change-Id: I748b5e2dbf335a03bb7c3eaa1adbb5b468be8355
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Ed Warnicke [Wed, 24 Sep 2014 23:10:23 +0000 (18:10 -0500)]
Bug 2051: Catch exceptions in firePopListener
Change-Id: Idfeb9ec9e76e168df821554f8ab096de6d007b8a
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Martin Bobak [Tue, 23 Sep 2014 12:02:30 +0000 (14:02 +0200)]
Bug 1254 - added basic functionality test for LLDPSpeakerPopListener
Change-Id: I3e03964ed9f96158f940e714b1da0666253499c0
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Devin Avery [Wed, 24 Sep 2014 07:01:44 +0000 (03:01 -0400)]
Bug 2061 - DropRate and BurstSize swapped - fixed tests
This bug fixes an issue where the dropRate and burst size were swapped in code.
This bug also fixes the unit tests which tested for the bug instead. Made the test use hard-coded constants so inputs matched expected outputs which then caught the bug.
Signed-off-by: Devin Avery <devin.avery@brocade.com>
Ed Warnicke [Tue, 23 Sep 2014 02:09:58 +0000 (21:09 -0500)]
Bug 1948: Separate out restconf features
In order to avoid a maven project cycle in solving
Bug 1948, we need to separate restconf features.
Note, this is a first step, suffixing everything
with -new. Subsquently, after everywhere using
odl-restconf has been fixed to use this new repo,
we will deprecate the ones in the mdsal features.xml
and rename these to not have the -new.
This patch just adds the dependency to features/pom.xml
Change-Id: Ie22375e154848bbf5f7ab0336e6fb695e529c862
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Ed Warnicke [Mon, 22 Sep 2014 22:39:28 +0000 (22:39 +0000)]
Merge "BUG-1626: low cbench performance against dataStore"
Ed Warnicke [Mon, 22 Sep 2014 22:21:10 +0000 (22:21 +0000)]
Merge "BUG-1997: moving barrier after message"
Michal Rehak [Mon, 22 Sep 2014 16:19:25 +0000 (18:19 +0200)]
BUG-1626: low cbench performance against dataStore
- replaced constant flow.id with incremented value
Change-Id: Iae146611d54782805260c8341504ac6661213dc8
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Mon, 22 Sep 2014 20:39:12 +0000 (22:39 +0200)]
BUG-1997: moving barrier after message
- before <message>.isBarrier rendered into barrier exchange before message
now barrier exchange occurs after message
Change-Id: I1e4c4738eedef50b737a2d395123873156740df6
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Martin Bobak [Mon, 22 Sep 2014 12:42:13 +0000 (14:42 +0200)]
Bug 1985 - NPE when running groupbasedpolicy POC demo
- OFSessionUtild doesn't set session as valid anymore, session
management moved to SessionManagerOFImpl
- session validation/invalidation is synchronized
- when registration is about to be closed SalRegistrationManager checks
whether session from which registration is originated is valid
Change-Id: I2c523586676d3533aaf84afd2cecc38bd53181f4
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Ed Warnicke [Mon, 22 Sep 2014 00:12:30 +0000 (00:12 +0000)]
Merge "BUG-2012: stats via jmx failing with exception"
Michal Rehak [Sun, 21 Sep 2014 22:52:38 +0000 (00:52 +0200)]
BUG-2012: stats via jmx failing with exception
- removed trailing spaces on right (formatting experiment consequences)
Change-Id: Ic1048f994e33cb724d7a9b419dae8bdee26223ea
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Sun, 21 Sep 2014 08:54:43 +0000 (10:54 +0200)]
BUG-1988: OF Plugin changes the order of NodeConnector update events 2
- processing of messages is now turned on after features delivery
and service registrations - messages must wait till registration done
- moved enqeueueing of featureReply (for OF-1.0) in front of registration code
(for registration takes some time during which port updates arrive)
Change-Id: I0a25974b9c51eccb2772af44685c613b83dc098f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Prasanna Huddar [Sun, 21 Sep 2014 09:32:44 +0000 (09:32 +0000)]
Merge "Bug 1254 - Added unit tests"
Prasanna Huddar [Sun, 21 Sep 2014 09:32:25 +0000 (09:32 +0000)]
Merge "BUG-1952 Flow update rpc"
Michal Rehak [Sun, 21 Sep 2014 08:54:43 +0000 (10:54 +0200)]
BUG-1988: OF Plugin changes the order of NodeConnector update events
- processing of messages is now turned on after features delivery
and service registrations - messages must wait till registration done
Change-Id: Ibc08ccc176ae87c021e0741dcf672f6f2a98a341
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Tue, 16 Sep 2014 17:15:12 +0000 (19:15 +0200)]
BUG-1952 Flow update rpc
- in case that delete and recreate of flow is required then
the action after delete should be add -> was modify
- fixed xid propagation to notification
- using RpcResultBuilder
Change-Id: Idd519256519e32b2cd475b4cd954fe16f7518e66
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Polkorab [Fri, 19 Sep 2014 15:23:25 +0000 (17:23 +0200)]
Bug 1254 - Added unit tests
- + fixed MultipartReplyTranslator#getGroupActionsSupportBitmap()
Change-Id: Ie05f26b366da6e2edaf5ca6392b80ce81c018734
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Ed Warnicke [Sat, 20 Sep 2014 12:36:03 +0000 (07:36 -0500)]
Bug 1999: fix msgspy
Change-Id: Ie06d390170a092fb2f42f6b97d8544bd18ecad9d
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Code Review / openflowplugin.git / log