External api proposal

 - barrier renamed, cleaned
 - flow-basic cleanup: port, queue
 - added external API description
 - worked in API cleanup changes
 - flow-statistics cleaned
 - added echo rpc

Change-Id: Ibb8fd26909001c8a0c9e5690f9f182f39c78c9d9
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-2794: incorporate ofjava instruction changes

- https://git.opendaylight.org/gerrit/#/c/16039/3

Change-Id: I3a8dd0b9666a91ba438bbced8e2c9e45aeb2a59e
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

BUG-2794: Incorporated model Action api changes in OFJava to openflowplugin

- incorporated model changes from OFJava
- https://git.opendaylight.org/gerrit/#/c/15932

Change-Id: I199b1f39c172652a82806879e135652fb9a7e06d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

BUG-2794: incorporate openflowjava api changes to openflowplugin

 - rebased

Change-Id: I92f8ad211859c5f03c388fa1a32f28484b63efd1
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Use BigInteger.valueOf()

This is faster than parsing a string.

Change-Id: I7dc07dcf97fbb99ec2c6f5696048054e3c45d346
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-837: it unstable (added missing bundles)"

BUG-837: it unstable (added missing bundles)

 - added missing bundles (md-sal impls)

Change-Id: I7f6227ca7781abcdb0e2bf61f4c7c7e9e39a9a84
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "Bug 2753 - 4 managers api proposal."

BUG-837: it unstable (timeout to 60s)

 - changed timeout for resolving services to 60s

Change-Id: I8b9796f22cd5bdaef580875c6ff3661b26e99130
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Bug 2753 - 4 managers api proposal.

- proposal for new API manager
- HandshakeManager code cleanup
- added handshakeContext
- minor cleanup in connectionContext
- added features to connectionContext

Change-Id: Iba6b90247c54affa3be326f98f93b00d763b5402
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-837: it unstable

 - added additional timeout for resolving bindingAwareBroker

Change-Id: If838b5d0446303a13c6c7a1fe35dd98c26fda571
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Bug 868: Removed test code-duplicated from MD-SAL

Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Fix for bug#2861: areObjectsEqual doesn't check if storedMatch==null.

Change-Id: I86b337a6280d044f17bf9f87bdaf1672f3e15673
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "BUG-2608: LLDP packet-out for link learning should use OFP_NO_BUFFER"

BUG-2608: LLDP packet-out for link learning should use OFP_NO_BUFFER

Signed-off-by: Jamo Luhrsen <james.luhrsen@hp.com>

installation of rest in karaf openflowplugin distribution

Change-Id: I2bceb097ecd7d83977fc2ad3572bef8c2b5b0858
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Bug-2827: role switch proposal

- stub for entry point where propagation of role change should start
- logic for pushing role to device with failover
- added tests
- role change logic wired to openflowpluginprovider
  (change can by invoked via configsubsystem)
- added max retry limit
- comments worked in
- rebased
- comments worked in (whitespace, 1 method rename)
- worked-in configSubsystem change

Change-Id: I942d4b0e297543324c5fa0495f078834bee44899
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Fix of port-number model

 - reason: default union builder changed name (caused by generators change)
   (avoiding anonymous inner type is safer way)
 - fix:
   - promoted port-number inner type to typedef
   - renamed type in order to avoid name collisions (with leaf name and inet type)

Change-Id: I30b0532b5c74d52aa74b334e5f6d017cc116915f
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-2315: Remove dependency to OFJava-impl

- removed ofjava-impl deps (except distributions)

Change-Id: I75d4ef4e64b134322b9e7dae8d9b79ca4bba5c7f
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Revert "Bug-2827: role switch proposal"

This seems to be causing an NPE:
https://bugs.opendaylight.org/show_bug.cgi?id=2827#c2

Reverting to unblock downstream.

This reverts commit 9dd9664db32bd7fa972bd414fb4e02ec83ad8e83.
This reverts gerrithttps://git.opendaylight.org/gerrit/#/c/12644/

Change-Id: Iad8f2d5c840b203a04fa67d2be999bc74fc13d18
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Bug-2827: role switch proposal

- stub for entry point where propagation of role change should start
- logic for pushing role to device with failover
- added tests
- role change logic wired to openflowpluginprovider
  (change can by invoked via configsubsystem)
- added max retry limit
- comments worked in
- rebased
- comments worked in (whitespace, 1 method rename)

Change-Id: I6f43401821310c22a1b8b42c280e67f01ec9ed8f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

squashed test fix

 - remove import of non existing ForwardedBackwardsCompatibleDataBroker
 - fixed broken integration tests

Change-Id: Ia896dc5391624f4571f043abaf372536393e8751
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "BUG-2382: OutputActionBuilder.setOutputNodeConnector"

Merge "BUG 2757 - %s in logger."

Merge "BUG 2750 - remove of migrated class"

Merge "BUG-2661: Sonar issues for ofp-extension-api"

BUG 2757 - %s in logger.

%s was added to logger by mistake.

Change-Id: Iff37fcbba2508a8f15635d6cea4bc116da457a85
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG 2750 - remove of migrated class

REMARK:
can be merged after patch https://git.opendaylight.org/gerrit/#/c/15660/ (movement of functionality) will be merged.

Change-Id: Ibce31fe57ec53ffa566dcbad81706060c7c4a3a0
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Removal of obsolete distributions

 - distribution/base and distribution/cbench were based
   on controller's distribution/opendaylight which is already
   history.

Change-Id: Ia0df26094961d9b9f37268b56fea25ccbdac417e
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-2382: OutputActionBuilder.setOutputNodeConnector

 - use of OutputActionBuilder.setOutputNodeConnector in openflowplugin changed
   to proper form

Change-Id: I930aba68293a7498d0b2be61bf9a2c155637427a
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

BUG 2757 - repeating logging of warning.

Fixes repeating logging of warnings - "flow hashing hit a duplicate for"

Change-Id: I810def7f5c181ac962a18ec1544d2c6b2257ed35
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Merge "BUG 2661 - sonar issues in openflowplugin artifact - anonymous class2."

Merge "BUG 2661 - sonar issues in openflowplugin artifact - anonymous class."

BUG 2661 - sonar issues in openflowplugin artifact - anonymous class2.

Annonymous class was replaced with named inner class.

REMARK: it is possible that this commit will be reverted.

Change-Id: I57dc5f5e67497168b55e8b9da2d6eb49450303b8
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG 2661 - sonar issues in openflowplugin artifact - anonymous class.

Annonymous class was replaced with named inner class.

REMARK: it is possible that this commit will be reverted.

Change-Id: Ice30fbe21ae160ec6b1004644d1c1397ac0bec56
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG 2661 - sonar issues in openflowplugin artifact2

Some of sonar issues in openflowplugin artifact in package org.opendaylight.openflowplugin.openflow.md.core were solved.

Change-Id: Id2731f16cd5c026245cd6c3894dc1ca90b13c787
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG 2661 - sonar issues in statistics-manager

Fixing mistakes in bd6bb42d1998d417581c5ffc28812ad3d9386320.

Breake FlowComparator class to:
- MatchComparatorFactory
- MatchComparatorFactory
- SimpleComparator
- FlowComparatorHelper
- FlowComparator

Adding unit tests which cover new static methods created during breakage mentioned above.

Change-Id: I42aa8c1cc8bd88deef0d0591551508df7ad40e7a
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-2776: Mac Address masks in FlowRemovedTranslaton fails

 - replaced local join code with guava's BaseEncoding implementation

Change-Id: Iabb0b9b3820a92b922115f82763939457a10ea30
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Use odlparent:features-test instead of yangtools:features-test.

 - forgotten reference in surefire plugin configuration

Change-Id: Idb6144ea7dcb2f70c184c9cce7a1d6a598de529e
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "BUG 2754 - unit test cover for FlowComparator.StrIpToIntIp()"

Bug 2750 - migrate drop-test to drop-test-karaf.

Move methods _showDropStats(....) and _clearDropStats(....) from drop-test artifact to drop-test-karaf artifact.

Change-Id: Iaaa5cab7fd6f3774784a0121c7a98bbe3dbdfaae
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG 2754 - unit test cover for FlowComparator.StrIpToIntIp()

Cover FlowComparator.StrIpToIntIp() method with direct unit test in statistics-manager artifact.

Change-Id: I7b603fc036cfb89c41cf7e5533d2832c368c82c9
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Merge "Bug 2753 : interface HandshakeManager moved to openflow-api"

Bug 2753 : interface HandshakeManager moved to openflow-api

Change-Id: Ib7274bf53477435ac8b0c7b43e6fbc0be757c7b0
Signed-off-by: Martin Bobak <mbobak@cisco.com>

BUG 2661: Sonar issues for drop-test

- solving some technical debts in drop-test artifact

Change-Id: I3d6e42be72b9454b2f952b801d52938ef013fa69
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

Merge "Bug 2661 - method name should start with lower case letter"

Merge "BUG-1563 added default mac address and mac address for non-OF infrastructure to config"

BUG-1563 added default mac address and mac address for non-OF infrastructure to config

Signed-off-by: ary <jatoth@cisco.com>
Change-Id: I7872fb2801f88ce06db6240c1000eab89a7f4efe

Use odlparent:features-test instead of yangtools:features-test.

Change-Id: I8c6471cd980393e0f679ad007e521164c3a0cd41
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-2661: Sonar issues for ofp-extension-api

- some technical debts in artifact ofp-extension-api solved

Change-Id: I356bbf05b813d146d9e06afcd28cec82dd8a762b
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

BUG 2661 - sonar issues in statistics-manager

Removed some of sonar issues from statistics-manager artifact.

Change-Id: Ia69a3f37d0be625fc9003834dc25fc8a916816a0
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Bug 2661 - method name should start with lower case letter

Method names started with underscore

Change-Id: I650bc9b11b280a62bad270c30c681ce3c59483e9
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Merge "BUG 2661 - sonar issues in openflowplugin-api"

BUG 2661 - sonar issues in openflowplugin artifact.

Some of sonar issues in openflowplugin artifact in package
src.main.java.org.opendaylight.openflowplugin.openflow.md.core.sal.convertor
were solved

Change-Id: Ic795acae9159a7b67945f2db6d89b7918361b0ba
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG 2661 - sonar issues in openflowplugin-api

Some of sonar issues in openflowplugin-api artifact

Change-Id: I8f4c04b6c5e1937e48986d40dda49c2a3544a2e1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-837: IT fix

 - increased wait after handshake

Change-Id: I079d9798c42b15e76b95c440b5cbccb827fd49bd
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-2637: Create features for migrated apps

  - created features
  - replaced old md-sal flow* models
  - this change depends on disabling of apps and models in their
    old place in md-sal
  - fixed outdated dirty dependencies of features
  - added sal-compatibility
  - rebased
  - redirected features and IT to local models

see controller: https://git.opendaylight.org/gerrit/#/c/14464/

Change-Id: I6d7d4f1461bc7200e31736462a284ff94ed3b8f6
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Re-enable running of SingleFeaturesTest

For reasons I have not yet figured out, depending on the
yangtools version of features-test causes features tests
to no longer run.  This patch changes controller
to depending on the features-tests from odlparent

Change-Id: I70d6a8ea24d9b0546d9f9e94b65a0008f8a05708
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Merge "Remove repository and pluginRepository sections"

BUG 2661 - sonar issues in learning-switch

Some of sonar issues in learning-switch artifact were solved.

Change-Id: I423136cb503c8d9922eb7064ab2bd3eddd24d411
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

bug 2446 - High priority (control) queue stop reading from channel if is full

this patch depends on https://git.opendaylight.org/gerrit/#/c/14438/

Signed-off-by: ary <jatoth@cisco.com>
Change-Id: Ie990b1987d2210ec520648e081bb250588f4f342

Remove repository and pluginRepository sections

These sections have been moved to settings.xml, no need to carry them
here.

Change-Id: Idf669790957f7b9488f8e09c0c79bf56baa22f37
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-2661: Sonar issue"

Merge "BUG 2661 - sonar issues in test-common artifact"

Merge "BUG-2661:Sonar issue"

Merge "BUG-2706: Processing of messages from device starts too late"

BUG 2661 - sonar issues in test-common artifact

 - fixed atomic field updaters

Change-Id: Icdab410e12db4d1571e3d822dd9a796e0bcc5ff1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "Remove ganymed dependency"

Merge "Remove unused version declarations"

Merge "BUG-837: IT unstable"

Bug 2661 - printStackTrace() method call

Critical bug from sonar - printStackTrace() used. It was replaced with logger.

Change-Id: Id9aeb13c39f3cc659e267b472ca3886f7794e5fd
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Merge "BUG 2280 - mac address mask translation."

BUG-2661: Sonar issue

- solving technical depth

Change-Id: Ic9b92f38d4aa52f091c84648da009e482b3eb101
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

BUG-2661:Sonar issue

- introducing integration test for flow as a preparation for reducing complexity
  of test-provider

Change-Id: Ic87a91697f55dbd461517de4c79ff9fb11bc254a
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

BUG-2706: Processing of messages from device starts too late

Change-Id: I60a1f70db1bfaa00d69a0b40965d8c7f5f730e88
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

Remove ganymed dependency

Ganymed is no longer used in Helium, so remove it from dependency tree.

Change-Id: I6b35d5e72c21b91bb71ba8f0dc2cba21cbec09b0
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unused version declarations

These versions are not referenced anywhere -- remove them.

Change-Id: Ic6616bb2b7efde2eefbdd3c9c60cb2f43785c85f
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2665: jacoco configuration

 - removed experimental excludes
 - added global include configuration covering all packages from
   org.opendaylight.openflowplugin.*

Change-Id: Ic19d74766eebbedd963be40289f008e89c8b4be6
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-837: IT unstable

  - fixed threading and waiting for scenario execution
  - pulled simulator logic into common assistant class

Change-Id: Ic3373607033700179ed4a6097bd95c541e7c62f1
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "DO-NOT-MERGE-YET: Port description is not getting udpated when port removed from openflow switch"

Bug 2245 - OFJava corresponding change (package cycles decreased)

DO NOT MERGE UNTIL: https://git.opendaylight.org/gerrit/#/c/12321/ is merged
- decrease packages cycles

Change-Id: Ie9df1338e9ca77f085d002956f2aed716fea578a
Signed-off-by: Martin Uhlir <martin.uhlir@pantheon.sk>

Merge "Bug 2245 - OFJava corresponding change (Sonar technical debt)"

DO-NOT-MERGE-YET: Port description is not getting udpated when port removed from openflow switch

If user removed port from openflow switch, it generated port status message with reason - DELETE
But this message is not properly hooked to onNodeUpdateRemoved notification defined in inventory
models. This patch fixes the issue.

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

 BUG-2636: Wire sal-compatibility to local models

     - changed model version to match ofplugin
     - switched to local models
     - used temporary profile with dependencyManagement
       for migrated apps
     - temporary dependencyManagement moved to root pom

Change-Id: I7509dbe0718aaf38681cdc6ef3d3b6322b5eb1ff
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-2659: Changes package names to ofPlugin naming strucuture

Change-Id: I43a5b6b11b0e31fa7506f30c633bb7cd55622629
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

BUG-2613: Migrating sal-compatibility from controller project to openflowplugin
          project

Following changes are done:
    *.* Moved all the bundle to openflowplugin/legacy directory
    *.* Fixed all the relavent pom files to successfully build the projects
    *.* Did not change bundle version of any of the project, just to avoid breaking any dependent project
    *.* Instead changed the bundle version in application pom.xml to 1.2.0 from 0.1.0, because all the
    dependenct child project is offset two bundles.
    Todo:
    *.* Change the package name of models and source code according to new location
    *.* Adapt downstream project in order to use these model projects
    *.* remove models from controller repository

    As of now all the bundles moved to openflowplugin contains all the commit that is pushed till
    following commit
    $ git log -1
    commit 6340a32c44b6a423d52fd98ce3c66bc480ab9246
    Merge: 94d7e66 4c90ff7
    Author: Tony Tkacik <ttkacik@cisco.com>
    Date:   Fri Jan 16 12:50:26 2015 +0000

        Merge "Fixed missing dependencies in netconf-netty-util."

Change-Id: I7e99e324d64cde29e01832c265341abd23ceb53e
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Bug 2245 - OFJava corresponding change (Sonar technical debt)

DO NOT MERGE UNTIL: https://git.opendaylight.org/gerrit/#/c/14496/ is merged
- Synchronized Stack data structure replaced by unsynchornized Deque

Change-Id: Idaf3e9f563d5a569aca6a2ec73cbe0dbd773cc72
Signed-off-by: Martin Uhlir <martin.uhlir@pantheon.sk>

BUG 2280 - mac address mask translation.

Added ODL to SAL mac addres mask translation.

Change-Id: I6288e5dfa4b9fe77b98f39549e95b9e56e944ab1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Merge "BUG-2363: Wire NSF apps to local models"

Merge "BUG 2281 - Incorrect IP address conversion"

BUG 2281 - Incorrect IP address conversion

It looks like reported problem (do not cut the ip mask off) was fixed. Test is passing after uncommenting commented parts.

Change-Id: If81e4f675ac2bae25d57a18a14cf3e3802faecea
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG 2280 - mask check in laye3Match.

Only commented part of testing code was uncommented.

Change-Id: I2eb90e91d5bf1eeb52b071c2bac9a063e6092ab8
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-2363: Wire NSF apps to local models

 - changed model version to match ofplugin
 - switched apps to local models
 - introduced temporary profile with dependencyManagement
   for migrated apps

Change-Id: Ia8f43fc3e140cdcd1ef6359772b94a28c2abab63
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-2645: Unit test failing

 - changed assertEquals to assertArrayEquals

Change-Id: I08a18f216c24e70d1594299481e5778e63b97073
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "BUG-2621: Change project/package names of migrated statistics-manager"

Merge "BUG-2622: Change project/package names of migrated inventory-manager"

BUG-2622: Change project/package names of migrated inventory-manager

  - changed package names to ofPlugin naming structure

Change-Id: Ifafe1caf3a81d70cb51fd8b79ed4395fbbdb5c63
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-2621: Change project/package names of migrated statistics-manager

  - changed package names to ofPlugin naming structure
  - includes statistics-manager-config

Change-Id: I50b5c0736a9f69789a93f3ba63e5b488db9f88f8
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-2620: Change project/package names of migrated topoogy-manager

  - changed package names to ofPlugin naming structure
  - includes topology-lldp-discovery

Change-Id: I2a28616e003ea24042cc64af8dcd2fc31c12bde9
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-2615: Change project/package names of migrated FRM

 - changed package names to ofPlugin naming structure

Change-Id: I2d27816dd1222219b0e8dea4e35dedc1f26e7751
Signed-off-by: Martin Bobak <mbobak@cisco.com>