Changed methods in DeviceContext, created DeviceReplyProcessor interface

- changed methods in DeviceContext
- .processReply methods excluded into DeviceReplyProcessor interface
- both interfaces implemented in DeviceContextImpl
- added tests

Change-Id: I7a07d94c6c018feef562f5c7f4274871b2a28c69
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

statistics related services moved to separate package

- statistics related services are not exposed for MD-SAl

Change-Id: Id4c94fea6bad7d68ac095944f0d836e8fc2329b2
Signed-off-by: Martin Bobak <mbobak@cisco.com>

CommonService exposes more methods and parameters

Change-Id: I4aefe586b295b762547f3f754f541f533fac23a0
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DeviceContextReadyHandler propagates requst ctx and device ctx

Change-Id: I542b60a0b9de37249a2fdffdf01f05ceaeb3e264
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DataCrate becomes public

Change-Id: Ic414f6db60db32423eb0d34b60cdce3c231fcbbe
Signed-off-by: Martin Bobak <mbobak@cisco.com>

RpcContext extends RequestContextStack

Change-Id: Ifa8ec430bc05ade99d0e88b149040526e06687d7
Signed-off-by: Martin Bobak <mbobak@cisco.com>

removing request context from a stack extracted to separate interface

Change-Id: Ifafb333f4385d1bb3bb0b5b213e32de63aaa70f0
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DeviceContext API cleanup

- removed comments
- removed method sendRequest()

Change-Id: I9b2c9ce5c087066663ee293afdafbbec23b9fd91
Signed-off-by: Martin Bobak <mbobak@cisco.com>

 CommonService publishes its methods and properties

Change-Id: I89d6f287e90d5c71e2ca4a78cc5c4b605451b9fa
Signed-off-by: Martin Bobak <mbobak@cisco.com>

added feature odl-openflowplugin-new-southbound

- rebased

Change-Id: I68ba2436525f0a46365c6e57326b77bef83f4992
Signed-off-by: Martin Bobak <mbobak@cisco.com>

api from impl separation : created openflow-provider.yang in API

Change-Id: Ifa91422c8857ff531530195cc5ce60a31140f824
Signed-off-by: Martin Bobak <mbobak@cisco.com>

added missing dependency in artifacts

Change-Id: I29bf9ff404985052121547594780e436c0bf09ed
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Fix merge job not working

As it turns out while moving out the parent pom contents I failed to
mention parent in the aggregator, which meant that the reactor was not
properly resolved locally.

Change-Id: Iffd390020cae2c9b0e2f8106edb856c5745b4550
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not mention enunciate

Enunciate is incompatible with Java 8 and is not used anywhere in this
project. Remove its mention in m2e mapping.

Change-Id: Ieb1c78563930088a5d072cbd84c43997e1327700
Signed-off-by: Robert Varga <rovarga@cisco.com>

Move openflowplugin-parent

Parent should be in a subdirectory, so we have a top-level aggregator.

Change-Id: I8b82b585acd0646d23904125b95d743b323aa8d7
Signed-off-by: Robert Varga <rovarga@cisco.com>

Start openflowplugin-artifacts

Inter-project dependencies are better tracked through a single artifact.
All our upstream projects already define one, so let's follow their
lead.

Change-Id: Iead4c5653bab895a5b0b404f24fffb01975f44f2
Signed-off-by: Robert Varga <rovarga@cisco.com>

Refactor dependency management to import upstream artifacts

Upstream projects are exposing appropriate dependencyManagement section
in $project-artifacts. Import them to simplify dependency declarations.

Change-Id: Iec4af832e22857a0147c08c9deda3830351d44b5
Signed-off-by: Robert Varga <rovarga@cisco.com>

Unify property definitions

Change-Id: I6d9da75cd6903c8695d996c6178025394388e625
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix Jdk8 compatibility

JDK8 has stricter javadoc rules, make sure we do not fail on them.

Change-Id: I13ae2d0cc750faf66dc4f0c41a7982f9e9aae4cb
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "unifying statistics manager api packages"

Revert "PostHandshakeNodeProducer help class"

According to author - this change needs to get reworked;

This reverts commit a29553293e059ea656ec0bb3339d6e261ecf081b.

Change-Id: I686c4dbddec9f30ce61d23104a2ff292a5bd14bb
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Setting xid to request context in all services.

All of the services currently set request context xid value to
xid which is generated in each service.

Change-Id: I74935bafc4c5008619fceb3f2fbcc7160debf744
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

FlowService - standalone request context for multiflow input

If input flow is devided to more (2 maybe more) flows then result
Future isn't chained but for every flow is created standalone
request context with unique Xid. Methods addFlow and updateFlow
return future object which will contains global result of all
partial futures (if one fail then global fail, if all success then
global success)

Change-Id: I0406888a0568d6ba3905113cde69e2a96aa78141
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Wrap service handlers to method handleServiceCall.

Handling code in service handlers (expect PacketProcessingServiceImpl) were wrapped
to handleServiceCall() method.
Method handleServiceCall() was moved to CommonService abstract class

Change-Id: I027f1b0658b4805366748377dfd43ca9c102df44
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Hooking of Request context from services to device context

Change-Id: If19db05a23f3c7141cf4a044d1273fad0c25ca2b
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Added Xid and waitTimeout getter and setter.

Getter and setter methods for Xid and waitTimout fields
were added to interface RequestContext .

Change-Id: I85cc92f6729aac37b3a2e1cba51a67e08f3a2026
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Handle exceptional state while closing RequestContext.

Current close() method is wrong one. Correct one if from AutoClosable
interface and raises Exception.

Change-Id: I7fe8d65c3ac5c7ab036cee1da642c8e3c7672162
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

DeviceContext constructor and some final property exposed methods

Note: DeviceContext has to implement TransactionChainListener
to catch async Transaction DataStore write process. So we've
changed a DeviceContext interface for providing WriteTransaction
(tx for putting new data to DataStore) and fresh ReadTransaction
which provide a possible different DataStore snapshot, but what
could make a written transaction as fast as is possible.

* DeviceContextImpl constructor, Transaction get/set methods;
* DeviceContextImplTest - add/fix relevant tests
* DeviceManager - commented out all out of date code

Change-Id: Ida5ce3d47aeffcb6dd2f987f26d62edcc696b2e7
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Merge "DeviceState implementation"

Merge "PostHandshakeNodeProducer help class"

Merge "MultipartRequestInputFactory"

Merge "MultiMsgCollector moving package"

unifying statistics manager api packages

Change-Id: I29b495fd26c45ce50e73b96c9d23380eeb09f4c1
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DeviceState implementation

Note: DeviceState is a basic object which we need to populate
from ConnectionContext and it has to be a input object for
DeviceContext. So this implementation has to be before
DeviceContext implementation in the chain order.

* DeviceState interface - fix getNextXid and getPortsBandwidth methods
* impl DeviceStateImpl
* impl test suite in DeviceStateImplTest

Change-Id: Iadf19754c3373b25a6a320c676118d13338a0097
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

PostHandshakeNodeProducer help class

Note: PostHandshake process has to populate complex static information about
new FlowCapableNode before add DataStore process. But whole postHandsake
process contains a lot of functionality which is related only this short
time window so we put it to one class together. This new helper has to be
forgotten after succesfull add to DataStore process and it doesn't need
to be a part of DeviceManager code.

* settableFuture<Node> produce new Node with all device info and features
  * collecting Devide description
  * collecting Device meterFutures
  * collecting Device grupFutures
  * collecting Device tableFutures (TODO : add DataStore model and finish impl)

(Tests and possible fixies for this class will be
 a part of DeviceManager#deviceConnected method implemenation and its test suite)

Change-Id: I84fdd3004f211590d5066711518490cd134d6573
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Fixed (de)serialization issue

 - fixed: TunnelIdValue -> TunIdValue (model misuse)
 - fixed: removed masks from setField (SetDlSrc, SetDlDst)

Change-Id: I96e4f9e3eda0cb26b455f68c9453441e07133c3a
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

MultipartRequestInputFactory

Note: Factory class produces MultipartRequestInput object
for ConnectinAdapter.multipartRequest method. Class should
help a newbie to understand relationship between MultipartType
and set MultipartRequestBody children.

* factory class with an input validation
* test suite for factory MultipartRequestInput

Change-Id: Id728fa3e6f15cf8c83442a23b0b118fd35f2c5ee
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

MultiMsgCollector moving package

Note: MultiMsgCollector is logicaly part of ConnectionContext no DeviceContext,
so we move all implemented classes and interface to correct package.

* change package for MultiMsgCollector MultiMsgCollectorImpl
MultiMsgCollectorImplTest
* add validation for same MultipartType for same XID
* add MuliMsgCollector to ConnectionContext + implementation
delegated methods
* implement onMultipartReplyMessages method from
OpenflowProtocolListenerImpl + test

Change-Id: I3caeb83c46c9a107c8e36ce7630cee4e75fca815
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Merge "Feature/Bug#2774: Decrease verbosity of flow hash duplicate."

Merge "added yang file describing openflowplugin-impl as CoSS module"

Feature/Bug#2774: Decrease verbosity of flow hash duplicate.

Patch set 3: Add more info on code path when debug is enabled.

Change-Id: Ifd722e7e427c1ebca53636d371dcf6187911b95b
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "separation of api and impl - crated openflowplugin types yang"

added yang file describing openflowplugin-impl as CoSS module

Change-Id: I0ed0158e4815516e9255301c89f9bf31f460e82a
Signed-off-by: Martin Bobak <mbobak@cisco.com>

separation of api and impl - crated openflowplugin types yang

Change-Id: Iebcd7659a9d76d53c2dada234d0f8d466da87281
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Implemented DeviceContext.hookRequest and DeviceContext.processReply

Change-Id: I7f440dd8623f051e071e923636c7d3d3835d9f14
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

Added type parameteris.

Class type parameter was added to all classes in this change.

Change-Id: I7cd27edef23b7b52bcc2d32d42f7feac3e7a9b4c
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Statistics services implementation and cleanup

Change-Id: I550fb3666d021283c283398c07a95d12330c6eb3
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Implementation of services Sal*Service and PacketProcessing

Implementation of:
- SalFlowService
- SalGroupService
- SalMeterService
- SalPortService
- SalTableService
- PacketProcessingService

Picking common functionality to ServiceCallProcessingUtil.

Change-Id: I071280e2d5cab7ea201c8ea829f89ca4a300b178
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

implementation of GroupStatisticsService

Change-Id: Idb7ce9a185ae88a3216ead053d487034d7ed541b
Signed-off-by: Martin Bobak <mbobak@cisco.com>

implementation of FlowStatisticsService and FlowTableStatisticsService

- introduced RequestInputUtils

Change-Id: I71490ef9e65039b0c8d3d41357af7227d155508e
Signed-off-by: Martin Bobak <mbobak@cisco.com>

implementation of FlowStatisticsServiceImpl

Change-Id: Icde601bd22d662de777304b3feba5177e5268d3b
Signed-off-by: Martin Bobak <mbobak@cisco.com>

implementation of NodeConfigService

- introduced RpcResultConvertor for converting OFJava future to  requestContext's future
- RpcResultConvertor used in SalFlowServiceImpl

Change-Id: I11dc0e6f15920dab3323128749a877532a0486f8
Signed-off-by: Martin Bobak <mbobak@cisco.com>

auxiliary connections stored in DeviceContext

Change-Id: I41ccc99e797cb0419d9d4655998573478af79551
Signed-off-by: Martin Bobak <mbobak@cisco.com>

SalFlowServiceImpl - implementing methods

Contains pattern implementation (service call + handling of exceptional states)
for all ramaining services.

Change-Id: Ic7a4b16bd79347e63b742ea7ec393f36ba01a6e6
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Implementation of services

Change-Id: I408a6360ffd31d2b04682ee1bc47c60a58f1df93
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Static methods on XidGenerator changed to non-static

Change-Id: I9d626793db7158a88eb287f3a180422271679167
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

creation of settable future extracted to separate interface

- creation of settable future was extracted from RequestContext
  to separate interface RequestFutureContext

Change-Id: I9ff7f7a074f33f8e8863f63362c933ec47dac89d
Signed-off-by: Martin Bobak <mbobak@cisco.com>

RpcContext and RequestContext implementation

- implementation used in SalFlowServiceImpl

Change-Id: I3b000526d9a1102464ca5ab8b81af00e5f98f2bb
Signed-off-by: Martin Bobak <mbobak@cisco.com>

XID holds only long value doesn't generate new values

Change-Id: Ia1ee8c8510840f1fdf33b7d52ec0c38147a70c40
Signed-off-by: Martin Bobak <mbobak@cisco.com>

API changes in RequestCtx and DeviceCtx

Change-Id: Id671b7782cdc2133b3c108416fa8d7def03d3670
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Implementation of Rpc interfaces

Implementation classes were created for interfaces RequestContext, RpcContext, RpcManager.
MdSalRegistrationUtils class for registration of services

Change-Id: I8f1f7e7342e04f94f74f7900eeaede3515b37f73
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

RequestContext implementation

Change-Id: I566ff0168e061d15271d931fda61e0b193b74139
Signed-off-by: Martin Bobak <mbobak@cisco.com>

RpcContext and RequestContext API fine tuning

Change-Id: Ib9ffa744b2b0e483ced2dbe07cf5fb6dd439b5cb
Signed-off-by: Martin Bobak <mbobak@cisco.com>

evolved API

- device context offers primary and auxiliary connection contexts
- RpcContext and RequestContext offers generic way of invoking rpc call

Change-Id: Icafafdb7c64e5c43a0d4675ee360e177d8f0d69e
Signed-off-by: Martin Bobak <mbobak@cisco.com>

package naming cleanup

Change-Id: I4dfd1d0a09260220ff56c23cf57a72da1b7b46f2
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Rpc

adding RpcContextImpl and RpcManagerImpl

Change-Id: I57ba3d71f3b3bddcf40b6527fe76b34d97eb376e
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Refined Request Context and RpcContext API

- addRequest method moved from RequestContext to RpcContext
- returning value of addNewRequest was changed to Future
- request quota counter moved to RpcContext
- removed setter for deviceContext from RequestContext

Change-Id: I87c99b584622a58284f96acc2171ce87946ce704
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

MultiMsgCollector for Multipart response messaging

Note: OF device could return Multipart msg response for a requests.
So we would like to have one-to-one contract for request-to-CollectionResponse
and we will able to identify differences between actualState and
a future state.

* MultiMsgCollector interface - a definition
* MultiMsgCollectorImpl class - implementation of definition with
internal Cache for collecting MultipartResponseMessages
* MultiMsgCollectorImplTest   - test suite for testing basic
functionality

Change-Id: I920e2ee69929ed874304116da6711ab3f2dfb159
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DeviceContext proposal

 - initial test

Change-Id: I21c7d49bc2ac6a41fbdef2c7f994195a7141cee0
Signed-off-by: Martin Bobak <mbobak@cisco.com>

ConnectionManager proposal

 - created impl for new proposal
 - connection manager and friends
 - timeout in test

Change-Id: Ice0f4b4655be5c933d429cd9b74898a4fd326fe6
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

fix log loop

 - set scope of all slf4j-log4j12 dependencies to test in order not to
   mix up feature tests where log4j-over-sl4j is active

Change-Id: I51d47e9884d328d6bef528e0ce655e10fe8269b8
Signed-off-by: Martin Bobak <mbobak@cisco.com>

External api proposal

 - barrier renamed, cleaned
 - flow-basic cleanup: port, queue
 - added external API description
 - worked in API cleanup changes
 - flow-statistics cleaned
 - added echo rpc

Change-Id: Ibb8fd26909001c8a0c9e5690f9f182f39c78c9d9
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-2794: incorporate ofjava instruction changes

- https://git.opendaylight.org/gerrit/#/c/16039/3

Change-Id: I3a8dd0b9666a91ba438bbced8e2c9e45aeb2a59e
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

BUG-2794: Incorporated model Action api changes in OFJava to openflowplugin

- incorporated model changes from OFJava
- https://git.opendaylight.org/gerrit/#/c/15932

Change-Id: I199b1f39c172652a82806879e135652fb9a7e06d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

BUG-2794: incorporate openflowjava api changes to openflowplugin

 - rebased

Change-Id: I92f8ad211859c5f03c388fa1a32f28484b63efd1
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Use BigInteger.valueOf()

This is faster than parsing a string.

Change-Id: I7dc07dcf97fbb99ec2c6f5696048054e3c45d346
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-837: it unstable (added missing bundles)"

BUG-837: it unstable (added missing bundles)

 - added missing bundles (md-sal impls)

Change-Id: I7f6227ca7781abcdb0e2bf61f4c7c7e9e39a9a84
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "Bug 2753 - 4 managers api proposal."

BUG-837: it unstable (timeout to 60s)

 - changed timeout for resolving services to 60s

Change-Id: I8b9796f22cd5bdaef580875c6ff3661b26e99130
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Bug 2753 - 4 managers api proposal.

- proposal for new API manager
- HandshakeManager code cleanup
- added handshakeContext
- minor cleanup in connectionContext
- added features to connectionContext

Change-Id: Iba6b90247c54affa3be326f98f93b00d763b5402
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-837: it unstable

 - added additional timeout for resolving bindingAwareBroker

Change-Id: If838b5d0446303a13c6c7a1fe35dd98c26fda571
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Bug 868: Removed test code-duplicated from MD-SAL

Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Fix for bug#2861: areObjectsEqual doesn't check if storedMatch==null.

Change-Id: I86b337a6280d044f17bf9f87bdaf1672f3e15673
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "BUG-2608: LLDP packet-out for link learning should use OFP_NO_BUFFER"

BUG-2608: LLDP packet-out for link learning should use OFP_NO_BUFFER

Signed-off-by: Jamo Luhrsen <james.luhrsen@hp.com>

installation of rest in karaf openflowplugin distribution

Change-Id: I2bceb097ecd7d83977fc2ad3572bef8c2b5b0858
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Bug-2827: role switch proposal

- stub for entry point where propagation of role change should start
- logic for pushing role to device with failover
- added tests
- role change logic wired to openflowpluginprovider
  (change can by invoked via configsubsystem)
- added max retry limit
- comments worked in
- rebased
- comments worked in (whitespace, 1 method rename)
- worked-in configSubsystem change

Change-Id: I942d4b0e297543324c5fa0495f078834bee44899
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Fix of port-number model

 - reason: default union builder changed name (caused by generators change)
   (avoiding anonymous inner type is safer way)
 - fix:
   - promoted port-number inner type to typedef
   - renamed type in order to avoid name collisions (with leaf name and inet type)

Change-Id: I30b0532b5c74d52aa74b334e5f6d017cc116915f
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-2315: Remove dependency to OFJava-impl

- removed ofjava-impl deps (except distributions)

Change-Id: I75d4ef4e64b134322b9e7dae8d9b79ca4bba5c7f
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Revert "Bug-2827: role switch proposal"

This seems to be causing an NPE:
https://bugs.opendaylight.org/show_bug.cgi?id=2827#c2

Reverting to unblock downstream.

This reverts commit 9dd9664db32bd7fa972bd414fb4e02ec83ad8e83.
This reverts gerrithttps://git.opendaylight.org/gerrit/#/c/12644/

Change-Id: Iad8f2d5c840b203a04fa67d2be999bc74fc13d18
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Bug-2827: role switch proposal

- stub for entry point where propagation of role change should start
- logic for pushing role to device with failover
- added tests
- role change logic wired to openflowpluginprovider
  (change can by invoked via configsubsystem)
- added max retry limit
- comments worked in
- rebased
- comments worked in (whitespace, 1 method rename)

Change-Id: I6f43401821310c22a1b8b42c280e67f01ec9ed8f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

squashed test fix

 - remove import of non existing ForwardedBackwardsCompatibleDataBroker
 - fixed broken integration tests

Change-Id: Ia896dc5391624f4571f043abaf372536393e8751
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "BUG-2382: OutputActionBuilder.setOutputNodeConnector"

Merge "BUG 2757 - %s in logger."

Merge "BUG 2750 - remove of migrated class"

Merge "BUG-2661: Sonar issues for ofp-extension-api"

BUG 2757 - %s in logger.

%s was added to logger by mistake.

Change-Id: Iff37fcbba2508a8f15635d6cea4bc116da457a85
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG 2750 - remove of migrated class

REMARK:
can be merged after patch https://git.opendaylight.org/gerrit/#/c/15660/ (movement of functionality) will be merged.

Change-Id: Ibce31fe57ec53ffa566dcbad81706060c7c4a3a0
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Removal of obsolete distributions

 - distribution/base and distribution/cbench were based
   on controller's distribution/opendaylight which is already
   history.

Change-Id: Ia0df26094961d9b9f37268b56fea25ccbdac417e
Signed-off-by: Michal Rehak <mirehak@cisco.com>