Code Review / ovsdb.git / log
? search:
summary | shortlog | log | commit | commitdiff | review | tree
first ⋅ prev ⋅ next
ovsdb.git
9 years agoSquashed commit of the following: 73/20473/1
commit | commitdiff | tree
Sam Hague [Fri, 15 May 2015 02:56:20 +0000 (22:56 -0400)]
Squashed commit of the following:

commit dcc9311c5de4a178ffe53c93959ac4e54da30c5f
Merge: fbff755 8e14a99
Author: Sam Hague <shague@redhat.com>
Date:   Thu May 14 21:24:40 2015 -0400

    Merge branch 'master' into topic/netvirtsbmerge

    Conflicts:
     southbound/southbound-it/src/test/java/org/opendaylight/ovsdb/southbound/it/SouthboundIT.java

    Change-Id: I46888c0d5ceb1dcdda559be194f7e09a0b902095
Signed-off-by: Sam Hague <shague@redhat.com>
commit fbff755cb910e18238ba04bf01b760486fd1f4a5
Merge: 1597fb6 7271ca4
Author: Sam Hague <shague@redhat.com>
Date:   Fri May 15 01:20:59 2015 +0000

    Merge "Cleanup features.xml files" into topic/netvirtsb

commit 7271ca49e29ef37df8bc155ee17f82604f4a25d1
Author: Sam Hague <shague@redhat.com>
Date:   Thu May 14 21:19:05 2015 -0400

    Cleanup features.xml files

    Change-Id: I9d63cea9b341979f95b632c2a19193ddf8af8f1b
Signed-off-by: Sam Hague <shague@redhat.com>
commit 1597fb660db4b9aeeb24c2701052137d08bf6f5b
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Thu May 14 17:19:06 2015 -0400

    Make NeutronL3Adapter node filter out non br-int bridges

    Patch 2: use MdsalUtils.getBridge()
    Patch 3: remove unused import

    Change-Id: I4daf0d086e156d7540b7dd3b829a9fbf8783cd1f
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit ebdb94dc5ef34b87c416c07dfe8422bbb9534c5a
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu May 14 23:53:33 2015 +0530

    Do-Not-Merge-It-Yet : Removed dependency over netvirt.api#OvsdbConnectionService
    Instead using NodeCacheManager service
    This patch builds fine.

    Todo: Testing network delete with this patch

    Change-Id: Ia1c848d4f2effaedd29929fd8a034d89c6aed0a9
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 97e651f31720351cec6e13b8906fd473a9c7500c
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu May 14 19:51:32 2015 +0000

    Revert "custom logging--do not merge"

    This reverts commit 3fd5fa34e138be2e6fa773a57b8384353946397c.

    Change-Id: I88352e97f1f87d0c81e5b3f8ea54e8d250819d9d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 4566551c448b19d374536985ace5dc6401c71a29
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu May 14 17:36:07 2015 +0530

    Fix flow cleanup when on port delete

    Change-Id: Ie1308fce961d6eac9948630d285c96a679e3ce29
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 3fd5fa34e138be2e6fa773a57b8384353946397c
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu May 14 17:34:50 2015 +0530

    custom logging--do not merge

    Change-Id: I8ebe65c26888e796a984296756c1ab1448055d49
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit c71a6aa10a1fd2b2c5836287aaef2c4405b62fa9
Author: Sam Hague <shague@redhat.com>
Date:   Thu May 14 15:23:29 2015 -0400

    Add netvirt integration tests

    Change-Id: I3fb27e0bbfb41251859a8eda3ee90aff1cb27645
Signed-off-by: Sam Hague <shague@redhat.com>
commit f6e26f85b2ce887081d9428cfcce3f51553b7dbf
Author: Sam Hague <shague@redhat.com>
Date:   Thu May 14 10:25:24 2015 -0400

    Add some debugging for vlan case

    Change-Id: Ib84d1f73da44364a9648209eef45ccef6c3173ec
Signed-off-by: Sam Hague <shague@redhat.com>
commit b2781a5ccbcbea3daa09c3ccc0182c05ba45b407
Merge: 82fdc59 097b809
Author: Sam Hague <shague@redhat.com>
Date:   Thu May 14 07:50:37 2015 -0400

    Merge branch 'master' into topic/netvirtsbmerge

    Conflicts:
     southbound/southbound-it/src/test/java/org/opendaylight/ovsdb/southbound/it/SouthboundIT.java

    Change-Id: I2f883829e029c074fc564f589805a924b3b514e0
Signed-off-by: Sam Hague <shague@redhat.com>
commit 82fdc597e0aa3d66481432d91a18646ed1fde1b7
Author: Sam Hague <shague@redhat.com>
Date:   Wed May 13 20:56:58 2015 -0400

    Allow terminationPoints to not need an interfaceType

    Change-Id: I3cb09cb16535fc5e23e3a5f976d0095a16208db2
Signed-off-by: Sam Hague <shague@redhat.com>
commit dbf3e656265ee873788b897f6978e52d7a54b301
Author: Sam Hague <shague@redhat.com>
Date:   Wed May 13 20:56:27 2015 -0400

    vlan fixes

    Change-Id: I76a0e55f0801d1ad02ba0fc3e155153b5aadd730
Signed-off-by: Sam Hague <shague@redhat.com>
commit 56beeb4be24f8f568faad03f6c29cea9a3c16b22
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu May 14 04:20:46 2015 +0530

    Fixed illegalStateException while creating tunnel termination point

    Change-Id: I5877034bf70a2e1c80bd18600b12f7dd9807a863
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit a4e39b8bc086c670ac1c92ccfffdfd8eff3fe738
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu May 14 00:51:46 2015 +0530

    Fixed tunnel port configuration

    Change-Id: I1119289749aa2b025afb90f47d37ccf67e1d416c
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit d7799f24cb0c2422f7e4a5401dac3e0d302a776e
Author: Sam Hague <shague@redhat.com>
Date:   Wed May 13 12:04:04 2015 -0400

    Fix ofPort and ovsdbNode to bridgeNode issues

    Change-Id: I855b3b509bd15ddec6865c347e7eaef28e089054
Signed-off-by: Sam Hague <shague@redhat.com>
commit 9a6da91e3aceadb65b8f1d53f061dc0b4029bf94
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed May 13 19:35:40 2015 +0530

    Fix getOtherCOnfig from ovsdbNode

    Change-Id: I50aeb3077038d2c08c4aed45638c994953cf9a1b
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 54f3f12c74b5539c92018125d6fd450b60be06af
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed May 13 19:04:53 2015 +0530

    Fixes bridge name comparison in isNodeTunnelReady

    Change-Id: I6fecda39ea79a522651f2240b19fbe718c51c796
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 37df228b87587e0879525cd9b9bc80d3e67d3d27
Author: Sam Hague <shague@redhat.com>
Date:   Wed May 13 08:51:46 2015 -0400

    Add break in loop

    Change-Id: I08de718832b6d99c1425c7f520b01c8d9fbcc2f2
Signed-off-by: Sam Hague <shague@redhat.com>
commit 1348a2d783fb20ac545a0093e275622597e9659f
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed May 13 18:06:07 2015 +0530

    Minor fixes

    Change-Id: I125fc9b322520dfdff2f83c29a92e0c62118b6bd
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 0be83b75f1868f138f5a01cb14fa9010988c5c27
Author: Sam Hague <shague@redhat.com>
Date:   Wed May 13 08:32:35 2015 -0400

    Remove internal vlan processing

    Change-Id: I5b277a8abcf2ae675b0d5a6afb84074e3155c7f9
Signed-off-by: Sam Hague <shague@redhat.com>
commit 474fc1b4ef010d7ede207c5de9565923f7b7b7e7
Merge: 3a34f29 0606a85
Author: Sam Hague <shague@redhat.com>
Date:   Tue May 12 21:19:04 2015 -0400

    Merge branch 'master' into topic/netvirtsbmerge

    Change-Id: I1b55ec30b080038499f65246ab79716c52984f87
Signed-off-by: Sam Hague <shague@redhat.com>
commit 3a34f2923d070cbfdd672bcca1d3e832564b346c
Author: Sam Hague <shague@redhat.com>
Date:   Tue May 12 20:12:16 2015 -0400

    Change NodeCacheManager to use Map rather than List

    - Also a fix for external-ids to use the right key
    - moved OvsdbDataChangeListener logging to trace level
    - updated SouthboundIt#testNetVirt to add a port
    - change getControllerTarget to use the local_ip from the connectionInfo

    Change-Id: Ibc4d1794f882f7b07c75213704bd220c76c90866
Signed-off-by: Sam Hague <shague@redhat.com>
commit 51ef7d5cd91f14fa1487173dd70226e91d31a491
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed May 13 05:05:13 2015 +0530

    Offload data change event processing to separate pool

    Change-Id: I2a8630a2b43541a49c81e12715bdb033c2905575
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 5a33f628ccaee6dd722af42fb4ff27dba7538621
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed May 13 05:04:19 2015 +0530

    Enabled bridge config clean up from config data store on ovsdb node disconnect

    Change-Id: I35c5c471f2a31215da9513a7a370f8e87ec9a829
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit c7eb139e82c51d0f1c326453f6d2626227821aa6
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Tue May 12 15:48:42 2015 +0530

    Removed unused import - causing build failure

    Change-Id: Ia9f36d5c776564b3d1f3fcc113aff83e2214344c
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 6d423093e9b21fcfceaf6e9223bba8f9d2621c97
Merge: ad691b3 23d2611
Author: Sam Hague <shague@redhat.com>
Date:   Mon May 11 18:28:19 2015 -0400

    Merge branch 'master' into topic/netvirtsbmerge

    Conflicts:
     southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionInstance.java
     southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionManager.java

    Change-Id: Ibcf01b02b36b0ae366f00ae8f4f3e4a0efcb3854
Signed-off-by: Sam Hague <shague@redhat.com>
commit ad691b38162c87b06c80b64a16687dfd632042b8
Author: Sam Hague <shague@redhat.com>
Date:   Mon May 11 17:32:53 2015 -0400

    Remove SouthboundMapper and SouthboundConstants dependencies

    Change-Id: Ia061c66350df94a1df440c2baaa232253c3a3f87
Signed-off-by: Sam Hague <shague@redhat.com>
commit 12732eb73ebece106582869ee05d896263b6e32f
Author: Sam Hague <shague@redhat.com>
Date:   Mon May 11 17:32:07 2015 -0400

    Extra changes for SouthboundIT

    Change-Id: Ie2c8f7127e6a30cfd7f575bd5935170ff7e291cd
Signed-off-by: Sam Hague <shague@redhat.com>
commit a2e905196819ffb3c5a2d358c36fa02cfa48b94b
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Tue May 12 02:36:07 2015 +0530

    Fixed process{bridge,termiantion-point, connection-attributes} update
    command to send the udpated Node rather then the original node.

    Change-Id: I06cddf4f107d3ef4c9315e0def415f78cab3aa25
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 043aa9568b4b5c0dea1df89ab37a70b6b505741b
Author: Alexis de Talhouët <adetalhouet@inocybe.com>
Date:   Mon May 11 15:55:30 2015 -0400

    Add break and null condition to MdsalUtils#getExternalId

    Change-Id: If552086747c6e4e16a4195094b7ce48e59a1a638
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
commit 8b3471beddfde3ae628d4b43b5645c78b69037bd
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Mon May 11 23:52:01 2015 +0530

    Adding break in processOvsdbNodeEvent

    Change-Id: I254fc4186f0124f1283a82d8103c8e5484a3edf0
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit f880009bd646e9cd9abce76d2694af2a62bd31c0
Author: Sam Hague <shague@redhat.com>
Date:   Mon May 11 12:09:58 2015 -0400

    Use new bridge dataChangeListener events

    Change-Id: I8af330766243f177d708a9be06c25900f1c50346
Signed-off-by: Sam Hague <shague@redhat.com>
commit a4dc15f4328fa4c33a13afdacdc9ecae8a489cfd
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Mon May 11 21:47:24 2015 +0530

    Fixed instanceof comparison for processOvsdbConnectionAttributeUpdates

    Change-Id: I411e95ec17255af89987734205700d334ec21e89
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit cf865d6c4fb638d3fa4bb4e8249254d9e5571e4f
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Mon May 11 21:28:48 2015 +0530

    Fixed instanceof comparison for iid

    Change-Id: I62c9ece787800302c92657877ed51db99cfc2c84
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 3521246b1c75d700e4479b00fa9a0dd241fbb936
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Sat May 9 03:26:55 2015 +0530

    Client should be added to cache before we push the
    info(OvsdbNodeAugmentation) to operational data store.
    With the existing implementation we were putting task
    in invoker queue to dump the data to operational data
    store and then registtering for the connection callback.
    After that it's adding client to cache. So if invoker
    writes the data to operational data store before
    it adds client to cache, any code listening to
    OvsdbNodeAugmentaiton, might not be able to do any
    operation if that key is not there in connection
    manager cache. It works if invoker loose the race
    of putting data to operational data store, it fails if
    it succeed.

    Change-Id: Ic73c5b7bbe0f94b04bf932b67b872099f2c27b5c
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
    (cherry picked from commit 77af48ad9d278b2a7e6d54442bd23bff313e08ee)

commit f396736ad8af9be19ed209572de9a5d8edb03312
Author: Sam Hague <shague@redhat.com>
Date:   Fri May 8 16:32:26 2015 -0400

    Add NeutronL3Adapter back now that neutron wires correctly

    Change-Id: Ia9cd61d11454b34f01ea7fe7675030bee8759ef4
Signed-off-by: Sam Hague <shague@redhat.com>
commit 4da3721dcd9996af18fdefe3535f65b436efcce6
Merge: 4de6b80 58e83ca
Author: Sam Hague <shague@redhat.com>
Date:   Fri May 8 16:28:28 2015 -0400

    Merge branch 'master' into topic/netvirtsb_merge

    Conflicts:
     southbound/southbound-it/src/test/java/org/opendaylight/ovsdb/southbound/it/SouthboundIT.java

    Change-Id: Ieb1fe28a53b303e576cb060ff751cf02e1762ff0
Signed-off-by: Sam Hague <shague@redhat.com>
commit 4de6b804cfe6f4812ca1be444e8b8a3ff8b6f3fa
Merge: 2b254d4 4c11b47
Author: Sam Hague <shague@redhat.com>
Date:   Fri May 8 17:26:12 2015 +0000

    Merge "MdsalUtils#getOtherConfig() & MdsalUtils#getExternalIds()." into topic/netvirtsb

commit 2b254d4ca88e5452fdca18647f73459597416863
Merge: 3e817fb da34f09
Author: Sam Hague <shague@redhat.com>
Date:   Fri May 8 17:24:47 2015 +0000

    Merge "Fixed few things: ** Added support for deleting bridge from config data store to keep configuration sane *.* Fixed bridge creation (it was not creating integration bridge when second compute node connects" into topic/netvirtsb

commit 3e817fb2311a37fa6039508edbdfd92e1e21e0c0
Merge: f7117c8 f1fda75
Author: Sam Hague <shague@redhat.com>
Date:   Fri May 8 17:23:50 2015 +0000

    Merge "Fixing log level : Too much log making debugging hard" into topic/netvirtsb

commit f7117c89f0169a9ee1151077356fec9a7bffdbc2
Merge: ee0e2d1 c077d27
Author: Sam Hague <shague@redhat.com>
Date:   Fri May 8 17:23:24 2015 +0000

    Merge "Implemented getAllBridgedOnOvsNode" into topic/netvirtsb

commit 4c11b47ed5641e332007b16923e800073d904887
Author: Alexis de Talhouët <adetalhouet@inocybe.com>
Date:   Fri May 8 11:15:27 2015 -0400

    MdsalUtils#getOtherConfig() & MdsalUtils#getExternalIds().

    Patch Set 1: useless formatting
    Patch Set 2: remove trailing space
    Patch Set 3&4: MdsalUtils#getOtherConfig()
    Patch Set 5: remove trailing space
    Patch Set 6: MdsalUtils#getExternalIds()

    Change-Id: Ie5db49990f413f12052cdb44f82a0b4a0b3ea51b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
commit da34f09bacb70791529fb77b240f6f8c8ef09518
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri May 8 18:33:15 2015 +0530

    Fixed few things:
    ** Added support for deleting bridge from config data store
    to keep configuration sane
    *.* Fixed bridge creation (it was not creating integration bridge
    when second compute node connects

    Change-Id: I4233886f875b188f7d5d7e68fe8e0076b4365d82
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit f1fda758b1e36b4641289ae5f295e2a19c47019a
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri May 8 17:41:42 2015 +0530

    Fixing log level : Too much log making debugging hard

    Change-Id: Ic62bd38b888ca98befb3cff623c12a1f28544300
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit c077d27e6d279a94b6675215c6160e560e3eb4bc
Author: Sharad Mishra <sharad.d.mishra@intel.com>
Date:   Thu May 7 07:26:34 2015 -0700

    Implemented getAllBridgedOnOvsNode

    Change-Id: I00fc9b1c4b8e90752eb7cd0ed1eaa31d78c3bc59
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
commit ee0e2d1a3a73a914cc2afc220a83c2df8fec2101
Author: Sharad Mishra <sharad.d.mishra@intel.com>
Date:   Thu May 7 08:05:40 2015 -0700

    Implemented addPatchTerminationPoint()

    Change-Id: I709b608f2dc6776de2159677dbcb99737f1ca5e2
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
commit d290ac6658fbbc64449c7887f02c8092e688f157
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri May 8 02:59:26 2015 +0530

    MdsalUtils : Delete termination point from bridge

    Change-Id: If5af04f6baffbb65959d4859c56a43a6c1c2a276
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 5320e9fc2477aeb6e2f99a22986f260c81d2e6fd
Author: Sam Hague <shague@redhat.com>
Date:   Thu May 7 17:11:43 2015 -0400

    Reenable neutron I*Aware services

    Change-Id: I322a25efbff708327204c6264423f6848f4fb56f
Signed-off-by: Sam Hague <shague@redhat.com>
commit 87b2f7af844ce6eda81fa299ce9a2c6262657cbe
Merge: 0e0e324 4744ff4
Author: Sam Hague <shague@redhat.com>
Date:   Thu May 7 20:57:46 2015 +0000

    Merge "Remove mdsal-node utils" into topic/netvirtsb

commit 0e0e32441ad9d800cde0e30224b534b5731d5dc7
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri May 8 02:21:56 2015 +0530

    MdsalUtils : Implemented create tunnel termination point on bridge node

    Change-Id: I639a73d30f4a69d0596a8fa889c5e9d7ab4acd52
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 7a6bf6c43d57a88549804b06683898f475bb690c
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri May 8 01:51:35 2015 +0530

    MdsalUtils : Add internal termination point on ovsdb bridge

    Change-Id: I0cb0ef73d4fcf6740dd0d45539eb24ada08a5cd0
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 4744ff4ccff6d3cb6dfdf63a92eed9325f4d9df7
Author: Sam Hague <shague@redhat.com>
Date:   Thu May 7 14:38:28 2015 -0400

    Remove mdsal-node utils

    Change-Id: I234a6cc985846ebe0dc1f66debba8ea38f72e9a4
Signed-off-by: Sam Hague <shague@redhat.com>
commit e2c0bba124b0a356c0bc949ae9cc5363fa5e9db9
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu May 7 21:54:11 2015 +0530

    Refactor MdSalUtils class to

    *.* Clean up the duplication methods
    *.* Refactor methods to avoid confusion whether it's reading from data store
    or extracting from provided method
    *.* Arranged code for better readability

    Change-Id: Ib1a35ce76549c437f30b5eff7bb62959a21b676e
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 93fa888d26273c7ddbbe801726967f8a54417c6a
Author: Sam Hague <shague@redhat.com>
Date:   Thu May 7 13:44:40 2015 -0400

    Remove lib and schema from netvirt

    Change-Id: I687fca4b90b7d5a78cb7879e3cf21f50c61a7129
Signed-off-by: Sam Hague <shague@redhat.com>
commit f0e4eee81087f84c0ff77300296ee4ccac58143a
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu May 7 20:58:24 2015 +0530

    MdSalUtils : Implemented getPorts from {node, operational data store}

    Change-Id: I2fd2f552960c99012d743c2863690568ea0f49c1
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 10351a81c721755419882829478287e0c64997a3
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu May 7 16:20:54 2015 +0530

    Fixed OvsdbDataChangeListner bridge update processing

    Change-Id: Ie3414edce90795ce72823bbd8e93b0b4ce605c03
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit fe7968ac3d44b8474c5e38f2d14f59a461db6a61
Author: Sharad Mishra <sharad.d.mishra@intel.com>
Date:   Wed May 6 11:17:53 2015 -0700

    Implemented processing of Bridge Update

    Change-Id: I5d3c212950a37df81fc717b77f0b36fb826a969a
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
commit 9c861a9ca939254be63bdc5046ff22efcccdd263
Author: Sam Hague <shague@redhat.com>
Date:   Wed May 6 21:18:39 2015 -0400

    Keep netvirt pom exporting packages

    Change-Id: Ie54bf4a0d7a09bacbceecf9b48d5276b22c582ac
Signed-off-by: Sam Hague <shague@redhat.com>
commit 8b07083f70b2b87256183fe65d77a1fe301b321c
Merge: 71550bc da5e033
Author: Sam Hague <shague@redhat.com>
Date:   Wed May 6 20:55:25 2015 -0400

    Merge branch 'master' into topic/netvirtsb_merge

    Conflicts:
     openstack/net-virt/pom.xml
     openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/NetworkingProviderManager.java
     openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/TenantNetworkManager.java

    Change-Id: I26a8d6fba1f59504bd16da60168a420118d6c558
Signed-off-by: Sam Hague <shague@redhat.com>
commit 71550bc5db3a338558fdab5f027ac2fbd35f4c29
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu May 7 04:30:24 2015 +0530

    Quick and Dirty fix for bridge controller ip address
    Rather the using the hardcoded value, using the  local host ip address.
    This is dirty fix, we should remove it once we get the valid fix using
    the connectionInfo local ip address. I think local ip address issues is now
    fixed for conncetion-info, so we can probably use that. We need to merge the
     master to netvirtsb branch, that will bring that fix.
    With this fix, netvirt create br-int and install all the pipeline flow
    successfully.

    Change-Id: If9d4e1289e0bb8c2a2888801f3c219f01f9a962d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 71f2e0e8a26997afd1aaa6842c90b838707acfdd
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu May 7 01:42:56 2015 +0530

    OvsdbDataChangeListner : Implemented processing of openvswitch (ovsdb connection) updates

    Change-Id: Iea1b2a4ec804afce8801ec916a08b4bc5bbe3632
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 3a9a510bb8ab16faaabb64bec8a4c4bafcbcafce
Author: Sam Hague <shague@redhat.com>
Date:   Wed May 6 14:52:08 2015 -0400

    Workaround for INeutron bundles not letting services start

    Change-Id: I204c3a39f0843180915a02dcbd3287c61aa1eafc
Signed-off-by: Sam Hague <shague@redhat.com>
commit c24a6e4d85355378045b13ffc00b596e0d9cbaed
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed May 6 23:58:42 2015 +0530

    OvsdbDataChangeListner : Implemented processing of port/interface update

    Change-Id: Ic61f5f2c0b426b988882f9bef7553143e9c537e7
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 568657c817db1daa425b0135fd150cfa464d6a0f
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed May 6 22:31:26 2015 +0530

    OvsdbDataChangeListner : Implemented processing of bridge deletion

    Change-Id: If94b5fcd6e2af2c564637d7740f48f18733686fd
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 79c6b9ad55845cd14eb5464c8b876054d9ab6b79
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed May 6 21:51:49 2015 +0530

    OvsdbDataChangeListener : Implemented processing of new bridge creation

    Change-Id: I8053f7be5b89c8a4d409ba245e509fac68d783b3
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit d2b14c68a6f4f42f18bb1c57b4b3fa9ea2d6c1b5
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed May 6 19:07:49 2015 +0530

    OvsdbDataChangeListener : Implemented ovsdb node disconnection processing

    Change-Id: I7edcfb0e8dd6528d6a1aaf870f71b38eca542b8c
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit ca345931de73d97a2fd86226185d102811cf098c
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed May 6 18:42:03 2015 +0530

    OvsdbDataChangeListener : Implemented port (termination point) delete event processing

    Change-Id: I6cd3ef89927aaae829815b2a9c625b6f89907162
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 1a26d989b36f2cfc039ac8765b2fd41af2540c0b
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed May 6 17:46:15 2015 +0530

    ovsdbDataChangeListener : Implemented Termination point creation processing
    Patch 2: rebased patch

    Change-Id: I03c440609b838177f990a471ed609467d7e581be
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 1f91f04c01bebbdf1b374b88fd007da40e6408cc
Author: Sam Hague <shague@redhat.com>
Date:   Wed May 6 07:12:49 2015 -0400

    Remove OvsdbConfigurationService

    Change-Id: Ie33affff9de47120bc0d5d134edcdbcf96a2c5ee
Signed-off-by: Sam Hague <shague@redhat.com>
commit 0c6846883444a8309790079dc2e29dc5993962f3
Author: Sam Hague <shague@redhat.com>
Date:   Tue May 5 08:51:25 2015 -0400

    Add missing handleInterfaceDelete for tunnel case

    Change-Id: I9259fc0d377724c2e7c9959a547b255f37439960
Signed-off-by: Sam Hague <shague@redhat.com>
commit 907d1f7b52823445ae0f980ce12345635d4eb6fe
Author: Sam Hague <shague@redhat.com>
Date:   Tue May 5 08:47:56 2015 -0400

    SouthboundHandler@processOpenVSwitchUpdate

    Change-Id: I23c622889236310850c6b0dd5d944479a21b7574
Signed-off-by: Sam Hague <shague@redhat.com>
commit 45c73ec506b5e1c1d199a0988b780bc0b621ba25
Author: Sam Hague <shague@redhat.com>
Date:   Tue May 5 08:38:07 2015 -0400

    Remove old interface delete row processing

    Change-Id: I2dccab918622e4c4877c4106813bdf78010f0014
Signed-off-by: Sam Hague <shague@redhat.com>
commit 30e5a75f279aead27c075cecd5cd084d30b2f996
Author: Sam Hague <shague@redhat.com>
Date:   Tue May 5 08:26:22 2015 -0400

    update NetvirtIT to include remove of flowCapableNode processing

    Change-Id: Idbcb4117af744d57a014866d0d10325a13e9d91b
Signed-off-by: Sam Hague <shague@redhat.com>
commit 632d5574ccbe6e994b467681534991b254740f8d
Author: Sam Hague <shague@redhat.com>
Date:   Tue May 5 08:24:03 2015 -0400

    SouthboundHandler#triggerUpdates

    Change-Id: Ia2455649badbec3814ad384be743fadfd8fb071d
Signed-off-by: Sam Hague <shague@redhat.com>
commit c7d114768fd36ac88988f9a85387f10f6dd756a5
Author: Sam Hague <shague@redhat.com>
Date:   Tue May 5 08:07:03 2015 -0400

    Remove FlowCapableNodeDataChangeListener

    Change-Id: I737cef9874c5ac15a2805d2e4b08aba5b371c1d6
Signed-off-by: Sam Hague <shague@redhat.com>
commit 6a6156dbfa4a6dcd8242158d4a857f47c986827a
Author: Sam Hague <shague@redhat.com>
Date:   Tue May 5 07:59:11 2015 -0400

    Add SouthboundHandler#processBridgeUpdate

    Change-Id: I1a9161fa03f9cd8778973879e40aac6bf3283a70
Signed-off-by: Sam Hague <shague@redhat.com>
commit 24687ac0ef8594eeac7326fedbc444092a3414b7
Author: Sam Hague <shague@redhat.com>
Date:   Mon May 4 20:53:47 2015 -0400

    Add SouthboundHandler#processInterfaceUpdate

    Change-Id: I413d2846b5b62d08a082c7540f150e28468e34ab
Signed-off-by: Sam Hague <shague@redhat.com>
commit 40fd738e7836831246f0ebad73f91431b97662a7
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Tue May 5 02:28:18 2015 +0530

    Implemented SouthboundHandler#processInterfaceDelete()

    Change-Id: I62654de72ecc45eefba549125c6f6c6c02accd70
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 460720c4fae549fa5cf4e60a74285f3590aefe34
Author: Sam Hague <shague@redhat.com>
Date:   Mon May 4 16:43:01 2015 -0400

    Add MdsalUtils API stubs

    Change-Id: I45c91dd577732cdc84161114fd154d4f6fef5871
Signed-off-by: Sam Hague <shague@redhat.com>
commit 2a5bb061b2d5ec6ff6686903d3c38ecf762cebb3
Merge: d71c130 dfd6de2
Author: Sam Hague <shague@redhat.com>
Date:   Mon May 4 19:53:32 2015 +0000

    Merge "Add ovsdbUpdate() to OvsdbInventoryListener" into topic/netvirtsb

commit dfd6de2dc66fe8ab23c01df346254b07f4c8ef6e
Author: Sam Hague <shague@redhat.com>
Date:   Mon May 4 15:52:21 2015 -0400

    Add ovsdbUpdate() to OvsdbInventoryListener

    Change-Id: Iefa15fdf20f27b95481067d5d915fc2ccf845487
Signed-off-by: Sam Hague <shague@redhat.com>
commit d71c130e2fc9772d720dbd88a93c623fa869b0af
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Mon May 4 23:49:59 2015 +0530

    Fixed check-style error

    Change-Id: I8f70f91e3ebdd09a20740aa349d65f3ec2ab7a46
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit d592446f6562d41acc69686d3f22bc8c35a19173
Author: Sam Hague <shague@redhat.com>
Date:   Fri May 1 19:50:50 2015 -0400

    Get correct dpid so that pipeline flows are programmed.

    This commit also fixes the initialzeOpenflowRules.

    Change-Id: I838db8f727b0057066afcce1e242e1aab80ed1ac
Signed-off-by: Sam Hague <shague@redhat.com>
commit 5ad3ab7b7fc61110cc6133d50111e4ef9fa976b6
Author: Sam Hague <shague@redhat.com>
Date:   Thu Apr 30 21:30:18 2015 -0400

    Add support for openflow node callbacks

    Change-Id: I79a8f9d1cf2ee46b240ff0ffbe467f35558f6e41
Signed-off-by: Sam Hague <shague@redhat.com>
commit 48d4f37d6d1f2583c150393e436079f08af7d9d2
Merge: da5ba20 f16cf37
Author: Sam Hague <shague@redhat.com>
Date:   Thu Apr 30 12:30:01 2015 -0400

    Merge branch 'master' into topic/netvirtsbmerge

    Change-Id: I1da78555e1e5a29f9b195ceedf508fc597a025a5
Signed-off-by: Sam Hague <shague@redhat.com>
commit da5ba20e8732bdebc213ad5fbbb9c871f47013dd
Author: Sam Hague <shague@redhat.com>
Date:   Thu Apr 30 12:25:22 2015 -0400

    Set the controller

    Change-Id: Ib62eaee4a5a95032f5a4b4197d4fe24e861d012c
Signed-off-by: Sam Hague <shague@redhat.com>
commit 411cb31714f30c11b4d1d8bd6a29b099f0d0ca90
Merge: 70a965d 2a4f037
Author: Sam Hague <shague@redhat.com>
Date:   Tue Apr 28 20:43:27 2015 -0400

    Merge branch 'master' into topic/netvirtsb2

    Change-Id: I70ee2e158f4ed2b97c51861e4b44aa2306740694
Signed-off-by: Sam Hague <shague@redhat.com>
commit 70a965d3e32b0d3105ef72982f82f5563d0311f5
Author: Sam Hague <shague@redhat.com>
Date:   Tue Apr 28 20:39:06 2015 -0400

    Process ovsdb node created dataChanges

    Change-Id: I084cc1e3cf1cc3b499cef858cc9a8ae0fac32466
Signed-off-by: Sam Hague <shague@redhat.com>
commit f7cbe864b251aa70bff91bea476349727ca1a9ad
Merge: c9a4ba2 b8fae55
Author: Sam Hague <shague@redhat.com>
Date:   Mon Apr 27 10:54:37 2015 -0400

    Merge branch 'master' into topic/netvirtsb2

Signed-off-by: Sam Hague <shague@redhat.com>
    Conflicts:
     southbound/southbound-it/src/test/java/org/opendaylight/ovsdb/southbound/it/AbstractConfigTestBase.java
     southbound/southbound-it/src/test/java/org/opendaylight/ovsdb/southbound/it/SouthboundIT.java

    Change-Id: I226c8118b399e60ef846d165a701f62873324739
Signed-off-by: Sam Hague <shague@redhat.com>
commit c9a4ba2415328d10b766b26cf9ca5e7d987a726d
Author: Sam Hague <shague@redhat.com>
Date:   Mon Apr 27 10:49:55 2015 -0400

    Add working integration-test

    Change-Id: I7fb4cdb4b897bad022055ff14a4e2d60a6f7fa78
Signed-off-by: Sam Hague <shague@redhat.com>
commit 0c540e87e2fed3b1671be8b7461e560d6be3734b
Merge: d51c465 92edcb1
Author: Sam Hague <shague@redhat.com>
Date:   Sun Apr 26 15:27:25 2015 -0400

    Merge branch 'master' into topic/netvirtsb2

Signed-off-by: Sam Hague <shague@redhat.com>
    Conflicts:
     openstack/net-virt/src/test/java/org/opendaylight/ovsdb/openstack/netvirt/NetworkHandlerTest.java

Signed-off-by: Sam Hague <shague@redhat.com>
    Change-Id: I75654ecea55d84cd022b856e2b0a30a1144a6f05
Signed-off-by: Sam Hague <shague@redhat.com>
commit d51c465d6fab5e2980f8fe2ca44795ce1e67ea0d
Author: Sam Hague <shague@redhat.com>
Date:   Sun Apr 26 14:33:48 2015 -0400

    More southbound migration for netvirt

    Change-Id: Ie972ab5914cc2a209fb73b53936c76269590f75a
Signed-off-by: Sam Hague <shague@redhat.com>
commit f5899985330b16f207a810c032b90ce4e02dcc54
Merge: 08c0397 d8ee9ed
Author: Sam Hague <shague@redhat.com>
Date:   Tue Apr 21 15:54:54 2015 -0400

    Merge branch 'master' into topic/netvirtsb2

    Change-Id: I8555d101f09b2e347a0ecf199dbbb3ce3be81905
Signed-off-by: Sam Hague <shague@redhat.com>
commit 08c03979ac2fc1b725224e0aba84cca281ac4225
Author: Sam Hague <shague@redhat.com>
Date:   Mon Apr 20 22:52:54 2015 -0400

    Use Topology Node in place of Inventory Node

    Change-Id: I8aa774acc6d617036d5803716619573df52e0697
Signed-off-by: Sam Hague <shague@redhat.com>
commit 933824bab5080a62ac35449e1961054446e64eb8
Author: Sam Hague <shague@redhat.com>
Date:   Mon Apr 20 15:07:49 2015 -0400

    Replace plugin interfaces with net-virt interfaces.

    This commit simply defines the interfaces that were removed in the previous commit. The next step from here is to modify the interfaces to be more generic so if the underlying southbound changes the interface does not need to change.

    Change-Id: I6778b1019e05e3eb7e5d2e48693ca980f17bebdd
Signed-off-by: Sam Hague <shague@redhat.com>
commit dae3d5ae32ae2639aecc5a9736690a38fdd76797
Author: Sam Hague <shague@redhat.com>
Date:   Mon Apr 20 11:46:48 2015 -0400

    Remove plugin dependencies

    Change-Id: I9c6d6c497c8651421549b91009ab337d294d37ba
Signed-off-by: Sam Hague <shague@redhat.com>
commit f6e5345b8c2f447a387b3ff0abcc4a5891751f93
Merge: 1b26c14 117a3bb
Author: Sam Hague <shague@redhat.com>
Date:   Mon Apr 20 10:41:23 2015 -0400

    Merge branch 'master' into topic/netvirtsb

    Change-Id: I6fdc1f6d3f80e3acfc8baf1c5e411815dcd6d7a0
Signed-off-by: Sam Hague <shague@redhat.com>
Change-Id: I8985d7bf51413a18385bcf5f044f9883f7918b17
Signed-off-by: Sam Hague <shague@redhat.com>
Also-By: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoRefactor tests for TerminationPoint options 33/20433/2
commit | commitdiff | tree
Ryan Goulding [Thu, 14 May 2015 20:40:02 +0000 (16:40 -0400)]
Refactor tests for TerminationPoint options

This change refactors the test procedure for TerminationPoint options.
Functionality is added to perform "update" tests for the TerminationPoint
options field.  The existing test case for Create, Read & Delete of
TerminationPoint options is consolidated with the new update test procedure
resulting in one test containing 16 test cases for full CRUD coverage.

Change-Id: Icf7cabf824b09e7b27e5af4ec11bb561bd10cfdf
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoRemove netvirt from SouthboundIT since netvirt has it now. 36/20436/1
commit | commitdiff | tree
Sam Hague [Thu, 14 May 2015 20:56:50 +0000 (16:56 -0400)]
Remove netvirt from SouthboundIT since netvirt has it now.

Change-Id: Ia9e31ca00cbbb350c4d163d8b4be585e742e98d4
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoMerge "Refactor tests for Port external_ids"
commit | commitdiff | tree
Sam Hague [Thu, 14 May 2015 19:43:06 +0000 (19:43 +0000)]
Merge "Refactor tests for Port external_ids"

9 years agoRefactor tests for Port external_ids 08/20408/4
commit | commitdiff | tree
Ryan Goulding [Thu, 14 May 2015 15:11:42 +0000 (11:11 -0400)]
Refactor tests for Port external_ids

This change refactors the test procedure for Port external_ids.  Functionality
is added to perform "update" tests for the Port external_ids field.  The
existing test case for Create, Read & Delete of Port external_ids is
consolidated with the new update test procedure resulting in one test
containing 16 test cases for full CRUD coverage.

Change-Id: I5c7d85ccb6d38f6fcce5f0946e0a3fd0a83621c4
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoRefactor tests for Interface external_ids 25/20425/1
commit | commitdiff | tree
Ryan Goulding [Thu, 14 May 2015 18:50:26 +0000 (14:50 -0400)]
Refactor tests for Interface external_ids

This change refactors the test procedure for Interface external_ids.
Functionality is added to perform "update" tests for the Interface external_ids
field.  The existing test case for Create, Read & Delete of Interface
external_ids is consolidated with the new update test procedure resulting in
one test containing 16 test cases for full CRUD coverage.

Change-Id: I92bf2532cdd2f005ddbc736b8c7de7bbb82efdea
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoMerge "Refactor OpenVSwitchUpdateCommand to improve readability."
commit | commitdiff | tree
Sam Hague [Thu, 14 May 2015 11:24:36 +0000 (11:24 +0000)]
Merge "Refactor OpenVSwitchUpdateCommand to improve readability."

9 years agoMerge "Allow terminationPoints to not need an interfaceType"
commit | commitdiff | tree
Flavio Fernandes [Thu, 14 May 2015 01:20:03 +0000 (01:20 +0000)]
Merge "Allow terminationPoints to not need an interfaceType"

9 years agoMerge "Bug 3136: Delete output port from instruction should use order instead of...
commit | commitdiff | tree
Sam Hague [Thu, 14 May 2015 01:03:22 +0000 (01:03 +0000)]
Merge "Bug 3136: Delete output port from instruction should use order instead of index"

9 years agoMerge "Bug 3147 OVSDB Bridge update external_ids"
commit | commitdiff | tree
Sam Hague [Thu, 14 May 2015 01:02:36 +0000 (01:02 +0000)]
Merge "Bug 3147 OVSDB Bridge update external_ids"

9 years agoAllow terminationPoints to not need an interfaceType 15/20315/1
commit | commitdiff | tree
Sam Hague [Thu, 14 May 2015 00:56:58 +0000 (20:56 -0400)]
Allow terminationPoints to not need an interfaceType

Change-Id: I3cb09cb16535fc5e23e3a5f976d0095a16208db2
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit 82fdc597e0aa3d66481432d91a18646ed1fde1b7)

9 years agoRefactor OpenVSwitchUpdateCommand to improve readability. 01/20301/1
commit | commitdiff | tree
Ed Warnicke [Wed, 13 May 2015 22:20:43 +0000 (15:20 -0700)]
Refactor OpenVSwitchUpdateCommand to improve readability.

Note:  This is *only* extracting methods so we can keep track
of what we are doing.

Change-Id: Ia09180f131c77a6ba9b00fb73009f0c7c3fe3d5b
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
9 years agoBug 3147 OVSDB Bridge update external_ids 47/19947/11
commit | commitdiff | tree
Ryan Goulding [Thu, 7 May 2015 11:48:45 +0000 (07:48 -0400)]
Bug 3147 OVSDB Bridge update external_ids

Fix to properly propagate external_ids and other updates to OVS.  SouthboundIT
tests are added to test this functionality for bridge external_ids.

Change-Id: I7aded71307f87c0d19165367b8336b3cb1f64f14
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoBug 3136: Delete output port from instruction should use order instead of index 97/19797/4
commit | commitdiff | tree
Flavio Fernandes [Thu, 7 May 2015 11:55:08 +0000 (20:55 +0900)]
Bug 3136: Delete output port from instruction should use order instead of index

Added comments to better explain the impmlementation.

The removeOutputPortFromInstructions was implemented under the assumption that
list index and order of action are equal. This could lead to action list where
order is not rebuilt properly.

Also, if removing port is not found in action list, the implementation would
cause the removal of the flow; when in fact it should leave list as is.

Change-Id: Id42d592db52c83897fd731f3bbef0434cc83d435
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Also-By: shc411 <jung33@gmail.com>
9 years agoAnil noticed there was a race condition here where we might write 88/20188/6
commit | commitdiff | tree
Ed Warnicke [Tue, 12 May 2015 22:27:11 +0000 (15:27 -0700)]
Anil noticed there was a race condition here where we might write
an ovsdb-node to the operatational store before recording the
TransactInvoker we needed for people to be able to use it to write to
ovsdb.  This fixes that by imposing the order:

1)  Record the TransactInvoke for the ovsdb-node (internally)
2)  Write the ovsdb-node to OPER
3)  Register callbacks for monitors from ovsdb

Change-Id: I55202678521065b1a8c2f018a9f229b6be263a48
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
9 years agoFixing sonar issues. Amending earlier changes 03/20003/2
commit | commitdiff | tree
evvy [Tue, 12 May 2015 08:37:49 +0000 (14:07 +0530)]
Fixing sonar issues. Amending earlier changes

Change-Id: I5e68b6795c10ed4ff83e7da293105525e9cf4f44
Signed-off-by: evvy <dhiraviam.natarajan@gmail.com>
9 years agoFix race condition in initial connection. 50/20050/5
commit | commitdiff | tree
Ed Warnicke [Mon, 11 May 2015 18:56:09 +0000 (11:56 -0700)]
Fix race condition in initial connection.

We must register the OvsdbConnectionCreateCommand prior
to registerCallback or we will get race conditions.

*Before* any bridge information can be successfully written
to the operational datastore, the OvsdbNode *must* be written.
The txInvoker guarantees writes occur in the order they were
provided to *it*.

If we have:

  txInvoker.invoke(new OvsdbNodeCreateCommand(key, null,null));
  registerCallBack();

We can guarantee that, and thus guarantee we will not have race conditions.

However, if we reverse that:

  registerCallBack();
  txInvoker.invoke(new OvsdbNodeCreateCommand(key, null,null));

We are guarenteed to have race conditions, as the results of the original
monitor dump get written to the datastore before the OvsdbNode gets written.

Please note: ovsdb is actively broken out of the box due to this race
conditions, so this must be corrected ASAP.

Change-Id: Id71221f7665ece5ec4b2eb9a0b39465618bada01
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
9 years agoRemove duplication call for OvsdbNode augmentation 08/20008/2
commit | commitdiff | tree
Anil Vishnoi [Mon, 11 May 2015 11:23:44 +0000 (16:53 +0530)]
Remove duplication call for OvsdbNode augmentation

Change-Id: I405e09ced0747369085ffb0c81f010e10e73a0d9
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoClient should be added to cache before we push the 56/19956/1
commit | commitdiff | tree
Anil Vishnoi [Fri, 8 May 2015 21:56:55 +0000 (03:26 +0530)]
Client should be added to cache before we push the
info(OvsdbNodeAugmentation) to operational data store.
With the existing implementation we were putting task
in invoker queue to dump the data to operational data
store and then registtering for the connection callback.
After that it's adding client to cache. So if invoker
writes the data to operational data store before
it adds client to cache, any code listening to
OvsdbNodeAugmentaiton, might not be able to do any
operation if that key is not there in connection
manager cache. It works if invoker loose the race
of putting data to operational data store, it fails if
it succeed.

Change-Id: Ic73c5b7bbe0f94b04bf932b67b872099f2c27b5c
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoSouthboundIT tests for Bridge external_ids and other_config 95/19795/1
commit | commitdiff | tree
Ryan Goulding [Thu, 7 May 2015 11:48:45 +0000 (07:48 -0400)]
SouthboundIT tests for Bridge external_ids and other_config

Tests create, read and delete functionality for bridge external_ids and
other_config.  Future changesets will utilize work here to test update
of bridges.

Change-Id: Icd45d19c58e4838415cccb06a3d4f08b117d678f
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoMerge "Southbound-IT: add test to verify dpdk enabled switch."
commit | commitdiff | tree
Sam Hague [Thu, 7 May 2015 00:29:22 +0000 (00:29 +0000)]
Merge "Southbound-IT: add test to verify dpdk enabled switch."

9 years agoFix SouthboundIT by disconnecting after each test 27/19727/1
commit | commitdiff | tree
Ryan Goulding [Wed, 6 May 2015 16:01:51 +0000 (12:01 -0400)]
Fix SouthboundIT by disconnecting after each test

SouthboundIT requires disconnection from OVSDB after each test.

Change-Id: Ifb916f103e94d53049f684a64b87c0ed1fc2efd6
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoSouthbound-IT: add test to verify dpdk enabled switch. 35/19635/7
commit | commitdiff | tree
Ryan Goulding [Tue, 5 May 2015 15:22:57 +0000 (11:22 -0400)]
Southbound-IT: add test to verify dpdk enabled switch.

This test will

1. Check if it is a DPDK node.
2. Test exits if its not a DPDK node. If DPDK node then,
3. Create a netdev bridge.
4. Verifies that a netdev bridge was created.
5. Creates a dpdk port.
6. Verifies that a dpdk port was added.
7. deletes bridge and disconnects node.
8. Test fails if any of the 3-7 step fails.

Change-Id: I58e10ba18ed82193782b981ed35b22ee0e14fd62
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoFix javadoc JDK8 compatibility 83/19683/2
commit | commitdiff | tree
Robert Varga [Tue, 5 May 2015 14:58:01 +0000 (16:58 +0200)]
Fix javadoc JDK8 compatibility

JDK8 is more picky about javadoc correctness -- fix it up so we can pass
compilation.

Change-Id: Iae446e890afe91c6ca0b670c2ea53f18793b5e99
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoSort reported nodes 82/19682/2
commit | commitdiff | tree
Robert Varga [Tue, 5 May 2015 14:57:26 +0000 (16:57 +0200)]
Sort reported nodes

The order of the nodes is asserted by the unit tests -- make sure this
is predictable across JDK versions.

Change-Id: I804024fe66530aa380dbd48907268fc12a4d3085
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoRemove explicit export-package 88/19688/1
commit | commitdiff | tree
Robert Varga [Wed, 6 May 2015 09:05:40 +0000 (11:05 +0200)]
Remove explicit export-package

net-virt-providers/OF13Provider requires the
org.opendaylight.ovsdb.openstack.netvirt package to be visible. Instead
of hard-coding the exported packages, allow the bundle plugin to decide
what to export.

Change-Id: Iac66eeaf70854712b9dc5917c748d519178968e5
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "User provided bridge external-ids not making to operational/OVSDB."
commit | commitdiff | tree
Flavio Fernandes [Wed, 6 May 2015 00:37:58 +0000 (00:37 +0000)]
Merge "User provided bridge external-ids not making to operational/OVSDB."

9 years agoUser provided bridge external-ids not making to operational/OVSDB. 36/19636/2
commit | commitdiff | tree
Sharad Mishra [Tue, 5 May 2015 07:20:50 +0000 (00:20 -0700)]
User provided bridge external-ids not making to operational/OVSDB.

When setting up a new bridge with user provided external-ids to
config datastore, these external-ids get dropped and only the iid
shows up as bridge external-id in ovsdb/oper datastore. This patch
fixes that issue.

Change-Id: I04676e166cab96323aff0ce5747a950c111da99c
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
9 years agoFixing issue with interface update. 67/19567/1
commit | commitdiff | tree
Amit Mandke [Tue, 5 May 2015 01:15:33 +0000 (18:15 -0700)]
Fixing issue with interface update.
Currently by mistake it updates the port uuid (in operation tp) using interface uuid.

Change-Id: Ia4f3dfdb676c377dab83dda11148222640e6bf78
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoMerge "Fix for bridge other config in mdsal."
commit | commitdiff | tree
Sam Hague [Tue, 5 May 2015 00:57:27 +0000 (00:57 +0000)]
Merge "Fix for bridge other config in mdsal."

9 years agoFix for bridge other config in mdsal. 51/19551/2
commit | commitdiff | tree
Sharad Mishra [Mon, 4 May 2015 09:47:46 +0000 (02:47 -0700)]
Fix for bridge other config in mdsal.

bridge other config are not showing up in operational or ovsdb.

Change-Id: Id1fd2f4f57fdd3aef1a25bf08229df26f6d3c76d
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
9 years agoAbstractServices need unique flowIds in order to avoid rules coalescing 54/19454/1
commit | commitdiff | tree
Flavio Fernandes [Fri, 1 May 2015 19:48:51 +0000 (15:48 -0400)]
AbstractServices need unique flowIds in order to avoid rules coalescing

This is a follow up from gerrit https://git.opendaylight.org/gerrit/#/c/19410/.
When assembling different flow rules for different match, it is important
to make their flowIds unique. By not doing that, openflowPlugin will treat
them as one; and that is what gets pushed to OF capable node.

Also removed cases when writeFlow() was being invoked twice for no reason.

Change-Id: I898d777e779e61da3c9f070306915c4c37f65572
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
9 years agoFixed issue with connection-info->{local-ip,local-port} not being stored 44/19444/1
commit | commitdiff | tree
Ed Warnicke [Fri, 1 May 2015 17:58:52 +0000 (10:58 -0700)]
Fixed issue with connection-info->{local-ip,local-port} not being stored

Use of ConnectionInfo as a key in OvsdbConnectionManager
should only have remote{Ip,port} info... so:

1)  Introduced a method suppressLocalIpPort() to SouthboundMapper
    to strip localIp/Port info out of a ConnectionInfo if needed
2)  Insured that *all* gets to the clients map in OvsdbConnectionManager
    use that method before doing a lookup
3)  Insured that *all* puts to the clients map in OvsdbConnectionManager
    use that method before writing.

Also in passing fixed disconnect to just get the connectionInfo from
the ovsdbNode it has, instead of doing a convoluted dance and
removed the then no longer used createConnectionInfo(ovsdbNode) from
SouthboundMapper.

Change-Id: Idb2b16d52ec23267584c69c6e474652dd25a4ab0
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
9 years agoWork around bug 3005: RoutingService needs special care to keep from rule coalescing 10/19410/1
commit | commitdiff | tree
Flavio Fernandes [Thu, 30 Apr 2015 20:17:58 +0000 (16:17 -0400)]
Work around bug 3005: RoutingService needs special care to keep from rule coalescing

When rules with for RoutingService only differ on match for tun_id, the existing openflow implementation does
not distinguish them as separate rules and overrides them into a single OF entry. That is very bad for L3
forwarding, when there are more than 2 subnets, or when multiple tenants use overlapping prefixes.

Until bug 3005 is fixed, we will leverage cookie to force openflow to treat the rule as unique. Fortunately
this is easily done by using the src_tun_id itself as the cookie (i.e. no cache is needed).

Also, add segmentation info in logs for when router interface is being programmed.

vagrant@devstack-control:/vagrant/puppet/scripts$ sudo ovs-ofctl -O OpenFlow13 dump-flows br-int | grep table=60
 cookie=0x0, duration=561.894s, table=60, n_packets=219, n_bytes=26397, priority=0 actions=goto_table:70
 cookie=0x3ea, duration=468.025s, table=60, n_packets=0, n_bytes=0, priority=2048,ip,tun_id=0x3ea,nw_dst=3.0.0.0/24 actions=set_field:fa:16:3e:d6:0c:aa->eth_src,dec_ttl,set_field:0x3eb->tun_id,goto_table:70
 cookie=0x3e9, duration=470.048s, table=60, n_packets=0, n_bytes=0, priority=2048,ip,tun_id=0x3e9,nw_dst=3.0.0.0/24 actions=set_field:fa:16:3e:d6:0c:aa->eth_src,dec_ttl,set_field:0x3eb->tun_id,goto_table:70
 cookie=0x3eb, duration=467.009s, table=60, n_packets=0, n_bytes=0, priority=2048,ip,tun_id=0x3eb,nw_dst=2.0.0.0/24 actions=set_field:fa:16:3e:2d:28:89->eth_src,dec_ttl,set_field:0x3ea->tun_id,goto_table:70
 cookie=0x3eb, duration=469.035s, table=60, n_packets=0, n_bytes=0, priority=2048,ip,tun_id=0x3eb,nw_dst=1.0.0.0/24 actions=set_field:fa:16:3e:25:0d:1b->eth_src,dec_ttl,set_field:0x3e9->tun_id,goto_table:70
 cookie=0x3e9, duration=489.275s, table=60, n_packets=0, n_bytes=0, priority=2048,ip,tun_id=0x3e9,nw_dst=2.0.0.0/24 actions=set_field:fa:16:3e:2d:28:89->eth_src,dec_ttl,set_field:0x3ea->tun_id,goto_table:70
 cookie=0x3ea, duration=488.184s, table=60, n_packets=0, n_bytes=0, priority=2048,ip,tun_id=0x3ea,nw_dst=1.0.0.0/24 actions=set_field:fa:16:3e:25:0d:1b->eth_src,dec_ttl,set_field:0x3e9->tun_id,goto_table:70

Ref: https://gist.github.com/f3ba1edbab72b26c8d97
Ref: http://www.flaviof.com/blog/work/how-to-odl-with-openstack-part2.html

Change-Id: I7eb43b141f26b09a1c5870a7d494bc9c2cebecd8
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
9 years agoMerge "Add testGetOvsdbNodes to it"
commit | commitdiff | tree
Sam Hague [Thu, 30 Apr 2015 16:27:07 +0000 (16:27 +0000)]
Merge "Add testGetOvsdbNodes to it"

9 years agoAdd testGetOvsdbNodes to it 93/19393/1
commit | commitdiff | tree
Sam Hague [Thu, 30 Apr 2015 16:11:51 +0000 (12:11 -0400)]
Add testGetOvsdbNodes to it

Change-Id: I33d1051bad7a220d14e569642a358ed9d929acf0
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoAdd is_connected to mdsal 79/19379/1
commit | commitdiff | tree
Sam Hague [Thu, 30 Apr 2015 11:57:27 +0000 (07:57 -0400)]
Add is_connected to mdsal

Change-Id: I6ddfb22afbb2b4a27887602a8e00fa15a676d217
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoFix for NPE during GBP testing. 43/19343/1
commit | commitdiff | tree
Thomas Bachman [Wed, 29 Apr 2015 19:57:33 +0000 (15:57 -0400)]
Fix for NPE during GBP testing.

This addresses an NPE that happens if the
controller entry "isConnected" isn't set but
is referenced.

Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoAdd bridge fails on older OVS versions (< v1.10) 60/19260/3
commit | commitdiff | tree
Sharad Mishra [Tue, 28 Apr 2015 08:45:21 +0000 (01:45 -0700)]
Add bridge fails on older OVS versions (< v1.10)

To recreate -

Run "ovs-vsctl add-br br0" on OVS 1.9 or lower.
The above command fails with SchemaVersionMismatchException.

Change-Id: Iee3adda5252e50e17c493373f74ee26e928f524f
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
9 years agoMerge "Add OpenFlow node reference to the bridge."
commit | commitdiff | tree
Sam Hague [Tue, 28 Apr 2015 19:35:30 +0000 (19:35 +0000)]
Merge "Add OpenFlow node reference to the bridge."

9 years agoMerge "Update TerminationPoint operational data on ovsdb port/interface update"
commit | commitdiff | tree
Sam Hague [Tue, 28 Apr 2015 11:20:07 +0000 (11:20 +0000)]
Merge "Update TerminationPoint operational data on ovsdb port/interface update"

9 years agoUpdate TerminationPoint operational data on ovsdb port/interface update 63/19063/3
commit | commitdiff | tree
Anil Vishnoi [Sat, 25 Apr 2015 00:36:30 +0000 (06:06 +0530)]
Update TerminationPoint operational data on ovsdb port/interface update

Change-Id: Id6f78e233c4c165d3f7e49a173794d08510abb65
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoFix NPE in operational Bridge remove. 90/19190/1
commit | commitdiff | tree
Sharad Mishra [Mon, 27 Apr 2015 19:00:41 +0000 (12:00 -0700)]
Fix NPE in operational Bridge remove.

To Recreate -

1. Run 'ovs-vsctl add-br br0'
2. Verify that bridge is added.
3. Run 'ovs-vsctl del-br br0'
4. The logs show NPE and br0 is not removed from operational/ovsdb.

Change-Id: I742a0661e97521047ee1c16c2b0a45e3a2a1f1cd
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
9 years agoRemove assumes from southbound-it now that deletes from operational work 43/19143/1
commit | commitdiff | tree
Sam Hague [Mon, 27 Apr 2015 11:20:25 +0000 (07:20 -0400)]
Remove assumes from southbound-it now that deletes from operational work

Change-Id: I8493086453f09b8aac6d4825543bce2d00191ec1
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoAdd OpenFlow node reference to the bridge. 54/18954/9
commit | commitdiff | tree
Alexis de Talhouët [Thu, 23 Apr 2015 20:24:07 +0000 (16:24 -0400)]
Add OpenFlow node reference to the bridge.

Change-Id: Id000733a51f35841c5ddbd14b57887418e30f16d
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoFixed termination point deletion from operational data store. 12/19012/3
commit | commitdiff | tree
Anil Vishnoi [Fri, 24 Apr 2015 13:08:02 +0000 (18:38 +0530)]
Fixed termination point deletion from operational data store.
Plugin was not removing termination point operational data from
operational data store once port deleted from bridge

Change-Id: I61de3e9b5dcdc4ac096422f6445562a194ba9fa1
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoAdded detailed description to external-ids and other-configs in ovsdb.yang 96/18596/3
commit | commitdiff | tree
Anil Vishnoi [Sat, 18 Apr 2015 21:30:48 +0000 (14:30 -0700)]
Added detailed description to external-ids and other-configs in ovsdb.yang

Detailed descriptions from OpenVswitch schema were added to external-ids
and other-configs in ovsdb.yang file.

But, the javadoc created as a result of new description is not correctly
formatted. Any help here will be appreciated.
Patch 2: Fixed whitespaces

Change-Id: I0016fd02a76829fe4aa20a6967eb21c5a379eb06
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoMerge "Fix for exception thrown when no ovs_version set."
commit | commitdiff | tree
Sam Hague [Fri, 24 Apr 2015 02:05:52 +0000 (02:05 +0000)]
Merge "Fix for exception thrown when no ovs_version set."

9 years agoMerge "SouthboundIT: Test to check ovs version for node."
commit | commitdiff | tree
Sam Hague [Fri, 24 Apr 2015 01:33:49 +0000 (01:33 +0000)]
Merge "SouthboundIT: Test to check ovs version for node."

9 years agoDelete redundant tests in Network, Port and Subnet handlers 39/18939/6
commit | commitdiff | tree
Cédric Ollivier [Thu, 23 Apr 2015 17:03:40 +0000 (19:03 +0200)]
Delete redundant tests in Network, Port and Subnet handlers

This removes redundant tests according to Neutron*Northbound.java.
HTTP_OK is returned now if the neutron resource can be created, updated
or deleted.

Change-Id: I621121f020123653da8ef87fef62a27ab951629e
Signed-off-by: Cédric Ollivier <ollivier.cedric@gmail.com>
9 years agoPrevent the network shared attribute from being updated 73/14773/6
commit | commitdiff | tree
Cédric Ollivier [Tue, 3 Feb 2015 09:14:48 +0000 (10:14 +0100)]
Prevent the network shared attribute from being updated

This modifies canUpdateNetwork() to check the network shared
attribute.

Change-Id: Ie875c4cc437c27f6b202e4e26dc1acd1aeff41f8
Signed-off-by: Cédric Ollivier <ollivier.cedric@gmail.com>
9 years agoFix for exception thrown when no ovs_version set. 70/18970/1
commit | commitdiff | tree
Sharad Mishra [Thu, 23 Apr 2015 16:52:38 +0000 (09:52 -0700)]
Fix for exception thrown when no ovs_version set.

I am running a DPDK accelerated OVS that was manually built.
It does not have its ovs_version field set and ODL throws exception.

Not sure if we support such ovs ... is it a support statement issue or bug ??

Change-Id: I778c89e241120058b380c96b2b074eab255a85bd
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
9 years agoSouthboundIT: Test to check ovs version for node. 65/18965/1
commit | commitdiff | tree
Sharad Mishra [Thu, 23 Apr 2015 15:16:37 +0000 (08:16 -0700)]
SouthboundIT: Test to check ovs version for node.

Starting small ... this patch checks ovs version attribute
of ovs node.

I could have added this check to "testAddDeleteOvsdbNode', but decided
that it could lead to minor confusion.

Change-Id: Iab4bf14215a2ced55f3c05be5f5a083db190f286
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
9 years agoSouthboundIT for vlan, vlanmode and vlan trunks 50/18850/2
commit | commitdiff | tree
Ryan Goulding [Wed, 22 Apr 2015 15:03:58 +0000 (11:03 -0400)]
SouthboundIT for vlan, vlanmode and vlan trunks

Add integration tests to verify vlan, vlan mode and vlan trunks functionality.

Change-Id: I745ba976a244b42d7f38a9d43db8eacac77ba416
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoMerge "additional southbound-it for port/interface"
commit | commitdiff | tree
Flavio Fernandes [Tue, 21 Apr 2015 19:51:11 +0000 (19:51 +0000)]
Merge "additional southbound-it for port/interface"

9 years agoadditional southbound-it for port/interface 63/18763/1
commit | commitdiff | tree
Ryan Goulding [Tue, 21 Apr 2015 15:43:34 +0000 (11:43 -0400)]
additional southbound-it for port/interface

Adds integration tests to verify ofPortRequest, termination point options,
interface external-ids, port external-ids, interface other-configs, and port
other-configs.

Change-Id: Ibf76a20a5844885e404b53d4a9c163452ca4084a
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoUpdate poms for Maven Central Requirements 52/18752/1
commit | commitdiff | tree
Sam Hague [Tue, 21 Apr 2015 14:54:40 +0000 (10:54 -0400)]
Update poms for Maven Central Requirements

Change-Id: I73fa6324ea917594e5cd110acd8f7b68102b3ca1
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoofPort test in SouthboundIT 68/18668/1
commit | commitdiff | tree
Ryan Goulding [Mon, 20 Apr 2015 21:14:57 +0000 (17:14 -0400)]
ofPort test in SouthboundIT

Adds an integration test to verify ofPort functionality.  A helper method is
provided to create a new TerminationPoint for testing.

Change-Id: I4588b9c95dff067007ebec47ea268c0f4e1f1bdf
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoFix ovsdb node disconnect - Removing ovsdb node from config data store 43/18643/2
commit | commitdiff | tree
Anil Vishnoi [Mon, 20 Apr 2015 15:28:20 +0000 (20:58 +0530)]
Fix ovsdb node disconnect - Removing ovsdb node from config data store
is not disconnecting the node.

Change-Id: I15012381814b80b887f4fb0cb5b62dbcbe9eb458
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoAdd Unit tests for openstack/netvirt/providers/openflow13/OF13Provider.java 06/18606/1
commit | commitdiff | tree
Ben Eze [Sun, 19 Apr 2015 23:47:24 +0000 (19:47 -0400)]
Add Unit tests for openstack/netvirt/providers/openflow13/OF13Provider.java

Change-Id: I7b92343cfb7653e44755bb54afcc003b1adebcb9
Signed-off-by: Ben Eze <beze@inocybe.ca>
9 years agoFix broken SouthboundIT test 04/18604/2
commit | commitdiff | tree
Sam Hague [Sun, 19 Apr 2015 19:30:00 +0000 (15:30 -0400)]
Fix broken SouthboundIT test

The mdsalUtils field needs to be static becuase each @Test method is a totally new allocation and the value is reaallocated for each test.

Also added some extra debug logs.

Patchset 2: checkstyle

Change-Id: Ic75b5bc25cdf62b1c3daa4ee2fdea487804fb0a9
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoMerge "TerminationPointUpdate command to update termination point on ovsdb node"
commit | commitdiff | tree
Sam Hague [Sun, 19 Apr 2015 17:55:00 +0000 (17:55 +0000)]
Merge "TerminationPointUpdate command to update termination point on ovsdb node"

9 years agoTerminationPointUpdate command to update termination point on ovsdb node 65/18565/2
commit | commitdiff | tree
Prateek Garg [Fri, 17 Apr 2015 19:55:31 +0000 (12:55 -0700)]
TerminationPointUpdate command to update termination point on ovsdb node

Change-Id: I17c4bd890a120b4fbf74ff5288f97bf00fd224df
Signed-off-by: Prateek Garg <prategar@cisco.com>
9 years agoMerge "Remove .../distribution/opendaylight-karaf/. It is now .../karaf"
commit | commitdiff | tree
Sam Hague [Sat, 18 Apr 2015 01:22:37 +0000 (01:22 +0000)]
Merge "Remove .../distribution/opendaylight-karaf/. It is now .../karaf"

9 years agoMerge "Add JUnit testing for L2RewriteService class."
commit | commitdiff | tree
Flavio Fernandes [Fri, 17 Apr 2015 21:20:46 +0000 (21:20 +0000)]
Merge "Add JUnit testing for L2RewriteService class."

9 years agoMerge "Add JUnit testing for L2FowardingService class."
commit | commitdiff | tree
Flavio Fernandes [Fri, 17 Apr 2015 21:20:35 +0000 (21:20 +0000)]
Merge "Add JUnit testing for L2FowardingService class."

9 years agoMerge "Add JUnit testing for LoadBalancerService class."
commit | commitdiff | tree
Flavio Fernandes [Fri, 17 Apr 2015 21:20:28 +0000 (21:20 +0000)]
Merge "Add JUnit testing for LoadBalancerService class."

9 years agoAdd JUnit testing for IngressAclService class. 47/18547/4
commit | commitdiff | tree
Alexis de Talhouët [Fri, 17 Apr 2015 14:40:10 +0000 (10:40 -0400)]
Add JUnit testing for IngressAclService class.

Change-Id: I44c088d640413d978cbbec9fa67c8a5d7d0aea8b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd JUnit testing for LoadBalancerService class. 60/18560/2
commit | commitdiff | tree
Alexis de Talhouët [Fri, 17 Apr 2015 18:46:27 +0000 (14:46 -0400)]
Add JUnit testing for LoadBalancerService class.

Change-Id: I18fb554389d4baa05e0f58a538243cdaa456cc5a
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd JUnit testing for L2FowardingService class. 54/18554/4
commit | commitdiff | tree
Alexis de Talhouët [Fri, 17 Apr 2015 17:18:09 +0000 (13:18 -0400)]
Add JUnit testing for L2FowardingService class.

Change-Id: I1d7b565f1cfa81b78423827d277e8cd5929dd51a
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd JUnit testing for L2RewriteService class. 62/18562/3
commit | commitdiff | tree
Alexis de Talhouët [Fri, 17 Apr 2015 19:08:38 +0000 (15:08 -0400)]
Add JUnit testing for L2RewriteService class.

Change-Id: I902ce652c3edb0857cca697ead04a9ffd475db67
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoRemove .../distribution/opendaylight-karaf/. It is now .../karaf 66/18566/1
commit | commitdiff | tree
Flavio Fernandes [Fri, 17 Apr 2015 20:44:46 +0000 (16:44 -0400)]
Remove .../distribution/opendaylight-karaf/. It is now .../karaf

Change-Id: I7287ac40e9a2cfc25e3551662cde4a32bf0b88e8
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
9 years agoMerge "Move ovsdb distribution to use karaf-parent"
commit | commitdiff | tree
Sam Hague [Fri, 17 Apr 2015 20:20:25 +0000 (20:20 +0000)]
Merge "Move ovsdb distribution to use karaf-parent"

9 years agoMove ovsdb distribution to use karaf-parent 64/18564/1
commit | commitdiff | tree
Sam Hague [Fri, 17 Apr 2015 19:31:27 +0000 (15:31 -0400)]
Move ovsdb distribution to use karaf-parent

Change-Id: Ief6939eb8f1cc15f1042ecc1fd7e549c60de57cc
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoMerge "Add JUnit testing for OutboundNatService class."
commit | commitdiff | tree
Flavio Fernandes [Fri, 17 Apr 2015 18:43:07 +0000 (18:43 +0000)]
Merge "Add JUnit testing for OutboundNatService class."

9 years agoMerge "Add JUnit testing for L3FowardingService class."
commit | commitdiff | tree
Flavio Fernandes [Fri, 17 Apr 2015 18:42:58 +0000 (18:42 +0000)]
Merge "Add JUnit testing for L3FowardingService class."

9 years agoMerge "Add JUnit testing for EgressAclService class."
commit | commitdiff | tree
Flavio Fernandes [Fri, 17 Apr 2015 18:42:17 +0000 (18:42 +0000)]
Merge "Add JUnit testing for EgressAclService class."

9 years agoMerge "Add JUnit testing for RoutingService class."
commit | commitdiff | tree
Flavio Fernandes [Fri, 17 Apr 2015 18:40:36 +0000 (18:40 +0000)]
Merge "Add JUnit testing for RoutingService class."

9 years agoMerge "Fix for TerminationPointCreateCommand to insert a termination point, if not...
commit | commitdiff | tree
Flavio Fernandes [Fri, 17 Apr 2015 18:40:11 +0000 (18:40 +0000)]
Merge "Fix for TerminationPointCreateCommand to insert a termination point, if not present already in operational store"

9 years agoMerge "Workaround for busted controller opendaylight-karaf-empty"
commit | commitdiff | tree
Flavio Fernandes [Fri, 17 Apr 2015 18:38:47 +0000 (18:38 +0000)]
Merge "Workaround for busted controller opendaylight-karaf-empty"

9 years agoAdd JUnit testing for L3FowardingService class. 57/18557/1
commit | commitdiff | tree
Alexis de Talhouët [Fri, 17 Apr 2015 17:50:51 +0000 (13:50 -0400)]
Add JUnit testing for L3FowardingService class.

Change-Id: Icb067fabb217511a5aca155f668b492d0d823ae5
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd JUnit testing for OutboundNatService class. 56/18556/1
commit | commitdiff | tree
Alexis de Talhouët [Fri, 17 Apr 2015 17:44:02 +0000 (13:44 -0400)]
Add JUnit testing for OutboundNatService class.

Change-Id: Ic3da229c61af4a412ab9031d735c1f5a5fb1cc2f
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd JUnit testing for RoutingService class. 55/18555/2
commit | commitdiff | tree
Alexis de Talhouët [Fri, 17 Apr 2015 17:32:10 +0000 (13:32 -0400)]
Add JUnit testing for RoutingService class.

Change-Id: Ie40d1009a840f646260c676b5338088d926b73bc
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoWorkaround for busted controller opendaylight-karaf-empty 51/18551/2
commit | commitdiff | tree
Sam Hague [Fri, 17 Apr 2015 16:33:42 +0000 (12:33 -0400)]
Workaround for busted controller opendaylight-karaf-empty

Somehow the controller opendaylight-karaf-empty is busted with all the recent karaf 3.0.3 migration. Luckily we will a local distribution that doesn't seem to have the same issues.

Change-Id: I8f90981ba684dd68c17cadf6513ef4046a5b9cfb
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoFix for TerminationPointCreateCommand to insert a termination point, if not present... 49/18549/2
commit | commitdiff | tree
Prateek Garg [Fri, 17 Apr 2015 14:06:48 +0000 (07:06 -0700)]
Fix for TerminationPointCreateCommand to insert a termination point, if not present already in operational store

Change-Id: I8ed209033986d8338cc65589d8f497a152dd2011
Signed-off-by: Prateek Garg <prategar@cisco.com>
9 years agoAdd JUnit testing for EgressAclService class. 43/18543/2
commit | commitdiff | tree
Alexis de Talhouët [Fri, 17 Apr 2015 13:57:17 +0000 (09:57 -0400)]
Add JUnit testing for EgressAclService class.

Change-Id: I9e2e0e6174a381c4a49bb667c33ec1a593dc597a
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd JUnit testing for InboundNatService class. 44/18544/2
commit | commitdiff | tree
Alexis de Talhouët [Fri, 17 Apr 2015 14:21:51 +0000 (10:21 -0400)]
Add JUnit testing for InboundNatService class.

Change-Id: Ia2a80aa73c7cabcfe91acb1fa1ab3f6718f08ca0
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoMerge changes Ifb9ee4a4,Id0a7512b
commit | commitdiff | tree
Flavio Fernandes [Fri, 17 Apr 2015 13:48:38 +0000 (13:48 +0000)]
Merge changes Ifb9ee4a4,Id0a7512b

* changes:
  Correct spelling of getBrideTermiationPoint()
  Add bridge integration test

9 years agoCorrect spelling of getBrideTermiationPoint() 37/18537/1
commit | commitdiff | tree
Sam Hague [Fri, 17 Apr 2015 12:27:11 +0000 (08:27 -0400)]
Correct spelling of getBrideTermiationPoint()

Change-Id: Ifb9ee4a4793a57a854f685cd0afce79d1ca96d2f
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoMerge "Add Unit Tests for openstack.net-virt-providers.openflow13 - FlowCapableNodeDa...
commit | commitdiff | tree
Sam Hague [Fri, 17 Apr 2015 12:22:55 +0000 (12:22 +0000)]
Merge "Add Unit Tests for openstack.net-virt-providers.openflow13 - FlowCapableNodeDataChangeListener.java and MdsalConsumerImpl.java"

9 years agoMerge "Add JUnit testing for ArpResponderService class."
commit | commitdiff | tree
Sam Hague [Fri, 17 Apr 2015 12:21:26 +0000 (12:21 +0000)]
Merge "Add JUnit testing for ArpResponderService class."

9 years agoAdd bridge integration test 35/18535/1
commit | commitdiff | tree
Sam Hague [Fri, 17 Apr 2015 11:36:16 +0000 (07:36 -0400)]
Add bridge integration test

Change-Id: Id0a7512bc4fb08c6bec4533eb35447cf4ba57be1
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoAdd Unit Tests for openstack.net-virt-providers.openflow13 - FlowCapableNodeDataChang... 04/18504/1
commit | commitdiff | tree
Ben Eze [Fri, 17 Apr 2015 02:05:45 +0000 (22:05 -0400)]
Add Unit Tests for openstack.net-virt-providers.openflow13 - FlowCapableNodeDataChangeListener.java and MdsalConsumerImpl.java

Change-Id: Icc614719be95e5b945a2bb686d509712a956c703
Signed-off-by: Ben Eze <beze@inocybe.ca>
9 years agoMerge "Add OpenFlow ID to ovsdb-bridge-attributes."
commit | commitdiff | tree
Flavio Fernandes [Thu, 16 Apr 2015 23:42:59 +0000 (23:42 +0000)]
Merge "Add OpenFlow ID to ovsdb-bridge-attributes."

9 years agoMerge "BUG 3005: WORKAROUND issue where match cannot differ only on extensions portion"
commit | commitdiff | tree
Flavio Fernandes [Thu, 16 Apr 2015 23:42:10 +0000 (23:42 +0000)]
Merge "BUG 3005: WORKAROUND issue where match cannot differ only on extensions portion"

9 years agoMerge "Add JUnit testing for ClassifierService class."
commit | commitdiff | tree
Flavio Fernandes [Thu, 16 Apr 2015 23:41:45 +0000 (23:41 +0000)]
Merge "Add JUnit testing for ClassifierService class."

9 years agoMerge "Update gogo versions to account for new karaf 3.0.3 constraints"
commit | commitdiff | tree
Flavio Fernandes [Thu, 16 Apr 2015 23:40:53 +0000 (23:40 +0000)]
Merge "Update gogo versions to account for new karaf 3.0.3 constraints"

9 years agoUpdate gogo versions to account for new karaf 3.0.3 constraints 33/18433/3
commit | commitdiff | tree
Sam Hague [Thu, 16 Apr 2015 13:46:03 +0000 (09:46 -0400)]
Update gogo versions to account for new karaf 3.0.3 constraints

Change-Id: Id062a95990a903873ab4b1f06408889f786f50fb
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoAdd JUnit testing for ClassifierService class. 71/18471/1
commit | commitdiff | tree
Alexis de Talhouët [Thu, 16 Apr 2015 19:11:05 +0000 (15:11 -0400)]
Add JUnit testing for ClassifierService class.

Change-Id: I4f00ae666cc28ad3d438f879da4b5780c2b1ab7c
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoBUG 3005: WORKAROUND issue where match cannot differ only on extensions portion 63/18463/2
commit | commitdiff | tree
Flavio Fernandes [Thu, 16 Apr 2015 17:40:52 +0000 (13:40 -0400)]
BUG 3005: WORKAROUND issue where match cannot differ only on extensions portion

The details on the original issue were discovered by Anil Vishnoi:

BUG-2757 : Openflowplugin manager doesn't use match extensions while comparing two flows
Ovsdb installs two flows which is different from each other just by the match extension (reg0) (actions are not used in comparison).

cookie=0x0, duration=255.353s, table=110, n_packets=8, n_bytes=648, priority=16384,reg0=0x1,tun_id=0x1,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00 actions=output:1,output:2
cookie=0x0, duration=256.115s, table=110, n_packets=9, n_bytes=1464, priority=16384,reg0=0x2,tun_id=0x1,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00 actions=output:1

So statistics manager assign the same id internally to both the flows and that's causing the repeated error message about duplicate id.
Adding match extension in flow comparison is not trivial and we cannot implement it in this release.

Change-Id: I9d9986628fcb4996a7b7aac7af327df59201904a
Also-By: Anil Vishnoi <vishnoianil@gmail.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
next
Open vSwitch Database Management Protocol