Cleaned up Subnet.java and added/extended unit tests. 60/28360/2
authorRyan Vail <r.vail@cablelabs.com>
Wed, 14 Oct 2015 01:32:34 +0000 (19:32 -0600)
committerRyan Vail <r.vail@cablelabs.com>
Wed, 14 Oct 2015 01:55:53 +0000 (19:55 -0600)
commit6032fc08cf47d9d8b0c8feac90acfc63bc6d52eb
tree999dd5ebfe9a7197b8c1cb01bc24d1273b5e0f36
parent0973886d52e510c313e9d99b575ff7edc891de55
Cleaned up Subnet.java and added/extended unit tests.

Subnet.java
  - Reordered modifiers to standard java lang spec order
  - Improved equals() with checks for null and this
  - Improved hashCode() by using all member vars used in equals().
  - Added braces to all if/else statements
  - Added constructor argument checks to ensure valid objects are created.
  - Renamed member variables to clearly identify what they are
  - Added javadoc
  - Added @Nullable and @Nonnull as appropriate

SubnetTest.java
  Fleshed out tests to cover all methods and cover more corner cases

PS2: minor javadoc error fix

Change-Id: I2b8097b096ee707ade064f6e583f72aba244e509
Signed-off-by: Ryan Vail <r.vail@cablelabs.com>
packetcable-policy-server/src/main/java/org/opendaylight/controller/packetcable/provider/Subnet.java
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/SubnetTest.java