git.opendaylight Code Review - packetcable.git/commit

author	Ryan Vail <r.vail@cablelabs.com>
	Tue, 8 Dec 2015 17:21:55 +0000 (10:21 -0700)
committer	Ryan Vail <r.vail@cablelabs.com>
	Mon, 14 Dec 2015 22:05:43 +0000 (15:05 -0700)
commit	a2fc60e8f0a237d2d82a3322807434c3200c1f31
tree	de4ad6d6e75697245f4994547c7dcac38cee5c33	tree \| snapshot
parent	0502631e1d8a01b76229f9037bebeb70baef4538	commit \| diff

Minor fixes and adding unit testing for validators

-Renamed GateSpecValidatator to GateSpecValidator
-Added null checks to a few foreach loops
-Added new JUnit Rule, Params to add Parametrized testing with a developer friendly interface.
-Lots of tests added for validation code

Change-Id: I3ce0b8c0d3698cf2ef364c5b9862bc152af7b586
Signed-off-by: Ryan Vail <r.vail@cablelabs.com>

31 files changed:

packetcable-policy-server/src/main/java/org/opendaylight/controller/packetcable/provider/validation/impl/QosValidatorProviderFactory.java		diff \| blob \| history
packetcable-policy-server/src/main/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/GateSpecValidator.java	[moved from packetcable-policy-server/src/main/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/GateSpecValidatator.java with 93% similarity]	diff \| blob \| history
packetcable-policy-server/src/main/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/GateValidator.java		diff \| blob \| history
packetcable-policy-server/src/main/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/GatesValidator.java		diff \| blob \| history
packetcable-policy-server/src/main/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/SubscribersValidator.java		diff \| blob \| history
packetcable-policy-server/src/main/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/TrafficProfileValidator.java		diff \| blob \| history
packetcable-policy-server/src/main/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/classifier/ClassifiersValidator.java		diff \| blob \| history
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/test/rules/Params.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/DataValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/CcapsValidatorProviderFactoryTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/QosValidatorProviderFactoryTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/ValidatorProviderFactoryImplTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/ValidatorProviderImplTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/ccaps/AmIdValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/ccaps/CcapValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/ccaps/CcapsValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/ccaps/ConnectionValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/AppValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/AppsValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/GateSpecValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/GateValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/GatesValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/SubscriberValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/SubscribersValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/TrafficProfileValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/classifier/ClassifierChoiceValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/classifier/ClassifierContainerValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/classifier/ClassifierValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/classifier/ClassifiersValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/classifier/ExtClassifierValidatorTest.java	[new file with mode: 0644]	blob
packetcable-policy-server/src/test/java/org/opendaylight/controller/packetcable/provider/validation/impl/validators/qos/classifier/Ipv6ClassifierValidatorTest.java	[new file with mode: 0644]	blob

PacketCable

RSS Atom