package org.opendaylight.transportpce.common.device;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.lenient;
+import static org.mockito.Mockito.when;
-import com.google.common.util.concurrent.FluentFuture;
-import com.google.common.util.concurrent.Futures;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.common.util.concurrent.MoreExecutors;
import java.util.LinkedList;
import java.util.List;
import java.util.Optional;
import java.util.concurrent.ExecutionException;
-import java.util.concurrent.Executors;
import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
-import org.eclipse.jdt.annotation.NonNull;
-import org.junit.After;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.Mockito;
-import org.mockito.junit.MockitoJUnitRunner;
+import org.mockito.junit.jupiter.MockitoExtension;
import org.opendaylight.mdsal.binding.api.DataBroker;
import org.opendaylight.mdsal.binding.api.MountPoint;
import org.opendaylight.mdsal.binding.api.MountPointService;
import org.opendaylight.mdsal.binding.api.ReadWriteTransaction;
-import org.opendaylight.mdsal.common.api.CommitInfo;
import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.NetworkId;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.Networks;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.networks.Network;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.networks.NetworkBuilder;
import org.opendaylight.yangtools.util.concurrent.FluentFutures;
import org.opendaylight.yangtools.yang.binding.DataObject;
import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
-
-@RunWith(MockitoJUnitRunner.class)
+@ExtendWith(MockitoExtension.class)
public class DeviceTransactionManagerTest {
- @Mock private MountPointService mountPointServiceMock;
- @Mock private MountPoint mountPointMock;
- @Mock private DataBroker dataBrokerMock;
- @Mock private ReadWriteTransaction rwTransactionMock;
+ @Mock
+ private MountPointService mountPointServiceMock;
+ @Mock
+ private MountPoint mountPointMock;
+ @Mock
+ private DataBroker dataBrokerMock;
+ @Mock
+ private ReadWriteTransaction rwTransactionMock;
+
private DeviceTransactionManagerImpl transactionManager;
private String defaultDeviceId = "device-id";
private LogicalDatastoreType defaultDatastore = LogicalDatastoreType.OPERATIONAL;
- private InstanceIdentifier<Network> defaultIid = InstanceIdentifier.create(Network.class);
- private Network defaultData = new NetworkBuilder().build();
+ private InstanceIdentifier<Network> defaultIid = InstanceIdentifier
+ .builder(Networks.class).child(Network.class).build();
+ private Network defaultData;
private long defaultTimeout = 1000;
private TimeUnit defaultTimeUnit = TimeUnit.MILLISECONDS;
- @Before
- public void before() {
- Mockito.when(mountPointServiceMock.getMountPoint(any())).thenReturn(Optional.of(mountPointMock));
- Mockito.when(mountPointMock.getService(any())).thenReturn(Optional.of(dataBrokerMock));
- Mockito.when(dataBrokerMock.newReadWriteTransaction()).thenReturn(rwTransactionMock);
- Mockito.doReturn(FluentFutures.immediateNullFluentFuture()).when(rwTransactionMock.commit());
-
+ @BeforeEach
+ void before() {
+ when(mountPointServiceMock.getMountPoint(any())).thenReturn(Optional.of(mountPointMock));
+ when(mountPointMock.getService(any())).thenReturn(Optional.of(dataBrokerMock));
+ when(dataBrokerMock.newReadWriteTransaction()).thenReturn(rwTransactionMock);
+ lenient().when(rwTransactionMock.commit()).thenReturn(FluentFutures.immediateNullFluentFuture());
+ NetworkId networkId = new NetworkId("NETWORK1");
+ defaultData = new NetworkBuilder().setNetworkId(networkId).build();
this.transactionManager = new DeviceTransactionManagerImpl(mountPointServiceMock, 3000);
}
- @After
- public void after() {
+ @AfterEach
+ void after() {
transactionManager.preDestroy();
}
@Test
- public void basicPositiveTransactionTest() {
+ void basicPositiveTransactionTest() {
try {
putAndSubmit(transactionManager, defaultDeviceId, defaultDatastore, defaultIid, defaultData);
} catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
+ fail("Exception catched! " + e);
return;
}
}
@Test
- public void advancedPositiveTransactionTest() {
+ void advancedPositiveTransactionTest() {
try {
Future<java.util.Optional<DeviceTransaction>> firstDeviceTxFuture =
transactionManager.getDeviceTransaction(defaultDeviceId);
Future<java.util.Optional<DeviceTransaction>> secondDeviceTxFuture =
transactionManager.getDeviceTransaction(defaultDeviceId);
- Assert.assertFalse(secondDeviceTxFuture.isDone());
+ assertFalse(secondDeviceTxFuture.isDone());
Future<java.util.Optional<DeviceTransaction>> thirdDeviceTxFuture =
transactionManager.getDeviceTransaction(defaultDeviceId);
- Assert.assertFalse(thirdDeviceTxFuture.isDone());
+ assertFalse(thirdDeviceTxFuture.isDone());
firstDeviceTx.put(defaultDatastore, defaultIid, defaultData);
- Assert.assertFalse(secondDeviceTxFuture.isDone());
- Assert.assertFalse(thirdDeviceTxFuture.isDone());
+ assertFalse(secondDeviceTxFuture.isDone());
+ assertFalse(thirdDeviceTxFuture.isDone());
Thread.sleep(200);
- Assert.assertFalse(secondDeviceTxFuture.isDone());
- Assert.assertFalse(thirdDeviceTxFuture.isDone());
+ assertFalse(secondDeviceTxFuture.isDone());
+ assertFalse(thirdDeviceTxFuture.isDone());
Future<java.util.Optional<DeviceTransaction>> anotherDeviceTxFuture =
transactionManager.getDeviceTransaction("another-id");
- Assert.assertTrue(anotherDeviceTxFuture.isDone());
+ Thread.sleep(50);
+ assertTrue(anotherDeviceTxFuture.isDone());
anotherDeviceTxFuture.get().get().commit(defaultTimeout, defaultTimeUnit);
firstDeviceTx.commit(defaultTimeout, defaultTimeUnit);
Thread.sleep(200);
- Assert.assertTrue(secondDeviceTxFuture.isDone());
- Assert.assertFalse(thirdDeviceTxFuture.isDone());
+ assertTrue(secondDeviceTxFuture.isDone());
+ assertFalse(thirdDeviceTxFuture.isDone());
DeviceTransaction secondDeviceTx = secondDeviceTxFuture.get().get();
secondDeviceTx.put(defaultDatastore, defaultIid, defaultData);
- Assert.assertFalse(thirdDeviceTxFuture.isDone());
+ assertFalse(thirdDeviceTxFuture.isDone());
secondDeviceTx.commit(defaultTimeout, defaultTimeUnit);
Thread.sleep(200);
- Assert.assertTrue(thirdDeviceTxFuture.isDone());
+ assertTrue(thirdDeviceTxFuture.isDone());
DeviceTransaction thirdDeviceTx = thirdDeviceTxFuture.get().get();
thirdDeviceTx.put(defaultDatastore, defaultIid, defaultData);
Mockito.verify(rwTransactionMock, Mockito.times(3)).put(defaultDatastore, defaultIid, defaultData);
Mockito.verify(rwTransactionMock, Mockito.times(4)).commit();
} catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
+ fail("Exception catched! " + e);
}
}
@Test
- public void bigAmountOfTransactionsOnSameDeviceTest() {
+ void bigAmountOfTransactionsOnSameDeviceTest() {
int numberOfTxs = 100;
List<Future<java.util.Optional<DeviceTransaction>>> deviceTransactionFutures = new LinkedList<>();
List<DeviceTransaction> deviceTransactions = new LinkedList<>();
deviceTransactions.add(deviceTx);
}
} catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
+ fail("Exception catched! " + e);
}
for (DeviceTransaction deviceTx : deviceTransactions) {
- Assert.assertTrue(deviceTx.wasSubmittedOrCancelled().get());
+ assertTrue(deviceTx.wasSubmittedOrCancelled().get());
}
}
@Test
- public void bigAmountOfTransactionsOnDifferentDevicesTest() {
+ void bigAmountOfTransactionsOnDifferentDevicesTest() {
int numberOfTxs = 1000;
List<DeviceTransaction> deviceTransactions = new LinkedList<>();
deviceTransactions.add(transactionManager.getDeviceTransaction(defaultDeviceId + " " + i).get().get());
}
} catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
+ fail("Exception catched! " + e);
}
deviceTransactions.parallelStream()
.forEach(deviceTransaction -> deviceTransaction.commit(defaultTimeout, defaultTimeUnit));
deviceTransactions.parallelStream()
- .forEach(deviceTransaction -> Assert.assertTrue(deviceTransaction.wasSubmittedOrCancelled().get()));
+ .forEach(deviceTransaction -> assertTrue(deviceTransaction.wasSubmittedOrCancelled().get()));
}
@Test
- public void bigAmountOfTransactionsOnDifferentDevicesWithoutSubmitTest() {
+ void bigAmountOfTransactionsOnDifferentDevicesWithoutSubmitTest() {
int numberOfTxs = 1000;
List<DeviceTransaction> deviceTransactions = new LinkedList<>();
deviceTransactions.add(transactionManager.getDeviceTransaction(defaultDeviceId + " " + i).get().get());
}
} catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
+ fail("Exception catched! " + e);
}
try {
Thread.sleep(transactionManager.getMaxDurationToSubmitTransaction() + 1000);
} catch (InterruptedException e) {
- Assert.fail("Exception catched! " + e);
+ fail("Exception catched! " + e);
}
deviceTransactions.parallelStream()
- .forEach(deviceTransaction -> Assert.assertTrue(deviceTransaction.wasSubmittedOrCancelled().get()));
+ .forEach(deviceTransaction -> assertTrue(deviceTransaction.wasSubmittedOrCancelled().get()));
}
@Test
- public void notSubmittedTransactionTest() {
+ void notSubmittedTransactionTest() {
Future<java.util.Optional<DeviceTransaction>> deviceTxFuture =
transactionManager.getDeviceTransaction(defaultDeviceId);
try {
deviceTxFuture.get();
Thread.sleep(transactionManager.getMaxDurationToSubmitTransaction() + 1000);
} catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
+ fail("Exception catched! " + e);
}
Mockito.verify(rwTransactionMock, Mockito.times(1)).cancel();
try {
putAndSubmit(transactionManager, defaultDeviceId, defaultDatastore, defaultIid, defaultData);
} catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
+ fail("Exception catched! " + e);
return;
}
}
@Test
- public void dataBrokerTimeoutTransactionTest() {
+ void dataBrokerTimeoutTransactionTest() {
Mockito.when(dataBrokerMock.newReadWriteTransaction()).then(invocation -> {
Thread.sleep(transactionManager.getMaxDurationToSubmitTransaction() + 1000);
return rwTransactionMock;
try {
putAndSubmit(transactionManager, defaultDeviceId, defaultDatastore, defaultIid, defaultData);
} catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
+ fail("Exception catched! " + e);
}
Mockito.verify(rwTransactionMock, Mockito.times(1)).commit();
try {
putAndSubmit(transactionManager, defaultDeviceId, defaultDatastore, defaultIid, defaultData);
} catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
+ fail("Exception catched! " + e);
return;
}
}
@Test
- public void getFutureTimeoutTransactionTest() {
+ void getFutureTimeoutTransactionTest() {
Mockito.when(dataBrokerMock.newReadWriteTransaction()).then(invocation -> {
Thread.sleep(3000);
return rwTransactionMock;
try {
deviceTxFuture.get(1000, TimeUnit.MILLISECONDS);
} catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
+ fail("Exception catched! " + e);
} catch (TimeoutException e) {
throwedException = e;
}
if (throwedException == null) {
- Assert.fail("TimeoutException should be thrown!");
+ fail("TimeoutException should be thrown!");
return;
}
try {
putAndSubmit(transactionManager, defaultDeviceId, defaultDatastore, defaultIid, defaultData);
} catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
+ fail("Exception catched! " + e);
return;
}
Mockito.verify(rwTransactionMock, Mockito.times(1)).commit();
}
- @Test
- public void submitTxTimeoutTransactionTest() {
- ListeningExecutorService executor = MoreExecutors.listeningDecorator(Executors.newSingleThreadExecutor());
- Mockito.when(rwTransactionMock.commit()).then(invocation -> Futures.makeChecked(executor.submit(() -> {
- try {
- Thread.sleep(3000);
- } catch (InterruptedException e) {
- Assert.fail("Exception catched in future! " + e);
- }
- return null;
- }), input -> input));
-
- Future<java.util.Optional<DeviceTransaction>> deviceTxFuture =
- transactionManager.getDeviceTransaction(defaultDeviceId);
- DeviceTransaction deviceTx;
- try {
- deviceTx = deviceTxFuture.get().get();
- } catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
- return;
- }
-
- deviceTx.put(defaultDatastore, defaultIid, defaultData);
-
- Exception throwedException = null;
-
- FluentFuture<? extends @NonNull CommitInfo> submitFuture = deviceTx.commit(200, defaultTimeUnit);
- try {
- submitFuture.get();
- } catch (InterruptedException e) {
- Assert.fail("Exception catched! " + e);
- } catch (ExecutionException e) {
- throwedException = e;
- }
-
- if (throwedException == null
- || !throwedException.getMessage().contains(TimeoutException.class.getName())) {
- Assert.fail("TimeoutException inside of should be thrown!");
- return;
- }
-
-
- Mockito.doReturn(FluentFutures.immediateNullFluentFuture()).when(rwTransactionMock.commit());
-
- try {
- putAndSubmit(transactionManager, defaultDeviceId, defaultDatastore, defaultIid, defaultData);
- } catch (InterruptedException | ExecutionException e) {
- Assert.fail("Exception catched! " + e);
- return;
- }
-
- Mockito.verify(rwTransactionMock, Mockito.times(2)).put(defaultDatastore, defaultIid, defaultData);
- Mockito.verify(rwTransactionMock, Mockito.times(2)).commit();
-
- executor.shutdown();
- }
-
private <T extends DataObject> void putAndSubmit(DeviceTransactionManagerImpl deviceTxManager, String deviceId,
LogicalDatastoreType store, InstanceIdentifier<T> path, T data)
throws ExecutionException, InterruptedException {
Code Review / transportpce.git / blobdiff