Code Review / transportpce.git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | inline | side by side
fix some pylint issues
[transportpce.git] / tests / transportpce_tests / 1.2.1 / test_gnpy.py
diff --git a/tests/transportpce_tests/1.2.1/test_gnpy.py b/tests/transportpce_tests/1.2.1/test_gnpy.py
index 235b85f89c46d436156e86b3003c52ed73fe8f4d..80a92bf0dc1146f0c0ded39da425880431e7d828 100644 (file)
--- a/tests/transportpce_tests/1.2.1/test_gnpy.py
+++ b/tests/transportpce_tests/1.2.1/test_gnpy.py
@@ -9,8 +9,10 @@
 # http://www.apache.org/licenses/LICENSE-2.0
 ##############################################################################
 
+# pylint: disable=no-member
+# pylint: disable=too-many-public-methods
+
 import unittest
-import json
 import os
 import sys
 import time
@@ -20,13 +22,6 @@ from common import test_utils
 
 class TransportGNPYtesting(unittest.TestCase):
 
-    @classmethod
-    def __init_logfile(cls):
-        GNPY_LOGFILE = os.path.join(os.path.dirname(os.path.realpath(__file__)),
-                                    "..", "..", "transportpce_tests", "gnpy.log")
-        if os.path.isfile(GNPY_LOFGILE):
-            os.remove(GNPY_LOFGILE)
-
     topo_cllinet_data = None
     topo_ordnet_data = None
     topo_ordtopo_data = None
@@ -34,6 +29,7 @@ class TransportGNPYtesting(unittest.TestCase):
 
     @classmethod
     def setUpClass(cls):
+        # pylint: disable=bare-except
         try:
             sample_files_parsed = False
             TOPO_CLLINET_FILE = os.path.join(os.path.dirname(os.path.realpath(__file__)),
@@ -68,6 +64,7 @@ class TransportGNPYtesting(unittest.TestCase):
 
     @classmethod
     def tearDownClass(cls):
+        # pylint: disable=not-an-iterable
         for process in cls.processes:
             test_utils.shutdown_process(process)
         print("all processes killed")
@@ -93,30 +90,11 @@ class TransportGNPYtesting(unittest.TestCase):
 
     # Path computed by PCE is feasible according to Gnpy
     def test_04_path_computation_FeasibleWithPCE(self):
-        url = "{}/operations/transportpce-pce:path-computation-request"
-        data = {
-            "input": {
-                "service-name": "service-1",
-                "resource-reserve": "true",
-                "pce-metric": "hop-count",
-                "service-handler-header": {
-                    "request-id": "request-1"
-                },
-                "service-a-end": {
-                    "node-id": "XPONDER-1",
-                    "service-rate": "100",
-                    "service-format": "Ethernet",
-                    "clli": "Node1"
-                },
-                "service-z-end": {
-                    "node-id": "XPONDER-5",
-                    "service-rate": "100",
-                    "service-format": "Ethernet",
-                    "clli": "Node5"
-                }
-            }
-        }
-        response = test_utils.post_request(url, data)
+        response = test_utils.path_computation_request("request-1", "service-1",
+                                                       {"node-id": "XPONDER-1", "service-rate": "100",
+                                                           "service-format": "Ethernet", "clli": "Node1"},
+                                                       {"node-id": "XPONDER-5", "service-rate": "100",
+                                                           "service-format": "Ethernet", "clli": "Node5"})
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertEqual(res['output']['configuration-response-common'][
@@ -135,54 +113,16 @@ class TransportGNPYtesting(unittest.TestCase):
     # Path computed by PCE is not feasible by GNPy and GNPy cannot find
     # another one (low SNR)
     def test_05_path_computation_FoundByPCE_NotFeasibleByGnpy(self):
-        url = "{}/operations/transportpce-pce:path-computation-request"
-        data = {
-            "input": {
-                "service-name": "service-2",
-                "resource-reserve": "true",
-                "pce-metric": "hop-count",
-                "service-handler-header": {
-                    "request-id": "request-2"
-                },
-                "service-a-end": {
-                    "node-id": "XPONDER-1",
-                    "service-rate": "100",
-                    "service-format": "Ethernet",
-                    "clli": "Node1"
-                },
-                "service-z-end": {
-                    "node-id": "XPONDER-5",
-                    "service-rate": "100",
-                    "service-format": "Ethernet",
-                    "clli": "Node5"
-                },
-                "hard-constraints": {
-                    "include_": {
-                        "ordered-hops": [
-                            {
-                                "hop-number": "0",
-                                "hop-type": {
-                                    "node-id": "OpenROADM-2"
-                                }
-                            },
-                            {
-                                "hop-number": "1",
-                                "hop-type": {
-                                    "node-id": "OpenROADM-3"
-                                }
-                            },
-                            {
-                                "hop-number": "2",
-                                "hop-type": {
-                                    "node-id": "OpenROADM-4"
-                                }
-                            }
-                        ]
-                    }
-                }
-            }
-        }
-        response = test_utils.post_request(url, data)
+        response = test_utils.path_computation_request("request-2", "service-2",
+                                                       {"node-id": "XPONDER-1", "service-rate": "100",
+                                                           "service-format": "Ethernet", "clli": "Node1"},
+                                                       {"node-id": "XPONDER-5", "service-rate": "100",
+                                                           "service-format": "Ethernet", "clli": "Node5"},
+                                                       {"include_": {"ordered-hops": [
+                                                           {"hop-number": "0", "hop-type": {"node-id": "OpenROADM-2"}},
+                                                           {"hop-number": "1", "hop-type": {"node-id": "OpenROADM-3"}},
+                                                           {"hop-number": "2", "hop-type": {"node-id": "OpenROADM-4"}}]}
+                                                        })
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertEqual(res['output']['configuration-response-common'][
@@ -202,48 +142,15 @@ class TransportGNPYtesting(unittest.TestCase):
 
     # #PCE cannot find a path while GNPy finds a feasible one
     def test_06_path_computation_NotFoundByPCE_FoundByGNPy(self):
-        url = "{}/operations/transportpce-pce:path-computation-request"
-        data = {
-            "input": {
-                "service-name": "service-3",
-                "resource-reserve": "true",
-                "pce-metric": "hop-count",
-                "service-handler-header": {
-                    "request-id": "request-3"
-                },
-                "service-a-end": {
-                    "node-id": "XPONDER-1",
-                    "service-rate": "100",
-                    "service-format": "Ethernet",
-                    "clli": "Node1"
-                },
-                "service-z-end": {
-                    "node-id": "XPONDER-4",
-                    "service-rate": "100",
-                    "service-format": "Ethernet",
-                    "clli": "Node5"
-                },
-                "hard-constraints": {
-                    "include_": {
-                        "ordered-hops": [
-                            {
-                                "hop-number": "0",
-                                "hop-type": {
-                                    "node-id": "OpenROADM-2"
-                                }
-                            },
-                            {
-                                "hop-number": "1",
-                                "hop-type": {
-                                    "node-id": "OpenROADM-3"
-                                }
-                            }
-                        ]
-                    }
-                }
-            }
-        }
-        response = test_utils.post_request(url, data)
+        response = test_utils.path_computation_request("request-3", "service-3",
+                                                       {"node-id": "XPONDER-1", "service-rate": "100",
+                                                           "service-format": "Ethernet", "clli": "Node1"},
+                                                       {"node-id": "XPONDER-4", "service-rate": "100",
+                                                           "service-format": "Ethernet", "clli": "Node5"},
+                                                       {"include_": {"ordered-hops": [
+                                                           {"hop-number": "0", "hop-type": {"node-id": "OpenROADM-2"}},
+                                                           {"hop-number": "1", "hop-type": {"node-id": "OpenROADM-3"}}]}
+                                                        })
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertEqual(res['output']['configuration-response-common'][
@@ -261,60 +168,17 @@ class TransportGNPYtesting(unittest.TestCase):
 
     # Not found path by PCE and GNPy cannot find another one
     def test_07_path_computation_FoundByPCE_NotFeasibleByGnpy(self):
-        url = "{}/operations/transportpce-pce:path-computation-request"
-        data = {
-            "input": {
-                "service-name": "service-4",
-                "resource-reserve": "true",
-                "pce-metric": "hop-count",
-                "service-handler-header": {
-                    "request-id": "request-4"
-                },
-                "service-a-end": {
-                    "node-id": "XPONDER-1",
-                    "service-rate": "100",
-                    "service-format": "Ethernet",
-                    "clli": "Node1"
-                },
-                "service-z-end": {
-                    "node-id": "XPONDER-4",
-                    "service-rate": "100",
-                    "service-format": "Ethernet",
-                    "clli": "Node5"
-                },
-                "hard-constraints": {
-                    "include_": {
-                        "ordered-hops": [
-                            {
-                                "hop-number": "0",
-                                "hop-type": {
-                                    "node-id": "OpenROADM-2"
-                                }
-                            },
-                            {
-                                "hop-number": "1",
-                                "hop-type": {
-                                    "node-id": "OpenROADM-3"
-                                }
-                            },
-                            {
-                                "hop-number": "2",
-                                "hop-type": {
-                                    "node-id": "OpenROADM-4"
-                                }
-                            },
-                            {
-                                "hop-number": "3",
-                                "hop-type": {
-                                    "node-id": "OpenROADM-3"
-                                }
-                            }
-                        ]
-                    }
-                }
-            }
-        }
-        response = test_utils.post_request(url, data)
+        response = test_utils.path_computation_request("request-4", "service-4",
+                                                       {"node-id": "XPONDER-1", "service-rate": "100",
+                                                           "service-format": "Ethernet", "clli": "Node1"},
+                                                       {"node-id": "XPONDER-4", "service-rate": "100",
+                                                           "service-format": "Ethernet", "clli": "Node5"},
+                                                       {"include_": {"ordered-hops": [
+                                                           {"hop-number": "0", "hop-type": {"node-id": "OpenROADM-2"}},
+                                                           {"hop-number": "1", "hop-type": {"node-id": "OpenROADM-3"}},
+                                                           {"hop-number": "2", "hop-type": {"node-id": "OpenROADM-4"}},
+                                                           {"hop-number": "3", "hop-type": {"node-id": "OpenROADM-3"}}]}
+                                                        })
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertEqual(res['output']['configuration-response-common'][
Repository for Transport PCE project.