Code Review / transportpce.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 04425a0) | patch
Fix spotbugs issues of the PCE module 42/88542/4
authoratriki <ahmed.triki.tn@gmail.com>
Thu, 19 Mar 2020 22:26:29 +0000 (23:26 +0100)
committeratriki <ahmed.triki.tn@gmail.com>
Thu, 26 Mar 2020 10:55:16 +0000 (11:55 +0100)
commit5e0ad32ac6d31d300babbe9f1ad367cc728d5605
tree9eda5bc4c7c0e59e469435e88922cac9e32e3f00tree | snapshot
parent04425a0c511b7ed0a1f601f5ceaa08b070f5f891commit | diff
Fix spotbugs issues of the PCE module

Fix issues related to:
- reliance on default encoding
- format and Logger Factory
- unused parameters
- bigDecimal constructor
- comparison operators
- serialization/deserialization issues
- check for null fields
- dead store for local variable
- inner static class

JIRA: TRNSPRTPCE-212
Change-Id: I82838dd72f1e42e434b9062e0166b61d22ff4c6a
Signed-off-by: atriki <ahmed.triki.tn@gmail.com>
20 files changed:
pce/src/main/java/org/opendaylight/transportpce/pce/PcePathDescription.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/PceSendingPceRPCs.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/SortPortsByName.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/constraints/PceConstraints.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/constraints/PceConstraintsCalc.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/gnpy/ConnectToGnpyServer.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/gnpy/GnpyResult.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/gnpy/GnpyServiceImpl.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/gnpy/GnpyTopoImpl.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/gnpy/GnpyUtilitiesImpl.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/gnpy/ServiceDataStoreOperationsImpl.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/graph/InAlgoPathValidator.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/graph/PceGraph.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/graph/PostAlgoPathValidator.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/networkanalyzer/MapUtils.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/networkanalyzer/PceCalculation.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/networkanalyzer/PceLink.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/networkanalyzer/PceOpticalNode.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/networkanalyzer/PceOtnNode.java diff | blob | history
pce/src/main/java/org/opendaylight/transportpce/pce/service/PathComputationServiceImpl.java diff | blob | history
Repository for Transport PCE project.