do not explicit serialVersionUID anymore 97/92697/1
authorguillaume.lambert <guillaume.lambert@orange.com>
Tue, 22 Sep 2020 08:11:12 +0000 (10:11 +0200)
committerGuillaume Lambert <guillaume.lambert@orange.com>
Fri, 2 Oct 2020 12:19:34 +0000 (12:19 +0000)
commit2a5e8946b98f8740c96079c3845f3ee7696247c2
tree04baf8e7c8644c09cde3fde74c09adc6b137589c
parentc0f688ff5872305f06ff71b5e95c4873f272ddc1
do not explicit serialVersionUID anymore

A new SpotBug rule has been introduced in odlparent Aluminium and
suggests to explicit the serialVersionUID in serializable classes to
avoid compilers interoperability problems due to a Java implementation
design flaw.

If this is useful in a few situations (rare today), this also means that
theorically developers must maintain this field and increment it across
classes incompatible versions.
Practically, this step is often forgotten, paving the way to more
serious problems.
Since the situation here does not require it, it is healthier to simply
ignore this (soon obsolete?) recommendation.

For more details:
git log pce/src/main/java/org/opendaylight/transportpce/pce/networkanalyzer/PceLink.java
https://github.com/rzwitserloot/lombok/wiki/WHY-NOT:-serialVersionUID
https://moi.vonos.net/java/serialization-synthetic/
https://rules.sonarsource.com/java/RSPEC-4926
https://www.vojtechruzicka.com/explicitly-declare-serialversionuid/
https://www.infoworld.com/article/3275924/oracle-plans-to-dump-risky-java-serialization.html

JIRA: TRNSPRTPCE-292
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I4e36134061104d912a75f3a578d43ca0bc17ab1f
(cherry picked from commit a00f3ee60b16735f27af765a5bf357c56a091bc5)
common/src/main/java/org/opendaylight/transportpce/common/mapping/SortPort121ByName.java
common/src/main/java/org/opendaylight/transportpce/common/mapping/SortPort221ByName.java
lighty/src/main/java/io/lighty/controllers/tpce/exception/TechnicalException.java
pce/src/main/java/org/opendaylight/transportpce/pce/SortPortsByName.java
pce/src/main/java/org/opendaylight/transportpce/pce/graph/PceGraphEdge.java
pce/src/main/java/org/opendaylight/transportpce/pce/networkanalyzer/PceLink.java