Code refactoring and added new checks 18/56618/7
authoruser <db929a@att.com>
Fri, 5 May 2017 17:33:05 +0000 (20:33 +0300)
committerDhruv Bhardwaj <db929a@att.com>
Wed, 10 May 2017 19:23:53 +0000 (19:23 +0000)
commitc3511abce385a49a96caced1520cd4ee8a5ceac9
treecd438657ee30abb808d081676699b8795ff143af
parent4987399c8114b87cb14a7a845528cbc621dae48a
Code refactoring and added new checks

1. Divided code into subclasses
2. Before deleting the interface now method checks if:
   --interface exists
   --if yes, then change admin state to out of service
   --if change of state successful then delete
3. Before creating interface now the method checks if:
   --if interface with same name in service exists then donot create
     new
   --if exists but state not in service then create new
   --if does not exist then create new interface with state in service
4. Before deleting a cross connect check if it exists, if not
   then do not proceed.
5. Created new class CrossConnect.java with methods:
   --getCrossConnect()
   --postCrossConnect()
   --deleteCrossConnect()
   --setPowerLevel()
   --getConnectionPortTrail()
6. Created new class OpenRoadmInerface.java with methods/attributes
   common to all interface irrespective to their type:
   --getIntfBuilder()
   --postInterface()
   --getInterface()
   --deleteInterface()
7. Added child classes OpenRoadmOdu4Interface.java,
   OpenRoadmOchInterface.java,OpenRoadmOtu4Interface.java
8. Added check for nodeType mandatory field.
9. Added checks for null value in data change notification
   when a device is disconnected.

Change-Id: Id775e36a8db0d14a11147e23414df4b07d1d6910
Signed-off-by: Dhruv Bhardwaj <db929a@att.com>
renderer/src/main/java/org/opendaylight/transportpce/renderer/RendererNotificationsImpl.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/mapping/PortMapping.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/openroadminterface/OpenRoadmInterfaces.java [new file with mode: 0644]
renderer/src/main/java/org/opendaylight/transportpce/renderer/openroadminterface/OpenRoadmOchInterface.java [new file with mode: 0644]
renderer/src/main/java/org/opendaylight/transportpce/renderer/openroadminterface/OpenRoadmOdu4Interface.java [new file with mode: 0644]
renderer/src/main/java/org/opendaylight/transportpce/renderer/openroadminterface/OpenRoadmOtu4Interface.java [new file with mode: 0644]
renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/CrossConnect.java [new file with mode: 0644]
renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/DeviceRenderer.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/OpenRoadmInterfaces.java [deleted file]