Fix spotbugs issues of the renderer module 98/89198/1
authormanuedelf <emmanuelle.delfour@gmail.com>
Mon, 23 Mar 2020 20:40:03 +0000 (21:40 +0100)
committerChristophe Betoule <christophe.betoule@orange.com>
Tue, 21 Apr 2020 07:55:59 +0000 (09:55 +0200)
commiteb01f458a38bfd681cf6551c5f33572ad3035e72
tree99693356f8d7b9e1ad92b73eaabe575d4c1d704d
parent4d3ca89f3a28102941b979b932a1826bed72adb7
Fix spotbugs issues of the renderer module

Fix following categories:
- NP_LOAD_OF_KNOWN_NULL_VALUE
- PZLA_PREFER_ZERO_LENGTH_ARRAYS
- RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE
- SLF4J_ILLEGAL_PASSED_CLASS
- DM_CONVERT_CASE
- NM_CONFUSING
- SLF4J_FORMAT_SHOULD_BE_CONST
- UPM_UNCALLED_PRIVATE_METHOD
- EC_UNRELATED_TYPES
- NP_ALWAYS_NULL
- NP_LOAD_OF_KNOWN_NULL_VALUE

JIRA: TRNSPRTPCE-213
Signed-off-by: manuedelf <emmanuelle.delfour@gmail.com>
Change-Id: I19b1654ad5ac6f4ea3a8c1ef468a2e69016b69cc
15 files changed:
renderer/pom.xml
renderer/src/main/java/org/opendaylight/transportpce/renderer/ModelMappingUtils.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/openroadminterface/OpenRoadmInterface121.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/openroadminterface/OpenRoadmInterface221.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/openroadminterface/OpenRoadmInterfaceFactory.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/openroadminterface/OpenRoadmOtnInterface221.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/DeviceRendererServiceImpl.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/OtnDeviceRendererServiceImpl.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/RendererServiceOperationsImpl.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/otn/OtnDeviceOperations.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/otn/OtnDeviceOperationsImpl.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/tasks/DeviceRenderingTask.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/rpcs/DeviceRendererRPCImpl.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/rpcs/TransportPCEServicePathRPCImpl.java
renderer/src/test/java/org/opendaylight/transportpce/renderer/stub/MountPointStub.java