Explicit unchecked conversions in networkmodel 57/95757/2
authorguillaume.lambert <guillaume.lambert@orange.com>
Tue, 13 Apr 2021 09:22:57 +0000 (11:22 +0200)
committerguillaume.lambert <guillaume.lambert@orange.com>
Tue, 13 Apr 2021 09:45:41 +0000 (11:45 +0200)
to avoid compilation warnings.

JIRA: TRNSPRTPCE-430
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id8f08201c484aef895291aba517080a54866b391

networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/listeners/PortMappingListener.java
networkmodel/src/test/java/org/opendaylight/transportpce/networkmodel/NetConfTopologyListenerTest.java

index 60a260d0dc5d2de036e1ab39a216039a4cc2fb30..fc597726322cf014535bea7bc0ad2c7710ee2295 100644 (file)
@@ -44,8 +44,8 @@ public class PortMappingListener implements DataTreeChangeListener<Mapping> {
                     path.addAll((Collection<? extends PathArgument>) change.getRootPath().getRootIdentifier()
                         .getPathArguments());
                     path.removeLast();
-                    InstanceIdentifier<Nodes> portmappintNodeID = (InstanceIdentifier<Nodes>) InstanceIdentifier
-                        .create(path);
+                    @SuppressWarnings("unchecked") InstanceIdentifier<Nodes> portmappintNodeID =
+                        (InstanceIdentifier<Nodes>) InstanceIdentifier.create(path);
                     String nodeId = InstanceIdentifier.keyOf(portmappintNodeID).getNodeId();
                     networkModelService.updateOpenRoadmTopologies(nodeId, newMapping);
                 }
index 4e8a5e908b6270d91c5df7b6d2d8ad65bbb20c56..8e57c872044184748c69360e4aeabb6d6fcfcfe1 100644 (file)
@@ -67,9 +67,9 @@ public class NetConfTopologyListenerTest {
 
     @Test
     public void testOnDataTreeChangedWhenDeleteNode() {
-        final DataObjectModification<Node> node = mock(DataObjectModification.class);
+        @SuppressWarnings("unchecked") final DataObjectModification<Node> node = mock(DataObjectModification.class);
         final Collection<DataTreeModification<Node>> changes = new HashSet<>();
-        final DataTreeModification<Node> ch = mock(DataTreeModification.class);
+        @SuppressWarnings("unchecked") final DataTreeModification<Node> ch = mock(DataTreeModification.class);
         final NodeRegistration nodeRegistration = mock(NodeRegistration.class);
         changes.add(ch);
         when(ch.getRootNode()).thenReturn(node);
@@ -92,7 +92,7 @@ public class NetConfTopologyListenerTest {
 
     @Test
     public void testOnDataTreeChangedWhenAddNode() {
-        final DataObjectModification<Node> node = mock(DataObjectModification.class);
+        @SuppressWarnings("unchecked") final DataObjectModification<Node> node = mock(DataObjectModification.class);
         final Collection<DataTreeModification<Node>> changes = new HashSet<>();
         @SuppressWarnings("unchecked") final DataTreeModification<Node> ch = mock(DataTreeModification.class);
         changes.add(ch);
@@ -118,9 +118,9 @@ public class NetConfTopologyListenerTest {
 
     @Test
     public void testOnDataTreeChangedWhenDisconnectingNode() {
-        final DataObjectModification<Node> node = mock(DataObjectModification.class);
+        @SuppressWarnings("unchecked") final DataObjectModification<Node> node = mock(DataObjectModification.class);
         final Collection<DataTreeModification<Node>> changes = new HashSet<>();
-        final DataTreeModification<Node> ch = mock(DataTreeModification.class);
+        @SuppressWarnings("unchecked") final DataTreeModification<Node> ch = mock(DataTreeModification.class);
         changes.add(ch);
         when(ch.getRootNode()).thenReturn(node);
 
@@ -145,9 +145,9 @@ public class NetConfTopologyListenerTest {
 
     @Test
     public void testOnDataTreeChangedWhenShouldNeverHappen() {
-        final DataObjectModification<Node> node = mock(DataObjectModification.class);
+        @SuppressWarnings("unchecked") final DataObjectModification<Node> node = mock(DataObjectModification.class);
         final Collection<DataTreeModification<Node>> changes = new HashSet<>();
-        final DataTreeModification<Node> ch = mock(DataTreeModification.class);
+        @SuppressWarnings("unchecked") final DataTreeModification<Node> ch = mock(DataTreeModification.class);
         changes.add(ch);
         when(ch.getRootNode()).thenReturn(node);