Remove RequestProcessor.readTx 50/104350/4
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 9 Feb 2023 16:47:22 +0000 (17:47 +0100)
committerGilles Thouenon <gilles.thouenon@orange.com>
Tue, 14 Feb 2023 15:14:30 +0000 (15:14 +0000)
This field is completely unused, remove it.

Change-Id: I56f0334a2c33d32103be3774e8bb9a8a6fae893a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
common/src/main/java/org/opendaylight/transportpce/common/network/RequestProcessor.java

index 810902dd42dc775c2e27e8450dbe614aaf60e7c2..b58961c8e998d19e4e5f0ca50f6c41c8bff2c89e 100644 (file)
@@ -7,13 +7,14 @@
  */
 package org.opendaylight.transportpce.common.network;
 
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.FluentFuture;
 import com.google.common.util.concurrent.ListenableFuture;
 import java.util.Optional;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
 import org.eclipse.jdt.annotation.NonNull;
 import org.opendaylight.mdsal.binding.api.DataBroker;
-import org.opendaylight.mdsal.binding.api.ReadTransaction;
 import org.opendaylight.mdsal.binding.api.ReadWriteTransaction;
 import org.opendaylight.mdsal.common.api.CommitInfo;
 import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
@@ -28,22 +29,20 @@ public class RequestProcessor {
 
     private final DataBroker dataBroker;
     private ReadWriteTransaction rwTx;
-    private ReadTransaction readTx;
     private ReentrantReadWriteLock lock;
 
 
 
     public RequestProcessor(DataBroker dataBroker) {
-        this.dataBroker = dataBroker;
+        this.dataBroker = requireNonNull(dataBroker);
         rwTx = dataBroker.newReadWriteTransaction();
-        readTx = dataBroker.newReadOnlyTransaction();
         lock = new ReentrantReadWriteLock();
         LOG.info("RequestProcessor instantiated");
 
     }
 
-    public <T extends DataObject> ListenableFuture<Optional<T>>
-         read(LogicalDatastoreType store,InstanceIdentifier<T> path) {
+    public <T extends DataObject> ListenableFuture<Optional<T>> read(LogicalDatastoreType store,
+            InstanceIdentifier<T> path) {
 
         ListenableFuture<Optional<T>> result = null;
         acquireReadLock();
@@ -71,8 +70,7 @@ public class RequestProcessor {
     }
 
 
-    public <T extends DataObject> void merge(LogicalDatastoreType store,
-        InstanceIdentifier<T> path, T data) {
+    public <T extends DataObject> void merge(LogicalDatastoreType store, InstanceIdentifier<T> path, T data) {
 
         acquireLock();
         LOG.debug("Number of merge requests waiting in queue :{}", lock.getQueueLength());