fix some compilation warnings

Change-Id: I007c87de212afbc58ad91965eeefa3649066c375
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

diff --git a/common/src/main/java/org/opendaylight/transportpce/common/InstanceIdentifiers.java b/common/src/main/java/org/opendaylight/transportpce/common/InstanceIdentifiers.java
index e883923e5ed3224a1840fa5f1f17977844c40531..5c698f40c44dc34066a8494e8b05d926c993e3a5 100644 (file)
--- a/common/src/main/java/org/opendaylight/transportpce/common/InstanceIdentifiers.java
+++ b/common/src/main/java/org/opendaylight/transportpce/common/InstanceIdentifiers.java
@@ -18,7 +18,7 @@ import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.
 import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.TopologyKey;
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 
-public class InstanceIdentifiers {
+public final class InstanceIdentifiers {
 
     public static final InstanceIdentifier<Topology> NETCONF_TOPOLOGY_II =
             InstanceIdentifier.create(NetworkTopology.class).child(Topology.class, new TopologyKey(

diff --git a/common/src/main/java/org/opendaylight/transportpce/common/StringConstants.java b/common/src/main/java/org/opendaylight/transportpce/common/StringConstants.java
index e45d99335ed14a1f24dd79d42af9a6fa319cf9f3..09f7753fb81a78ed0c4944e0e5435f872a483149 100644 (file)
--- a/common/src/main/java/org/opendaylight/transportpce/common/StringConstants.java
+++ b/common/src/main/java/org/opendaylight/transportpce/common/StringConstants.java
@@ -8,7 +8,7 @@
 
 package org.opendaylight.transportpce.common;
 
-public class StringConstants {
+public final class StringConstants {
 
     public static final String OPENROADM_DEVICE_MODEL_NAME = "org-openroadm-device";
     public static final String DEFAULT_NETCONF_NODEID = "controller-config";

diff --git a/inventory/src/main/java/org/opendaylight/transportpce/inventory/query/QueryUtils.java b/inventory/src/main/java/org/opendaylight/transportpce/inventory/query/QueryUtils.java
index 6e031f0d23d3d02dba06ba85db1523bd400880fe..93b146a122a3bf190892e19b7e62f64a4ebcba85 100644 (file)
--- a/inventory/src/main/java/org/opendaylight/transportpce/inventory/query/QueryUtils.java
+++ b/inventory/src/main/java/org/opendaylight/transportpce/inventory/query/QueryUtils.java
@@ -25,7 +25,7 @@ import org.opendaylight.yang.gen.v1.http.org.openroadm.service.rev161014.service
 /**
  * Query manipulation class.
  */
-public class QueryUtils {
+public final class QueryUtils {
 
     private QueryUtils() {
         // no instance, just static access

diff --git a/inventory/src/main/java/org/opendaylight/transportpce/inventory/query/StatementBuilder.java b/inventory/src/main/java/org/opendaylight/transportpce/inventory/query/StatementBuilder.java
index 1990bb951b771d6effbaa5b05b7a2a115a8c7091..d34ca5443fc8c2f5c715bbac4683c4dc3ef66db6 100644 (file)
--- a/inventory/src/main/java/org/opendaylight/transportpce/inventory/query/StatementBuilder.java
+++ b/inventory/src/main/java/org/opendaylight/transportpce/inventory/query/StatementBuilder.java
@@ -10,7 +10,7 @@ package org.opendaylight.transportpce.inventory.query;
 import java.sql.PreparedStatement;
 import java.sql.SQLException;
 
-public class StatementBuilder {
+public final class StatementBuilder {
 
     private final PreparedStatement statement;
     private int index;

diff --git a/inventory/src/main/java/org/opendaylight/transportpce/inventory/utils/StringUtils.java b/inventory/src/main/java/org/opendaylight/transportpce/inventory/utils/StringUtils.java
index 1ae663157c536a548966d9a782ba6cc2714c40bc..7b48f784c4b86a5a54106ce9de31f99fec1fd58a 100644 (file)
--- a/inventory/src/main/java/org/opendaylight/transportpce/inventory/utils/StringUtils.java
+++ b/inventory/src/main/java/org/opendaylight/transportpce/inventory/utils/StringUtils.java
@@ -14,7 +14,7 @@ import java.util.Date;
  * Utility class which handles strings in inventory project.
  *
  */
-public class StringUtils {
+public final class StringUtils {
     public static final String DEFAULT_SQL_DATE = "yyyy-MM-dd HH:mm:ss";
 
     private StringUtils() {

diff --git a/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/OrdLink.java b/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/OrdLink.java
index 1915c5e6479ccd90ae5b2efe3190aaf7c4e78b33..e0e05eea35bf16d4896312e6994690f273fa91bc 100644 (file)
--- a/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/OrdLink.java
+++ b/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/OrdLink.java
@@ -33,7 +33,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public final class OrdLink {
+final class OrdLink {
 
     private static final Logger LOG = LoggerFactory.getLogger(OrdLink.class);
 

diff --git a/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/Rdm2XpdrLink.java b/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/Rdm2XpdrLink.java
index b757a7ba56973e046662c38c628b621f567995f7..516a531e8e47464d9dd059ff554d7f37b323b606 100644 (file)
--- a/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/Rdm2XpdrLink.java
+++ b/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/Rdm2XpdrLink.java
@@ -32,7 +32,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public final class Rdm2XpdrLink {
+final class Rdm2XpdrLink {
 
     private static final Logger LOG = LoggerFactory.getLogger(Rdm2XpdrLink.class);
 

diff --git a/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/util/ClliNetwork.java b/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/util/ClliNetwork.java
index 9c251823c7c549e1d7cca36977b9c06e45eab60f..1af2d3567c0e27ea30b664c6fc7206b224b95227 100644 (file)
--- a/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/util/ClliNetwork.java
+++ b/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/util/ClliNetwork.java
@@ -40,7 +40,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier.InstanceIdenti
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class ClliNetwork {
+public final class ClliNetwork {
 
     private static final Logger LOG = LoggerFactory.getLogger(ClliNetwork.class);
 

diff --git a/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/util/OpenRoadmNetwork.java b/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/util/OpenRoadmNetwork.java
index 14ff27bd6f808efc2a7bf0a7abf2b05c1b7ae781..39924b27edee2f12d19dd26cc9e0fadf28e66c3e 100644 (file)
--- a/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/util/OpenRoadmNetwork.java
+++ b/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/util/OpenRoadmNetwork.java
@@ -47,7 +47,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier.InstanceIdenti
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class OpenRoadmNetwork {
+public final class OpenRoadmNetwork {
 
     private static final Logger LOG = LoggerFactory.getLogger(OpenRoadmNetwork.class);
 

diff --git a/test-common/src/main/java/org/opendaylight/transportpce/binding/converter/JSONDataObjectConverter.java b/test-common/src/main/java/org/opendaylight/transportpce/binding/converter/JSONDataObjectConverter.java
index 0413ef4e1436fcfdd0f58dc54de43597539e02b9..c97b2145c1602035cc1a152c9182aa7500deabed 100644 (file)
--- a/test-common/src/main/java/org/opendaylight/transportpce/binding/converter/JSONDataObjectConverter.java
+++ b/test-common/src/main/java/org/opendaylight/transportpce/binding/converter/JSONDataObjectConverter.java
@@ -17,9 +17,9 @@ import java.io.StringWriter;
 import java.io.Writer;
 import java.util.Optional;
 import javax.annotation.Nonnull;
+import org.opendaylight.mdsal.binding.dom.codec.impl.BindingNormalizedNodeCodecRegistry;
 import org.opendaylight.transportpce.binding.converter.api.DataObjectConverter;
 import org.opendaylight.transportpce.test.common.DataStoreContext;
-import org.opendaylight.mdsal.binding.dom.codec.impl.BindingNormalizedNodeCodecRegistry;
 import org.opendaylight.yangtools.yang.binding.DataObject;
 import org.opendaylight.yangtools.yang.common.QName;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
@@ -36,7 +36,7 @@ import org.opendaylight.yangtools.yang.model.api.SchemaNode;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class JSONDataObjectConverter extends AbstractDataObjectConverter {
+public final class JSONDataObjectConverter extends AbstractDataObjectConverter {
 
     private static final Logger LOG = LoggerFactory.getLogger(JSONDataObjectConverter.class);
 
@@ -133,7 +133,7 @@ public class JSONDataObjectConverter extends AbstractDataObjectConverter {
         NormalizedNodeResult result = new NormalizedNodeResult();
         try (NormalizedNodeStreamWriter streamWriter = ImmutableNormalizedNodeStreamWriter.from(result);
             JsonParserStream jsonParser = JsonParserStream.create(streamWriter, getSchemaContext(),
-            getSchemaContext())) {
+                getSchemaContext())) {
             jsonParser.parse(reader);
         } catch (IOException e) {
             LOG.warn("An error {} occured during parsing Json input stream", e.getMessage(), e);

diff --git a/test-common/src/main/java/org/opendaylight/transportpce/binding/converter/XMLDataObjectConverter.java b/test-common/src/main/java/org/opendaylight/transportpce/binding/converter/XMLDataObjectConverter.java
index e882dd384652272f7272a1c2ef7be3b4b4673e7c..40c8420ed210013c55f22e3ce04ca2b7aa1832c8 100644 (file)
--- a/test-common/src/main/java/org/opendaylight/transportpce/binding/converter/XMLDataObjectConverter.java
+++ b/test-common/src/main/java/org/opendaylight/transportpce/binding/converter/XMLDataObjectConverter.java
@@ -43,7 +43,7 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.xml.sax.SAXException;
 
-public class XMLDataObjectConverter extends AbstractDataObjectConverter {
+public final class XMLDataObjectConverter extends AbstractDataObjectConverter {
 
     private static final Logger LOG = LoggerFactory.getLogger(XMLDataObjectConverter.class);
 

diff --git a/test-common/src/main/java/org/opendaylight/transportpce/test/DeviceWrapper.java b/test-common/src/main/java/org/opendaylight/transportpce/test/DeviceWrapper.java
index 81489cf3dd123e24244bd4357393c64938d73164..5c2d737165fe093531ee81f3e2938202703ede25 100644 (file)
--- a/test-common/src/main/java/org/opendaylight/transportpce/test/DeviceWrapper.java
+++ b/test-common/src/main/java/org/opendaylight/transportpce/test/DeviceWrapper.java
@@ -37,7 +37,7 @@ import org.slf4j.LoggerFactory;
  * Wrapper class around {@link DataBroker} and {@link DOMDataBroker}.
  *
  */
-public class DeviceWrapper {
+public final class DeviceWrapper {
     private static final Logger LOG = LoggerFactory.getLogger(DeviceWrapper.class);
 
     private final String identifier;

diff --git a/test-common/src/main/java/org/opendaylight/transportpce/test/common/DataStoreContextImpl.java b/test-common/src/main/java/org/opendaylight/transportpce/test/common/DataStoreContextImpl.java
index 84a6428577103c42eb9553da2bf6508f870d6183..fb4c6f7b79c6a64161219ef64f1a6ca16f475bf9 100644 (file)
--- a/test-common/src/main/java/org/opendaylight/transportpce/test/common/DataStoreContextImpl.java
+++ b/test-common/src/main/java/org/opendaylight/transportpce/test/common/DataStoreContextImpl.java
@@ -30,13 +30,13 @@ import org.opendaylight.controller.md.sal.dom.broker.impl.DOMNotificationRouter;
 import org.opendaylight.controller.md.sal.dom.broker.impl.SerializedDOMDataBroker;
 import org.opendaylight.controller.md.sal.dom.store.impl.InMemoryDOMDataStore;
 import org.opendaylight.controller.sal.core.spi.data.DOMStore;
+import org.opendaylight.mdsal.binding.dom.codec.gen.impl.StreamWriterGenerator;
+import org.opendaylight.mdsal.binding.dom.codec.impl.BindingNormalizedNodeCodecRegistry;
 import org.opendaylight.mdsal.binding.generator.impl.GeneratedClassLoadingStrategy;
 import org.opendaylight.mdsal.binding.generator.impl.ModuleInfoBackedContext;
 import org.opendaylight.mdsal.binding.generator.util.BindingRuntimeContext;
 import org.opendaylight.mdsal.binding.generator.util.JavassistUtils;
 import org.opendaylight.mdsal.dom.api.DOMSchemaService;
-import org.opendaylight.mdsal.binding.dom.codec.gen.impl.StreamWriterGenerator;
-import org.opendaylight.mdsal.binding.dom.codec.impl.BindingNormalizedNodeCodecRegistry;
 import org.opendaylight.yangtools.concepts.ListenerRegistration;
 import org.opendaylight.yangtools.util.ListenerRegistry;
 import org.opendaylight.yangtools.yang.binding.YangModelBindingProvider;
@@ -149,7 +149,7 @@ public class DataStoreContextImpl implements DataStoreContext {
         return store;
     }
 
-    private class SchemaContextHolder implements DOMSchemaService, SchemaContextProvider {
+    private final class SchemaContextHolder implements DOMSchemaService, SchemaContextProvider {
 
         private final SchemaContext schemaContext;
         private final ListenerRegistry<SchemaContextListener> listeners;