adding some pce unit tests and remove ignore from olm class 60/88960/5
authorshaaban Altanany <shaaban.eltanany.ext@orange.com>
Tue, 31 Mar 2020 08:45:40 +0000 (10:45 +0200)
committerGuillaume Lambert <guillaume.lambert@orange.com>
Wed, 15 Apr 2020 07:12:45 +0000 (07:12 +0000)
Change-Id: Id6325fdf47100b4bdc75c5cacd826f18cda12eca
Signed-off-by: ShaabanEltanany <shaaban.eltanany.ext@orange.com>
14 files changed:
olm/pom.xml
olm/src/test/java/org/opendaylight/transportpce/olm/OlmPowerServiceRpcImplTest.java
olm/src/test/java/org/opendaylight/transportpce/olm/power/PowerMgmtTest.java
olm/src/test/java/org/opendaylight/transportpce/olm/service/OlmPowerServiceImplSpanLossBaseTest.java
olm/src/test/java/org/opendaylight/transportpce/olm/service/OlmPowerServiceImplTest.java
pce/pom.xml
pce/src/test/java/org/opendaylight/transportpce/pce/PceComplianceCheckResultTest.java [new file with mode: 0644]
pce/src/test/java/org/opendaylight/transportpce/pce/PceSendingPceRPCsTest.java [new file with mode: 0644]
pce/src/test/java/org/opendaylight/transportpce/pce/SortPortsByNameTest.java [new file with mode: 0644]
pce/src/test/java/org/opendaylight/transportpce/pce/constraints/PceConstraintsTest.java [new file with mode: 0644]
pce/src/test/java/org/opendaylight/transportpce/pce/networkanalyzer/PceCalculationTest.java [new file with mode: 0644]
pce/src/test/java/org/opendaylight/transportpce/pce/service/PathComputationServiceImplTest.java [new file with mode: 0644]
pce/src/test/java/org/opendaylight/transportpce/pce/utils/PceTestData.java
pom.xml

index 234638fdb8efed7fabe2ea21c6231db503a22dbd..e0b3abc4662abdd9c979ac75160cb0c55481c7f1 100644 (file)
@@ -33,7 +33,7 @@ and is available at http://www.eclipse.org/legal/epl-v10.html
     <dependency>
       <groupId>org.mockito</groupId>
       <artifactId>mockito-core</artifactId>
-      <version>2.25.0</version>
+      <version>3.2.4</version>
       <scope>test</scope>
     </dependency>
     <dependency>
index 470b1211685bf28cb1860bf2802c240005721c3f..3b21afe7afcabb70dd5f34c254e3bbf34e1d6db4 100644 (file)
@@ -15,7 +15,6 @@ import java.util.Optional;
 import java.util.concurrent.ExecutionException;
 import org.junit.Assert;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.mockito.Mockito;
 import org.opendaylight.mdsal.binding.api.MountPoint;
@@ -74,7 +73,7 @@ import org.opendaylight.yangtools.yang.common.RpcResult;
 import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
 import org.opendaylight.yangtools.yang.common.Uint64;
 
-@Ignore
+
 public class OlmPowerServiceRpcImplTest extends AbstractTest {
 
     private MountPoint mountPoint;
index af83eb3a1959eca1333b0a1554d2ec5746f4c684..d226387694a6e53dcdb91a5c03fd36e6bcb5eb60 100644 (file)
@@ -11,7 +11,6 @@ package org.opendaylight.transportpce.olm.power;
 import java.util.List;
 import org.junit.Assert;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.mockito.Mockito;
 import org.opendaylight.mdsal.binding.api.MountPoint;
@@ -42,7 +41,7 @@ import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.olm.rev17
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.olm.rev170418.ServicePowerTurndownInput;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.NodeId;
 
-@Ignore
+
 public class PowerMgmtTest extends AbstractTest {
 
     private MountPoint mountPoint;
@@ -64,7 +63,7 @@ public class PowerMgmtTest extends AbstractTest {
     public void setUp() {
         this.mountPoint = new MountPointStub(this.getDataBroker());
         this.mountPointService = new MountPointServiceStub(mountPoint);
-        this.mappingUtils = new MappingUtilsImpl(getDataBroker());
+        // this.mappingUtils = new MappingUtilsImpl(getDataBroker());
         this.mappingUtils = Mockito.spy(new MappingUtilsImpl(getDataBroker()));
         Mockito.doReturn(StringConstants.OPENROADM_DEVICE_VERSION_1_2_1).when(mappingUtils)
                 .getOpenRoadmVersion(Mockito.anyString());
@@ -82,7 +81,8 @@ public class PowerMgmtTest extends AbstractTest {
                 new PortMappingVersion221(getDataBroker(), deviceTransactionManager, this.openRoadmInterfaces);
         this.portMappingVersion121 =
                 new PortMappingVersion121(getDataBroker(), deviceTransactionManager, this.openRoadmInterfaces);
-        this.portMapping = new PortMappingImpl(getDataBroker(), this.portMappingVersion22, this.portMappingVersion121);
+        this.portMapping = new PortMappingImpl(getDataBroker(),
+                this.portMappingVersion22, this.portMappingVersion121);
         this.portMapping = Mockito.spy(this.portMapping);
         this.powerMgmt = new PowerMgmtImpl(this.getDataBroker(), this.openRoadmInterfaces, this.crossConnect,
                 this.deviceTransactionManager);
index 1c620a2332a0d731f289671c3e6d37b23f49a0f9..7237f33f83a77112159bc8038547c7e715e21886 100644 (file)
@@ -13,7 +13,6 @@ import java.util.Optional;
 
 import org.junit.Assert;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.mockito.Mockito;
 import org.mockito.MockitoAnnotations;
@@ -59,7 +58,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-@Ignore
+
 public class OlmPowerServiceImplSpanLossBaseTest extends AbstractTest {
 
     private static final Logger LOG = LoggerFactory.getLogger(OlmPowerServiceImplSpanLossBaseTest.class);
index c446799265086f3e5c58dddb1af79a6958c38cb0..5ef9de0bfdcac78532a1a478a73be04d87307089 100644 (file)
@@ -71,7 +71,7 @@ import org.powermock.api.mockito.PowerMockito;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-@Ignore
+
 public class OlmPowerServiceImplTest  extends AbstractTest {
 
     private static final Logger LOG = LoggerFactory.getLogger(OlmPowerServiceImplTest.class);
index 8f0c8c9bbfbc97206cc972c60525bdcdf56b0f7f..229dc199d796ae92d5120e39fe65bc8152afff6e 100644 (file)
@@ -45,6 +45,38 @@ Author: Martial Coulibaly <martial.coulibaly@gfi.com> on behalf of Orange
       <version>3.0.2</version>
       <optional>true</optional>
     </dependency>
+
+    <dependency>
+      <groupId>org.opendaylight.transportpce</groupId>
+      <artifactId>test-common</artifactId>
+      <version>2.0.0-SNAPSHOT</version>
+      <scope>test</scope>
+    </dependency>
+
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-core</artifactId>
+      <version>2.25.0</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.powermock</groupId>
+      <artifactId>powermock-core</artifactId>
+      <version>2.0.2</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.powermock</groupId>
+      <artifactId>powermock-api-mockito2</artifactId>
+      <version>2.0.2</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.powermock</groupId>
+      <artifactId>powermock-module-junit4</artifactId>
+      <version>2.0.2</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
   <repositories>
diff --git a/pce/src/test/java/org/opendaylight/transportpce/pce/PceComplianceCheckResultTest.java b/pce/src/test/java/org/opendaylight/transportpce/pce/PceComplianceCheckResultTest.java
new file mode 100644 (file)
index 0000000..a7e1f17
--- /dev/null
@@ -0,0 +1,23 @@
+/*
+ * Copyright © 2020 Orange Labs, Inc. and others.  All rights reserved.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
+ */
+package org.opendaylight.transportpce.pce.utils;
+
+import org.junit.Assert;
+import org.junit.Test;
+import org.opendaylight.transportpce.pce.PceComplianceCheckResult;
+
+public class PceComplianceCheckResultTest {
+
+    PceComplianceCheckResult pceComplianceCheckResult = new PceComplianceCheckResult(false, "message");
+
+    @Test
+    public void checkGetter() {
+        Assert.assertEquals(false, pceComplianceCheckResult.hasPassed());
+        Assert.assertNotNull(pceComplianceCheckResult.getMessage());
+    }
+}
diff --git a/pce/src/test/java/org/opendaylight/transportpce/pce/PceSendingPceRPCsTest.java b/pce/src/test/java/org/opendaylight/transportpce/pce/PceSendingPceRPCsTest.java
new file mode 100644 (file)
index 0000000..d94f583
--- /dev/null
@@ -0,0 +1,51 @@
+/*
+ * Copyright © 2020 Orange Labs, Inc. and others.  All rights reserved.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
+ */
+package org.opendaylight.transportpce.pce;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.opendaylight.transportpce.pce.utils.PceTestData;
+
+public class PceSendingPceRPCsTest {
+
+    private PceSendingPceRPCs pceSendingPceRPCs;
+
+    @Before
+    public void setUp() {
+        pceSendingPceRPCs = new PceSendingPceRPCs(PceTestData.getPCE_test1_request_54(), null);
+    }
+
+    @Test
+    public void cancelResourceReserve() {
+        pceSendingPceRPCs.cancelResourceReserve();
+        Assert.assertEquals(true, pceSendingPceRPCs.getSuccess());
+    }
+
+    @Test
+    public void pathComputationTest() throws Exception {
+
+        pceSendingPceRPCs.pathComputation();
+
+    }
+
+    @Test
+    public void checkMessage() {
+        Assert.assertNull(pceSendingPceRPCs.getMessage());
+    }
+
+    @Test
+    public void responseCodeTest() {
+        Assert.assertNull(pceSendingPceRPCs.getResponseCode());
+    }
+
+    @Test
+    public void pathComputationWithConstraintsTest() {
+        pceSendingPceRPCs.pathComputationWithConstraints(null, null);
+    }
+}
diff --git a/pce/src/test/java/org/opendaylight/transportpce/pce/SortPortsByNameTest.java b/pce/src/test/java/org/opendaylight/transportpce/pce/SortPortsByNameTest.java
new file mode 100644 (file)
index 0000000..1c1470e
--- /dev/null
@@ -0,0 +1,33 @@
+/*
+ * Copyright © 2020 Orange Labs, Inc. and others.  All rights reserved.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
+ */
+package org.opendaylight.transportpce.pce;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class SortPortsByNameTest {
+
+    private SortPortsByName sortPortsByName = new SortPortsByName();
+
+    @Test
+    public void compareTest() {
+        Assert.assertEquals(12, sortPortsByName.compare("value22", "valu10"));
+    }
+
+    @Test
+    public void compareWithoutNUM() {
+        Assert.assertEquals(0, sortPortsByName.compare("value", "value"));
+    }
+
+    @Test
+    public void compareLessThan() {
+        Assert.assertEquals(-11, sortPortsByName.compare("value1", "value12"));
+    }
+
+
+}
diff --git a/pce/src/test/java/org/opendaylight/transportpce/pce/constraints/PceConstraintsTest.java b/pce/src/test/java/org/opendaylight/transportpce/pce/constraints/PceConstraintsTest.java
new file mode 100644 (file)
index 0000000..e462b79
--- /dev/null
@@ -0,0 +1,106 @@
+/*
+ * Copyright © 2020 Orange, Inc. and others.  All rights reserved.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
+ */
+
+package org.opendaylight.transportpce.pce.constraints;
+
+import java.util.ArrayList;
+import java.util.List;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import org.opendaylight.transportpce.test.AbstractTest;
+
+public class PceConstraintsTest extends AbstractTest {
+    private static PceConstraints pceConstraints = new PceConstraints();
+
+    @Before
+    public void setup() {
+        pceConstraints = new PceConstraints();
+    }
+
+    @Test
+    public void setAndGetMaxLatencyTest() {
+        Assert.assertEquals(-1, this.pceConstraints.getMaxLatency().intValue());
+        pceConstraints.setMaxLatency(-2L);
+        Assert.assertEquals(-2, this.pceConstraints.getMaxLatency().intValue());
+    }
+
+    @Test
+    public void setAndGetExcludeSupNodesTest() {
+        Assert.assertEquals(0, this.pceConstraints.getExcludeSupNodes().size());
+        List<String> nodes = new ArrayList<>();
+        nodes.add("test");
+        this.pceConstraints.setExcludeSupNodes(nodes);
+        Assert.assertEquals(1, this.pceConstraints.getExcludeSupNodes().size());
+    }
+
+    @Test
+    public void setAndGetExcludeSRLGTest() {
+        Assert.assertEquals(0, this.pceConstraints.getExcludeSRLG().size());
+        List<Long> nodes = new ArrayList<>();
+        nodes.add(1L);
+        this.pceConstraints.setExcludeSRLG(nodes);
+        Assert.assertEquals(1, this.pceConstraints.getExcludeSRLG().size());
+    }
+
+    @Test
+    public void setAndGetExcludeCLLITest() {
+        Assert.assertEquals(0, this.pceConstraints.getExcludeCLLI().size());
+        List<String> nodes = new ArrayList<>();
+        nodes.add("test");
+        this.pceConstraints.setExcludeCLLI(nodes);
+        Assert.assertEquals(1, this.pceConstraints.getExcludeCLLI().size());
+    }
+
+    @Test
+    public void setAndGetExcludeClliNodesTest() {
+        Assert.assertEquals(0, this.pceConstraints.getExcludeClliNodes().size());
+        List<String> nodes = new ArrayList<>();
+        nodes.add("test");
+        this.pceConstraints.setExcludeClliNodes(nodes);
+        Assert.assertEquals(1, this.pceConstraints.getExcludeClliNodes().size());
+    }
+
+    @Test
+    public void setAndGetExcludeSrlgLinksTest() {
+        Assert.assertEquals(0, this.pceConstraints.getExcludeSrlgLinks().size());
+        List<String> nodes = new ArrayList<>();
+        nodes.add("test");
+        this.pceConstraints.setExcludeSrlgLinks(nodes);
+        Assert.assertEquals(1, this.pceConstraints.getExcludeSrlgLinks().size());
+    }
+
+    @Test
+    public void setAndGetExcludeNodesTest() {
+        Assert.assertEquals(0, this.pceConstraints.getExcludeNodes().size());
+        List<String> nodes = new ArrayList<>();
+        nodes.add("test");
+        this.pceConstraints.setExcludeNodes(nodes);
+        Assert.assertEquals(1, this.pceConstraints.getExcludeNodes().size());
+    }
+
+    @Test
+    public void setAndGetIncludeNodesTest() {
+        Assert.assertEquals(0, this.pceConstraints.getIncludeNodes().size());
+        List<String> nodes = new ArrayList<>();
+        nodes.add("test");
+        this.pceConstraints.setIncludeNodes(nodes);
+        Assert.assertEquals(1, this.pceConstraints.getIncludeNodes().size());
+    }
+
+    @Test
+    public void getTypeAndNameOfResourcePairTest() {
+        PceConstraints.ResourcePair resourcePair = new PceConstraints
+                .ResourcePair(PceConstraints.ResourceType.CLLI, "test");
+        Assert.assertEquals(resourcePair.getType(), PceConstraints.ResourceType.CLLI);
+        Assert.assertEquals("test", resourcePair.getName());
+
+    }
+
+}
diff --git a/pce/src/test/java/org/opendaylight/transportpce/pce/networkanalyzer/PceCalculationTest.java b/pce/src/test/java/org/opendaylight/transportpce/pce/networkanalyzer/PceCalculationTest.java
new file mode 100644 (file)
index 0000000..e26e306
--- /dev/null
@@ -0,0 +1,50 @@
+/*
+ * Copyright © 2020 Orange Labs, Inc. and others.  All rights reserved.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
+ */
+package org.opendaylight.transportpce.pce.utils.networkanalyzer;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.opendaylight.transportpce.common.network.NetworkTransactionImpl;
+import org.opendaylight.transportpce.common.network.RequestProcessor;
+import org.opendaylight.transportpce.pce.networkanalyzer.PceCalculation;
+import org.opendaylight.transportpce.pce.networkanalyzer.PceResult;
+import org.opendaylight.transportpce.pce.utils.PceTestData;
+import org.opendaylight.transportpce.test.AbstractTest;
+
+public class PceCalculationTest extends AbstractTest {
+
+    private PceCalculation pceCalculation;
+
+    // setup object
+    @Before
+    public void setUp() {
+        PceResult pceResult = new PceResult();
+        pceResult.setRC("200");
+
+        pceCalculation = new PceCalculation(
+                PceTestData.getPCERequest(),
+                new NetworkTransactionImpl(new RequestProcessor(this.getDataBroker())),
+                null,
+                null,
+                pceResult);
+
+
+    }
+
+    @Test
+    public void testPceCalculationValues() {
+
+        pceCalculation.retrievePceNetwork();
+        Assert.assertEquals("100GE", pceCalculation.getServiceType());
+        Assert.assertNotNull(pceCalculation.getReturnStructure());
+
+        Assert.assertNull(pceCalculation.getaendPceNode());
+        Assert.assertNull(pceCalculation.getzendPceNode());
+    }
+}
diff --git a/pce/src/test/java/org/opendaylight/transportpce/pce/service/PathComputationServiceImplTest.java b/pce/src/test/java/org/opendaylight/transportpce/pce/service/PathComputationServiceImplTest.java
new file mode 100644 (file)
index 0000000..71d57e0
--- /dev/null
@@ -0,0 +1,36 @@
+/*
+ * Copyright © 2020 Orange Labs, Inc. and others.  All rights reserved.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
+ */
+package org.opendaylight.transportpce.pce.utils.service;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.opendaylight.transportpce.common.network.NetworkTransactionImpl;
+import org.opendaylight.transportpce.common.network.RequestProcessor;
+import org.opendaylight.transportpce.pce.service.PathComputationServiceImpl;
+import org.opendaylight.transportpce.pce.utils.PceTestData;
+import org.opendaylight.transportpce.test.AbstractTest;
+
+public class PathComputationServiceImplTest extends AbstractTest {
+
+    private PathComputationServiceImpl pathComputationServiceImpl;
+
+    @Before
+    public void setUp() {
+        pathComputationServiceImpl = new PathComputationServiceImpl(
+                new NetworkTransactionImpl(new RequestProcessor(this.getDataBroker())),
+                this.getNotificationPublishService());
+        pathComputationServiceImpl.init();
+    }
+
+    @Test
+    public void pathComputationRequestTest() {
+        Assert.assertNotNull(pathComputationServiceImpl.pathComputationRequest(PceTestData.getPCERequest()));
+        pathComputationServiceImpl.close();
+    }
+}
index 5439cab0196d8111dc356d60a1752818ecbdef96..b822b7a8bf3b0f31b2f338c21856e07285c25a22 100644 (file)
@@ -69,7 +69,7 @@ public final class PceTestData {
                 .build();
         ServiceAEnd serviceAEnd = new ServiceAEndBuilder()
                 .setServiceFormat(ServiceFormat.Ethernet)
-                .setServiceRate(0L)
+                .setServiceRate(100L)
                 .setClli("clli11")
                 .setNodeId("XPONDER-2-2")
                 .setTxDirection(new TxDirectionBuilder().setPort(
diff --git a/pom.xml b/pom.xml
index 211cc5a36af54913baa30c904ec81b47ed364530..9d491d5ab1a7f8314ec370c871919e06e4df05af 100644 (file)
--- a/pom.xml
+++ b/pom.xml
@@ -5,71 +5,74 @@ This program and the accompanying materials are made available under the
 terms of the Eclipse Public License v1.0 which accompanies this distribution,
 and is available at http://www.eclipse.org/legal/epl-v10.html INTERNAL
 -->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-  <modelVersion>4.0.0</modelVersion>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
 
-  <parent>
-    <groupId>org.opendaylight.odlparent</groupId>
-    <artifactId>odlparent</artifactId>
-    <version>6.0.4</version>
-    <relativePath/>
-  </parent>
+    <parent>
+        <groupId>org.opendaylight.odlparent</groupId>
+        <artifactId>odlparent</artifactId>
+        <version>6.0.4</version>
+        <relativePath/>
+    </parent>
 
-  <groupId>org.opendaylight.transportpce</groupId>
-  <artifactId>transportpce-aggregator</artifactId>
-  <version>2.0.0-SNAPSHOT</version>
-  <name>transportpce</name>
-  <packaging>pom</packaging>
+    <groupId>org.opendaylight.transportpce</groupId>
+    <artifactId>transportpce-aggregator</artifactId>
+    <version>2.0.0-SNAPSHOT</version>
+    <name>transportpce</name>
+    <packaging>pom</packaging>
 
-  <scm>
-    <connection>scm:git:ssh://git.opendaylight.org:29418/transportpce.git</connection>
-    <developerConnection>scm:git:ssh://git.opendaylight.org:29418/transportpce.git</developerConnection>
-    <tag>HEAD</tag>
-    <url>https://wiki.opendaylight.org/view/transportpce:Main</url>
-  </scm>
+    <scm>
+        <connection>scm:git:ssh://git.opendaylight.org:29418/transportpce.git</connection>
+        <developerConnection>scm:git:ssh://git.opendaylight.org:29418/transportpce.git</developerConnection>
+        <tag>HEAD</tag>
+        <url>https://wiki.opendaylight.org/view/transportpce:Main</url>
+    </scm>
 
-  <modules>
-    <module>ordmodels</module>
-    <module>tapimodels</module>
-    <module>api</module>
-    <module>common</module>
-    <module>test-common</module>
-    <module>renderer</module>
-    <module>networkmodel</module>
-    <module>inventory</module>
-    <module>olm</module>
-    <module>pce</module>
-    <module>servicehandler</module>
-    <module>tapi</module>
-    <module>features</module>
-    <module>karaf</module>
-  </modules>
+    <modules>
+        <module>ordmodels</module>
+        <module>tapimodels</module>
+        <module>api</module>
+        <module>common</module>
+        <module>test-common</module>
+        <module>renderer</module>
+        <module>networkmodel</module>
+        <module>inventory</module>
+        <module>olm</module>
+        <module>pce</module>
+        <module>servicehandler</module>
+        <module>tapi</module>
+        <module>features</module>
+        <module>karaf</module>
+    </modules>
 
-  <build>
-    <plugins>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-deploy-plugin</artifactId>
-        <configuration>
-          <skip>true</skip>
-        </configuration>
-      </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-install-plugin</artifactId>
-        <configuration>
-          <skip>true</skip>
-        </configuration>
-      </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-javadoc-plugin</artifactId>
-        <configuration>
-          <sourcepath>*/target/generated-sources/mdsal-binding/*</sourcepath>
-          <excludePackageNames>*</excludePackageNames>
-        </configuration>
-      </plugin>
-    </plugins>
-  </build>
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-deploy-plugin</artifactId>
+                <configuration>
+                    <skip>true</skip>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-install-plugin</artifactId>
+                <configuration>
+                    <skip>true</skip>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-javadoc-plugin</artifactId>
+                <configuration>
+                    <sourcepath>*/target/generated-sources/mdsal-binding/*</sourcepath>
+                    <excludePackageNames>*</excludePackageNames>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
 
 </project>
+
+