Remove unchecked warnings from Junit tests

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1115d54f831001250d94ec5d66232edd21cbda65

diff --git a/olm/src/test/java/org/opendaylight/transportpce/olm/stub/MountPointStub.java b/olm/src/test/java/org/opendaylight/transportpce/olm/stub/MountPointStub.java
index 25de9a585e3a71ed74627cc9e7af837ed9ecfbd6..6ba508ed4abaca5ca9f2d4bff2f6faf6ab2f8db0 100644 (file)
--- a/olm/src/test/java/org/opendaylight/transportpce/olm/stub/MountPointStub.java
+++ b/olm/src/test/java/org/opendaylight/transportpce/olm/stub/MountPointStub.java
@@ -32,6 +32,7 @@ public class MountPointStub  implements MountPoint {
     }
 
     @Override
+    @SuppressWarnings("unchecked")
     public <T extends BindingService> Optional<T> getService(Class<T> service) {
         if (service.isInstance(dataBroker)) {
             return Optional.ofNullable((T)dataBroker);

diff --git a/olm/src/test/java/org/opendaylight/transportpce/olm/util/OlmTransactionUtils.java b/olm/src/test/java/org/opendaylight/transportpce/olm/util/OlmTransactionUtils.java
index 8122692044bca518fcedf8f5c9a553c5f92a4c5b..b5dd347c3c0f094ad03c05a786daf2705703506c 100644 (file)
--- a/olm/src/test/java/org/opendaylight/transportpce/olm/util/OlmTransactionUtils.java
+++ b/olm/src/test/java/org/opendaylight/transportpce/olm/util/OlmTransactionUtils.java
@@ -72,6 +72,7 @@ public final class OlmTransactionUtils {
     private OlmTransactionUtils() {
     }
 
+    @SuppressWarnings("unchecked")
     public static void writeTransaction(DataBroker dataBroker, InstanceIdentifier instanceIdentifier,
                                         DataObject object) {
         @NonNull

diff --git a/olm/src/test/java/org/opendaylight/transportpce/olm/util/TransactionUtils.java b/olm/src/test/java/org/opendaylight/transportpce/olm/util/TransactionUtils.java
index ea38cd400f499e5ebcd06fa4bf371b3682744675..d96d880a3ab0c5986f60ffcf46222a4226082678 100644 (file)
--- a/olm/src/test/java/org/opendaylight/transportpce/olm/util/TransactionUtils.java
+++ b/olm/src/test/java/org/opendaylight/transportpce/olm/util/TransactionUtils.java
@@ -70,6 +70,7 @@ public final class TransactionUtils {
 
     }
 
+    @SuppressWarnings("unchecked")
     public static boolean writeTransaction(DataBroker dataBroker, InstanceIdentifier instanceIdentifier,
         DataObject object) {
         ReadWriteTransaction transaction = dataBroker.newReadWriteTransaction();

diff --git a/renderer/src/test/java/org/opendaylight/transportpce/renderer/stub/MountPointStub.java b/renderer/src/test/java/org/opendaylight/transportpce/renderer/stub/MountPointStub.java
index 0ee8393f8af8e13e944776adac8129b854e7954c..3a2a3885099fd87b66739bcd76ca06dc363c7f74 100644 (file)
--- a/renderer/src/test/java/org/opendaylight/transportpce/renderer/stub/MountPointStub.java
+++ b/renderer/src/test/java/org/opendaylight/transportpce/renderer/stub/MountPointStub.java
@@ -32,6 +32,7 @@ public class MountPointStub  implements MountPoint {
     }
 
     @Override
+    @SuppressWarnings("unchecked")
     public <T extends BindingService> Optional<T> getService(Class<T> service) {
         if (service.isInstance(dataBroker)) {
             return Optional.ofNullable((T)dataBroker);

diff --git a/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/TransactionUtils.java b/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/TransactionUtils.java
index 6b68bf1c703313757186b89ad8751a9e9802a009..406eece81e7931689f882973e522c823481eb205 100644 (file)
--- a/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/TransactionUtils.java
+++ b/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/TransactionUtils.java
@@ -24,7 +24,7 @@ public final class TransactionUtils {
 
     }
 
-    @SuppressWarnings("deprecation")
+    @SuppressWarnings({ "unchecked", "deprecation" })
     // deviceTx.put needs the "true" boolean parameter at the end in order to not compromise the Junit test suite
     public static boolean writeTransaction(DeviceTransactionManager deviceTransactionManager,
                                     String nodeId,

diff --git a/tapi/src/test/java/org/opendaylight/transportpce/tapi/utils/TopologyDataUtils.java b/tapi/src/test/java/org/opendaylight/transportpce/tapi/utils/TopologyDataUtils.java
index 53f7e3b38ff79ca6ae4c9cbbac344cc1e07176f2..936ff6f667ecd8dfeeee5156637e2374efb6e7c6 100644 (file)
--- a/tapi/src/test/java/org/opendaylight/transportpce/tapi/utils/TopologyDataUtils.java
+++ b/tapi/src/test/java/org/opendaylight/transportpce/tapi/utils/TopologyDataUtils.java
@@ -77,6 +77,7 @@ public final class TopologyDataUtils {
         LOG.info("openroadm-topology stored with success in datastore");
     }
 
+    @SuppressWarnings("unchecked")
     private static boolean writeTransaction(DataBroker dataBroker, InstanceIdentifier instanceIdentifier,
         DataObject object) {
         @NonNull