added karaf netconf CLI and some minor fixes mostly from compilation warnings

added odl-netconf-console feature to default karaf installation
added missing <relativePath/>  in karaf/pom.xml parent
fixed wrong lexical order warning in TransportpceCliCommandsImpl.java
fixed linelength warning in TransportpceCliTestCommand.java

Change-Id: I5bab81b5d1fd2a0952faf38f145f000af6feaa9e
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

diff --git a/cli/src/main/java/org/opendaylight/transportpce/cli/commands/TransportpceCliTestCommand.java b/cli/src/main/java/org/opendaylight/transportpce/cli/commands/TransportpceCliTestCommand.java
index f9c4e9565ea9aa6ebd7b2793464ad4431ab39703..3efbab91f24318ce81246baf0556faec2ba28cb8 100644 (file)
--- a/cli/src/main/java/org/opendaylight/transportpce/cli/commands/TransportpceCliTestCommand.java
+++ b/cli/src/main/java/org/opendaylight/transportpce/cli/commands/TransportpceCliTestCommand.java
@@ -18,7 +18,9 @@ import org.slf4j.LoggerFactory;
  * This is an example class. The class name can be renamed to match the command implementation that it will invoke.
  * Specify command details by updating the fields in the Command annotation below.
  */
-@Command(name = "test-command", scope = "add the scope of the command, usually project name", description = "add a description for the command")
+@Command(name = "test-command",
+         scope = "add the scope of the command, usually project name",
+         description = "add a description for the command")
 public class TransportpceCliTestCommand extends AbstractAction {
 
     private static final Logger LOG = LoggerFactory.getLogger(TransportpceCliTestCommand.class);
@@ -50,4 +52,4 @@ public class TransportpceCliTestCommand extends AbstractAction {
         final String testMessage = (String) service.testCommand(testArgument);
         return testMessage;
     }
-}
\ No newline at end of file
+}

diff --git a/cli/src/main/java/org/opendaylight/transportpce/cli/impl/TransportpceCliCommandsImpl.java b/cli/src/main/java/org/opendaylight/transportpce/cli/impl/TransportpceCliCommandsImpl.java
index af15d6814dba601ecac908ca4f4a5cf40c7c7e29..9da5c6fd2f54d17ff4c5c2eb8a46a4819eb01bdb 100644 (file)
--- a/cli/src/main/java/org/opendaylight/transportpce/cli/impl/TransportpceCliCommandsImpl.java
+++ b/cli/src/main/java/org/opendaylight/transportpce/cli/impl/TransportpceCliCommandsImpl.java
@@ -8,9 +8,9 @@
 package org.opendaylight.transportpce.cli.impl;
 
 import org.opendaylight.controller.md.sal.binding.api.DataBroker;
+import org.opendaylight.transportpce.cli.api.TransportpceCliCommands;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.opendaylight.transportpce.cli.api.TransportpceCliCommands;
 
 public class TransportpceCliCommandsImpl implements TransportpceCliCommands {
 
@@ -26,4 +26,4 @@ public class TransportpceCliCommandsImpl implements TransportpceCliCommands {
     public Object testCommand(Object testArgument) {
         return "This is a test implementation of test-command";
     }
-}
\ No newline at end of file
+}

diff --git a/features/src/main/features/features.xml b/features/src/main/features/features.xml
index cb9fcc19b40c2e16569595a73ea35dbc23d8cc32..9d57336fa6a04548e498d007e6d6fe794883ded5 100644 (file)
--- a/features/src/main/features/features.xml
+++ b/features/src/main/features/features.xml
@@ -29,6 +29,7 @@ and is available at http://www.eclipse.org/legal/epl-v10.html
     <feature version='${mdsal.version}'>odl-mdsal-broker</feature>
     <feature version='${netconf.version}'>odl-netconf-all</feature>
     <feature version='${netconf.version}'>odl-netconf-connector-all</feature>
+    <feature version='${netconf.version}'>odl-netconf-console</feature>
     <feature version='${project.version}'>odl-transportpce-api</feature>
     <feature version='${project.version}'>odl-transportpce-ordmodels</feature>
     <bundle>mvn:org.opendaylight.transportpce/transportpce-impl/{{VERSION}}</bundle>

diff --git a/karaf/pom.xml b/karaf/pom.xml
index 83c78b13db34a52c39b1fa42b9ac6326afad730a..740701c29fa53d1b0f39647c61ec7fff012a5e74 100644 (file)
--- a/karaf/pom.xml
+++ b/karaf/pom.xml
@@ -12,12 +12,14 @@ and is available at http://www.eclipse.org/legal/epl-v10.html INTERNAL
     <groupId>org.opendaylight.odlparent</groupId>
     <artifactId>karaf-parent</artifactId>
     <version>1.8.0-SNAPSHOT</version>
+    <relativePath/>
   </parent>
 
   <groupId>org.opendaylight.transportpce</groupId>
   <artifactId>transportpce-karaf</artifactId>
   <version>0.1.0-SNAPSHOT</version>
   <name>${project.artifactId}</name>
+  <packaging>pom</packaging>
 
   <properties>
     <karaf.localFeature>odl-transportpce-ui</karaf.localFeature>