From: Gilles Thouenon Date: Fri, 1 Sep 2023 17:06:08 +0000 (+0200) Subject: Declare as final private classes X-Git-Tag: 8.0.0~13^2 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=transportpce.git;a=commitdiff_plain;h=7ebd052fb7e46f81fc0566dfa92f1d298601d8a6 Declare as final private classes Latest checkstyle version (10.12.3) reports bug when private class without constructor is not declared final. Fix it up. Signed-off-by: Gilles Thouenon Change-Id: Ifdc824a9d5c5ac4aaba38b222a8240b8a9235a52 --- diff --git a/networkmodel/src/test/java/org/opendaylight/transportpce/networkmodel/util/OpenRoadmTopologyTest.java b/networkmodel/src/test/java/org/opendaylight/transportpce/networkmodel/util/OpenRoadmTopologyTest.java index 5ca66393f..31d9180dd 100644 --- a/networkmodel/src/test/java/org/opendaylight/transportpce/networkmodel/util/OpenRoadmTopologyTest.java +++ b/networkmodel/src/test/java/org/opendaylight/transportpce/networkmodel/util/OpenRoadmTopologyTest.java @@ -453,7 +453,7 @@ public class OpenRoadmTopologyTest { } } - private class InterruptedLinkFuture implements ListenableFuture> { + private final class InterruptedLinkFuture implements ListenableFuture> { @Override public boolean cancel(boolean arg0) { diff --git a/tapi/src/test/java/org/opendaylight/transportpce/tapi/topology/TapiTopologyImplExceptionTest.java b/tapi/src/test/java/org/opendaylight/transportpce/tapi/topology/TapiTopologyImplExceptionTest.java index b09340b25..9e46f5395 100644 --- a/tapi/src/test/java/org/opendaylight/transportpce/tapi/topology/TapiTopologyImplExceptionTest.java +++ b/tapi/src/test/java/org/opendaylight/transportpce/tapi/topology/TapiTopologyImplExceptionTest.java @@ -75,7 +75,7 @@ public class TapiTopologyImplExceptionTest { } } - private class ReadTransactionMock implements ReadTransaction { + private final class ReadTransactionMock implements ReadTransaction { @Override public @NonNull Object getIdentifier() {