Refactor Networkmodel PortMappingListener

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id4c08284c6f032258d1cc00920ccb208ccee6e8c

Bump kafka-client version to 3.7.0

JIRA: TRNSPRTPCE-789
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Id83149775a1a670880a58be39270bae5f4b5d275

Migrate tapi notification functional tests to 2.4

- fix NPE issue in CreateConnectivityServiceValidation when the request
does not contain any topology constraints
- TAPI notification functional test suite had been forgotten in the TAPI
migration to new models in v2.4. Adapt these tests to the new
implementation.

JIRA: TRNSPRTPCE-790
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I0d0cb473cc7178205e1a5e8614563aa7aaf63dc9

Fix bugs in nbinotifications module

- fix NPE issue in NbiNotificationsHandler
- fix message issue in PceNotificationHandler of service handler
- add small delay in functional test execution to let the notification
being sent in kafka broker
- fix issue when uninstalling the feature (publisher sessions with
kafka server remained open)

JIRA: TRNSPRTPCE-790
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I914f3c2313e17ec25b36633ef8af26ff8f8394bf

Fix karaf client issue in functional test library

- Remove logout from the bash command sent with subprocess run to avoid
having a runtime exception in karaf when we install the
odl-transportpce-nbinotifications feature
- remove an useless variable in sims_update_cp_port_ntcf method

JIRA: TRNSPRTPCE-782
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I002c3c154d49ff5f128929084a5802f9eea16c9f

Bump netconf to version 7.0.3

Use latest netconf version to pick few fixes.

JIRA: TRNSPRTPCE-782
Change-Id: Ib0d870c1c8d65da4878851afc955415df64144b4
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Bump grizzly-http-server version to 4.0.2

Instead of an old and unsecured 2.4.0 version.

JIRA: TRNSPRTPCE-789
Change-Id: Ia99c42f013e1c7415fbce0973795ddc8fb2095d6
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Replace javax.activation-api by the jakarta one

Remove the fixed and old version of javax.activation-api for the benefit
of the jakarta.activation-api provided by odlparent.

JIRA: TRNSPRTPCE-789
Change-Id: I3a22c3207c72f8efacde0654c3005b676b478763
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Merge changes I6014d5f7,I88b072fa

* changes:
  Refine the RPC implementation registration
  Bump upstream dependencies to latest Ca versions

Refine the RPC implementation registration

- Replace the ClassToInstanceMap argument by a plain varargs with the
RPC implementations when registering RPC to
mdsal.binding.api.RpcProviderService.
- Optimize code by removing classes that have now become almost useless
- adapt the JUnit tests to check exactly which RPC impl are registered

JIRA: TRNSPRTPCE-788
Change-Id: I6014d5f7a4d0447a14ddcac59de6b1d9539677fb
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Bump upstream dependencies to latest Ca versions

Adopt:
- odlparent-13.0.11
- yangtools-13.0.2
- mdsal-13.0.1
- netconf-7.0.2

JIRA: TRNSPRTPCE-782
Change-Id: I88b072fa5abb6c020da743429777f1f2c96075f0
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Fix inventory listeners code style

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8120d9e53faf337ab4e32705782ba844ce58ca60

Refactor common CrossConnectImpl

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I23cbb0a2b6aaa61d90cf86fa6417dcb948b377a2

Only verify PreFEC BER if end node is Xponder

Trying to read PreFEC BER from end nodes when creating a ROADM-to-ROADM
service is unnecessary since only Xponders report this parameter.
Adapt renderer unitary tests

JIRA: TRNSPRTPCE-158
Change-Id: Id1a9bfe69296abaeffe63d589a79d113bf8d9bcc
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>

Fix Renderer Junit Tests exceptions

New rollback process makes junit tests running with exceptions. Fix
them.

JIRA: TRNSPRTPCE-782
Change-Id: Ie8b95582589140b6e079861a4878f683b193ac02
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Bump upstream dependencies to Ca

Adopt:
- odlparent-13.0.10 (already done)
- yangtools-13.0.1
- mdsal-13.0.0
- netconf-7.0.1
- transportpce-models-20.0.0-SNAPSHOT

Also, move each rpc implementation in a dedicated class to ease their
registration.
Adapt, and sometimes redo, some unitary tests.

Prepare lighty build.
FIXME: need mdsal.binding.api.RpcService in lighty.

Adapt the python lib (test_utils) to the new way of configuring
login/passwork when we mount a netconf device.

JIRA: TRNSPRTPCE-782
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I5e8b0634e02b8d0ee810d9bb8471b4b6cac8e990

Make lighty build non voting in CI

Change-Id: I55709eae45349e011923b77825c97062e5ce1676
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Merge changes I8c049137,I8660893e

* changes:
  Switch all func tests to lightynode
  Add a tox profile to install lightynode

Merge changes Ib0dab687,Ia7e45116,I6839ad8b

* changes:
  Turn down OLM power AtoZ and ZtoA in parallel
  Refactor RendererServiceOperationsImpl notify
  Olm Power Down Task

Merge changes I453a92fd,I68ba6341

* changes:
  Allow the client to specify ROADM service SRG port
  Address yang name change for transportpce-pce

Merge "Complement sims configuration files"

Merge changes from topic "lambdaHandling"

* changes:
  Reindent PceTestData Junit
  Refactor PCE OperatorConstraints
  Add SpectrumFillingRule check in postAlgoValidator

Reindent PceTestData Junit

JIRA: TRNSPRTPCE-783
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id8ab0f5d24f9ed845ccc0e0ffcfbadb1003d2a39

Refactor PCE OperatorConstraints

JIRA: TRNSPRTPCE-783
Change-Id: I062e49ad39ad417026919d4bf5f74b15265cd7bd
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Switch all func tests to lightynode

- in tox.ini adopt lightynode sims for remaing 7.1, hybrid and
  with_docker tests
- adapt tests using netconf connector instead of restconf one as soon as
Lightynode does not support restconf api.
- adopt lighty-openroadm-device-19.1.0.5

JIRA: TRNSPRTPCE-754
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I8c049137c56c46e4ca4af1ed95a20c4d62a7d420

Add a tox profile to install lightynode

- create a new tox profile that install lightynode
- fix a bug when lightynode directory was not present
- adapt the shell script to be able to specify eiter a specific released
or snapshot version to install
- make tox fail when download fails

JIRA: TRNSPRTPCE-754
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I8660893e48a02d6c355fb6d63778ee5667cd2b69

Add SpectrumFillingRule check in postAlgoValidator

JIRA: TRNSPRTPCE-783
Change-Id: I4c98c6ddfcff4e71c2f8c00774b8e6d80801ca07
Signed-off-by: orenais <olivier.renais@orange.com>

Allow the client to specify ROADM service SRG port

Allows the client to specifiy port with 'port-device-name' and
'port-name' (see example down below).

The feature is implemented in PceOpticalNode. The rest are
classes being updated since there is a new argument in
the method PceOpticalNode.initSrgTps():

    initSrgTps(Preference portPreference) {...}

Feature implementation overview

The feature uses the classes in package:
org.opendaylight.transportpce.pce.networkanalyzer.port

* PceCalculation instantiates an instance of Preference using
  PreferenceFactory and passing it on to the constructor in
  PceOpticalNode.
* PreferenceFactory in turn uses PathComputationRequestInput
  to return either 'NoPreference' or 'ClientPreference'.
* Returning an instance of 'NoPreference' is the backwards compatible
  approach. The class 'NoPreference' is currently implemented as
  the equivalent of 'port-device-name' and 'port-name' being absent
  from the client request.
* If the client uses 'port-device-name' and 'port-name' an instance
  of ClientPreference is returned.
* PceOpticalNode uses the method preferredPort(...) defined by
  the interface Preference (implemented by NoPreference/
  ClientPreference) when building a list of avilable ports.
  If a port is not in the preferred list, it's treated as
  unavailable by PceOpticalNode.

APIImpact

POST /rests/operations/org-openroadm-service:service-create
{
  "input": {
...
    "port": {
      "port-device-name": "ROADM-B-SRG1",
      "port-name":        "SRG1-PP2-TXRX",
    }
...
  }
}

The above will result in port SRG1-PP2-TXRX on node ROADM-B-SRG1
being used in the service. All other ports on ROADM-B-SRG1
will be treated as "unavailable".

JIRA: TRNSPRTPCE-176
Change-Id: I453a92fda2977ac86c5c5ff47e1a7f6cd322334d
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Address yang name change for transportpce-pce

In TRNSPRTPCE-783, there is name revision update from
transportpce-pce@2023-09-25 to transportpce-pce@2024-02-05.

JIRA: TRNSPRTPCE-176
Change-Id: I68ba63411045c18087e15854835a2d9913e20424
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Merge "Refactor TAPI Connectivity Utils"

Merge "Fix persistence when karaf is restarted"

Merge changes Ib795f077,I723e4262

* changes:
  Refactoring rollback when service create fails
  New Package dealing with device rollback

Merge "Determine preferred node/port from PCRI"

Merge "Add customer name to pathComputationRequest input"

Complement sims configuration files

- Add current-pm-description (pm-handling yang model) for 7.1 ROADM
- Add current-pm-list list (org-openroadm-pm yang model) for 7.1 ROADM-B

JIRA: TRNSPRTPCE-787
Change-Id: I32f5b79e6e6b4555bcd8e8812ee4840e9aad928c
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>

Turn down OLM power AtoZ and ZtoA in parallel

Use the new task OlmPowerTurnDownTask to delete a service
AtoZ and ZtoA in parallel.

JIRA: TRNSPRTPCE-616
Change-Id: Ib0dab687ef3f5c4a12ad8a71fa5c78d1f9d72254
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Refactor RendererServiceOperationsImpl notify

Refactor three private methods in RendererServiceOperationsImpl
into a separate class implementing the interface 'Notification'
in package:

    org.opendaylight.transportpce.renderer.provisiondevice.notification

The constructor in RendererServiceOperationsImpl requires an instance
of 'Notification' instead of 'NotificationPublishService'. Meaning
RendererServiceOperationsImpl is using NotificationPublishService
indirectly as opposed to directly.

The rest of the changes is a ripple effect due to the constructor
being updated.

JIRA: TRNSPRTPCE-616
Change-Id: Ia7e45116d44581fe2a54dc0b58843840a007d5fb
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Olm Power Down Task

A task capable of running in parallel powering down OLM power.
The package also contains an Interface left open to be implemented
at a later time.

Pseudo code example usage:

ListenableFuture<OLMRenderingResult> futureAtoZ =
    this.executor.submit(
        new OlmPowerTurnDownTask(...)
    );

ListenableFuture<OLMRenderingResult> futureZtoA =
    this.executor.submit(
        new OlmPowerTurnDownTask(...)
    );

ListenableFuture<List<OLMRenderingResult>> futures =
    Futures.allAsList(futureAtoZ, futureZtoA);

List<OLMRenderingResult> results;

try{
    results = futures.get(Timeouts.OLM_TIMEOUT, TimeUnit.MILLISECONDS);
} catch (Exception e) {
    LOG.error("Error while turning down power!");
}

if (results.get(0).isSuccess() && results.get(1).isSuccess()) {
    LOG.info("OLM power successfully turned down");
}

JIRA: TRNSPRTPCE-616
Change-Id: I6839ad8bdd5feeec5bcd63700efe55c8aed01085
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Refactor TAPI Connectivity Utils

JIRA: TRNSPRTPCE-734
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I05fec0450c269ff5dbc169c70a81c7144834f9c1

Merge "Allow 0 dB spanloss in power management"

Merge "Refactor TAPI ConvertORTopoToTapiFullTopo"

Merge "Refactor TAPI ConvertORToTapiTopology"

Merge "Fix some TAPI ConnectivityUtils log msg"

Merge "Fix OLM rollback"

Fix some TAPI ConnectivityUtils log msg

JIRA: TRNSPRTPCE-734
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iab258e658613bce1cc4e4962a2b2456aa8182edf

Determine preferred node/port from PCRI

Package intended to be used to determine preferred SRG port
usage when setting up optical services between ROADMs.

Use an instance of PathComputationRequestInput, e.g. API
input and provides a method for checking if a specific SRG port
is among the ports in the client request.

Package org.opendaylight.transportpce.pce.networkanalyzer.port:

* Preference        - Interface defining one method capable
                      of determining if a node/port is 'preferred'
                      by the client.
* ClientPreference  - Implements Preference. Contains information
                      about actual client port preference.
* NoPreference      - Implements Preference. Typically used when
                      the client has no preference regarding port.

* Factory           - Interface defining methods needed in order
                      to convert a PathComputationRequestInput
                      to an implementation of Preferenc.
* PreferenceFactory - Implements Factory. The method
                      'portPreference' should typically be used
                      implementing the feature in the application.

                      The method portPreference either returns
                      an instance of 'ClientPreference' or
                      'NoPreference'.

Example:

public void someMethod(PathComputationRequestInput input) {

    Factory portPreferenceFactory = new PreferenceFactory();

    Preference preference = portPreferenceFactory.portPreference(input);

    if (preference.preferredPort("ROADM-A-SRG1", "SRG1-PP1-TXRX")) {
        System.out.println("The port 'SRG1-PP1-TXRX' on 'ROADM-A-SRG1' "
                          +"is preferred by the client.");
    }

}

JIRA: TRNSPRTPCE-176
Change-Id: Iba7e7886678deb6d965391633f819995635caa06
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Fix persistence when karaf is restarted

OpenDaylight supports datastore persistence but this does not currently
work for TransportPCE since the service list and all openroadm network
layers are initialised as empty when karaf is started.

This changes the transaction from put to merge in order to not
overwrite existing services and network layers.

This also sets config datastore persistence to false before running
tests since they are implemented with the assumption that datastore is
not persistent.

JIRA: TRNSPRTPCE-706

Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
Change-Id: Icec7a1ae47d7001eb408b3b573a837daa8645bc8

Merge "Fix warning message when service creation fails"

Fix warning message when service creation fails

When service implementation failed, the warning message "Service was
not removed from datastore!" was shown in the log, even if the service
was successfully removed.

JIRA: TRNSPRTPCE-784
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
Change-Id: I64bb939459e32155626bce1a57da6bd09db22ac8

Fix OLM rollback

The OLM rollback task did not correctly set spectral slot numbers,
causing a null pointer exception.

JIRA: TRNSPRTPCE-786
Change-Id: I8cdaa109b718d47c8d5b620b9d686903f19c08d3
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>

Refactor TAPI ConvertORToTapiTopology

JIRA: TRNSPRTPCE-759
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I00c47bebf899a5abc2fd5584d96ba4ce7a8b41ca

Refactoring rollback when service create fails

The new rollback feature is primarily implemented in the method
deviceRendering in the class RendererServiceOperationsImpl.

The new class TransactionHistory is passed into
DeviceRendererServiceImpl via DeviceRenderingTask.
DeviceRendererServiceImpl populates the TransationHistory class
with created interfaces etc.

A new rollback task NetworkDeviceRenderingRollbackTask has been
created intended to replace DeviceRenderingRollbackTask. The
class is instantiated with a TransactionHistory object intended
to be used in case of a rollback.

Sample pseudo code extract

class RendererServiceOperationsImpl:
private List<DeviceRenderingResult> deviceRendering(...) {

    History transactionHistory = new TransactionHistory();

    ListenableFuture<DeviceRenderingResult> atozrenderingFuture =
        this.executor.submit(
            new DeviceRenderingTask(..., transactionHistory));

    ListenableFuture<DeviceRenderingResult> ztoarenderingFuture =
        this.executor.submit(
            new DeviceRenderingTask(..., transactionHistory));

    ListenableFuture<List<DeviceRenderingResult>>
        renderingCombinedFuture = Futures.allAsList(
            atozrenderingFuture, ztoarenderingFuture
        );

    List<DeviceRenderingResult> renderingResults = new ArrayList<>(2);
    renderingResults = renderingCombinedFuture.get(...);

    rollbackProcessor.addTask(
        new NetworkDeviceRenderingRollbackTask(
            "RollbackTransactionHistoryTask",
            transactionHistory,
            ! (renderingResults.get(0).isSuccess()
                && renderingResults.get(1).isSuccess()),
            deviceRenderer,
            new RollbackResultMessage()
        )
    );

    return renderingResults;
}

New somewhat simplified rollback method using TransactionHistory
intended to replace the previous method using RendererRollbackInput:

class RendererServiceOperationsImpl:
@Override
public RendererRollbackOutput rendererRollback(
    History transactionHistory
) {
    LOG.info("Rolling back...");

    Result rollbackResult = new FailedRollbackResult();
    Subscriber deleteSubscriber = new DeleteSubscriber(rollbackResult);

    transactionHistory.rollback(
            new DeleteService(
                    crossConnect,
                    openRoadmInterfaces,
                    deleteSubscriber
            )
    );

    LOG.info("Rollback done!");

    return rollbackResult.renderRollbackOutput();
}

JIRA: TRNSPRTPCE-615
Change-Id: Ib795f077ae763bd92bac44ee77186a19ed0e4b2a
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Fix ConvertORToTapiTopology Upper/Lower Freq bug

JIRA: TRNSPRTPCE
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I91568bef19ddb5475c74696720517fed8c905f11

New Package dealing with device rollback

Add a new class (TransactionHistory) capable of keeping
track of created interfaces (during a service creation
process) and rolling them back.

The DeleteService class handles the rollback process. Passing
in a subscriber (DeleteSubscriber) capable of tracking the process
and creating a result.

Pseudo code example

public Result rollbackExample(
        OpenRoadmInterfaceFactory openRoadmInterfaceFactory,
        OpenRoadmInterfaces openRoadmInterfaces,
        CrossConnect crossConnect
) {

    History transactionHistory = new TransactionHistory();

    String supportingOchInterface = openRoadmInterfaceFactory
        .createOpenRoadmOchInterface(...);

    transactionHistory.add(
        new DeviceInterface(nodeId, supportingOchInterface)
    );
    transactionHistory.addInterfaces(
        nodeId,
        supportingOchInterface.split("#")
    );

    Result rollbackResult = new FailedRollbackResult();
    Subscriber deleteSubscriber = new DeleteSubscriber(rollbackResult);

    transactionHistory.rollback(
        new DeleteService(
            crossConnect,
            openRoadmInterfaces,
            deleteSubscriber
        )
    );

    return rollbackResult.renderRollbackOutput();

}

JIRA: TRNSPRTPCE-615
Change-Id: I723e42628e8de0b45ab9160b5b8c366497c0f550
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Allow 0 dB spanloss in power management

Currently, power management, and therefore also service creation, fails
if any spanloss is 0 dB. There is nothing in the OpenROADM spec that
says 0 dB is out of range. The spanloss range is defined as:
Min: 0, Max: 27 dB

JIRA: TRNSPRTPCE-785
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
Change-Id: I62969b7cbe5c9ba06cdbfa51ee5db87c372479ea

Merge "Refactor TAPI ConvertORTopoToTapiTopo Junit"

Add customer name to pathComputationRequest input

JIRA: TRNSPRTPCE-783
Change-Id: I16dbcf89e3626051cacee2e693cebe5795a6fdc2
Signed-off-by: orenais <olivier.renais@orange.com>

Refactor some TAPI Junit tests code

JIRA: TRNSPRTPCE:758
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I49fe0a517fd7c57616ddd32697cd4ab8fd931085

Refactor TAPI ConvertORTopoToTapiTopo Junit

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I865c3b62363162ab34558fda8a1e2720a2d8e9e0

Refactor TAPI ConvertORTopoToTapiFullTopo

JIRA: TRNSPRTPCE-735
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I707ce33c5be5540a8fd7692c06d214fd4bb6d8ed

Udate tapi dependency in Lighty

JIRA: TRNSPRTPCE-759
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I36aacf6d41b8b46ac10366bbd306b1bd2733b8b2

Fix tox wiki dead URL false positives in CI

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I33ad8e4b482ea5c5249b138e25c150004263bf98

Refactoring of Tapi Step3

Add characteristics introduced in T-API 2.4 starting with nodes.
Add Payload-structure and photonic-owned-node-edge-point-spec
to xpdr OTSi and OTS NEPs (at initialization, and onDataTreeChange)

JIRA: TRNSPRTPCE-759
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I71e5e148b9ac4cd94589bb85c39618effdde3aa4

Add Supported OM to PortMapping.yang

JIRA: TRNSPRTPCE-707
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: Ic3b42fe180a856e905f57f66691131b7324a7e3c

Refactoring of Tapi Step2

Add createAvailable/SupportedPayloadStructure and photonic-owned
-node-edge-point-spec attribute in convertORToTapiTopology class

JIRA: TRNSPRTPCE-758

Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I04821270cab8a1408032cea42e45292fdfe81ef1

Refactoring of TAPI Step1

- Step 1.1 : suppress redundant methods between ConnectivityUtils &
TapiPceNotificationHandler
- Step 1.2 : homogenize code between converORTopoTo-Tapi/TapiFull-Topo
& TapiNetworkModelServiceImpl classes
- Step 1.3 : Suppress redundant code in convertORTopoTo-Tapi/
TapiFull-Topo & TapiNetworkModelServiceImpl classes and create
ConvertORToTapiTopology to host common methods of these classes

JIRA: TRNSPRTPCE-758
Change-Id: Ic068c3a610db6b664420f8a864cfe5e75fae91e1
Signed-off-by: orenais <olivier.renais@orange.com>

Migration to TAPI 2.4 Step3

- Correct some bugs associated with migration to T-API 2.4
- Adjust JUnit tests accordingly
- Adjust functional tests

JIRA: TRNSPRTPCE-734
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I54a3cc091cb75b145c81f3e0b251cfc8a0607d56

Migration to TAPI 2.4 Step2

Migration of nbi-notification to TAPI 2.4

JIRA: TRNSPRTPCE-734
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I868d82258cdb1c7b2ee3cb16653dbb89a5ca13cc

Migration to TAPI 2.4 Step1

- Migration of transportpce-tapi to TAPI2.4, including code and tests
- Integrate change of nbi-notification performed in change 106484 to
simplify merge
- Compilation succeeds for tpce-tapi, but fails at tpce-nbinotifications
for which migration is planned in Step2

JIRA: TRNSPRTPCE-735
Change-Id: I7a8580a5d77b80346186084b134a3d42e1c24332
Signed-off-by: orenais <olivier.renais@orange.com>

Remove odl-transportpce-swagger feature

This feature is an old workaround that was intended to allow TPCE
developers to enable swagger. This is an empty feature that has been
useless for a while. Just delete it.

JIRA: TRNSPRTPCE-779
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ie3b087d2d383c904b1e17c838195b87cd61db2c2

Don't use NotificationListener (NodeRegistration)

Don't use NotificationListener in classes used by NodeRegistration.
This is a part of NotificationListener to Listener<?> migration.

JIRA: TRNSPRTPCE-756
Change-Id: Ic527adce8e535c2c7e5bd694afd7219b4e1a5613
Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>

Bump upstream dependencies to K-SR2

Adopt:
- odlparent-13.0.10
- yangtools-11.0.5
- mdsal-12.0.4
- netconf-6.0.6
- transportpce-models-19.2.0

Also, update the revision of opendaylight.netconf.device packages
imported in different modules to rev240118.

JIRA: TRNSPRTPCE-777
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ib2ef5c492c774bb1442345bd58983d0210f3df7c

Remove some useless code

Remove few useless properties in common, tapi, nbinotifications and
dmaap-client modules.

JIRA: TRNSPRTPCE-778
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I06135cddd40b073c41e4ce37d3032a36a2c02c98

Remove softConstraints from PceGraph

pceSoftConstraints is a property never used in PceGraph. Just remove it
and adapt code consequently.

JIRA: TRNSPRTPCE-778
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Iebedae657ce5114b1d36078bd386b684677db724

Bump lighty-app-parent to 19.1.0

JIRA: TRNSPRTPCE-777
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I465e6dc0aacaae3662aabe06a687bd23abee87a3

Add new functional PCE test to check bug-772

- Add a new pce functional test suite dedicated to check pce bugs. Check
the fix of TRNSPRTPCE-772 bug
- Add adequate topo and portmapping json input files

JIRA: TRNSPRTPCE-772
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I6f9948865343ca15c238f2185134c7f35ccba374

PCE graph spectrum assignment slight refactoring

JIRA: TRNSPRTPCE-772
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ib4210d7fe451e9be673f11eb9860e07a2665f351

Spectrum assignment skipped the last node in path

APIImpact

Corrects an issue were the last node in a path was not
taken into account during spectrum assignment.

A path consists of a list of source/destination node pairs,
eg [(N1,N2) (N2,N3) (N3,N4)].

Consider this network: [A] ----- [B],  were A and B are ROADMs.
During path computation the above example may produce a path
such as:
[(A-SRG1, A-DEG1) (A-DEG1, B-DEG1) (B-DEG1, B-SRG1)]

The bug caused the code to skip checking for available
spectrum on B-SRG1.

This was due to spectrum assignment is only processed
in the A-Z direction, combined with an iteration only
taking the source node into account.

JIRA: TRNSPRTPCE-772
Change-Id: Ia0822a1cdb0e4b5f67d9c9675e1203f0a0746ef6
Signed-off-by: Joakim Törnqvist <joakim.tornqvist@smartoptics.com>

Bump upstream dependencies to K-SR1

Adopt:
- odlparent-13.0.7
- yangtools-11.0.4
- mdsal-12.0.3
- netconf-6.0.5
- transportpce-models-19.1.0

Also, update the netconf/device revision imports to rev231024.

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I154c6d4b457d0a0953024acce6bf94e945626657

Bump jgrapht upstream dependency to 1.5.2

- bump to the latests jgrapht version
- replace the KShortestSimplePaths deprecated algo by the new
YenKShortestPath one

JIRA: TRNSPRTPCE-770
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I0fefeefbab1d195bfbb466fd3f68cfffe19a0c77

Fix PCE bug to select the path proposed by GNPy

Introduce the "loose" or "strict" mode to differentiate two ways to
manage include node constraints: either the path must simply include
some nodes whatever the order of node inside the list is, or the path
must be exactly equal to the list of nodes.

JIRA: TRNSPRTPCE-769
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I34c0e3491fc341af3de0ff5b0dc702f40c7dd653

Add pce-constraint-mode enum in pce yang model

This enum will allow to select a way to manage hardconstraints, either
in a "loose" or "strict" mode.
Update import version.

JIRA: TRNSPRTPCE-769
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Iaa91f34f2d9129471b29c51ff7bd506ad42baa86

Merge "Update tox documentation link in tox-guide"

Merge "Fix port-mapping bug for 7.1 device-models"

Fix port-mapping bug for 7.1 device-models

- For switch-client ports that have
  supported-interface-capabilties such as if-100GE, that does
  not contain otn-capabilities

JIRA: TRNSPRTPCE-771
Signed-off-by: Balagangadhar (Bala) Bathula <bb4341@att.com>
Change-Id: I785d251889b7ae5b5eb7d08f6ba7929342260481

Merge changes I6a92bf21,Idd21a62d

* changes:
  Complement B100G_end2end functional test
  Fix PCE bug to select the correct client port

Update tox documentation link in tox-guide

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Iee9cd47d7e4674ae5e0f19d27c8dacdd13a2af58

Don't use NotificationListener (TapiProvider)

Don't use NotificationListener in classes used by TapiProvider.
This is a part of NotificationListener to Listener<?> migration.

JIRA: TRNSPRTPCE-756
Change-Id: I087bc8dacbc710da39c308dc5fbef7028d0d6d56
Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>

NBI notification support for service-result-rpc

- After the temp-serice-create, service-rpc-result notification
  is sent on the MD-SAL binding.
- However this notification should be available for north-bound
  (external) controller to indicate the transport assignment
  details.
- Add code to enable NBI notification for service-result-rpc.
- Modify nbi-notification YANG structure to include transport-assignment
  details of the temp-service-create.

JIRA: TRNSPRTPCE-751

Change-Id: I87ab30176136783e0a448cfbe48df0b7d29b6a31
Signed-off-by: Balagangadhar (Bala) Bathula <bb4341@att.com>

Add JSON assert dependency

Change-Id: I88d9f57683dd90965a70f12aac4b705291769a0a
Signed-off-by: Balagangadhar (Bala) Bathula <bb4341@att.com>

Use mvn quick profile in other tests Karaf builds

JIRA: TRNSPRTPCE-767
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ifc45add76952c692afee6e74b277851bd380b344

Merge "Don't use NotificationListener (NbiNotifications)"

Complement B100G_end2end functional test

Add new tests in hybrid/B100G_end2end functional test suite to check the
case of an OTN service terminated on different client ports on both A
and Z ends.

JIRA: TRNSPRTPCE-768
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I6a92bf214b025e3694f373d383a2311ad95bb1fa

Fix PCE bug to select the correct client port

Introduce a clientA and clientZ into PceLink to allow having different
values at both ends of the path.

JIRA: TRNSPRTPCE-768
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Idd21a62dd67a4e3668a4d32f5074d347abbd20a2

Fix tests/requirements.txt

Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I1bfffe8714cc9dd424b54786d3a53ca76ff55002

Merge "Don't use NotificationListener (Servicehandler)"

Don't use NotificationListener (Servicehandler)

Don't use NotificationListener in classes
used by ServicehandlerProvider.
This is a part of NotificationListener to Listener<?> migration.

JIRA: TRNSPRTPCE-756
Change-Id: I90eba1664c2954e7e3954b7eabb47aa4d6c1843b
Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>

Update aggregator POMs

Disable artifact processing for aggregator POM that don't produce any
useful artifact.

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I6862c9ab76bdf802aa3402f05d6d038997f4aabf

Don't use NotificationListener (NbiNotifications)

Don't use NotificationListener in NbiNotificationsListenerImpl.
This is a part of NotificationListener to Listener<?> migration.

JIRA: TRNSPRTPCE-756
Change-Id: I2b70fa611061179f5e1f4db33eede7fd3d05cd07
Signed-off-by: Matej Sramcik <matej.sramcik@pantheon.tech>

Use maven quick profile in tox-verify job

Quick profile allows to disable test, code analysis, javadoc generation
and so on.

JIRA: TRNSPRTPCE-767
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I20166dd309e46229fe698e7e12879272ad3eb083