transportpce.git
3 days agoAutonomous impairment aware path computation 63/103663/21 master
orenais [Tue, 31 Jan 2023 16:00:04 +0000 (17:00 +0100)]
Autonomous impairment aware path computation

- in PostAlgoValidator, adapt checkOSNR to scan the path in both AtoZ
and ZtoA directions, and to calculate impairments using catalog
primitives
- add to CatalogUtils some complementary primitives that were missing
getPceRoadmAmpOutputPower
- add to PceOpticalNode and PceLink missing methods
- refactor GraphTest for integration test associated with path
computation and add portMapping2.json and or-base-topology.json with
adpted OMS parameters

JIRA: TRNSPRTPCE-517 TRNSPRTPCE-605
Change-Id: I00973dcd0898d786c421c46f031d9b2b915514e8
Signed-off-by: orenais <olivier.renais@orange.com>
4 days agoFix pylint issues 30/104230/1
guillaume.lambert [Thu, 2 Feb 2023 19:05:57 +0000 (20:05 +0100)]
Fix pylint issues

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I6bdd76c2478859bfc34be3937a60821369c04b3c

9 days agoAdd test_utils ODL startup opt-out support 79/104179/7
guillaume.lambert [Thu, 26 Jan 2023 19:16:52 +0000 (20:16 +0100)]
Add test_utils ODL startup opt-out support

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I28b94e6ff6cf94c4bc9643992aef6c0ff68ba41a

9 days agoRestore TAPI feat install w/ Karaf client in tests 85/104185/1
guillaume.lambert [Sat, 28 Jan 2023 09:21:45 +0000 (10:21 +0100)]
Restore TAPI feat install w/ Karaf client in tests

JIRA: TRNSPRTPCE-701
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I15eca75c9187192bf02c27f585c991c547a61d18

10 days agoUse karaf client batch mode 78/104178/3
Sangwook Ha [Thu, 26 Jan 2023 19:10:38 +0000 (11:10 -0800)]
Use karaf client batch mode

Karaf 'client' command has a batch mode option ('-b') to take commands
from stdin without requiring TTY. Hence this option makes it possible
to run the command without getting affected by the Karaf terminal
property setup issue.

JIRA: TRNSPRTPCE-701
Change-Id: I885df3ee97fd528e151edcf98bb648ac9ebb2cc5
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>
12 days agoRemove websocket config from post-install script 39/104139/3
guillaume.lambert [Wed, 25 Jan 2023 10:27:49 +0000 (11:27 +0100)]
Remove websocket config from post-install script

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ib8fe1b5c8bd6d990f14310782405fc79e691d84d

12 days agoUnenforce Lighty use in CI 37/104137/2
guillaume.lambert [Tue, 24 Jan 2023 13:40:24 +0000 (14:40 +0100)]
Unenforce Lighty use in CI

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ibdd0447cc985dc177090b2d563b47935939bb68a

12 days agoWorkaround to install tapi feature in func tests 38/104138/3
guillaume.lambert [Wed, 25 Jan 2023 10:17:31 +0000 (11:17 +0100)]
Workaround to install tapi feature in func tests

JIRA: TRNSPRTPCE-701
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I148587b258066e90930012cba2ca7387af75e8f2

2 weeks agoMerge "Refactor few LOG messages management"
Guillaume Lambert [Thu, 19 Jan 2023 08:10:24 +0000 (08:10 +0000)]
Merge "Refactor few LOG messages management"

2 weeks agoRefactor few LOG messages management 42/103942/3
orenais [Fri, 6 Jan 2023 15:12:32 +0000 (16:12 +0100)]
Refactor few LOG messages management

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I192894a27950ea3e70b5d05e91c61a7c958dd996

2 weeks agoBump upstream dependencies to Cl-SR2 08/103908/5
Gilles Thouenon [Tue, 3 Jan 2023 15:22:18 +0000 (16:22 +0100)]
Bump upstream dependencies to Cl-SR2

Adopt:
- odlparent-11.0.4
- yangtools-9.0.6
- mdsal-10.0.6
- netconf-4.0.5
- lighty-17.1.0
- transportpce-models-17.2.0

JIRA: TRNSPRTPCE-718
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I2119352eb772adea9a2f3c50939f7083d0c31762

2 weeks agoMerge "Complement sims configuration files"
Gilles Thouenon [Wed, 18 Jan 2023 07:03:38 +0000 (07:03 +0000)]
Merge "Complement sims configuration files"

3 weeks agoCheck input node parameter of getPM RPC 90/103990/3
Gilles Thouenon [Wed, 11 Jan 2023 14:27:55 +0000 (15:27 +0100)]
Check input node parameter of getPM RPC

- do not invoke this RPC on a node which is not mounted to avoid a NPE
- make the RPC result being failed

JIRA: TRNSPRTPCE-716
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I1b196c576c1298875c74dd90a47ca10921b32566

3 weeks agoRewrite JUnit tests of OlmPowerServiceImplTest 89/103989/3
Gilles Thouenon [Wed, 11 Jan 2023 09:56:34 +0000 (10:56 +0100)]
Rewrite JUnit tests of OlmPowerServiceImplTest

- rewrite all the test class using mocks instead of instantiating
dependent objects
- remove all tests related to spanloss calculation mehtods since these
tests already exist in the dedicated OlmPowerServiceImplSpanLossBaseTest
class
- remove needless methods in OlmPowerServiceTpcImplUtil class

JIRA: TRNSPRTPCE-717
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ice175c9cf588ae762db0726246ad82d6331b00c0

3 weeks agoFail power setup if node is not connected 09/103709/3
Jonas Mårtensson [Mon, 19 Dec 2022 21:54:47 +0000 (21:54 +0000)]
Fail power setup if node is not connected

Currently, if getting info from a node fails, power setup just
continues with the next node. This is wrong since power levels
have to be adjusted for each node in the path sequentially.

Instead, return false from setPower if getting node info fails.
Also adapt UT.

JIRA: TRNSPRTPCE-715
Change-Id: I44fdfbe871b320b2d9e2bc174c769d6a521fb50c
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
3 weeks agoRewrite JUnit tests of PowerMgmt implementation 88/103988/3
Gilles Thouenon [Tue, 10 Jan 2023 09:27:25 +0000 (10:27 +0100)]
Rewrite JUnit tests of PowerMgmt implementation

- Rewrite all the PowerMgmtTest class using mocks instead of
instantiating dependent objects
- adapt OlmPowerServiceRpcImplUtils consequently

JIRA: TRNSPRTPCE-717
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I486988fc4f0abe2b937288570c81a5c24ce3847c

3 weeks agoRemove getNode method from OlmUtils 87/103987/3
Gilles Thouenon [Fri, 6 Jan 2023 16:02:12 +0000 (17:02 +0100)]
Remove getNode method from OlmUtils

- remove from OlmUtils getNode method which is redundant with
portmapping. Use that latter instead.
- adapt Junit tests
- disable PowerMgmtTest and OlmPowerServiceImplTest which need to be
  redone

JIRA: TRNSPRTPCE-717
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I97177cd86e0117190d9b4eb26d452d37c086bdc1

4 weeks agoComplement sims configuration files 28/103928/2
Gilles Thouenon [Thu, 5 Jan 2023 09:40:31 +0000 (10:40 +0100)]
Complement sims configuration files

Add current-pm-description (pm-handling yang model) configuration for
ROADM-B and ROADM-C to be able to detect pm threshold crossing events.

JIRA: TRNSPRTPCE-713
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ib205dc902b20a67080bfcc2b1ced7acfadf5c5d8

4 weeks agoUse Maven 3.8.7 in CI CentOS install script 37/103937/2
Gilles Thouenon [Thu, 5 Jan 2023 16:36:51 +0000 (17:36 +0100)]
Use Maven 3.8.7 in CI CentOS install script

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ia36aa7c0e48df39f7acac4fa8ef2e85a514b301d

6 weeks agoFix maven files to inherit version from artifacts 14/103714/1
Gilles Thouenon [Tue, 20 Dec 2022 11:09:02 +0000 (12:09 +0100)]
Fix maven files to inherit version from artifacts

- use transportpce-models-artifacts in a dependencyManagement section
instead of fixing versions for each dependency from transportpce-models
- fix project version in transportpce-artifacts module and
features-transportpce

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I30ca89278c828627a9194905d2972b515bb68e54

6 weeks agoBump transportpce-models version 13/103713/1
Gilles Thouenon [Mon, 19 Dec 2022 20:03:24 +0000 (21:03 +0100)]
Bump transportpce-models version

Adopt transportpce-models-17.1.0

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Iafe4d361c89e39ae3053820762844485da2da235

7 weeks agoAdd missing dependencies for features 07/103707/1
Sangwook Ha [Sun, 18 Dec 2022 06:17:49 +0000 (22:17 -0800)]
Add missing dependencies for features

Features with configuration files do not have the dependencies specified
in the POM file causing failure unless the dependencies are already
installed.

Add the missing dependencies to the features to make them work on their
own.

Change-Id: Ia18adc4cb84b0c9a9d8d64a12baf0c00e2716027
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>
7 weeks agoDeclare features in artifacts 06/103706/1
Gilles Thouenon [Sat, 17 Dec 2022 07:21:38 +0000 (08:21 +0100)]
Declare features in artifacts

Add features-transportpce in transportpce-artifacts

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I5f3524c04ace1dcab4472f67836a62f185fddccc

7 weeks agoClean few maven files 05/103705/1
Gilles Thouenon [Fri, 9 Dec 2022 14:59:19 +0000 (15:59 +0100)]
Clean few maven files

- adopt odlparent-lite for pom aggregator
- add missing yang-binding dependency in test-common

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I9c5c31c1760dd777825c63ffc1a68363269c072b

7 weeks agoAdd features-transportpce 04/103704/1
Gilles Thouenon [Fri, 9 Dec 2022 14:41:23 +0000 (15:41 +0100)]
Add features-transportpce

JIRA: TRNSPRTPCE-712
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ie7bc3b9ae27bee02e06764fcf7b6c00c041012ab

7 weeks agoAdd artifacts artifact to transportpce 03/103703/1
Gilles Thouenon [Fri, 9 Dec 2022 14:35:33 +0000 (15:35 +0100)]
Add artifacts artifact to transportpce

To list the project production artifacts.

JIRA: TRNSPRTPCE-711
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I978f22f3248ce9f39cd59aeb10ba311459c55f89

7 weeks agoFix feature issues 02/103702/1
Gilles Thouenon [Wed, 7 Dec 2022 17:49:35 +0000 (18:49 +0100)]
Fix feature issues

Activating SingleFeatureTest for odl-transportpce-tapi feature reveals
an issue to install the feature.

- declare in tpce features the upstream feature dependencies
- use transportpce-models-artifacts
- activate features tests
- fix issue in transportpce-olm blueprint.xml
- fix olm issue in lighty
- move config files from features to bundles to have them installed
before testing the feature

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I9a5e6d862ea29acc5e2b78a38c0c307b4d207770

7 weeks agoHandle missing LLDP nbr-list 12/103512/6
Jonas Mårtensson [Tue, 6 Sep 2022 07:04:59 +0000 (07:04 +0000)]
Handle missing LLDP nbr-list

In ROADM-to-ROADM link discovery, if LLDP subtree is present but
nbr-list is empty/missing, the code crashes from NullPointerException.

Check and return early if nbr-list is null.

JIRA: TRNSPRTPCE-709
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
Change-Id: I6dcb54e24445ac4c0fd0ff27e7335eb596307418

7 weeks agoMerge "Handle missing spanloss in PCE without crashing"
Guillaume Lambert [Thu, 15 Dec 2022 09:28:01 +0000 (09:28 +0000)]
Merge "Handle missing spanloss in PCE without crashing"

7 weeks agoRefactor NbiNotificationsUtils 51/103651/3
Gilles Thouenon [Fri, 9 Dec 2022 18:22:44 +0000 (19:22 +0100)]
Refactor NbiNotificationsUtils

- Adapt tapi_nbinotifications functional test consequently
- speed-up the tapi_nbinotifications functional test

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I63973269666268f28d1a47b6714c52a179798af4

8 weeks agoRefactor functional tests lighty support 55/103655/1
guillaume.lambert [Sat, 10 Dec 2022 13:34:21 +0000 (14:34 +0100)]
Refactor functional tests lighty support

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I0fdea693c3c80ca396c053c8fcbea80cf35ca0eb

2 months agoFix netconf version 65/103265/1
Robert Varga [Tue, 6 Dec 2022 17:20:43 +0000 (18:20 +0100)]
Fix netconf version

Chlorine SR1 uses netconf-4.0.4, fix that up.

Change-Id: I3c66ffc37d918ca24ed8fe0dd2e62880ee4de52b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoT-API notification JUnit test 32/100432/24
Javier Errea [Wed, 6 Apr 2022 13:32:30 +0000 (15:32 +0200)]
T-API notification JUnit test

JIRA: TRNSPRTPCE-649
Signed-off-by: errea <errea@eurecom.fr>
Change-Id: Icc1bd2a4815e3d6df6ab8c22bcba2466d3b1ee49

2 months agoBump upstream dependencies to Cl-SR1 63/103263/1
Robert Varga [Sun, 4 Dec 2022 22:02:08 +0000 (23:02 +0100)]
Bump upstream dependencies to Cl-SR1

Adopt:
- odlparent-11.0.3
- yangtools-9.0.5
- mdsal-10.0.5
- netconf-4.0.4

Change-Id: I5d8d8b23ec060233a252bc710fe5209662bec908
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2a1ef83f696ed4b0ff57da8fa59324c58262e8bf)

2 months agoHandle missing spanloss in PCE without crashing 15/103515/1
Jonas Mårtensson [Wed, 2 Nov 2022 10:05:07 +0000 (10:05 +0000)]
Handle missing spanloss in PCE without crashing

If spanloss is missing from OMS attributes in any span in the topology,
the PCE code crashes due to NullPointerException.

- Check for null before accessing spanloss when calculating OSNR

- Set the link to not valid when analyzing the network for path
  computation.

JIRA: TRNSPRTPCE-710

Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
Change-Id: I746cdefc0dd79e914ea235e5ad7801b2c73fc121

2 months agoMerge "Bump upstream dependencies to Cl-SR1"
Guillaume Lambert [Wed, 30 Nov 2022 15:17:31 +0000 (15:17 +0000)]
Merge "Bump upstream dependencies to Cl-SR1"

2 months agoMerge changes If443a46f,Ic236967c,Ia4ba687f
Christophe BETOULE [Wed, 30 Nov 2022 10:24:10 +0000 (10:24 +0000)]
Merge changes If443a46f,Ic236967c,Ia4ba687f

* changes:
  Activate lighty runtime for functional tests
  Adapt functional tests library to lighty build
  Upgrade lighty to Chlorine

2 months agoBump upstream dependencies to Cl-SR1 74/103174/5
Gilles Thouenon [Tue, 8 Nov 2022 16:51:20 +0000 (17:51 +0100)]
Bump upstream dependencies to Cl-SR1

Adopt:
- odlparent-11.0.2
- yangtools-9.0.2
- mdsal-10.0.3
- netconf-4.0.3
- transportpce-models-17.1.0-SNAPSHOT

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I8145e163b7afa3e0de5ff2573dc1b5eedfd7aa1f

2 months agoActivate lighty runtime for functional tests 58/103358/4
Gilles Thouenon [Thu, 24 Nov 2022 16:17:33 +0000 (17:17 +0100)]
Activate lighty runtime for functional tests

- activate lighty in all tpce functional tests
- use the lighty url
- adapt the lighty build script

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: If443a46fd2d7ea71b51dad398df72080189ac62e

2 months agoAdapt functional tests library to lighty build 57/103357/3
Gilles Thouenon [Thu, 24 Nov 2022 16:04:02 +0000 (17:04 +0100)]
Adapt functional tests library to lighty build

Lighty build in Chlorine requires new restconf url which are not totally
aligned with rfc8040 url used by ODL. Need to adapt the functional
library with this new url.

JIRA: TRNSPRTPCE-705
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ic236967c672e81098645752da056e1d7fe10a371

2 months agoUpgrade lighty to Chlorine 56/103356/2
Gilles Thouenon [Thu, 24 Nov 2022 15:57:40 +0000 (16:57 +0100)]
Upgrade lighty to Chlorine

- adopt lighty-app-parent-17.0.0
- add transportpce/models as upstream dependency in pom.xml
- adapt lighty code and unitary tests

JIRA: TRNSPRTPCE-705
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: Ia4ba687f80e99d9b4f73645efe79525f167abadb

2 months agoRefactor Renderer OpenRoadmInterfaces step 2 16/102616/5
guillaume.lambert [Wed, 12 Oct 2022 12:02:03 +0000 (14:02 +0200)]
Refactor Renderer OpenRoadmInterfaces step 2

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I32a7f978d9ca37e65c44fda24cd89d497047e3a0

2 months agoUpdate pre-commit and tox configuration 39/103239/1
guillaume.lambert [Wed, 16 Nov 2022 13:03:15 +0000 (14:03 +0100)]
Update pre-commit and tox configuration

- update pre-commit repo revision
- use new gitlint-ci pre-commit profile
  https://github.com/jorisroovers/gitlint/pull/192
- update pre-commit configuration accordingly
  especially remove gitlint profile from envlist
  since it is now supersed by gitlint-ci pre-commit profile

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I0984526059a4f869099c32f22909618fd294c549

3 months agoUpdate Java version check in installMavenCentOS.sh 74/102874/2
nathan.ellsworth [Wed, 26 Oct 2022 06:05:15 +0000 (01:05 -0500)]
Update Java version check in installMavenCentOS.sh

Java version strings are of the form XX.YY.ZZ
For Java 8 and earlier, XX was always 1 and YY was major version number.
For Java 9 and later, XX is the major version number

OpenDaylight versions that supported Java 8 are now all EOL
and there is no more reason to check YY content.
- update installMavenCentOS.sh to retrieve only the XX parameter
- update shebang to /bin/sh since we are in the area

JIRA: TRNSPRTPCE-700
Change-Id: Id0cff27763d48be773286f1c1a8312bb50e52523
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
3 months agoChange log level in FrequenciesServiceImpl 49/102649/1
Gilles Thouenon [Wed, 12 Oct 2022 14:14:05 +0000 (16:14 +0200)]
Change log level in FrequenciesServiceImpl

Replace error level by warn level.

JIRA: TRNSPRTPCE-696
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ibb62908048d7d927ce7ecb4ea3fcf6aa3186f8a2

3 months agoMerge "Update link status of service-path-list"
Guillaume Lambert [Mon, 10 Oct 2022 09:47:01 +0000 (09:47 +0000)]
Merge "Update link status of service-path-list"

3 months agoMerge "Update user and developer guides for chlorine"
Guillaume Lambert [Mon, 10 Oct 2022 09:27:18 +0000 (09:27 +0000)]
Merge "Update user and developer guides for chlorine"

3 months agoUpdate user and developer guides for chlorine 82/102582/3
Gilles Thouenon [Fri, 7 Oct 2022 12:05:35 +0000 (14:05 +0200)]
Update user and developer guides for chlorine

- update all API url to be RFC8040 compliant
- mention swagger and tapi feature installation issues

JIRA: TRNSPRTPCE-689
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Idb79265523f735d184046b11646b29621d26f392

3 months agoUpdate link status of service-path-list 75/102575/5
Gilles Thouenon [Wed, 5 Oct 2022 18:03:53 +0000 (20:03 +0200)]
Update link status of service-path-list

- Update status of link resources terminated on a tp when its status
changes.
- Test it in hybrid functional test

JIRA: TRNSPRTPCE-695
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I8ab606abd3053924fe9d411c97eef0337827dc83

4 months agoIncrease project version to 7.0.0-SNAPSHOT 83/102583/1
Gilles Thouenon [Fri, 7 Oct 2022 12:42:51 +0000 (14:42 +0200)]
Increase project version to 7.0.0-SNAPSHOT

To start Argon developments.

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Id886d21f090bda44a319bc721823882fc60bfc74

4 months agoMerge changes I636d36dd,I9d376663,I9354fdd3,Ibc97626f,I8431955f, ...
Gilles Thouenon [Wed, 5 Oct 2022 07:31:02 +0000 (07:31 +0000)]
Merge changes I636d36dd,I9d376663,I9354fdd3,Ibc97626f,I8431955f, ...

* changes:
  Remove OpenROADM and TAPI models from project
  Remove openroadm and tapi models building
  Reintroduce karaf restart in tapi functional tests
  Fix bad imports
  Update transportpce-common-types model
  Remove useless yang model from test-common

4 months agoRemove OpenROADM and TAPI models from project 13/102513/1
Gilles Thouenon [Fri, 30 Sep 2022 12:03:20 +0000 (14:03 +0200)]
Remove OpenROADM and TAPI models from project

These models are now managed in transportpce/models project.

JIRA: TRNSPRTPCE-694
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I636d36dd0dce9a6db33bfe2f47907dae0cb4305c

4 months agoRemove openroadm and tapi models building 98/102498/4
Gilles Thouenon [Mon, 26 Sep 2022 16:00:46 +0000 (18:00 +0200)]
Remove openroadm and tapi models building

Remove openroadm and tapi models building from TransportPCE project to
use them as an upstream dependency.
- adapt maven pom files
- remove from api transportpce yang model bad revision in imports that
  avoid having the latest ones
- fix few imports errors for SupportedIfCapability, OpucnTribSlotDef

JIRA: TRNSPRTPCE-694
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I9d376663d9c35d2c5a7400943384ae48f4b62d71

4 months agoReintroduce karaf restart in tapi functional tests 12/102512/2
Gilles Thouenon [Fri, 30 Sep 2022 07:37:07 +0000 (09:37 +0200)]
Reintroduce karaf restart in tapi functional tests

The tapi models import from upstream dependency reactivates a previous
karaf issue we had when installing odl-transportpce-tapi feature. Some
bundles can't restart. We need to logout karaf and log in again to be
sure to have all bundles restarted properly.

JIRA: TRNSPRTPCE-694
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I9354fdd3fde8780cfbc8288e4955185f547736cf

4 months agoFix bad imports 04/102504/2
Gilles Thouenon [Thu, 29 Sep 2022 07:34:48 +0000 (09:34 +0200)]
Fix bad imports

For few openroadm objects as ServiceFormat and NodeIdType

JIRA: TRNSPRTPCE-694
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ibc97626fe2ac26425abf8e6f739346a08fe9ea9a

4 months agoMerge "Add allure-pytest tox profiles for local use"
Gilles Thouenon [Thu, 29 Sep 2022 09:24:02 +0000 (09:24 +0000)]
Merge "Add allure-pytest tox profiles for local use"

4 months agoUpdate transportpce-common-types model 97/102497/2
Gilles Thouenon [Mon, 26 Sep 2022 15:49:31 +0000 (17:49 +0200)]
Update transportpce-common-types model

- add in this model the pm-granylarity from org-openroadm-pm-types model
to avoid its import and solve a linkage issue during the building step
when we remove openroadm models outside the project.
- update revision imports

JIRA: TRNSPRTPCE-694
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I8431955fc2bcaa75ce34b6042d5067a4b2fa6fe0

4 months agoRemove useless yang model from test-common 96/102496/2
Gilles Thouenon [Mon, 26 Sep 2022 16:02:48 +0000 (18:02 +0200)]
Remove useless yang model from test-common

This model has not been used for a while. No interest to keep it.

JIRA: TRNSPRTPCE-694
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I9eee371112176e2ca7893546e72e084c9781941a

4 months agoBump MRI upstreams 67/102467/1
Robert Varga [Fri, 23 Sep 2022 15:25:20 +0000 (17:25 +0200)]
Bump MRI upstreams

Adopt the following versions:
- mdsal-10.0.2
- controller-6.0.2
- aaa-0.16.3
- netconf-4.0.2
- bgpcep-0.18.2

Change-Id: I7a6ac54d33733eade6007925c56adf88c395e16a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoRe-open:Drop service-name from ODU connection name 98/102098/9
Balagangadhar Bathula [Tue, 16 Aug 2022 19:30:59 +0000 (15:30 -0400)]
Re-open:Drop service-name from ODU connection name

- Fix the bug w.r.t droping service-name from ODU connection
- Service-name is still concatenated to the lower order OTN network
  interfaces and client interfaces.
- Drop the service-name only from the ODU connection, so it will
  not be too long.
- Refer to the patch
  https://git.opendaylight.org/gerrit/c/transportpce/+/100830
  Commit hash: 397a481aa0674d4afea0bef72eb57276027bc343

JIRA: TRNSPRTPCE-628
Change-Id: Ic1df4fb69dd10977fb18ecb3574224589caec622
Signed-off-by: Balagangadhar Bathula <bb4341@att.com>
4 months agoFix PCE PathComputationServiceImpl useless NS 19/102419/1
guillaume.lambert [Wed, 21 Sep 2022 18:26:22 +0000 (20:26 +0200)]
Fix PCE PathComputationServiceImpl useless NS

JIRA: TRNSPRTPCE-683
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ib9ee162a0e96ea9d9d90f93eae5273a78c691781

4 months agoAdd unit tests PCE RPC path-computation-reroute 31/102031/7
Thierry Jiao [Wed, 10 Aug 2022 09:42:53 +0000 (11:42 +0200)]
Add unit tests PCE RPC path-computation-reroute

JIRA: TRNSPRTPCE-682
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I5a7e093f4eb69cedbf4b0dc2e3ab648f270915b5

4 months agoAdd unit & func tests for RPC service-reroute 30/102030/7
Thierry Jiao [Wed, 10 Aug 2022 08:14:28 +0000 (10:14 +0200)]
Add unit & func tests for RPC service-reroute

JIRA: TRNSPRTPCE-683
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I4ddb7391fdc4d75e3530e4cc884e60d071d736c0

4 months agoImplement service-reroute RPC 23/102023/7
Thierry Jiao [Tue, 9 Aug 2022 14:57:43 +0000 (16:57 +0200)]
Implement service-reroute RPC

The service-reroute RPC allows to check whether any route is possible
for an existing service.

JIRA: TRNSPRTPCE-683
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I3572b8c76c4600e463806da919f43e8bdbda1d4a

4 months agoImplement PCE RPC path-computation-reroute-request 22/102022/5
Thierry Jiao [Tue, 9 Aug 2022 08:56:53 +0000 (10:56 +0200)]
Implement PCE RPC path-computation-reroute-request

Before rerouting services, serviceListener will now call the RPC
path-computation-reroute-request to check that any other route exists.
If that's the case, the rerouting process will start.
Otherwise, the rerouting process is cancelled.

JIRA: TRNSPRTPCE-682
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I91c7a40ffdced804b059f523790f78245b81fe23

4 months agoUpdate transportpce-pce YANG 21/102021/3
Thierry Jiao [Mon, 8 Aug 2022 07:58:24 +0000 (09:58 +0200)]
Update transportpce-pce YANG

Add a new RPC named 'path-computation-reroute-request' which computes
paths by ignoring the reserved status of defined termination points
during the pruning process.

JIRA: TRNSPRTPCE-682
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I385913baaa762f6f77157418656ef525aaf8b3e2

4 months agoAdd allure-pytest tox profiles for local use 60/102260/7
Tianliang Zhang [Thu, 15 Sep 2022 14:24:41 +0000 (16:24 +0200)]
Add allure-pytest tox profiles for local use

When the allure-report folder is present, the default launcher for tests
currently based on pytest now uses allure report related options.

"allure serve tests/allure-report/" can be rund afterwards to view the
report in browser.

These capacities have been scripted in tox and are now used by default
to ensure CI.

JIRA: TRNSPRTPCE-685
Change-Id: Ic27b3efa1a77c1f2c55338861b8a6f60f9c47e02
Co-authored-by: guillaume.lambert <guillaume.lambert@orange.com>
Signed-off-by: Tianliang Zhang <zhangtleon@gmail.com>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
4 months agoFix unchecked build warnings 58/102358/1
guillaume.lambert [Tue, 13 Sep 2022 11:44:38 +0000 (13:44 +0200)]
Fix unchecked build warnings

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I563ca68da5a916858cd0d40692edc3615e0753b6

4 months agoFix raw types build warnings 55/102355/2
guillaume.lambert [Tue, 13 Sep 2022 07:28:43 +0000 (09:28 +0200)]
Fix raw types build warnings

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I090a9063f24fc826944de3f31f2c99dbbc0a4c1e

4 months agoClean poms after Chlorine bump 54/102354/1
guillaume.lambert [Mon, 12 Sep 2022 19:09:50 +0000 (21:09 +0200)]
Clean poms after Chlorine bump

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1f587d7ff98f7f241bda9374eba96e97ba1d62bc

4 months agoRefactor Renderer OpenRoadmInterfaces step 1 25/102325/4
guillaume.lambert [Fri, 9 Sep 2022 13:40:27 +0000 (15:40 +0200)]
Refactor Renderer OpenRoadmInterfaces step 1

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I01e4ed15dcf355e88b5c14f420b93e8381e70848

4 months agoRefactor code after Chlorine Bump 24/102324/2
guillaume.lambert [Fri, 9 Sep 2022 12:21:55 +0000 (14:21 +0200)]
Refactor code after Chlorine Bump

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3d1f875d8c5f5afe883b9556f1aaaac5a18fef36

4 months agoImprove feature install in functional tests 10/102310/2
guillaume.lambert [Thu, 8 Sep 2022 06:50:50 +0000 (08:50 +0200)]
Improve feature install in functional tests

There is no more need to restart the controller to take the feature
installation into account.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I9c7a39b3c41d6e1066817236e8832937820a2975

5 months agoAdapt functional tests to Chlorine 65/102265/7
guillaume.lambert [Fri, 2 Sep 2022 19:32:59 +0000 (21:32 +0200)]
Adapt functional tests to Chlorine

- fix maven installer script comments about JAVA version
- update OLM tests
- comment out code in failure in TAPI device_change_notifications tests

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I829529b1dcb649ed61e6371860c56465d2a5af16

5 months agoAdapt TransportPCE code to Chlorine 76/101976/8
Gilles Thouenon [Fri, 5 Aug 2022 16:56:35 +0000 (18:56 +0200)]
Adapt TransportPCE code to Chlorine

- remove some no longer existing Optional
- adapt code to new format of SuypportedIfCapability
- replace switch case structure based on string coming from typedef to
  if- else strcuture due to the removal of getSimpleName() method
- all class types are now .VALUE
- adapt unitary tests consequently

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I4278e7b7787564542f12575ceb2f5d6fab15446c

5 months agoAdapt some dependencies to Chlorine 75/101975/6
Gilles Thouenon [Fri, 5 Aug 2022 07:10:23 +0000 (09:10 +0200)]
Adapt some dependencies to Chlorine

- remove outdated dependencies (javax.ws.rs-api,
  odl-restconf-nb-bierman02)
- migrate some dependencies (ietf-netconf per rfc6241,
  ietf-netconf-notifications per rfc6470)

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I47015e32bc5cc7d12f1a19b05502f702869e4458

5 months agoBump upstream dependencies to chlorine 74/101974/5
Gilles Thouenon [Wed, 3 Aug 2022 12:19:40 +0000 (14:19 +0200)]
Bump upstream dependencies to chlorine

Adopt:
- odlparent-11.0.1
- yangtools-9.0.1
- mdsal-10.0.1
- netconf-4.0.1

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Id0510560a88af903c20f404b51d2b4dfe4ed5c09

5 months agoBump CI tox build to jdk17 63/102263/3
guillaume.lambert [Fri, 2 Sep 2022 12:58:58 +0000 (14:58 +0200)]
Bump CI tox build to jdk17

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Idb5c2594ee043dfdbc3c25e63fff65f5a1ac0f6f

5 months agoSwitch functional tests to RFC8040 49/97549/24
guillaume.lambert [Thu, 25 Aug 2022 19:12:49 +0000 (21:12 +0200)]
Switch functional tests to RFC8040

JIRA: TRNSPRTPCE-567
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I55a2abdd4480df9eb19fded9466b13902eb338a3

5 months agoFix 7.1 functional tests RFC8040 uncompatibilities 62/102262/1
guillaume.lambert [Fri, 2 Sep 2022 10:10:58 +0000 (12:10 +0200)]
Fix 7.1 functional tests RFC8040 uncompatibilities

JIRA: TRNSPRTPCE-567
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ida705dc6df9cd91f8dc849b14c2fce89326698e4

5 months agoMigrate TAPI functional tests to RFC8040 22/102222/8
Gilles Thouenon [Thu, 25 Aug 2022 09:15:03 +0000 (11:15 +0200)]
Migrate TAPI functional tests to RFC8040

JIRA: TRNSPRTPCE-567
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I168b6ce08c11433f82067bbe613f73797a185591

5 months agoMigrate with_docker funct tests to RFC8040 23/102223/7
Gilles Thouenon [Thu, 25 Aug 2022 08:00:14 +0000 (10:00 +0200)]
Migrate with_docker funct tests to RFC8040

JIRA: TRNSPRTPCE-567
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ib6de34a3d3fd688e2c2370c7b357f4e6c33677e2

5 months agoMerge changes I7dcf500e,Iad756c3f,I8e898d86
Guillaume Lambert [Thu, 1 Sep 2022 16:04:26 +0000 (16:04 +0000)]
Merge changes I7dcf500e,Iad756c3f,I8e898d86

* changes:
  Refactor common CatalogUtils step 2
  Refactor common CatalogUtils step 1
  Primitives to retrieve parameters from Catalog

5 months agoShift tox nbinotifications to with_docker profile 40/102240/3
guillaume.lambert [Sun, 28 Aug 2022 19:22:08 +0000 (21:22 +0200)]
Shift tox nbinotifications to with_docker profile

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ice39221bcacc3e90d450c115812c2cdba34c994b

5 months agoFix checkbashisms auto install in tox for CentOS8 58/102258/4
guillaume.lambert [Thu, 1 Sep 2022 14:08:57 +0000 (16:08 +0200)]
Fix checkbashisms auto install in tox for CentOS8

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I56c154f79d177bf419024874530ab504cca113af

5 months agoBump upstream dependencies to S-SR2 57/102257/1
Gilles Thouenon [Mon, 29 Aug 2022 09:53:42 +0000 (11:53 +0200)]
Bump upstream dependencies to S-SR2

Adopt:
- odlparent-10.0.3
- yangtools-8.0.7
- mdsal-9.0.5
- netconf-3.0.6

JIRA: TRNSPRTPCE-684
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I6d2197469a829e9e1be87d4c79c667a55d4b12db

5 months agoRelease Python version fixed for PCE func tests 69/102269/2
guillaume.lambert [Wed, 31 Aug 2022 08:24:52 +0000 (10:24 +0200)]
Release Python version fixed for PCE func tests

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iea3ee2e16edb2f0001da66a6432bc03d751fcb35

5 months agoFix new pylint issues in functional tests 56/102256/1
Gilles Thouenon [Wed, 31 Aug 2022 09:41:35 +0000 (11:41 +0200)]
Fix new pylint issues in functional tests

- add timeout in requests.request methods
- remove useless disable pylint warning

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I2acd0f10b458fe8f7ee1be65644880fd0b41d943

5 months agoMigrate hybrid functional tests to RFC8040 21/102221/10
Gilles Thouenon [Thu, 25 Aug 2022 09:14:42 +0000 (11:14 +0200)]
Migrate hybrid functional tests to RFC8040

JIRA: TRNSPRTPCE-567
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I46c77fffe33e31813ba908811c0fd484e5febab3

5 months agoFix few functests assert RFC8040 uncompatibilities 30/102230/6
guillaume.lambert [Sat, 27 Aug 2022 07:53:27 +0000 (09:53 +0200)]
Fix few functests assert RFC8040 uncompatibilities

JIRA: TRNSPRTPCE-567
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8a5055716e32f3a888e226ab192ab24dfca0a09f

5 months agoMigrate PCE functional tests to RFC8040 20/102220/6
Gilles Thouenon [Thu, 25 Aug 2022 09:14:06 +0000 (11:14 +0200)]
Migrate PCE functional tests to RFC8040

- complement test_utils_rfc8040 with adapted methods
- replace xml input files (portmapping, topologies) by json files
  to ease treatments
- refactor test01_pce to optimize few non functional tests

JIRA: TRNSPRTPCE-567
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ic91cc81c9c7bbb4168d45a9402c435b170b486fa

5 months agoRefactor test_utils_rfc8040.py portmapping methods 19/102219/9
Gilles Thouenon [Thu, 25 Aug 2022 09:13:21 +0000 (11:13 +0200)]
Refactor test_utils_rfc8040.py portmapping methods

JIRA: TRNSPRTPCE-567
Co-authored-by: Guillaume Lambert <guillaume.lambert@orange.com>
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Ibe593c9ecc5ea2f863b16ed87629b26f4f5ab93c

5 months agoMigrate end2end functional tests to RFC8040 18/102218/5
Gilles Thouenon [Thu, 25 Aug 2022 09:12:47 +0000 (11:12 +0200)]
Migrate end2end functional tests to RFC8040

- 1.2.1-end2end
- 2.2.1-end2end
- 2.2.1-otn_switch_end2end
- 2.2.1-otn_end2end_with_intermediate_switch

JIRA: TRNSPRTPCE-567
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I1ca04f930bb0bfcc1c6d40220153640bcdf38c5b

5 months agoRefactor common CatalogUtils step 2 72/101972/5
guillaume.lambert [Fri, 5 Aug 2022 14:36:18 +0000 (16:36 +0200)]
Refactor common CatalogUtils step 2

Improve getPceRoadmAmpParameters method implementation
- remove useless intermediate variables
- fix Interchannel spacing correction factor in OSNR calculation
  ADD case formula (forgotten 10 factor).
- introduce a list for OSNR computation polynomial factors  and review
  order of arithmetic operations with a for-loop for more precision
  and efficiency.
  Double is not strictly spoken a Mathematics commutative group because
  computers design limits their bits representation size.
  As a result, the order of arithmetic operation matters.
  In a sum, smallest numbers should be introduced first for a maximum of
  precision. In other words, the sum
      10 * Math.log10(spacing / 50.0)
      + osnrPolynomialFits.get(0)
      + osnrPolynomialFits.get(1) * pwrIn
      + osnrPolynomialFits.get(2) * Math.pow(pwrIn, 2)
      + osnrPolynomialFits.get(3) * Math.pow(pwrIn, 3)
  is not equal to its reverse form
      osnrPolynomialFits.get(3) * Math.pow(pwrIn, 3)
      + osnrPolynomialFits.get(2) * Math.pow(pwrIn, 2)
      + osnrPolynomialFits.get(1) * pwrIn
      + osnrPolynomialFits.get(0)
      + 10 * Math.log10(spacing / 50.0)
  and the more precise first form should be preferred here.
- Adapt comments and Junit tests accordingly

JIRA: TRNSPRTPCE-518
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I7dcf500eb7ff93aacfe594dbe2d6e6125dab2e03

5 months agoRefactor common CatalogUtils step 1 44/101944/4
guillaume.lambert [Tue, 2 Aug 2022 14:08:24 +0000 (16:08 +0200)]
Refactor common CatalogUtils step 1

- optimize most methods implementations
  and first pass of refactoring for getPceRoadmAmpParameters
- rework a few LOG messages content

JIRA: TRNSPRTPCE-518
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iad756c3f2b906af79e9689907153921c4e236df1

5 months agoPrimitives to retrieve parameters from Catalog 18/101918/14
orenais [Fri, 29 Jul 2022 15:31:40 +0000 (17:31 +0200)]
Primitives to retrieve parameters from Catalog

- add a CatalogUtils and a Catalogconstant class in common module
  with primitives to retrieve parameters from Catalog
- add a related Penalty comparator serializable class
- add related Junit with a sample apidocCatalog json file
  that sticks to latest version of OpenROADM optical specification v5.1

JIRA: TRNSPRTPCE-518
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I8e898d86d44ea9a8f3a58eb581c3fe6515534221

6 months agoMerge changes I8b6da9f3,I425a1d19,Ia3dfe19f,Idd68c408,I73f0c083, ...
Gilles Thouenon [Fri, 29 Jul 2022 09:35:49 +0000 (09:35 +0000)]
Merge changes I8b6da9f3,I425a1d19,Ia3dfe19f,Idd68c408,I73f0c083, ...

* changes:
  Migrate OTN E2E functional tests to RFC8040 step 6
  Migrate OTN E2E functional tests to RFC8040 step 5
  Migrate OTN E2E functional tests to RFC8040 step 4
  Migrate OTN E2E functional tests to RFC8040 step 3
  Migrate OTN E2E functional tests to RFC8040 step 2
  Migrate OTN E2E functional tests to RFC8040 step 1

6 months agoMerge "Bump lighty.io build to Sulfur SR1"
Gilles Thouenon [Thu, 28 Jul 2022 14:24:40 +0000 (14:24 +0000)]
Merge "Bump lighty.io build to Sulfur SR1"

6 months agoMerge "Refactor networkmodel OpenRoadmTopology Part 4"
Guillaume Lambert [Wed, 27 Jul 2022 14:16:05 +0000 (14:16 +0000)]
Merge "Refactor networkmodel OpenRoadmTopology Part 4"

6 months agoMerge "Switch tests from nose to pytest"
Guillaume Lambert [Wed, 27 Jul 2022 08:07:35 +0000 (08:07 +0000)]
Merge "Switch tests from nose to pytest"