git.opendaylight Code Review - transportpce.git/log

Improve Honeynode Docker scripts

to allow 1.2.1 and 2.2.1 containers simultaneous use
and make it the default behaviour

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I200ebfe108c358181d9f28a96109758f33da4fb9

Update config files and tests

- correct the ip-Addresses in some config files
- consider different clfi for different fibers
- move the opposite-link, TE-metric and clfi fields to
org-openroadm-common-network instead of
org-openroadm-network-topology:OMS-attributes

JIRA: TRNSPRTPCE-95
Change-Id: I77aa2130b56eb82157e4edce206aea73711ae497
Signed-off-by: atriki <ahmed.triki.tn@gmail.com>

default transponder power level

Set transponder power level to default
when SRG Rx power range does not exist

JIRA: TRNSPRTPCE-89
Change-Id: I5d916e7a70be84e5a52360433fbd8c173091c909

Calculate spanloss crashes when OTS is not present

-OTS interface check is added to avoid the crash
JIRA: TRNSPRTPCE-172

Change-Id: Ic8fa52eaf98069d7fe581d2c9b2a9f75cbf0fadd

Honeynode Docker refactoring for Java11

Upgrade Docker image generation process to use new Java11 simulators.
Both OpenROADM versions 1.2.1 and 2.2.1 simulators are now using a
same docker image and the same scripts.

This brings the following improvements:
- create a multi-stage docker file to isolate build and run processes
- decrease image size
- use an applicative user in Dockerfile rather than root
- add healthcheck
- expose both netconf and restconf ports
- use the docker option --name to set the name of the container
- rootless container and sudo management for docker command
- centralize most scripts parameters in dockercmd_profile.sh

JIRA: TRNSPRTPCE-239
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Co-authored-by: Emmanuelle Delfour <emmanuelle.delfour@orange.com>
Co-authored-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I86b47cac0f795c2ac9d1615efa703d8ca87b34e5

Honeynode build: MacOS compatibility

- set tarLongFileMode to posix for maven assembly plugin configuration

Signed-off-by: manuedelf <emmanuelle.delfour@gmail.com>
Change-Id: I6de1ca4a637fe9736b9c51cf1c92b699a145b7eb

Fix spotbugs issues in network topologies module

JIRA: TRNSPRTPCE-210 ODLPARENT-226
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I7b9928b6ee8ab06db0cc27fdcdfe1aaa4cd2fa80

Merge "Fix spotbugs issues in common module"

Merge "Master branch is now Aluminium"

Fix spotbugs issues in common module

JIRA: TRNSPRTPCE-206
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I818d9f1c9cd81d06468f23d36fad14feebf840f5

Merge "Bump project to 2.0.0 and fix feature deployment"

Merge "Fix spotbugs issues of the renderer module"

Merge "Fix spotbugs issues of the PCE module"

Master branch is now Aluminium

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I6de721957fce018b39fab691ed3577b0f2ad074b

Fix spotbugs issues of the PCE module

Fix issues related to:
- reliance on default encoding
- format and Logger Factory
- unused parameters
- bigDecimal constructor
- comparison operators
- serialization/deserialization issues
- check for null fields
- dead store for local variable
- inner static class

JIRA: TRNSPRTPCE-212
Change-Id: I82838dd72f1e42e434b9062e0166b61d22ff4c6a
Signed-off-by: atriki <ahmed.triki.tn@gmail.com>

Fix spotbugs issues of the renderer module

Fix following categories:
- NP_LOAD_OF_KNOWN_NULL_VALUE
- PZLA_PREFER_ZERO_LENGTH_ARRAYS
- RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE
- SLF4J_ILLEGAL_PASSED_CLASS
- DM_CONVERT_CASE
- NM_CONFUSING
- SLF4J_FORMAT_SHOULD_BE_CONST
- UPM_UNCALLED_PRIVATE_METHOD
- EC_UNRELATED_TYPES
- NP_ALWAYS_NULL
- NP_LOAD_OF_KNOWN_NULL_VALUE

JIRA: TRNSPRTPCE-213
Signed-off-by: manuedelf <emmanuelle.delfour@gmail.com>
Change-Id: I19b1654ad5ac6f4ea3a8c1ef468a2e69016b69cc

Bump project to 2.0.0 and fix feature deployment

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I4c2a8b00dcc0ea0451201998fb54da4b464aaba1

make Honeynode and tox scripts BSD compatible

- use a sed syntax compatible with both BSD and GNU versions
- replace /bin/bash by /bin/sh (regular bourne shell)
make necessary adaptations for compatibility
- upgrade python psutils requirements to 5.6.7
most BSD does not support earlier version with python 3.7

Co-authored-by: Shweta Vachhani <sv111y@att.com>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I6d390cede8abbbd44f92554e7b0f164ae5c0b173

Fix TAPI artifact deployement issue

Fix regression with regard to the installation and deployment of tapi
bundle/feature brought by change 88138

Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I842c1fa839f13a61f662c8ff5a2f87be8567b3d2
(cherry picked from commit 8a1a107601351ab34661b52ae5b6d79f40a965be)

Merge "Migrate rtd docs to python3"

Migrate rtd docs to python3

RTD builds have been failing on python2 since the required version
sphinx is not found in lftools-conf. Migrate to python3 resolves the
issue.

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I48ecbff0a5498f12c0511d6fce2bbd0ed58d1c3f

Rationalize features

- clean features pom.xml configurations
- remove models and api useless features
- separate TAPI support in a specific feature
and migrate tapi blueprint folder
- declare TAPI and inventory in karaf pom.xml
- update user guide

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I87ccca5e295c14e1a3ed2d06bebe312a463a5d9c

Update documentation for Magnesium

- introduction of the OTN layer
- presentation of the new services OTU4, ODU4, 1GE/ODU0 and 10GE/ODU2e
- new rpc for otn-service-path
- description of the otn-topology
- description of the interconnection with the GNPy tool to check path
feasilibty and perform impairment-aware path computation

Change-Id: I5869873f7fc426bee04c07b57d37cfcc5da727f2
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Fix GNPy functional tests issue due to Mg bump

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Ahmed Triki <ahmed.triki.tn@gmail.com>
Change-Id: I418faab4b76899313c9d1ca86db4240704aaabd5

Bump project version to 1.0.0-SNAPSHOT

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iab541b41e97fa488cd63ffc4eebf828299931aad

Fix issues related to Magnesium bump

- use of some Uint32 (instead of Long)
- use of ImmutableList

JIRA: TRNSPRTPCE-198
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Co-authored-by: Emmanuelle Delfour <emmanuelle.delfour@gmail.com>
Change-Id: Iaba3dda0941e957f549da0e9ca7ddbeb485c7dfe

Ignore Junit failing after Magnesium Bump

JIRA: TRNSPRTPCE-198
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1030af29943c26ecb326b33c66d129cf1a413306

skip checkstyle and spotbugs in functional tests

odlparent checkstyle and spotbugs slow down a lot the build process.
They must be skipped in releng profile with maven -D option in tox.ini.

JIRA: TRNSPRTPCE-197
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: If619bcba7658fc11115f7dd013228c22237c6bce

Bump to Magnesium dependencies

https://docs.opendaylight.org/projects/integration-distribution/en/latest/platform-versions.html
- upgrade pom to use ODL Magnesium target dev dependecies

https://wiki.opendaylight.org/view/Magnesium_platform_upgrade
- force jsr305 version
- disable SpotBugs enforcement in artifacts when needed
- UintXX yangtools migration

https://git.opendaylight.org/gerrit/c/mdsal/+/83960
- migrate class BindingStreamEventWriter
      from org.opendaylight.yangtools.yang.binding package
      to   org.opendaylight.mdsal.binding.dom.codec.api

- unforce maven-bundle-plugin version in api/pom.xml
  and ordmodels/device/pom.xml build sections
- unfoce iana-afn-safi version in ordmodels/device/pom.xml dependencies

TODO:
for next changes to come in the release:
- migrate Junit to yangtools UintXX
- propose fixes to reactivate SpotBugs enforcement
  and get rid of "deprecated marked for removal"

JIRA: TRNSPRTPCE-198
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I20dfe87985a1273e3f0864e6a4d26880fc80d197

clean OTN renderer code

JIRA: TRNSPRTPCE-174 TRNSPRTPCE-142
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I2babfd00dd554fc23aa8287146d87a7cc445db1d

Functional test for OTN Renderer

New functional test suite for otn renderer. Tests OCH/OTU4/ho-ODU4
creation/deletion, and 10GE/lo-ODU2E creation/deletion.

JIRA: TRNSPRTPCE-143
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I5680b858ef56ed72da172d8852df3e6db0242111

Fix issues in otn renderer

- add timer in OpenRoadmInterface221 to allow update portmapping with
odu supported interface
- manage lo-odu interfaces deletion (odu-connection and associated lo-interfaces)
- manage ho-odu/otu/och interfaces deletion

JIRA: TRNSPRTPCE-174 TRNSPRTPCE-142
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I899f9ffb2fe0a98b1d8a4184444fd4d3dfc4f4d5

OTN Renderer Consolidation

- ODU4 and OTU4 interface creation for OTN service
- Odu2e and Odu0 interfae creation
- odu-connections
- ODU service delete

JIRA: TRNSPRTPCE-174 TRNSPRTPCE-142
Signed-off-by: shweta <sv111y@att.com>
Change-Id: I1726e4b50c9b6dcceb0ba1d8e804fa3bc8b39dd6

init Renderer code for OTN Services

JIRA: TRNSPRTPCE-174
Signed-off-by: shweta <sv111y@att.com>
Change-Id: I1b95a4402038ce450822e3ba84f85f4b677927b6

improve functional tests

- make scripts with "sed" compatible with BSD and macOS

- remove illegal reflective access warnings introduced by JDK11
  - create a file tests/reflectwarn.sh with the right JDK_JAVA_OPTIONS
    variable content.
    sourcing this file at build or runtime removes the warnings.
    But instead, it generates a long note in stderr that still pollutes
    nosetests results.
- in functional tests, move sims and controller stderr to a file to
  prevent that note from polluting nosetests results.

https://dev.to/erichelgeson/removing-illegal-reflective-access-warnings-in-grails-4-393o

JIRA: TRNSPRTPCE-192 TRNSPRTPCE-197
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I04156ab104d7420d1eb2d180579593c67293175b

Adapt code to support the new version of GNPy

- change the gnpy version from 1.2 to 2.2 in tox.ini
- modify the yang model to add a new field "bidirectional"
- delete unused code lines
- update the gnpy tests to support the new version

Change-Id: If318cc4515372bdad86ba46d3c4929bc0a15da43
Signed-off-by: atriki <ahmed.triki.tn@gmail.com>

HoneyNode OTN support

- add odu connection deletion for OTN

Signed-off-by: Emmanuelle Delfour <emmanuelle.delfour@gmail.com>
Change-Id: I8b28c146360b070812d627fed026a64ed2dc2250

HoneyNode Java 11 support for 121 devices

- honeycomb 1.19.04 upgrade
- rename 2.1 folder into 1.2.1 to reflect the openroadm device version
rather than the openroadm common version
- update resconf honeynode config to allow remote access
- samples config files update
- delete old testtool 1.2.1 sample configs
- added support for openconfig models
- remove JDK8 gate support from tox and associated scripts

NB: script installJDKCentos.sh contains a workaround to have the right
JDK.

JIRA: TRNSPRTPCE-192
Signed-off-by: Emmanuelle Delfour <emmanuelle.delfour@gmail.com>
Change-Id: Ia30ceb05c927937d9b4fc81d42d91b7558cd1dfd

HoneyNode Java 11 support for 221 devices

- honeycomb 1.19.04 upgrade
- update resconf honeynode config to allow remote access
- samples config files update
- added support for openconfig models
- update tox.ini to build 2.2.1 sims with JDK11 in tox releng profile

JIRA: TRNSPRTPCE-192
Signed-off-by: Emmanuelle Delfour <emmanuelle.delfour@gmail.com>
Change-Id: Ie7ffb629c8209bc0c0fa31f482210094647197ca

JDK 11 controller support in tox job

update tox.ini to use JDK8 to build the sims
and JDK11 to build the controller and run the JVMs
inside ODL jenkins releng tox job.

JIRA: TRNSPRTPCE-192 TRNSPRTPCE-197
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ibb355d1181fd8de32b5b112b0145b87f38e2c38b

fix some files format

Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Id67138c19fde78ce76638bbdabbc98a6c13107ca

Fix some SpotBugs issues

JIRA: TRNSPRTPCE-198
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I14e7ef94a94036af7e5fb2725f9116c52dc23476

fix docs wiki URL link

TransportPCE wiki URL has been redirect to confluence
but it is not migrated yet resulting in an error here.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Icecd04e30cf80fc0c5970f8414e321076f6c9cab

reformat API YANG models

using pyang version 2.1.1
with --yang-canonical option

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I7bf772bf79fd6833009bb57037892ebeb80bf2b0

Upgrade to Service Path 1.7

JIRA: TRNSPRTPCE-178 TRNSPRTPCE-196
Signed-off-by: Olivier Renais <olivier.renais@orange.com>
Co-authored-by: Shweta Vachhani <sv111y@att.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Iefadc5477fc23e59e2b8f86c441e0165a329f63e

Adapt PCE code for OTN services

Allows pce code to calculate paths for OTU4, ODU4 structured for LO-ODU,
10GE and 1GE services, provided that the otn-topology contains correct
information for links and otn-nodes/tp.

- add PceNode interface, and use PceOpticalNode and PceOtnNode as two
different implementations of PceNode interface
- review implementations of chooseTribPort, chooseTribSlots methods in
PostAlogPathValidator

JIRA: TRNSPRTPCE-162 TRNSPRTPCE-201
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: Id7105571691e9513dff6ca41cd1287f351f35de9

PCE OTN layer support init

-Add PceOtnNode Class and complete PceLinkClass
-Add Algorithm in PceCalculation and PceGraph to handle path
calculation at the WDM or OTN layer
-Adapt InAlgoPathValidator to work with the OTN layer
-Adapt PostAlgoPathValidator with method to retrieve trib-port/slot in
place of wavelengths
CAUTION: at that time, it does not handle trib-slot and trib-port
pass to Service Handler (still based on old path-computation-request)
-Adapt PCE functional tests
-change topo to include supporting nodes
CAUTION: Expected node in rpc path-computation-request is of OTN type

JIRA: TRNSPRTPCE-162
Signed-off-by: Olivier Renais <olivier.renais@orange.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: If5c29cae48b94660f2536f86b2df814b6515969b

Consolidation of the PCE

- change k from 10 to 100 in the case of nodes inclusion in the hard
constraints and in the case when a first execution of k-shortest-path
failed
- conslidate the osnr calculation
- add the OUT_OF_SPEC_OSNR as a cause of path computation failure
- add the HD_NODE_INCLUDE as a cause of path computation failure
- detect TOO_HIGH_LATENCY in the case where the MaxLatency is exceeded
- Verfication of MaxLatency and node inclusion violation in
postAlgoPathValidator instead of inAlgoPathValidator
- change the name of the method calcPath() of PceCalculation to
retrievePceNetwork()

JIRA: TRNSPRTPCE-146, TRNSPRTPCE-147, TRNSPRTPCE-93
Change-Id: Ie2f8bf502af81de857dadbdc5a879f5c4b10c96b
Signed-off-by: atriki <ahmed.triki.tn@gmail.com>

Merge "Consolidation of the GNPy module"

Consolidation of the GNPy module

- add GnpyException to manage unexpected events
- expand the 32-bit identification field of fibers to range
from 243.0.0.1 to 243.255.255.255
- expand the 32-bit identification field of EDFAs to range
from 244.0.0.1 to 244.255.255.255
(the 32-bit identifiers are not ipv4 addresses but use the same
dotted-decimal notation. This format is imposed by GNPy yang model to
comply with the IETF recommendations and to be compliant with planning
tools coming from the IP world.)

- code refactoring

Signed-off-by: atriki <ahmed.triki.tn@gmail.com>
Change-Id: Ifa41c68874b8d87abe746cd6c1b87ee950131a32

fix tox docs profiles

- fix ODL version in docs/conf.yaml
- fix base-python version in tox.ini to use any python3 version.
  (better compatibility with potential new requirements)
- reactivate docs and docs-linkcheck profiles
  they only work with python 3.6 in releng at that day
  (because of current lfn-tools requirements)

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I7589b3f52c1f6d9f3c996566d59b861192de2c46

Fix issue in end2end functional tests

fix and reactivate test 33

JIRA: TRNSPRTPCE-177
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I77b1d3654870e278232ec725d33fed07f59420ef

Portmapping-topologies code consolidation

Refactor otn-topology code to avoid any access to OpenROADM device
configuration during node creation. To that purpose:
- review code related to all topology layers to use static methods
- add new class OtnNode to help creation of different otn-nodes in
  otn-topology
- change code to create otn node in otn-topology distinguishing tpdr,
  switch, mpdr
- adapt openroadm-topology to make appear network tp of otn switch/mpdr
  nodes
- remove from openroadm-topology tail-equipment-id for xpdr nodes
- adapt pce code consequently
- add tail-equipment-id with ROADM-SRG-PP info on tp of xpdr node when
  creating XPONDER-INPUT/OUTPUT links in openroadm-topology
- adapt functional tests consequently to all these modifications
- deactivate test 33 from end2end functional tests since the deletion of
  the "tail-equipment-id" from the topology is not fully implemented yet

JIRA: TRNSPRTPCE-177
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule.com>
Change-Id: I45bb0f06b0bae87af10164addbdedc3ab79dba36

upgrate network topology YANG to introduce OTN

- add openroadm-common-network/otn-topology augmentation
- update revision
- modify code accordingly to support this new revision

JIRA: TRNSPRTPCE-177
Signedff-by: guillaume.lambert <guillaume.lambert@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule.com>
Change-Id: Ifbeac6dd6a5ccaf348e82e2fa7afbc2f4dd65e6c

upgrade portmapping YANG to introduce OTN

- add otn data to portmapping YANG model
(odu-switching-pool, supported-interface-capability, xponder-type)
- rename associated-lcp in connection-map-lcp to avoid potential
confusions to come
- update revision
- modify code accordingly to support this new revision
- update tests accordingly

JIRA: TRNSPRTPCE-177
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule.com>
Change-Id: Ice6c2cff6bb105cb04abdf04b49976daa976571d

disable tox docs

job in failure for no apparent reason

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I5c24ca22a757b30c8b9474e5cf9f15bfd98dd73d

Bump to odlparent-5.0.5/yangtools-3.0.9/mdsal-4.0.11

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I19773c0a0988c01111940e37b9de055118a47e28

fix powerMock and mockito versions mismatch

this was causing failures in OLM PowerMgmtPowerMockTest Junit
and in OlmPowerServiceImplTest that is not completely fixed yet.

JIRA: TRNSPRTPCE-180
Change-Id: I0937f92c63a3999314dcb36ec0b02a65a46d5ff5
Signed-off-by: Ahmed Abbas <ahmad.helmy@orange.com>

fix javadoc warnings

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ic5a9edce2ed0ee0beb887a8b617ea0ef97b478b5

fix vulnerability identified by Sonar

JIRA: TRNSPRTPCE-193
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ifce9b71e5c9233145188107586428039f38b1c16

Cleanup and optimize POM

JIRA: TRNSPRTPCE-181
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I3229c20ca0df736a9845a4aa782b80bd6ab02317

ignore OLM Junit in failure after upstream changes

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I7f150ca3c9540d5c0c728aff13333aec1cca3b73

Bump dependencies to newer Sodium SR2 dev versions

org.opendaylight.odlparent  *                   5.0.3 -> 5.0.4
org.opendaylight.yangtools  yangtools-artifacts 3.0.6 -> 3.0.7
org.opendaylight.mdsal      binding-parent      4.0.7 -> 4.0.8
org.opendaylight.mdsal      mdsal-artifacts     4.0.7 -> 4.0.8

https://docs.opendaylight.org/projects/integration-distribution/en/stable-sodium/platform-versions.html

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I4e22d0e9310dbdf4107fb57a1a73b6bb83b38cb5

update mvn version in releng tox jobs

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3bcfba300629f7e36871cf50c75e38def82b28ca

fix CrossConnect methods implementation warnings

at build time

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I924ed7db04802bb0affda561f0baaf7fa6bf6874

un-deprecate common device getDeviceMountPoint

This method has been introduced already deprecated because it was
relying on the old md.sal controller API.
Since we use now the new MD-SAL API, there is no reason to keep it
deprecated.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I0fe318138e3d88177be0344ff9714ad2b7eb4af1

remove unchecked cast and conversion warnings

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1c30bbcc20c1560030a8409dd6c64e02870bf12d

fix Junit mockito deprecated warnings

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I71e7cf97afcf8774de2649fd93f5e9c4c4834e7b

Remove unchecked warnings from Junit tests

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1115d54f831001250d94ec5d66232edd21cbda65

fix deprecated openroadm interfaces/objects

Concerns mainly changes on node-type, link-type and tp-type, from
org-openroadm-network-topology to org-openroadm-common-network.

for example getLinkType() in
[].org.openroadm.network.topology.rev181130.Link1 objects
must now be called from
[].org.openroadm.common.network.rev181130.Link1

modify functional tests and sample configurations accordingly

JIRA: TRNSPRTPCE-144
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I04f69ea5507fbc3a76eceb92ec52efcbb5301c4c

Initial code for OTN topology and portmapping

JIRA: TRNSPRTPCE-138
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: Ie576bf4b90a3ca9a94e7a5152edb86b99281c69e

fix mdsal WriteOperations deprecated warnings

Caution:
the warning in Junit renderer TransactionUtils was only annotated since
it cannot be modified without compromising most of the renderer Junit
test suite.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I189ea9c6368936e0eae15bb9c542ad60575d9c2d

Deprecate some write operation functions

In org.opendaylight.mdsal.binding.api.WriteOperations, put and merge
methods with createMissingParents boolean parameter are now deprecated.
Derived functions in transportpce shall repercute this deprecation.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I36fb5907c0e4c6b2e81b78c80d325b4593107fee

remove mdsal StreamWriterGenerator

org.opendaylight.mdsal.binding.dom.codec.gen.impl.StreamWriterGenerator
is now deprecated

Binding context can be given to the BindingNormalizedNodeCodecRegistry
class builder.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: If48c3f8aabe982d59e2675e9d3ba961a5a51f37e

Update functional tests for gnpy

- Mount the clliNetwork, openroadmNetwork and
openroadmTopology
- Test the case where path computed by PCE is not feasible and
Gnpy computes a new one feasible
- Test the case where path computed by PCE is not feasible and
Gnpy cannot find a new one
- Test the case where path computed by PCE is feasible and
Gnpy confirms the feasibility
- Unmount the clliNetwork, openroadmNetwork and
openroadmTopology

JIRA: TRNSPRTPCE-132
Change-Id: If07482af397b419e42f810053e36c894f1668922
Signed-off-by: atriki <ahmed.triki.tn@gmail.com>

Supporting new paths computed by GNPy

- In the case where the path is not feasible, PCE asks gnpy to
compute a new path
- The service handler constraints concerning the nodes inclusion
are also transmitted to gnpy
- The PCE verifies the new path and computes the equivalent
openroadm-topology

JIRA: TRNSPRTPCE-49
Change-Id: Icb05209a6e3261dbb2da605f3787a0b48c0aee0a
Signed-off-by: atriki <ahmed.triki.tn@gmail.com>

Multi-layer TAPI topology creation for OTN

- implementation of TAPI:get-topology-details rpc to abstract nodes from
OpenROADM otn-topology

JIRA: TRNSPRTPCE-161
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I0f196248002390c7ec5567fd912d6fac2dcb1a91

TAPI topology creation for 100GE Transponder

- implementation of TAPI:get-topology-details rpc to abstract nodes from
OpenROADM openroadm-topology
- TAPI implementation based on models v2.1.2
- expose only one tapi-node, with all 100GE client ports of xpdr as
owned-node-edge-point with a single SIP(Service Interface Point) when
their associated line ports are connected to RDM infrastructure
through XPONDER-INPUT and XPONDER-OUTPUT links
- implement REST API for tapi:service-interface-points to associate
tapi service interface point (SIP) to an OpenROADM service-end-point

JIRA: TRNSPRTPCE-145
JIRA: TRNSPRTPCE-168
Change-Id: I9cafd68e7ab47d33d7e990cd349960357bb4352d
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule.com>

Functional tests for OTN topology

JIRA: TRNSPRTPCE-139
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I4c6e67eff9f1cd8c6c8c9d92167261d7c257a47e

Configuration with OTN for switch and muxponder

- oper-SPDRAv1.xml contains basic otn configuration
- oper-SPDRAv2.xml contains addition configuration for otn interfaces

JIRA: TRNSPRTPCE-166
Change-Id: Ifd02d0582f058ca4e9c43f406687f61fdf7bbc0c
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

Upgrade honeynode 2.2.1 emulator for OTN

- complement device and common 2.2.1 yang models to support
configuration with, among other things, otn functionalities.
- adapt XSLT transforms to start emulator with initial configuration
containing interfaces (ethernet, och, otu, odu)
- clean org-openroadm yang files (trailing spaces)

JIRA: TRNSPRTPCE-137
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I137446b6ff3f8f64db0db2c96b99eee82fb978fd

add an Inventory Docker file

based on MariaDB version 10.3

JIRA: TRNSPRTPCE-82
Change-Id: I567c21f2778a388ce3e1fe65ce25834c24dc5a2b
Signed-off-by: malick <malick.sylla@orange.com>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

switch inventory to Mariadb

and comment out devices v2.2.1 support

JIRA: TRNSPRTPCE-81 TRNSPRTPCE-82
Signed-off-by: Narayan Padi <np2698@att.com>
Change-Id: Ifa2150a91ee58b8c77cdfbae6721c78bed5f171e

Inventory init

- creates a new inventory module to store information in an external
MySQL/Mariadb database
- currently supports OpenROADM version 1.2.1 devices
- prepares the support of OpenROADM version 2.2.1 devices
- uses new mdsal Databroker API

JIRA: TRNSPRTPCE-81

Change-Id: I7c2df57d39964bc90dfd475efa4565d51e054822
Signed-off-by: malick <malick.sylla@orange.com>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

fix some checkstyle warnings

that appeared with dependencies bump

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ia48ca0bc6622153c52b76730e6ad50dd20a11b0b

Make the PCE more deterministic

in the choice of SRG node in a RDM, or the choice of the PP port on a
SRG, or the choice of the NETWORK TP on a XPDR.

JIRA: TRNSPRTPCE-169
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I7aa2088282aea2a0bcfb6301c09b4aab1c9cb3c6

upgrade tox jobs to python 3.5

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ifb7a1cf945167d9ad2d498e45f9eb5ea9b70db1a

Bump dependencies to Sodium SR2

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I57cd6b2720db96b30b2f3766a7a7f2c1defbc835

Change node-id in 1.2.1 functional tests

org-openroadm-service imposes a node-id compliant with
org-openroadm-common-node-types@2018-11-30.

All functional tests and device configuration files for
org-openroadm-device 1.2.1 need to be updated
(node-id must be a string of at least 7 characters...)

JIRA: TRNSPRTPCE-159
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ic185e4334b205aeefab599a67ab7b91a45101145

upgrade bundles to openROADM service 5.1.0

adapt code of PCE, renderer and servicehandler
to support the new openROADM service data models

JIRA: TRNSPRTPCE-159
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ie41e64f04c067e4bf8d6d3e34e94d781e4e895a8

upgrade models to OpenROADM service 5.1.0

- upgrade openROADM service models from 1.2 to 5.1.0
- add related openROADM common models
- adapt transportPCE service path models consequently
- fix revisions in java code

JIRA: TRNSPRTPCE-159
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I035175e5653a1e5ea0fd75c8a1086755e31bc05c

remove tpce service-path 1.5 models

JIRA: TRNSPRTPCE-160
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I9b9ff7709a26597636a40d3dd6a8563244816e69

remove Junit tests using service-path 1.5 models

JIRA: TRNSPRTPCE-160
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8aacee9742bdfcc2bbacef281094cc789570c62d

clean gnpy tox profile and OpenRoadmTopology22

fix gnpy tox profile:
- olm/src/main/java/org/opendaylight/transportpce/olm/util/OlmUtils.java
does not need to be patched when only the gnpy profile is called.
- the gnpy container must be killed after tests to avoid potential
problems with others tests to run.

clean networkmodel/[..]/util/OpenRoadmTopology22.java from superflous
call to builders.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I51774cd0aaf16f0604a35993e2e9711930539bc7

explicit switch/case fallthroughs with a comment

The maven checkstyle plugin allows to comment explicitly fallthrough in
switch/case structures so that they do not raise a warning.
https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/coding/FallThroughCheck.html

Replace the @SuppressWarnings decorator by such a comment

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I80f45d149eef2f234ec40044ee4c7f8193df646a

Bump lighty.io core and add tests support for it

lighty-core version bumped to current master branch = 12.0.0-SNAPSHOT
This branch is aligned with ODL magnesium but seems to work as well with
TransportPCE current dependencies based on Sodium.
As a result, removing deviations from Openroadm models is no more
required to pass E2E tests.

How to run tests with lighty.io:
1. set environment variable "USE_LIGHTY" to value "True"
2. start any tox tests

The example script tests/tox-lighty-e2e.sh can be used to start
end2end221 tests based on lighty.io TransportPCE version

JIRA: TRNSPRTPCE-126 TRNSPRTPCE-127
Change-Id: I856b69eb9c0a20c3b0b0ece1d9ecb704cd9a272a
Signed-off-by: Samuel Kontris <samuel.kontris@pantheon.tech>

Add PowerMock library in OLM module

-add dependecies to OLM module
-fix issues related to these changes in OLM
-add class PowerMgmtPowerMockTest as POS and for increasing test coverage too

Signed-off-by: Shaaban Ebrahim <shaaban.eltanany.ext@orange.com>
Change-Id: I3ceb2d32a3cf80925aa029bbf48e8097759fea19

disable docs-linkcheck tox jobs

currently broken in releng

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I884d3791e2530423532243ba76beda5de167fe95

Solve issue for testCalculateSpanlossBase

Show example of unitary test on the calculateSpanlossBase method from
OlmPowerServiceImpl.java.

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I1e2003981faffdd6a3558b131633a0589f769188