transportpce.git
18 months agoRemove useless yang model from test-common 96/102496/2
Gilles Thouenon [Mon, 26 Sep 2022 16:02:48 +0000 (18:02 +0200)]
Remove useless yang model from test-common

This model has not been used for a while. No interest to keep it.

JIRA: TRNSPRTPCE-694
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I9eee371112176e2ca7893546e72e084c9781941a

18 months agoBump MRI upstreams 67/102467/1
Robert Varga [Fri, 23 Sep 2022 15:25:20 +0000 (17:25 +0200)]
Bump MRI upstreams

Adopt the following versions:
- mdsal-10.0.2
- controller-6.0.2
- aaa-0.16.3
- netconf-4.0.2
- bgpcep-0.18.2

Change-Id: I7a6ac54d33733eade6007925c56adf88c395e16a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoRe-open:Drop service-name from ODU connection name 98/102098/9
Balagangadhar Bathula [Tue, 16 Aug 2022 19:30:59 +0000 (15:30 -0400)]
Re-open:Drop service-name from ODU connection name

- Fix the bug w.r.t droping service-name from ODU connection
- Service-name is still concatenated to the lower order OTN network
  interfaces and client interfaces.
- Drop the service-name only from the ODU connection, so it will
  not be too long.
- Refer to the patch
  https://git.opendaylight.org/gerrit/c/transportpce/+/100830
  Commit hash: 397a481aa0674d4afea0bef72eb57276027bc343

JIRA: TRNSPRTPCE-628
Change-Id: Ic1df4fb69dd10977fb18ecb3574224589caec622
Signed-off-by: Balagangadhar Bathula <bb4341@att.com>
18 months agoFix PCE PathComputationServiceImpl useless NS 19/102419/1
guillaume.lambert [Wed, 21 Sep 2022 18:26:22 +0000 (20:26 +0200)]
Fix PCE PathComputationServiceImpl useless NS

JIRA: TRNSPRTPCE-683
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ib9ee162a0e96ea9d9d90f93eae5273a78c691781

18 months agoAdd unit tests PCE RPC path-computation-reroute 31/102031/7
Thierry Jiao [Wed, 10 Aug 2022 09:42:53 +0000 (11:42 +0200)]
Add unit tests PCE RPC path-computation-reroute

JIRA: TRNSPRTPCE-682
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I5a7e093f4eb69cedbf4b0dc2e3ab648f270915b5

18 months agoAdd unit & func tests for RPC service-reroute 30/102030/7
Thierry Jiao [Wed, 10 Aug 2022 08:14:28 +0000 (10:14 +0200)]
Add unit & func tests for RPC service-reroute

JIRA: TRNSPRTPCE-683
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I4ddb7391fdc4d75e3530e4cc884e60d071d736c0

19 months agoImplement service-reroute RPC 23/102023/7
Thierry Jiao [Tue, 9 Aug 2022 14:57:43 +0000 (16:57 +0200)]
Implement service-reroute RPC

The service-reroute RPC allows to check whether any route is possible
for an existing service.

JIRA: TRNSPRTPCE-683
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I3572b8c76c4600e463806da919f43e8bdbda1d4a

19 months agoImplement PCE RPC path-computation-reroute-request 22/102022/5
Thierry Jiao [Tue, 9 Aug 2022 08:56:53 +0000 (10:56 +0200)]
Implement PCE RPC path-computation-reroute-request

Before rerouting services, serviceListener will now call the RPC
path-computation-reroute-request to check that any other route exists.
If that's the case, the rerouting process will start.
Otherwise, the rerouting process is cancelled.

JIRA: TRNSPRTPCE-682
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I91c7a40ffdced804b059f523790f78245b81fe23

19 months agoUpdate transportpce-pce YANG 21/102021/3
Thierry Jiao [Mon, 8 Aug 2022 07:58:24 +0000 (09:58 +0200)]
Update transportpce-pce YANG

Add a new RPC named 'path-computation-reroute-request' which computes
paths by ignoring the reserved status of defined termination points
during the pruning process.

JIRA: TRNSPRTPCE-682
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I385913baaa762f6f77157418656ef525aaf8b3e2

19 months agoFix unchecked build warnings 58/102358/1
guillaume.lambert [Tue, 13 Sep 2022 11:44:38 +0000 (13:44 +0200)]
Fix unchecked build warnings

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I563ca68da5a916858cd0d40692edc3615e0753b6

19 months agoFix raw types build warnings 55/102355/2
guillaume.lambert [Tue, 13 Sep 2022 07:28:43 +0000 (09:28 +0200)]
Fix raw types build warnings

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I090a9063f24fc826944de3f31f2c99dbbc0a4c1e

19 months agoClean poms after Chlorine bump 54/102354/1
guillaume.lambert [Mon, 12 Sep 2022 19:09:50 +0000 (21:09 +0200)]
Clean poms after Chlorine bump

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1f587d7ff98f7f241bda9374eba96e97ba1d62bc

19 months agoRefactor Renderer OpenRoadmInterfaces step 1 25/102325/4
guillaume.lambert [Fri, 9 Sep 2022 13:40:27 +0000 (15:40 +0200)]
Refactor Renderer OpenRoadmInterfaces step 1

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I01e4ed15dcf355e88b5c14f420b93e8381e70848

19 months agoRefactor code after Chlorine Bump 24/102324/2
guillaume.lambert [Fri, 9 Sep 2022 12:21:55 +0000 (14:21 +0200)]
Refactor code after Chlorine Bump

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3d1f875d8c5f5afe883b9556f1aaaac5a18fef36

19 months agoImprove feature install in functional tests 10/102310/2
guillaume.lambert [Thu, 8 Sep 2022 06:50:50 +0000 (08:50 +0200)]
Improve feature install in functional tests

There is no more need to restart the controller to take the feature
installation into account.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I9c7a39b3c41d6e1066817236e8832937820a2975

19 months agoAdapt functional tests to Chlorine 65/102265/7
guillaume.lambert [Fri, 2 Sep 2022 19:32:59 +0000 (21:32 +0200)]
Adapt functional tests to Chlorine

- fix maven installer script comments about JAVA version
- update OLM tests
- comment out code in failure in TAPI device_change_notifications tests

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I829529b1dcb649ed61e6371860c56465d2a5af16

19 months agoAdapt TransportPCE code to Chlorine 76/101976/8
Gilles Thouenon [Fri, 5 Aug 2022 16:56:35 +0000 (18:56 +0200)]
Adapt TransportPCE code to Chlorine

- remove some no longer existing Optional
- adapt code to new format of SuypportedIfCapability
- replace switch case structure based on string coming from typedef to
  if- else strcuture due to the removal of getSimpleName() method
- all class types are now .VALUE
- adapt unitary tests consequently

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I4278e7b7787564542f12575ceb2f5d6fab15446c

19 months agoAdapt some dependencies to Chlorine 75/101975/6
Gilles Thouenon [Fri, 5 Aug 2022 07:10:23 +0000 (09:10 +0200)]
Adapt some dependencies to Chlorine

- remove outdated dependencies (javax.ws.rs-api,
  odl-restconf-nb-bierman02)
- migrate some dependencies (ietf-netconf per rfc6241,
  ietf-netconf-notifications per rfc6470)

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I47015e32bc5cc7d12f1a19b05502f702869e4458

19 months agoBump upstream dependencies to chlorine 74/101974/5
Gilles Thouenon [Wed, 3 Aug 2022 12:19:40 +0000 (14:19 +0200)]
Bump upstream dependencies to chlorine

Adopt:
- odlparent-11.0.1
- yangtools-9.0.1
- mdsal-10.0.1
- netconf-4.0.1

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Id0510560a88af903c20f404b51d2b4dfe4ed5c09

19 months agoBump CI tox build to jdk17 63/102263/3
guillaume.lambert [Fri, 2 Sep 2022 12:58:58 +0000 (14:58 +0200)]
Bump CI tox build to jdk17

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Idb5c2594ee043dfdbc3c25e63fff65f5a1ac0f6f

19 months agoSwitch functional tests to RFC8040 49/97549/24
guillaume.lambert [Thu, 25 Aug 2022 19:12:49 +0000 (21:12 +0200)]
Switch functional tests to RFC8040

JIRA: TRNSPRTPCE-567
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I55a2abdd4480df9eb19fded9466b13902eb338a3

19 months agoFix 7.1 functional tests RFC8040 uncompatibilities 62/102262/1
guillaume.lambert [Fri, 2 Sep 2022 10:10:58 +0000 (12:10 +0200)]
Fix 7.1 functional tests RFC8040 uncompatibilities

JIRA: TRNSPRTPCE-567
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ida705dc6df9cd91f8dc849b14c2fce89326698e4

19 months agoMigrate TAPI functional tests to RFC8040 22/102222/8
Gilles Thouenon [Thu, 25 Aug 2022 09:15:03 +0000 (11:15 +0200)]
Migrate TAPI functional tests to RFC8040

JIRA: TRNSPRTPCE-567
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I168b6ce08c11433f82067bbe613f73797a185591

19 months agoMigrate with_docker funct tests to RFC8040 23/102223/7
Gilles Thouenon [Thu, 25 Aug 2022 08:00:14 +0000 (10:00 +0200)]
Migrate with_docker funct tests to RFC8040

JIRA: TRNSPRTPCE-567
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ib6de34a3d3fd688e2c2370c7b357f4e6c33677e2

19 months agoMerge changes I7dcf500e,Iad756c3f,I8e898d86
Guillaume Lambert [Thu, 1 Sep 2022 16:04:26 +0000 (16:04 +0000)]
Merge changes I7dcf500e,Iad756c3f,I8e898d86

* changes:
  Refactor common CatalogUtils step 2
  Refactor common CatalogUtils step 1
  Primitives to retrieve parameters from Catalog

19 months agoShift tox nbinotifications to with_docker profile 40/102240/3
guillaume.lambert [Sun, 28 Aug 2022 19:22:08 +0000 (21:22 +0200)]
Shift tox nbinotifications to with_docker profile

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ice39221bcacc3e90d450c115812c2cdba34c994b

19 months agoFix checkbashisms auto install in tox for CentOS8 58/102258/4
guillaume.lambert [Thu, 1 Sep 2022 14:08:57 +0000 (16:08 +0200)]
Fix checkbashisms auto install in tox for CentOS8

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I56c154f79d177bf419024874530ab504cca113af

19 months agoBump upstream dependencies to S-SR2 57/102257/1
Gilles Thouenon [Mon, 29 Aug 2022 09:53:42 +0000 (11:53 +0200)]
Bump upstream dependencies to S-SR2

Adopt:
- odlparent-10.0.3
- yangtools-8.0.7
- mdsal-9.0.5
- netconf-3.0.6

JIRA: TRNSPRTPCE-684
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I6d2197469a829e9e1be87d4c79c667a55d4b12db

19 months agoRelease Python version fixed for PCE func tests 69/102269/2
guillaume.lambert [Wed, 31 Aug 2022 08:24:52 +0000 (10:24 +0200)]
Release Python version fixed for PCE func tests

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iea3ee2e16edb2f0001da66a6432bc03d751fcb35

19 months agoFix new pylint issues in functional tests 56/102256/1
Gilles Thouenon [Wed, 31 Aug 2022 09:41:35 +0000 (11:41 +0200)]
Fix new pylint issues in functional tests

- add timeout in requests.request methods
- remove useless disable pylint warning

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I2acd0f10b458fe8f7ee1be65644880fd0b41d943

19 months agoMigrate hybrid functional tests to RFC8040 21/102221/10
Gilles Thouenon [Thu, 25 Aug 2022 09:14:42 +0000 (11:14 +0200)]
Migrate hybrid functional tests to RFC8040

JIRA: TRNSPRTPCE-567
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I46c77fffe33e31813ba908811c0fd484e5febab3

19 months agoFix few functests assert RFC8040 uncompatibilities 30/102230/6
guillaume.lambert [Sat, 27 Aug 2022 07:53:27 +0000 (09:53 +0200)]
Fix few functests assert RFC8040 uncompatibilities

JIRA: TRNSPRTPCE-567
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8a5055716e32f3a888e226ab192ab24dfca0a09f

19 months agoMigrate PCE functional tests to RFC8040 20/102220/6
Gilles Thouenon [Thu, 25 Aug 2022 09:14:06 +0000 (11:14 +0200)]
Migrate PCE functional tests to RFC8040

- complement test_utils_rfc8040 with adapted methods
- replace xml input files (portmapping, topologies) by json files
  to ease treatments
- refactor test01_pce to optimize few non functional tests

JIRA: TRNSPRTPCE-567
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ic91cc81c9c7bbb4168d45a9402c435b170b486fa

19 months agoRefactor test_utils_rfc8040.py portmapping methods 19/102219/9
Gilles Thouenon [Thu, 25 Aug 2022 09:13:21 +0000 (11:13 +0200)]
Refactor test_utils_rfc8040.py portmapping methods

JIRA: TRNSPRTPCE-567
Co-authored-by: Guillaume Lambert <guillaume.lambert@orange.com>
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Ibe593c9ecc5ea2f863b16ed87629b26f4f5ab93c

19 months agoMigrate end2end functional tests to RFC8040 18/102218/5
Gilles Thouenon [Thu, 25 Aug 2022 09:12:47 +0000 (11:12 +0200)]
Migrate end2end functional tests to RFC8040

- 1.2.1-end2end
- 2.2.1-end2end
- 2.2.1-otn_switch_end2end
- 2.2.1-otn_end2end_with_intermediate_switch

JIRA: TRNSPRTPCE-567
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I1ca04f930bb0bfcc1c6d40220153640bcdf38c5b

20 months agoRefactor common CatalogUtils step 2 72/101972/5
guillaume.lambert [Fri, 5 Aug 2022 14:36:18 +0000 (16:36 +0200)]
Refactor common CatalogUtils step 2

Improve getPceRoadmAmpParameters method implementation
- remove useless intermediate variables
- fix Interchannel spacing correction factor in OSNR calculation
  ADD case formula (forgotten 10 factor).
- introduce a list for OSNR computation polynomial factors  and review
  order of arithmetic operations with a for-loop for more precision
  and efficiency.
  Double is not strictly spoken a Mathematics commutative group because
  computers design limits their bits representation size.
  As a result, the order of arithmetic operation matters.
  In a sum, smallest numbers should be introduced first for a maximum of
  precision. In other words, the sum
      10 * Math.log10(spacing / 50.0)
      + osnrPolynomialFits.get(0)
      + osnrPolynomialFits.get(1) * pwrIn
      + osnrPolynomialFits.get(2) * Math.pow(pwrIn, 2)
      + osnrPolynomialFits.get(3) * Math.pow(pwrIn, 3)
  is not equal to its reverse form
      osnrPolynomialFits.get(3) * Math.pow(pwrIn, 3)
      + osnrPolynomialFits.get(2) * Math.pow(pwrIn, 2)
      + osnrPolynomialFits.get(1) * pwrIn
      + osnrPolynomialFits.get(0)
      + 10 * Math.log10(spacing / 50.0)
  and the more precise first form should be preferred here.
- Adapt comments and Junit tests accordingly

JIRA: TRNSPRTPCE-518
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I7dcf500eb7ff93aacfe594dbe2d6e6125dab2e03

20 months agoRefactor common CatalogUtils step 1 44/101944/4
guillaume.lambert [Tue, 2 Aug 2022 14:08:24 +0000 (16:08 +0200)]
Refactor common CatalogUtils step 1

- optimize most methods implementations
  and first pass of refactoring for getPceRoadmAmpParameters
- rework a few LOG messages content

JIRA: TRNSPRTPCE-518
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iad756c3f2b906af79e9689907153921c4e236df1

20 months agoPrimitives to retrieve parameters from Catalog 18/101918/14
orenais [Fri, 29 Jul 2022 15:31:40 +0000 (17:31 +0200)]
Primitives to retrieve parameters from Catalog

- add a CatalogUtils and a Catalogconstant class in common module
  with primitives to retrieve parameters from Catalog
- add a related Penalty comparator serializable class
- add related Junit with a sample apidocCatalog json file
  that sticks to latest version of OpenROADM optical specification v5.1

JIRA: TRNSPRTPCE-518
Signed-off-by: orenais <olivier.renais@orange.com>
Change-Id: I8e898d86d44ea9a8f3a58eb581c3fe6515534221

20 months agoMerge changes I8b6da9f3,I425a1d19,Ia3dfe19f,Idd68c408,I73f0c083, ...
Gilles Thouenon [Fri, 29 Jul 2022 09:35:49 +0000 (09:35 +0000)]
Merge changes I8b6da9f3,I425a1d19,Ia3dfe19f,Idd68c408,I73f0c083, ...

* changes:
  Migrate OTN E2E functional tests to RFC8040 step 6
  Migrate OTN E2E functional tests to RFC8040 step 5
  Migrate OTN E2E functional tests to RFC8040 step 4
  Migrate OTN E2E functional tests to RFC8040 step 3
  Migrate OTN E2E functional tests to RFC8040 step 2
  Migrate OTN E2E functional tests to RFC8040 step 1

20 months agoMerge "Bump lighty.io build to Sulfur SR1"
Gilles Thouenon [Thu, 28 Jul 2022 14:24:40 +0000 (14:24 +0000)]
Merge "Bump lighty.io build to Sulfur SR1"

20 months agoMerge "Refactor networkmodel OpenRoadmTopology Part 4"
Guillaume Lambert [Wed, 27 Jul 2022 14:16:05 +0000 (14:16 +0000)]
Merge "Refactor networkmodel OpenRoadmTopology Part 4"

20 months agoMerge "Switch tests from nose to pytest"
Guillaume Lambert [Wed, 27 Jul 2022 08:07:35 +0000 (08:07 +0000)]
Merge "Switch tests from nose to pytest"

20 months agoMigrate OTN E2E functional tests to RFC8040 step 6 71/101871/3
guillaume.lambert [Tue, 26 Jul 2022 14:50:17 +0000 (16:50 +0200)]
Migrate OTN E2E functional tests to RFC8040 step 6

JIRA: TRNSPRTPCE-567
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8b6da9f3fae20ee600e40dd6dc05f15af73b8fde

20 months agoMigrate OTN E2E functional tests to RFC8040 step 5 70/101870/4
guillaume.lambert [Mon, 25 Jul 2022 20:38:32 +0000 (22:38 +0200)]
Migrate OTN E2E functional tests to RFC8040 step 5

JIRA: TRNSPRTPCE-567
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I425a1d19c772e9ef6f5829c3b55604feae9534a0

20 months agoMigrate OTN E2E functional tests to RFC8040 step 4 69/101869/1
guillaume.lambert [Mon, 25 Jul 2022 13:55:50 +0000 (15:55 +0200)]
Migrate OTN E2E functional tests to RFC8040 step 4

JIRA: TRNSPRTPCE-567
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ia3dfe19f95bb8115f9e0771ee46ec06dacbb1a2f

20 months agoMigrate OTN E2E functional tests to RFC8040 step 3 67/101867/2
guillaume.lambert [Mon, 25 Jul 2022 11:42:52 +0000 (13:42 +0200)]
Migrate OTN E2E functional tests to RFC8040 step 3

JIRA: TRNSPRTPCE-567
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Idd68c408d77dfe567d7996868c3f3a2b807b4333

20 months agoMigrate OTN E2E functional tests to RFC8040 step 2 57/101757/7
guillaume.lambert [Wed, 6 Jul 2022 14:58:23 +0000 (16:58 +0200)]
Migrate OTN E2E functional tests to RFC8040 step 2

JIRA: TRNSPRTPCE-567
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I73f0c083b6b1c9aebb9ca742e8c12bfb1a85263f

20 months agoBump lighty.io build to Sulfur SR1 66/101866/1
guillaume.lambert [Mon, 25 Jul 2022 08:36:54 +0000 (10:36 +0200)]
Bump lighty.io build to Sulfur SR1

Version 16.1.0 for Sulfur SR1 is available.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ibe47222b24997a1d48016626c19d44daf4ab8657

20 months agoFix typo developer guide 62/101862/1
Javier Errea [Thu, 21 Jul 2022 14:48:43 +0000 (16:48 +0200)]
Fix typo developer guide

Signed-off-by: Javier Errea <errea@eurecom.fr>
Change-Id: Idde79145b85026c6a5ad442a4619e37cffa0f62e

21 months agoReplace tpce-topology yang by existing ordmodels 46/101646/12
Thierry Jiao [Thu, 30 Jun 2022 09:08:50 +0000 (11:08 +0200)]
Replace tpce-topology yang by existing ordmodels

- Replace all use of transportpce-topology elements with identical ones
present in OpenROADM models
- If there is no replica of an element in OpenROADM models, displace the
element to 'api/src/main/yang/transportpce-networkutils.yang'
- Delete the 'transportpce-topology' yang file

JIRA: TRNSPRTPCE-679
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I74da30412e2d9bcfedbddef5af0055bdd742446f

21 months agoT-API notification functional tests 69/100469/21
Javier Errea [Thu, 7 Apr 2022 12:20:05 +0000 (14:20 +0200)]
T-API notification functional tests

- Functional tests for device change notification
  in tapi context
- Functional tests for tapi notification service
- nbinotifications testenv in tox.ini needs to
  install tapi feature

JIRA: TRNSPRTPCE-583
Signed-off-by: errea <errea@eurecom.fr>
Change-Id: If73a79025d7abf21308279ad10b9597b37874936

21 months agoUpdate developer guide 41/101641/3
Javier Errea [Wed, 29 Jun 2022 15:46:22 +0000 (17:46 +0200)]
Update developer guide

- Include tapi notification service information
- Update tpce architecture

JIRA: TRNSPRTPCE-678
Signed-off-by: Javier Errea <errea@eurecom.fr>
Change-Id: I6c6e43a86cdc0aea29d24ff342284388ea8d2213

21 months agoImplementation of T-API notification rpcs 50/98050/29
Javier Errea [Fri, 22 Oct 2021 13:40:49 +0000 (15:40 +0200)]
Implementation of T-API notification rpcs

- Tapi notification rpcs implementation
- tapi notification de-serializer
- Add ENABLE_AUTO_COMMIT_CONFIG to kafka subscriber
  configuration & and TopicPartition 0 to ConsumerRecords
  to enable to read TapiNotifications

JIRA: TRNSPRTPCE-560
Signed-off-by: errea <errea@eurecom.fr>
Change-Id: Ic49522b43c6351835eec67001e42887392a71238

21 months agoInitial tapi notification implementation 38/97438/40
Javier Errea [Wed, 11 Aug 2021 13:06:54 +0000 (15:06 +0200)]
Initial tapi notification implementation

- Tapi notification to nbi module
- Create notification subscription service rpc
- Create tapi topic in kafka server and send tapi notifications
- Service state change use case
- Extension of nbi module to support tapi notification service
- Update nbinotification revision date
- TapiRendererListener sends a notification when TAPI service
  is implemented

JIRA: TRNSPRTPCE-387
Change-Id: I32ebbf62570474b5f18787ad0c1c422f3e5e8d68
Signed-off-by: errea <errea@eurecom.fr>
21 months agoAdd tests for autonomous service rerouting 38/101638/10
Thierry Jiao [Mon, 27 Jun 2022 08:42:48 +0000 (10:42 +0200)]
Add tests for autonomous service rerouting

JIRA: TRNSPRTPCE-676
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: Ide83d8aa967af3095c71587cb19410acc0984b8f

21 months agoSwitch tests from nose to pytest 68/101768/2
guillaume.lambert [Thu, 7 Jul 2022 14:06:14 +0000 (16:06 +0200)]
Switch tests from nose to pytest

nose is going to be deprecated.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I782bbd70f14a8edd1bf72cbb11fc5bc684127f6b

21 months agoUpgrade Honeynode sim version 39/101739/2
Thierry Jiao [Tue, 5 Jul 2022 12:29:26 +0000 (14:29 +0200)]
Upgrade Honeynode sim version

Upgrade Honeynode version for device 2.2.1 and 7.1.0

Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: Ib9b6a83c0800569a2e948a9d86051fea3b3bd84c

21 months agoRefactor networkmodel OpenRoadmTopology Part 4 51/101751/1
guillaume.lambert [Wed, 6 Jul 2022 08:12:44 +0000 (10:12 +0200)]
Refactor networkmodel OpenRoadmTopology Part 4

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I4598ed9b324fd1a904fcbbcfa6aa1a64fa678961

21 months agoMigrate OTN E2E functional tests to RFC8040 step 1 38/101738/5
guillaume.lambert [Tue, 5 Jul 2022 09:57:23 +0000 (11:57 +0200)]
Migrate OTN E2E functional tests to RFC8040 step 1

JIRA: TRNSPRTPCE-567
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ifcdb06b609720a738378cdc78e1b93ecae3294ee

21 months agoRefactor networkmodel OpenRoadmTopology Part 3 21/101721/2
guillaume.lambert [Mon, 4 Jul 2022 19:01:20 +0000 (21:01 +0200)]
Refactor networkmodel OpenRoadmTopology Part 3

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I50750477af920547d29501ae8b8f5fa270809b9e

21 months agoRefactor networkmodel OpenRoadmTopology Part 2 15/101715/6
guillaume.lambert [Mon, 4 Jul 2022 09:10:48 +0000 (11:10 +0200)]
Refactor networkmodel OpenRoadmTopology Part 2

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I0b7ccddcec80ccd0a72c00785f844ac832dd7c2f

21 months agoRefactor networkmodel OpenRoadmTopology Part 1 97/101597/30
Quentin Saillard [Mon, 4 Jul 2022 07:47:01 +0000 (09:47 +0200)]
Refactor networkmodel OpenRoadmTopology Part 1

Change-Id: Ie45fb713f1df0bb0b84e94da25b3a6838a4eeefd
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
21 months agoMerge "Fix PceCalculation bug when validating nodes"
Guillaume Lambert [Tue, 5 Jul 2022 07:11:44 +0000 (07:11 +0000)]
Merge "Fix PceCalculation bug when validating nodes"

21 months agoMerge changes from topic "fix_bugs"
Gilles Thouenon [Mon, 4 Jul 2022 10:42:31 +0000 (10:42 +0000)]
Merge changes from topic "fix_bugs"

* changes:
  Update ServicehandlerImplTest
  Fix bug service-create

21 months agoUpdate ServicehandlerImplTest 21/101621/3
Thierry Jiao [Wed, 22 Jun 2022 12:51:04 +0000 (14:51 +0200)]
Update ServicehandlerImplTest

- Refactor the redundant variables
- Add Unit test for service-create when service already exists in
DataStore

JIRA: TRNSPRTPCE-675
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: Ifa6657e8dac0cb81d6a3c4837aac1e18f1ba00be

21 months agoFix PceCalculation bug when validating nodes 47/101647/4
Thierry Jiao [Thu, 30 Jun 2022 07:31:41 +0000 (09:31 +0200)]
Fix PceCalculation bug when validating nodes

JIRA: TRNSPRTPCE-677
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: Ia969fce0ad8cdb57f5e18db9576a6007a54930f4

21 months agoMerge "Bump lighty.io build to Sulfur"
Guillaume Lambert [Fri, 1 Jul 2022 10:08:43 +0000 (10:08 +0000)]
Merge "Bump lighty.io build to Sulfur"

21 months agoBump lighty.io build to Sulfur 48/101648/3
guillaume.lambert [Thu, 30 Jun 2022 17:50:20 +0000 (19:50 +0200)]
Bump lighty.io build to Sulfur

Version 16.0.0 for Sulfur is available.
Thought, lighty.io cannot be enforced in the CI yet.
Most tests still do not pass with it.

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ic9d0b2f1c2760a1f5331cde4110177f816f2a285

21 months agoFix bug service-create 20/101620/2
Thierry Jiao [Wed, 22 Jun 2022 07:53:43 +0000 (09:53 +0200)]
Fix bug service-create

When creating a new service with service-create RPC, ServiceHandlerImpl
will now check that there are no existing services with the same name
in the datastore.

JIRA: TRNSPRTPCE-675
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I6ba726bc40c391077f3766f782205b2ec2c541c4

21 months agoMerge "Update project version for Chlorine release train"
Guillaume Lambert [Thu, 30 Jun 2022 12:25:12 +0000 (12:25 +0000)]
Merge "Update project version for Chlorine release train"

21 months agoUpdate project version for Chlorine release train 44/101644/2
guillaume.lambert [Thu, 30 Jun 2022 09:46:04 +0000 (11:46 +0200)]
Update project version for Chlorine release train

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I4577f9c44945b8243bff68d0a0310c8f6b2ea9a7

21 months agoUpdate docs conf.yaml version to Sulfur 42/101642/1
guillaume.lambert [Thu, 30 Jun 2022 08:26:10 +0000 (10:26 +0200)]
Update docs conf.yaml version to Sulfur

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: If94c40b6c25f99f36f58378dbc56c9d581085adf

21 months agoFix some indentations issues in OpenRoadmTopology 44/101544/25
Quentin [Fri, 3 Jun 2022 09:41:58 +0000 (11:41 +0200)]
Fix some indentations issues in OpenRoadmTopology

Several parts of the current code show high cyclomatic complexity.
Some of them still use old Java coding style patterns.

Change-Id: Ib434ef68b9b32f74bbc1132005c8d319a6d4ecca
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
21 months agoRefactor SH NetworkModelListenerImpl 84/101584/6
guillaume.lambert [Tue, 14 Jun 2022 13:55:10 +0000 (15:55 +0200)]
Refactor SH NetworkModelListenerImpl

JIRA: TRNSPRTPCE-668, TRNSPRTPCE-669
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I53b901247953aa19a9e4c5a462097183cedd99c0

21 months agoImplement an autonomous service rerouting 85/101585/7
Thierry Jiao [Tue, 24 May 2022 07:42:16 +0000 (09:42 +0200)]
Implement an autonomous service rerouting

If the OperationalState of a service becomes 'outOfService',
the service will be rerouted through the following process :

  - 1) Complete deletion of the service
  - 2) Recreation of the service with a new path

JIRA: TRNSPRTPCE-676
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I9227f0f2cf5993c54e66bffc0fbd4e3168a6839e

21 months agoAdd service-resiliency compliance check 83/101583/7
Thierry Jiao [Fri, 10 Jun 2022 13:17:22 +0000 (15:17 +0200)]
Add service-resiliency compliance check

- Implement new method of compliance check dedicated to
service-resiliency input
- Add JUnit test of this new method

JIRA: TRNSPRTPCE-670
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I522f0bc02bb9723408172b53d1f4b190db11d667

21 months agoAdd service-resiliency handling in service-create 82/101582/7
Thierry Jiao [Wed, 8 Jun 2022 12:43:54 +0000 (14:43 +0200)]
Add service-resiliency handling in service-create

Add possibility to specify the service-resiliency attribute
in the input of the service-create RPC.

JIRA: TRNSPRTPCE-670
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: I66423007af5261e77a2290fbe4539e976b6eb8b7

21 months agoFix issues in listeners 54/101454/6
Thierry Jiao [Wed, 25 May 2022 14:31:58 +0000 (16:31 +0200)]
Fix issues in listeners

- In PortMappingListener, change the predicate that conditions
the topology update
- In NetworkModelListener, update only the OperationalState of
the service after the topology update (and no longer the AdminState)
- Update the functional tests accordingly
- Add JUnit tests for PortMappingListener & NetworkModelListenerImpl

JIRA: TRNSPRTPCE-668, TRNSPRTPCE-669
Signed-off-by: Thierry Jiao <thierry.jiao@orange.com>
Change-Id: Ifbc4402794830fa6e060f8f3c60132dc05e803ba

21 months agoRefactor tapi-delete-connectivity service rpc 74/100474/12
Javier Errea [Thu, 7 Apr 2022 13:53:30 +0000 (15:53 +0200)]
Refactor tapi-delete-connectivity service rpc

- Delete connections from connectivity-context
  on delete-tapi-connectivity-service
- Add check to verify that the connection is not
  used by another service before deletion
- Delete only connections that correspond to the
  connectivity service layer

JIRA: TRNSPRTPCE-650
Signed-off-by: errea <errea@eurecom.fr>
Change-Id: Id9a31ca595156d93b59fded7476442614e3d9e07

21 months agoUpdate TAPI Connectivity Service on port change 37/97437/30
Javier Errea [Mon, 2 Aug 2021 12:27:01 +0000 (14:27 +0200)]
Update TAPI Connectivity Service on port change

- Update TAPI connections & connectivity service
  on topology update notification
- Update TAPI supported connectivity services (infrastructure)
- Update CEPs of connections
- Add tapiNetworkModelListener to TapiProvider class
- Refactor TAPI connection creation to include lower connections
- Add method for sending a notification on a TAPI topology update
- Refactor differentiation between SWITCH and MUXPDR connectivity
  service creation
- Refactor connectivity service creation when there is
  more than 1 ROADM between end points of the service

JIRA: TRNSPRTPCE-466
Change-Id: I95f7dfba0d9d01c48e60538b215890265d48cf19
Signed-off-by: errea <errea@eurecom.fr>
21 months agoUpdate TAPI Topology Service on port change 36/97436/29
Javier Errea [Mon, 2 Aug 2021 10:01:05 +0000 (12:01 +0200)]
Update TAPI Topology Service on port change

- PortMappingListener triggers TAPI topo update on port change
- Update TAPI NEPs, SIPs & Links on port change

JIRA: TRNSPRTPCE-466
Change-Id: I17d0b80a78a6154cd7bb1ceffd861e186c90a30a
Signed-off-by: errea <errea@eurecom.fr>
21 months agoUpdating the usage section of the developer guide 16/101516/4
Roshan Joyce [Thu, 9 Jun 2022 06:25:20 +0000 (11:55 +0530)]
Updating the usage section of the developer guide

The URIs mentioned in the developer guide has some
errors. Corrected them with working URIs based on
RFC8040.

Signed-off-by: Roshan Joyce <roshan.joyce@fujitsu.com>
Change-Id: I58add6fcb96a8017be22d46e48682532b119ba2f

22 months agoChange LOG level in PCE 48/99548/12
Gilles Thouenon [Tue, 1 Feb 2022 17:00:07 +0000 (18:00 +0100)]
Change LOG level in PCE

Change most of LOG messages of PCE from Info to Debug level.

JIRA: TRNSPRTPCE-570
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I1b2626b605f263ec62c534c453a1d211053c56eb

22 months agoChange log level in MappingUtilsImpl 47/99547/12
Gilles Thouenon [Tue, 1 Feb 2022 16:50:20 +0000 (17:50 +0100)]
Change log level in MappingUtilsImpl

Change part of log messages from info to debug.

JIRA: TRNSPRTPCE-570
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ia93d80cdd738a87353dfa39ca357935581f85bd8

22 months agopce(gnpy) for Sulfur 00/101300/18
wede7391 [Wed, 25 May 2022 20:26:53 +0000 (22:26 +0200)]
pce(gnpy) for Sulfur

- replace jackson module with MessageBodyWriter and MessageBodyReader
 to avoid intermediate String (fix scientific notation for decimal)
- add createDataObjectFromInputStream to JsonConverter
- put decimal value in gnpy test data

JIRA: TRNSPRTPCE-639
Signed-off-by: wede7391 <emmanuelle.delfour@orange.com>
Change-Id: I4399bf1004709860796884e3c990c8466cf57ca8

22 months agoQuick and dirty fix to sulfur build problems in CI 61/100861/24
guillaume.lambert [Thu, 28 Apr 2022 09:21:20 +0000 (11:21 +0200)]
Quick and dirty fix to sulfur build problems in CI

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I211fbd6389f48af9e2656811e6d6a0f529dc12f2

22 months agoAdapt TransportPCE code to Sulfur 46/100646/27
Gilles Thouenon [Wed, 13 Apr 2022 15:10:18 +0000 (17:10 +0200)]
Adapt TransportPCE code to Sulfur

- modify InstanceIdentifier creation using builderOfInherited() method
- replace BigDecimal by Decimal64
- adapt some RpcResultBuilder
- replace List by Set wherever it was necesary
- adapt values format used in input files of UT to Decimal64
- disable few UT still failing
- disable lighty build from the CI

Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ie49bec4438c9e58c9f894363fc6be1eded65ae28

22 months agoBump upstream dependencies to S-SR1 33/100633/15
Gilles Thouenon [Thu, 31 Mar 2022 07:22:21 +0000 (09:22 +0200)]
Bump upstream dependencies to S-SR1

Adopt:
- odlparent-10.0.2
- yangtools-8.0.6
- mdsal-9.0.4
- netconf-3.0.5

Also,
- remove useless power-mock dependencies from olm and pce modules

JIRA: TRNSPRTPCE-648
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I64667a43343a18ceccdc58731c00d294a74f5826

22 months agoupdate pce yang model 00/101600/1
manuedelf [Thu, 16 Jun 2022 13:19:35 +0000 (15:19 +0200)]
update pce yang model

change fraction digits from 2 to 6 for accumulative-value leaf
from 2 to 6 to be compliant with Gnpy

Signed-off-by: manuedelf <emmanuelle.delfour@orange.com>
Change-Id: Ib4bf9ab50cd13956e03564366d6fea718702cc83

22 months agofix gnpy model 95/101595/2
manuedelf [Wed, 15 Jun 2022 14:03:49 +0000 (16:03 +0200)]
fix gnpy model

- change fraction digits from 2 to 6 for accumulative-value leaf
- update unit test data file
- update gnpy4tpce version to be compliant

Signed-off-by: manuedelf <emmanuelle.delfour@orange.com>
Change-Id: I774d37a78dc732d509e5f18398eea73c2c7b704e

22 months agofix funcional test issue when list in dict 90/101290/4
Gilles Thouenon [Wed, 25 May 2022 13:27:31 +0000 (15:27 +0200)]
fix funcional test issue when list in dict

Adapt few functional test to be able to compare dictionaries containing
list, where order of items inside the list is taken into acount.

JIRA: TRNSPRTPCE-666
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I0fb6f235348583f04e7777f06698ed430c3320f2

22 months agoMerge "Use Maven 3.8.6 in CI CentOS install script"
Guillaume Lambert [Tue, 14 Jun 2022 07:49:54 +0000 (07:49 +0000)]
Merge "Use Maven 3.8.6 in CI CentOS install script"

22 months agoUse Maven 3.8.6 in CI CentOS install script 72/101572/2
guillaume.lambert [Mon, 13 Jun 2022 09:38:14 +0000 (11:38 +0200)]
Use Maven 3.8.6 in CI CentOS install script

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ia0b37555dcf845de682ee315a2d58b21602e65bb

22 months agoFix the pom files to compile in Windows OS 45/101545/2
Balagangadhar Bathula [Thu, 9 Jun 2022 14:26:48 +0000 (10:26 -0400)]
Fix the pom files to compile in Windows OS

- Windows machines do not recognize paths in
  certain pom.xml files

Change-Id: I8178841141d23a61dca90f4c719ac39409b18766
Signed-off-by: Balagangadhar Bathula <bb4341@att.com>
22 months agoMerge "Remove SupportedIfCapability conversion from TAPI"
Guillaume Lambert [Thu, 2 Jun 2022 14:58:15 +0000 (14:58 +0000)]
Merge "Remove SupportedIfCapability conversion from TAPI"

22 months agoMerge changes Idfae5b92,Ibc4de535,Iad341cb0,I5e0be59b,Id51f6680
Guillaume Lambert [Thu, 2 Jun 2022 14:50:50 +0000 (14:50 +0000)]
Merge changes Idfae5b92,Ibc4de535,Iad341cb0,I5e0be59b,Id51f6680

* changes:
  Refactor DpQpsk/DpQam16 100G OFEC support
  Renderer functional tests for 200G rate 31.6 Gbaud
  Fix bug in 200G 31.6 GBaud renderer
  Functional tests for 100 OFEC 31.6 GBaud
  Add support for 100G OFEC

22 months agoMerge "Update GNPy version used for functional tests"
Gilles Thouenon [Thu, 2 Jun 2022 14:30:32 +0000 (14:30 +0000)]
Merge "Update GNPy version used for functional tests"

22 months agoRemove SupportedIfCapability conversion from TAPI 47/100447/3
Gilles Thouenon [Thu, 7 Apr 2022 11:55:04 +0000 (13:55 +0200)]
Remove SupportedIfCapability conversion from TAPI

With change https://git.opendaylight.org/gerrit/c/transportpce/+/100135,
conversions of SupportedIfCapability should have been removed.
Remove useless conversion methods.

JIRA: TRNSPRTPCE-644
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ic4f885e4a8e45ff34496e27e20397dafc2975c53

22 months agoRefactor DpQpsk/DpQam16 100G OFEC support 18/101318/2
guillaume.lambert [Sat, 28 May 2022 14:52:43 +0000 (16:52 +0200)]
Refactor DpQpsk/DpQam16 100G OFEC support

JIRA: TRNSPRTPCE-636
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Idfae5b92ba0b2bddd366ee2fbf03c5fd3978eb19

22 months agoRenderer functional tests for 200G rate 31.6 Gbaud 04/101304/2
Balagangadhar Bathula [Thu, 26 May 2022 16:27:34 +0000 (12:27 -0400)]
Renderer functional tests for 200G rate 31.6 Gbaud

- Renderer service-path create and delete
- Fix a minor bug

JIRA: TRNSPRTPCE-637
Change-Id: Ibc4de5354e1188dec792fbc719513e4261d47312
Signed-off-by: Balagangadhar Bathula <bb4341@att.com>