From b5a312cc359527ae119076cadc5613ab85848ba4 Mon Sep 17 00:00:00 2001 From: "guillaume.lambert" Date: Mon, 23 Apr 2018 11:42:24 +0200 Subject: [PATCH] Minor checkstyle corrections Change-Id: Ie9f5ba977615211e5813cc47d39fb7f363d961e1 Signed-off-by: guillaume.lambert --- .../openroadminterfaces/OpenRoadmInterfacesImpl.java | 7 ++++--- .../renderer/provisiondevice/tasks/RollbackProcessor.java | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/common/src/main/java/org/opendaylight/transportpce/common/openroadminterfaces/OpenRoadmInterfacesImpl.java b/common/src/main/java/org/opendaylight/transportpce/common/openroadminterfaces/OpenRoadmInterfacesImpl.java index 793bffc78..d85b36db1 100644 --- a/common/src/main/java/org/opendaylight/transportpce/common/openroadminterfaces/OpenRoadmInterfacesImpl.java +++ b/common/src/main/java/org/opendaylight/transportpce/common/openroadminterfaces/OpenRoadmInterfacesImpl.java @@ -86,8 +86,8 @@ public class OpenRoadmInterfacesImpl implements OpenRoadmInterfaces { public Optional getInterface(String nodeId, String interfaceName) throws OpenRoadmInterfaceException { InstanceIdentifier interfacesIID = InstanceIdentifier.create(OrgOpenroadmDevice.class) .child(Interface.class, new InterfaceKey(interfaceName)); - return this.deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, interfacesIID, - Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + return this.deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, + interfacesIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); } @Override @@ -144,7 +144,8 @@ public class OpenRoadmInterfacesImpl implements OpenRoadmInterfaces { InstanceIdentifier interfacesIID = InstanceIdentifier.create(OrgOpenroadmDevice.class) .child(Interface.class, new InterfaceKey(interfaceName)); - Future> deviceTxFuture = this.deviceTransactionManager.getDeviceTransaction(nodeId); + Future> deviceTxFuture = + this.deviceTransactionManager.getDeviceTransaction(nodeId); DeviceTransaction deviceTx; try { Optional deviceTxOpt = deviceTxFuture.get(); diff --git a/renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/tasks/RollbackProcessor.java b/renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/tasks/RollbackProcessor.java index 709fc170a..2531a4260 100644 --- a/renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/tasks/RollbackProcessor.java +++ b/renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/tasks/RollbackProcessor.java @@ -60,6 +60,7 @@ public class RollbackProcessor { * @return * number of tasks rolled back */ + @SuppressWarnings("checkstyle:IllegalCatch") public int rollbackAll() { int rollbackCounter = 0; while (this.tasks.size() > 0) { @@ -68,6 +69,7 @@ public class RollbackProcessor { try { LOG.info("rolling back: {}", task.getId()); task.call(); + //this methode prototype only use the generic Exception and no specific and useable subclasse } catch (Exception e) { LOG.error("ERROR: Rollback task {} has failed", task.getId(), e); } -- 2.36.6