From ce96a3bb3962f1350f9c7cee6405dcfba88aaaa3 Mon Sep 17 00:00:00 2001 From: "guillaume.lambert" Date: Mon, 23 Jul 2018 17:15:35 +0200 Subject: [PATCH] fix some compilation warnings Change-Id: I73d5b4906d85cfc2ab6e2457335192e8a8d19ce7 Signed-off-by: guillaume.lambert --- .../org/opendaylight/transportpce/common/ResponseCodes.java | 5 ++++- .../java/org/opendaylight/transportpce/common/Timeouts.java | 3 +++ .../transportpce/common/crossconnect/CrossConnect.java | 5 +++-- .../common/openroadminterfaces/OpenRoadmInterfaces.java | 4 ++-- .../opendaylight/transportpce/inventory/query/Queries.java | 4 ++-- .../transportpce/networkmodel/NetConfTopologyListener.java | 5 +++-- .../transportpce/networkmodel/Rdm2XpdrLink.java | 4 ++++ .../org/opendaylight/transportpce/olm/util/OlmUtils.java | 5 ++++- .../renderer/provisiondevice/DeviceRenderingResult.java | 2 +- .../renderer/provisiondevice/OLMRenderingResult.java | 2 +- .../transportpce/renderer/utils/MountPointUtils.java | 6 +++++- .../transportpce/renderer/utils/ServiceDataUtils.java | 5 ++++- .../servicehandler/validation/ServiceCreateValidation.java | 6 +++++- .../validation/checks/CheckCoherencyHardSoft.java | 5 ++++- .../validation/checks/ServicehandlerCompliancyCheck.java | 5 ++++- .../validation/checks/ServicehandlerTxRxCheck.java | 5 ++++- .../servicehandler/mappers/PathDescriptionConverter.java | 5 ++++- .../servicehandler/mappers/ServiceAEndConverter.java | 5 ++++- .../servicehandler/mappers/ServiceDeleteInputConverter.java | 4 +++- .../mappers/ServiceDeleteOutputConverter.java | 4 +++- .../mappers/ServiceImplementationRequestInputConverter.java | 5 ++++- .../ServiceImplementationRequestOutputConverter.java | 5 ++++- .../servicehandler/mappers/ServiceZEndConverter.java | 5 ++++- .../transportpce/servicehandler/utils/ServiceDataUtils.java | 5 ++++- 24 files changed, 83 insertions(+), 26 deletions(-) diff --git a/common/src/main/java/org/opendaylight/transportpce/common/ResponseCodes.java b/common/src/main/java/org/opendaylight/transportpce/common/ResponseCodes.java index 435afd374..1c0965dcd 100644 --- a/common/src/main/java/org/opendaylight/transportpce/common/ResponseCodes.java +++ b/common/src/main/java/org/opendaylight/transportpce/common/ResponseCodes.java @@ -7,7 +7,7 @@ */ package org.opendaylight.transportpce.common; -public class ResponseCodes { +public final class ResponseCodes { public static final String RESPONSE_FAILED = "500"; public static final String RESPONSE_OK = "200"; @@ -17,4 +17,7 @@ public class ResponseCodes { public static final String SUCCESS_RESULT = "Success"; public static final String FAILED_RESULT = "Failed"; + private ResponseCodes() { + } + } diff --git a/common/src/main/java/org/opendaylight/transportpce/common/Timeouts.java b/common/src/main/java/org/opendaylight/transportpce/common/Timeouts.java index c8051c6f1..b59ab5e04 100644 --- a/common/src/main/java/org/opendaylight/transportpce/common/Timeouts.java +++ b/common/src/main/java/org/opendaylight/transportpce/common/Timeouts.java @@ -31,4 +31,7 @@ public final class Timeouts { public static final TimeUnit DEVICE_WRITE_TIMEOUT_UNIT = TimeUnit.SECONDS; //TODO add timeouts for device setup (olm power setup etc.) + + private Timeouts() { + } } diff --git a/common/src/main/java/org/opendaylight/transportpce/common/crossconnect/CrossConnect.java b/common/src/main/java/org/opendaylight/transportpce/common/crossconnect/CrossConnect.java index 0b708c006..c0c6e8598 100644 --- a/common/src/main/java/org/opendaylight/transportpce/common/crossconnect/CrossConnect.java +++ b/common/src/main/java/org/opendaylight/transportpce/common/crossconnect/CrossConnect.java @@ -73,10 +73,11 @@ public interface CrossConnect { * Source logical connection point. * @param destTp * Destination logical connection point. - * @throws OpenRoadmInterfaceException - * OpenRoadm Interface Exception. * * @return list of Ports object type. + * + * @throws OpenRoadmInterfaceException + * OpenRoadm Interface Exception. */ List getConnectionPortTrail(String nodeId, Long waveNumber, String srcTp, String destTp) throws OpenRoadmInterfaceException; diff --git a/common/src/main/java/org/opendaylight/transportpce/common/openroadminterfaces/OpenRoadmInterfaces.java b/common/src/main/java/org/opendaylight/transportpce/common/openroadminterfaces/OpenRoadmInterfaces.java index 3cec88f63..dc3821652 100644 --- a/common/src/main/java/org/opendaylight/transportpce/common/openroadminterfaces/OpenRoadmInterfaces.java +++ b/common/src/main/java/org/opendaylight/transportpce/common/openroadminterfaces/OpenRoadmInterfaces.java @@ -44,9 +44,9 @@ public interface OpenRoadmInterfaces { * @param interfaceName * Name of the interface * - * @throws OpenRoadmInterfaceException OpenRoadm Interface Exception - * * @return Optional of Interface from datastore + * + * @throws OpenRoadmInterfaceException OpenRoadm Interface Exception */ Optional getInterface(String nodeId, String interfaceName) throws OpenRoadmInterfaceException; diff --git a/inventory/src/main/java/org/opendaylight/transportpce/inventory/query/Queries.java b/inventory/src/main/java/org/opendaylight/transportpce/inventory/query/Queries.java index d0381cec4..8438fda5f 100644 --- a/inventory/src/main/java/org/opendaylight/transportpce/inventory/query/Queries.java +++ b/inventory/src/main/java/org/opendaylight/transportpce/inventory/query/Queries.java @@ -11,7 +11,7 @@ package org.opendaylight.transportpce.inventory.query; import com.google.common.base.Preconditions; import com.google.common.base.Strings; -public class Queries { +public final class Queries { private static final String DEVICE_INFO_INSERT = "INSERT INTO %sinv_dev_info " @@ -81,7 +81,7 @@ public class Queries { return new Query(); } - public static class Query { + public final static class Query { private String sql; private String schema; diff --git a/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/NetConfTopologyListener.java b/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/NetConfTopologyListener.java index 5f1882af8..059479b02 100644 --- a/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/NetConfTopologyListener.java +++ b/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/NetConfTopologyListener.java @@ -152,6 +152,7 @@ public class NetConfTopologyListener implements DataTreeChangeListener { } @Override + @SuppressWarnings("checkstyle:FallThrough") public void onDataTreeChanged(@Nonnull Collection> changes) { LOG.info("onDataTreeChanged"); for (DataTreeModification change : changes) { @@ -183,8 +184,8 @@ public class NetConfTopologyListener implements DataTreeChangeListener { netconfNode.getConnectionStatus(); try { long count = netconfNode.getAvailableCapabilities().getAvailableCapability().stream() - .filter(cp -> cp.getCapability().contains(StringConstants.OPENROADM_DEVICE_MODEL_NAME)) - .count(); + .filter(cp -> cp.getCapability().contains(StringConstants.OPENROADM_DEVICE_MODEL_NAME)) + .count(); if (count > 0) { LOG.info("OpenROADM node detected: {} {}", nodeId, connectionStatus.name()); switch (connectionStatus) { diff --git a/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/Rdm2XpdrLink.java b/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/Rdm2XpdrLink.java index 516a531e8..73b765cf7 100644 --- a/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/Rdm2XpdrLink.java +++ b/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/Rdm2XpdrLink.java @@ -112,5 +112,9 @@ final class Rdm2XpdrLink { nwBuilder.addAugmentation(Network1.class, nwBldr1.build()); return nwBuilder; } + + private Rdm2XpdrLink() { + } + } diff --git a/olm/src/main/java/org/opendaylight/transportpce/olm/util/OlmUtils.java b/olm/src/main/java/org/opendaylight/transportpce/olm/util/OlmUtils.java index cce360654..41caec5b6 100644 --- a/olm/src/main/java/org/opendaylight/transportpce/olm/util/OlmUtils.java +++ b/olm/src/main/java/org/opendaylight/transportpce/olm/util/OlmUtils.java @@ -54,7 +54,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -public class OlmUtils { +public final class OlmUtils { private static final Logger LOG = LoggerFactory.getLogger(OlmUtils.class); private static long DATABROKER_READ_TIMEOUT_SECONDS = 120; @@ -289,4 +289,7 @@ public class OlmUtils { return Optional.empty(); } + private OlmUtils() { + } + } diff --git a/renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/DeviceRenderingResult.java b/renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/DeviceRenderingResult.java index 0fa7d4e72..565956243 100644 --- a/renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/DeviceRenderingResult.java +++ b/renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/DeviceRenderingResult.java @@ -13,7 +13,7 @@ import org.opendaylight.transportpce.common.OperationResult; import org.opendaylight.yang.gen.v1.http.org.transportpce.common.types.rev170907.node.interfaces.NodeInterface; import org.opendaylight.yang.gen.v1.http.org.transportpce.common.types.rev170907.olm.renderer.input.Nodes; -public class DeviceRenderingResult extends OperationResult { +public final class DeviceRenderingResult extends OperationResult { private final List olmList; private final List renderedNodeInterfaces; diff --git a/renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/OLMRenderingResult.java b/renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/OLMRenderingResult.java index ae8ca9ee1..8f94dc804 100644 --- a/renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/OLMRenderingResult.java +++ b/renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/OLMRenderingResult.java @@ -9,7 +9,7 @@ package org.opendaylight.transportpce.renderer.provisiondevice; import org.opendaylight.transportpce.common.OperationResult; -public class OLMRenderingResult extends OperationResult { +public final class OLMRenderingResult extends OperationResult { private OLMRenderingResult(boolean success, String message) { super(success, message); diff --git a/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/MountPointUtils.java b/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/MountPointUtils.java index a5d469dc9..79690dce3 100644 --- a/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/MountPointUtils.java +++ b/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/MountPointUtils.java @@ -42,7 +42,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.opendaylight.yangtools.yang.common.RpcResult; import org.opendaylight.yangtools.yang.common.RpcResultBuilder; -public class MountPointUtils { +public final class MountPointUtils { public static MountPointStub getMountPoint(List ports, DataBroker dataBroker) { RpcConsumerRegistry rpcConsumerRegistry = Mockito.spy(RpcConsumerRegistry.class); @@ -114,4 +114,8 @@ public class MountPointUtils { } return true; } + + private MountPointUtils() { + } + } diff --git a/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/ServiceDataUtils.java b/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/ServiceDataUtils.java index bec9aa381..39ea8650d 100644 --- a/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/ServiceDataUtils.java +++ b/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/ServiceDataUtils.java @@ -48,7 +48,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.renderer import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.renderer.rev170228.ServicePathInputBuilder; -public class ServiceDataUtils { +public final class ServiceDataUtils { public static Nodes createNode(String nodeId, String srcTp, String dstTp) { return new NodesBuilder().setNodeId(nodeId).setKey(new NodesKey(nodeId)).setSrcTp(srcTp) @@ -253,4 +253,7 @@ public class ServiceDataUtils { .build()); } + private ServiceDataUtils() { + } + } diff --git a/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/ServiceCreateValidation.java b/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/ServiceCreateValidation.java index 5b946bbde..68f1f2b65 100644 --- a/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/ServiceCreateValidation.java +++ b/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/ServiceCreateValidation.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.http.org.openroadm.service.rev161014.Service import org.slf4j.Logger; import org.slf4j.LoggerFactory; -public class ServiceCreateValidation { +public final class ServiceCreateValidation { private static final Logger LOG = LoggerFactory.getLogger(ServiceCreateValidation.class); public static OperationResult validateServiceCreateRequest(ServiceCreateInput input) { @@ -89,4 +89,8 @@ public class ServiceCreateValidation { } return OperationResult.ok("Validation successful."); } + + public ServiceCreateValidation() { + } + } diff --git a/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/CheckCoherencyHardSoft.java b/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/CheckCoherencyHardSoft.java index 426f56b3e..a9a2d80b2 100644 --- a/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/CheckCoherencyHardSoft.java +++ b/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/CheckCoherencyHardSoft.java @@ -17,7 +17,7 @@ import org.slf4j.LoggerFactory; * Class to check coherency between hard and soft constraints. * */ -public class CheckCoherencyHardSoft { +public final class CheckCoherencyHardSoft { private static final Logger LOG = LoggerFactory.getLogger(CheckCoherencyHardSoft.class); @@ -41,4 +41,7 @@ public class CheckCoherencyHardSoft { return result; } + public CheckCoherencyHardSoft() { + } + } diff --git a/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerCompliancyCheck.java b/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerCompliancyCheck.java index 70c0df798..72995e6ba 100644 --- a/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerCompliancyCheck.java +++ b/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerCompliancyCheck.java @@ -17,7 +17,7 @@ import org.slf4j.LoggerFactory; * Class for checking service sdnc-request-header compliancy. * */ -public class ServicehandlerCompliancyCheck { +public final class ServicehandlerCompliancyCheck { private static final Logger LOG = LoggerFactory.getLogger(ServicehandlerCompliancyCheck.class); @@ -82,4 +82,7 @@ public class ServicehandlerCompliancyCheck { return new ComplianceCheckResult(result, message); } + public ServicehandlerCompliancyCheck() { + } + } diff --git a/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerTxRxCheck.java b/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerTxRxCheck.java index 70b488eb2..367e26dc1 100644 --- a/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerTxRxCheck.java +++ b/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerTxRxCheck.java @@ -22,7 +22,7 @@ import org.slf4j.LoggerFactory; * Class for checking missing info on Tx/Rx for A/Z end. * */ -public class ServicehandlerTxRxCheck { +public final class ServicehandlerTxRxCheck { private static final Logger LOG = LoggerFactory.getLogger(ServicehandlerTxRxCheck.class); @@ -168,4 +168,7 @@ public class ServicehandlerTxRxCheck { return new ComplianceCheckResult(result, message); } + public ServicehandlerTxRxCheck() { + } + } diff --git a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/PathDescriptionConverter.java b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/PathDescriptionConverter.java index 92d8f3a25..c1a949f57 100644 --- a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/PathDescriptionConverter.java +++ b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/PathDescriptionConverter.java @@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.service.implementation.request.input.PathDescription; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.service.implementation.request.input.PathDescriptionBuilder; -public class PathDescriptionConverter { +public final class PathDescriptionConverter { public static PathDescription getStub(org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface .servicepath.rev170426.service.implementation.request.input.PathDescription concrete) { @@ -31,4 +31,7 @@ public class PathDescriptionConverter { concreteBuilder.setZToADirection(stub.getZToADirection()); return concreteBuilder.build(); } + + private PathDescriptionConverter() { + } } diff --git a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceAEndConverter.java b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceAEndConverter.java index 79439a7d1..471d0974f 100644 --- a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceAEndConverter.java +++ b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceAEndConverter.java @@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.service.implementation.request.input.ServiceAEnd; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.service.implementation.request.input.ServiceAEndBuilder; -public class ServiceAEndConverter { +public final class ServiceAEndConverter { public static ServiceAEnd getStub(org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath .rev170426.service.implementation.request.input.ServiceAEnd concrete) { @@ -39,4 +39,7 @@ public class ServiceAEndConverter { concreteBuilder.setTxDirection(stub.getTxDirection()); return concreteBuilder.build(); } + + private ServiceAEndConverter() { + } } diff --git a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceDeleteInputConverter.java b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceDeleteInputConverter.java index 1f4b59e6b..412afb814 100644 --- a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceDeleteInputConverter.java +++ b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceDeleteInputConverter.java @@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceDeleteInput; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceDeleteInputBuilder; -public class ServiceDeleteInputConverter { +public final class ServiceDeleteInputConverter { public static ServiceDeleteInput getStub(org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface .servicepath.rev170426.ServiceDeleteInput concrete) { @@ -31,4 +31,6 @@ public class ServiceDeleteInputConverter { return concreteBuilder.build(); } + private ServiceDeleteInputConverter() { + } } diff --git a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceDeleteOutputConverter.java b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceDeleteOutputConverter.java index 9de86cf78..b6ea691ae 100644 --- a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceDeleteOutputConverter.java +++ b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceDeleteOutputConverter.java @@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceDeleteOutput; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceDeleteOutputBuilder; -public class ServiceDeleteOutputConverter { +public final class ServiceDeleteOutputConverter { public static ServiceDeleteOutput getStub( @@ -34,4 +34,6 @@ public class ServiceDeleteOutputConverter { return concreteBuilder.build(); } + private ServiceDeleteOutputConverter() { + } } diff --git a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceImplementationRequestInputConverter.java b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceImplementationRequestInputConverter.java index cea7a31c4..985cb64c9 100644 --- a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceImplementationRequestInputConverter.java +++ b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceImplementationRequestInputConverter.java @@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceImplementationRequestInput; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceImplementationRequestInputBuilder; -public class ServiceImplementationRequestInputConverter { +public final class ServiceImplementationRequestInputConverter { public static ServiceImplementationRequestInput getStub(org.opendaylight.yang.gen.v1.http.org.transportpce .b.c._interface.servicepath.rev170426.ServiceImplementationRequestInput concrete) { @@ -37,4 +37,7 @@ public class ServiceImplementationRequestInputConverter { return concreteBuilder.build(); } + private ServiceImplementationRequestInputConverter() { + } + } diff --git a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceImplementationRequestOutputConverter.java b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceImplementationRequestOutputConverter.java index d44e4848f..61aa49650 100644 --- a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceImplementationRequestOutputConverter.java +++ b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceImplementationRequestOutputConverter.java @@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceImplementationRequestOutput; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceImplementationRequestOutputBuilder; -public class ServiceImplementationRequestOutputConverter { +public final class ServiceImplementationRequestOutputConverter { public static ServiceImplementationRequestOutput getStub(org.opendaylight.yang.gen.v1.http.org.transportpce .b.c._interface.servicepath.rev170426.ServiceImplementationRequestOutput concrete) { @@ -29,4 +29,7 @@ public class ServiceImplementationRequestOutputConverter { return concreteBuilder.build(); } + private ServiceImplementationRequestOutputConverter() { + } + } diff --git a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceZEndConverter.java b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceZEndConverter.java index ed76c320c..c830b2dda 100644 --- a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceZEndConverter.java +++ b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceZEndConverter.java @@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.service.implementation.request.input.ServiceZEnd; import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.service.implementation.request.input.ServiceZEndBuilder; -public class ServiceZEndConverter { +public final class ServiceZEndConverter { public static ServiceZEnd getStub( org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.service.implementation .request.input.ServiceZEnd concrete) { @@ -40,4 +40,7 @@ public class ServiceZEndConverter { concreteBuilder.setTxDirection(stub.getTxDirection()); return concreteBuilder.build(); } + + private ServiceZEndConverter(){ + } } diff --git a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/utils/ServiceDataUtils.java b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/utils/ServiceDataUtils.java index 8342588c2..acdb22885 100644 --- a/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/utils/ServiceDataUtils.java +++ b/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/utils/ServiceDataUtils.java @@ -36,7 +36,7 @@ import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev170426.ServicePathNotificationTypes; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.DateAndTime; -public class ServiceDataUtils { +public final class ServiceDataUtils { public static ServiceCreateInput buildServiceCreateInput() { @@ -255,4 +255,7 @@ public class ServiceDataUtils { .build()); } + private ServiceDataUtils() { + } + } -- 2.36.6