From 24d436f1b7a0909804660afcfc2758d8c5cadc6a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jonas=20M=C3=A5rtensson?= Date: Fri, 9 Feb 2024 08:07:45 +0000 Subject: [PATCH] Allow 0 dB spanloss in power management MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Currently, power management, and therefore also service creation, fails if any spanloss is 0 dB. There is nothing in the OpenROADM spec that says 0 dB is out of range. The spanloss range is defined as: Min: 0, Max: 27 dB JIRA: TRNSPRTPCE-785 Signed-off-by: Jonas MÃ¥rtensson Change-Id: I62969b7cbe5c9ba06cdbfa51ee5db87c372479ea --- .../opendaylight/transportpce/olm/power/PowerMgmtImpl.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/olm/src/main/java/org/opendaylight/transportpce/olm/power/PowerMgmtImpl.java b/olm/src/main/java/org/opendaylight/transportpce/olm/power/PowerMgmtImpl.java index cbfc365ad..dda3592b2 100644 --- a/olm/src/main/java/org/opendaylight/transportpce/olm/power/PowerMgmtImpl.java +++ b/olm/src/main/java/org/opendaylight/transportpce/olm/power/PowerMgmtImpl.java @@ -197,8 +197,8 @@ public class PowerMgmtImpl implements PowerMgmt { LOG.info("Spanloss TX is {}", spanLossTx); // TODO: The span-loss limits should be obtained from optical specifications - if (spanLossTx == null || spanLossTx.intValue() <= 0 || spanLossTx.intValue() > 27) { - LOG.error("Power Value is null: spanLossTx null or out of openROADM range ]0,27] {}", + if (spanLossTx == null || spanLossTx.intValue() < 0 || spanLossTx.intValue() > 27) { + LOG.error("Power Value is null: spanLossTx null or out of openROADM range [0,27] {}", spanLossTx); return false; } -- 2.36.6