Code Review / yangtools.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 4e6fec1) | patch
Fix immutable NormalizedNode equality 58/100358/3
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 1 Apr 2022 21:37:22 +0000 (23:37 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Fri, 1 Apr 2022 23:49:49 +0000 (01:49 +0200)
commitd7afd8f9c3dd23433656663dbcf536b8a898f5d1
tree91163bd64c344b8b20d2209a9be368d597fa8a43tree | snapshot
parent4e6fec15b3d8b4ec8f666859a2a208711d66a1e0commit | diff
Fix immutable NormalizedNode equality

Equality has always been iffy in our immutable implementations, but we
are now making a decent attempt to implement it. There are three gaps in
that effort, where we only consider known subclasses for comparison of
value part of NormalizedNode.

Address this by providing fallback child comparison and add an explicit
test suite.

JIRA: YANGTOOLS-1417
Change-Id: I36e5bcfc6da06c789595b00b7ad86d973cb34703
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableLeafSetNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableUserLeafSetNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/nodes/AbstractImmutableDataContainerNode.java diff | blob | history
data/yang-data-impl/src/test/java/org/opendaylight/yangtools/yang/data/impl/schema/nodes/YT1417Test.java [new file with mode: 0644] blob
OpenDaylight YANG Tools