From: Robert Varga <robert.varga@pantheon.tech>
Date: Tue, 18 Jan 2022 10:28:17 +0000 (+0100)
Subject: Update XXX to a FIXME
X-Git-Tag: v8.0.0~65
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=yangtools.git;a=commitdiff_plain;h=79e84864626ae05287ae82c2edb9fe45f51399fc

Update XXX to a FIXME

Promote a simple note to a full-blown FIXME, as it seems we should be
able to convert BigDecimal more efficiently than we do today.

Change-Id: I50b84a68c961e1bd2f8c8284e3f0f196c6717900
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/Decimal64.java b/common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/Decimal64.java
index 1c9aa753e8..233f9499cb 100644
--- a/common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/Decimal64.java
+++ b/common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/Decimal64.java
@@ -205,7 +205,7 @@ public class Decimal64 extends Number implements CanonicalValue<Decimal64> {
     }
 
     public static Decimal64 valueOf(final BigDecimal decimalVal) {
-        // XXX: we should be able to do something smarter here
+        // FIXME: we should be able to do something smarter here using BigDecimal.unscaledValue() and BigDecimal.scale()
         return valueOf(decimalVal.toPlainString());
     }