From: Robert Varga <robert.varga@pantheon.tech>
Date: Mon, 4 Apr 2022 22:55:39 +0000 (+0200)
Subject: Simplify createFeaturesSet()
X-Git-Tag: v8.0.3~9
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=yangtools.git;a=commitdiff_plain;h=a22f541a07b38a6132129260ca2c4889949cda88

Simplify createFeaturesSet()

We can express this method in terms of a Stream transformation, saving
us an intermediate HashSet.

Change-Id: I26649e4d9d43bf288053dc76c1324db1d7cf9e1e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/parser/yang-parser-rfc7950/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6869Test.java b/parser/yang-parser-rfc7950/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6869Test.java
index 668f7db76a..0ab52503e7 100644
--- a/parser/yang-parser-rfc7950/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6869Test.java
+++ b/parser/yang-parser-rfc7950/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6869Test.java
@@ -16,9 +16,10 @@ import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 
 import com.google.common.collect.ImmutableSet;
+import java.util.Arrays;
 import java.util.Collection;
-import java.util.HashSet;
 import java.util.Set;
+import java.util.stream.Collectors;
 import org.junit.Test;
 import org.opendaylight.yangtools.yang.common.QName;
 import org.opendaylight.yangtools.yang.model.api.DataSchemaNode;
@@ -71,12 +72,9 @@ public class Bug6869Test extends AbstractYangTest {
     }
 
     private static Set<QName> createFeaturesSet(final String... featureNames) {
-        final Set<QName> supportedFeatures = new HashSet<>();
-        for (final String featureName : featureNames) {
-            supportedFeatures.add(QName.create("foo", featureName));
-        }
-
-        return ImmutableSet.copyOf(supportedFeatures);
+        return Arrays.stream(featureNames)
+            .map(featureName -> QName.create("foo", featureName))
+            .collect(Collectors.toUnmodifiableSet());
     }
 
     @Test