From: Robert Varga <robert.varga@pantheon.sk>
Date: Sat, 16 Jan 2016 01:05:31 +0000 (+0100)
Subject: BUG-865: deprecate recursive node instantiation
X-Git-Tag: release/beryllium~22
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=yangtools.git;a=commitdiff_plain;h=f57da82ed313a3c17a5f8b2a7ee3ec5bb5ff4263

BUG-865: deprecate recursive node instantiation

Recursive create() method forces a full materialization, which is slow
and not memory-efficient. Lazily-instantiated nodes work equally well
using less memory.

Change-Id: I320f375090df480c1b376f543cb0b00649b44234
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
---

diff --git a/yang/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/tree/spi/TreeNodeFactory.java b/yang/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/tree/spi/TreeNodeFactory.java
index e728bfaae2..05af016687 100644
--- a/yang/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/tree/spi/TreeNodeFactory.java
+++ b/yang/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/tree/spi/TreeNodeFactory.java
@@ -94,7 +94,10 @@ public final class TreeNodeFactory {
      * @param data data node
      * @param version data node version
      * @return new AbstractTreeNode instance, covering the data tree provided
+     *
+     * @deprecated Use lazy node initialization via {@link #createTreeNode(NormalizedNode, Version)}.
      */
+    @Deprecated
     public static TreeNode createTreeNodeRecursively(final NormalizedNode<?, ?> data, final Version version) {
         if (data instanceof NormalizedNodeContainer<?, ?, ?>) {
             @SuppressWarnings("unchecked")