Code Review / yangtools.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 53b0110) | patch
Improve ImmutableAugmentationNodeBuilder defensiveness 45/95845/1
authorRobert Varga <robert.varga@pantheon.tech>
Mon, 19 Apr 2021 19:41:10 +0000 (21:41 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Mon, 19 Apr 2021 19:43:16 +0000 (21:43 +0200)
commit1e24596294bdc2a57a808b77a2d9862198e4f46e
tree80bc2fa9d03bca286cd0f6ac91a1d9b759e11709tree | snapshot
parent53b0110f611d056c2761190e899acc6d2587718fcommit | diff
Improve ImmutableAugmentationNodeBuilder defensiveness

The check for nested augmentations is rather ugly and will trigger
a secondary UnsupportedOperationException -- simply because we are
accessing getNodeType() even for AugmentationNodes.

Fix the thinko by performing an explicit check first, which also makes
things a wee bit faster.

Change-Id: I001c8d3b7c4a53ddb2c45d7c9157f7b1081dc992
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableAugmentationNodeBuilder.java diff | blob | history
OpenDaylight YANG Tools