From 87308bd2078479fbe9a67561f8c45a479b09a97a Mon Sep 17 00:00:00 2001
From: Robert Varga <robert.varga@pantheon.tech>
Date: Sun, 5 May 2024 13:59:29 +0200
Subject: [PATCH] Define a feature-parent

We have quite a bit of repetition going on, centralize what we can
in a common pom.xml.

Change-Id: Ia42f26e9043a47a918e60c2c7b18d6fecfbfff16
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---
 features/odl-yangtools-codec/pom.xml      | 22 +++---------
 features/odl-yangtools-common/pom.xml     | 22 +++---------
 features/odl-yangtools-data-api/pom.xml   | 22 +++---------
 features/odl-yangtools-data/pom.xml       | 22 +++---------
 features/odl-yangtools-export/pom.xml     | 22 +++---------
 features/odl-yangtools-netty/pom.xml      | 22 +++---------
 features/odl-yangtools-parser-api/pom.xml | 22 +++---------
 features/odl-yangtools-parser/pom.xml     | 22 +++---------
 features/odl-yangtools-util/pom.xml       | 22 +++---------
 features/odl-yangtools-xpath-api/pom.xml  | 22 +++---------
 features/odl-yangtools-xpath/pom.xml      | 22 +++---------
 features/parent/pom.xml                   | 44 +++++++++++++++++++++++
 features/pom.xml                          |  2 ++
 13 files changed, 90 insertions(+), 198 deletions(-)
 create mode 100644 features/parent/pom.xml

diff --git a/features/odl-yangtools-codec/pom.xml b/features/odl-yangtools-codec/pom.xml
index 00e6d2fe7b..241df7a836 100644
--- a/features/odl-yangtools-codec/pom.xml
+++ b/features/odl-yangtools-codec/pom.xml
@@ -10,31 +10,17 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>org.opendaylight.odlparent</groupId>
-        <artifactId>template-feature-parent</artifactId>
-        <version>13.1.2</version>
-        <relativePath/>
+        <groupId>org.opendaylight.yangtools</groupId>
+        <artifactId>feature-parent</artifactId>
+        <version>13.0.6-SNAPSHOT</version>
+        <relativePath>../parent</relativePath>
     </parent>
 
-    <groupId>org.opendaylight.yangtools</groupId>
     <artifactId>odl-yangtools-codec</artifactId>
-    <version>13.0.6-SNAPSHOT</version>
     <packaging>feature</packaging>
     <name>OpenDaylight :: Yangtools :: Data Codecs</name>
     <description>Serialization/deserialization support for various formats</description>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>org.opendaylight.yangtools</groupId>
-                <artifactId>yangtools-artifacts</artifactId>
-                <version>${project.version}</version>
-                <scope>import</scope>
-                <type>pom</type>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.odlparent</groupId>
diff --git a/features/odl-yangtools-common/pom.xml b/features/odl-yangtools-common/pom.xml
index bf526eed9f..2cbb4f5a07 100644
--- a/features/odl-yangtools-common/pom.xml
+++ b/features/odl-yangtools-common/pom.xml
@@ -10,31 +10,17 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>org.opendaylight.odlparent</groupId>
-        <artifactId>template-feature-parent</artifactId>
-        <version>13.1.2</version>
-        <relativePath/>
+        <groupId>org.opendaylight.yangtools</groupId>
+        <artifactId>feature-parent</artifactId>
+        <version>13.0.6-SNAPSHOT</version>
+        <relativePath>../parent</relativePath>
     </parent>
 
-    <groupId>org.opendaylight.yangtools</groupId>
     <artifactId>odl-yangtools-common</artifactId>
-    <version>13.0.6-SNAPSHOT</version>
     <packaging>feature</packaging>
     <name>OpenDaylight :: Yangtools :: Common definitions</name>
     <description>Common YANG-related definitions</description>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>org.opendaylight.yangtools</groupId>
-                <artifactId>yangtools-artifacts</artifactId>
-                <version>${project.version}</version>
-                <scope>import</scope>
-                <type>pom</type>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.yangtools</groupId>
diff --git a/features/odl-yangtools-data-api/pom.xml b/features/odl-yangtools-data-api/pom.xml
index 9e531dd4b2..96f25de29e 100644
--- a/features/odl-yangtools-data-api/pom.xml
+++ b/features/odl-yangtools-data-api/pom.xml
@@ -10,31 +10,17 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>org.opendaylight.odlparent</groupId>
-        <artifactId>template-feature-parent</artifactId>
-        <version>13.1.2</version>
-        <relativePath/>
+        <groupId>org.opendaylight.yangtools</groupId>
+        <artifactId>feature-parent</artifactId>
+        <version>13.0.6-SNAPSHOT</version>
+        <relativePath>../parent</relativePath>
     </parent>
 
-    <groupId>org.opendaylight.yangtools</groupId>
     <artifactId>odl-yangtools-data-api</artifactId>
-    <version>13.0.6-SNAPSHOT</version>
     <packaging>feature</packaging>
     <name>OpenDaylight :: Yangtools :: Data API</name>
     <description>YANG modeled data APIs</description>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>org.opendaylight.yangtools</groupId>
-                <artifactId>yangtools-artifacts</artifactId>
-                <version>${project.version}</version>
-                <scope>import</scope>
-                <type>pom</type>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.yangtools</groupId>
diff --git a/features/odl-yangtools-data/pom.xml b/features/odl-yangtools-data/pom.xml
index 3ddccc493d..550308ca54 100644
--- a/features/odl-yangtools-data/pom.xml
+++ b/features/odl-yangtools-data/pom.xml
@@ -10,31 +10,17 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>org.opendaylight.odlparent</groupId>
-        <artifactId>template-feature-parent</artifactId>
-        <version>13.1.2</version>
-        <relativePath/>
+        <groupId>org.opendaylight.yangtools</groupId>
+        <artifactId>feature-parent</artifactId>
+        <version>13.0.6-SNAPSHOT</version>
+        <relativePath>../parent</relativePath>
     </parent>
 
-    <groupId>org.opendaylight.yangtools</groupId>
     <artifactId>odl-yangtools-data</artifactId>
-    <version>13.0.6-SNAPSHOT</version>
     <packaging>feature</packaging>
     <name>OpenDaylight :: Yangtools :: Data Reference Implementation</name>
     <description>YANG modeled data implementation</description>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>org.opendaylight.yangtools</groupId>
-                <artifactId>yangtools-artifacts</artifactId>
-                <version>${project.version}</version>
-                <scope>import</scope>
-                <type>pom</type>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.odlparent</groupId>
diff --git a/features/odl-yangtools-export/pom.xml b/features/odl-yangtools-export/pom.xml
index 40c1eb4ee9..6a6e5aec4b 100644
--- a/features/odl-yangtools-export/pom.xml
+++ b/features/odl-yangtools-export/pom.xml
@@ -10,31 +10,17 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>org.opendaylight.odlparent</groupId>
-        <artifactId>template-feature-parent</artifactId>
-        <version>13.1.2</version>
-        <relativePath/>
+        <groupId>org.opendaylight.yangtools</groupId>
+        <artifactId>feature-parent</artifactId>
+        <version>13.0.6-SNAPSHOT</version>
+        <relativePath>../parent</relativePath>
     </parent>
 
-    <groupId>org.opendaylight.yangtools</groupId>
     <artifactId>odl-yangtools-export</artifactId>
-    <version>13.0.6-SNAPSHOT</version>
     <packaging>feature</packaging>
     <name>OpenDaylight :: Yangtools :: Export</name>
     <description>YANG model export</description>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>org.opendaylight.yangtools</groupId>
-                <artifactId>yangtools-artifacts</artifactId>
-                <version>${project.version}</version>
-                <scope>import</scope>
-                <type>pom</type>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.yangtools</groupId>
diff --git a/features/odl-yangtools-netty/pom.xml b/features/odl-yangtools-netty/pom.xml
index aad09ff493..69494b4f11 100644
--- a/features/odl-yangtools-netty/pom.xml
+++ b/features/odl-yangtools-netty/pom.xml
@@ -10,31 +10,17 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>org.opendaylight.odlparent</groupId>
-        <artifactId>template-feature-parent</artifactId>
-        <version>13.1.2</version>
-        <relativePath/>
+        <groupId>org.opendaylight.yangtools</groupId>
+        <artifactId>feature-parent</artifactId>
+        <version>13.0.6-SNAPSHOT</version>
+        <relativePath>../parent</relativePath>
     </parent>
 
-    <groupId>org.opendaylight.yangtools</groupId>
     <artifactId>odl-yangtools-netty</artifactId>
-    <version>13.0.6-SNAPSHOT</version>
     <packaging>feature</packaging>
     <name>OpenDaylight :: Yangtools :: Netty integration</name>
     <description>YANG Tools/netty-buffer utilities</description>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>org.opendaylight.yangtools</groupId>
-                <artifactId>yangtools-artifacts</artifactId>
-                <version>${project.version}</version>
-                <scope>import</scope>
-                <type>pom</type>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.odlparent</groupId>
diff --git a/features/odl-yangtools-parser-api/pom.xml b/features/odl-yangtools-parser-api/pom.xml
index 08e12ff806..39c68bd067 100644
--- a/features/odl-yangtools-parser-api/pom.xml
+++ b/features/odl-yangtools-parser-api/pom.xml
@@ -10,31 +10,17 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>org.opendaylight.odlparent</groupId>
-        <artifactId>template-feature-parent</artifactId>
-        <version>13.1.2</version>
-        <relativePath/>
+        <groupId>org.opendaylight.yangtools</groupId>
+        <artifactId>feature-parent</artifactId>
+        <version>13.0.6-SNAPSHOT</version>
+        <relativePath>../parent</relativePath>
     </parent>
 
-    <groupId>org.opendaylight.yangtools</groupId>
     <artifactId>odl-yangtools-parser-api</artifactId>
-    <version>13.0.6-SNAPSHOT</version>
     <packaging>feature</packaging>
     <name>OpenDaylight :: Yangtools :: Parser API</name>
     <description>YANG metamodel and parser APIs</description>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>org.opendaylight.yangtools</groupId>
-                <artifactId>yangtools-artifacts</artifactId>
-                <version>${project.version}</version>
-                <scope>import</scope>
-                <type>pom</type>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.yangtools</groupId>
diff --git a/features/odl-yangtools-parser/pom.xml b/features/odl-yangtools-parser/pom.xml
index 6ec511478f..ab1b206f06 100644
--- a/features/odl-yangtools-parser/pom.xml
+++ b/features/odl-yangtools-parser/pom.xml
@@ -10,31 +10,17 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>org.opendaylight.odlparent</groupId>
-        <artifactId>template-feature-parent</artifactId>
-        <version>13.1.2</version>
-        <relativePath/>
+        <groupId>org.opendaylight.yangtools</groupId>
+        <artifactId>feature-parent</artifactId>
+        <version>13.0.6-SNAPSHOT</version>
+        <relativePath>../parent</relativePath>
     </parent>
 
-    <groupId>org.opendaylight.yangtools</groupId>
     <artifactId>odl-yangtools-parser</artifactId>
-    <version>13.0.6-SNAPSHOT</version>
     <packaging>feature</packaging>
     <name>OpenDaylight :: Yangtools :: Parser </name>
     <description>YANG parser reference implementation</description>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>org.opendaylight.yangtools</groupId>
-                <artifactId>yangtools-artifacts</artifactId>
-                <version>${project.version}</version>
-                <scope>import</scope>
-                <type>pom</type>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.odlparent</groupId>
diff --git a/features/odl-yangtools-util/pom.xml b/features/odl-yangtools-util/pom.xml
index 6b01f54e1d..e6b53e16f8 100644
--- a/features/odl-yangtools-util/pom.xml
+++ b/features/odl-yangtools-util/pom.xml
@@ -10,31 +10,17 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>org.opendaylight.odlparent</groupId>
-        <artifactId>template-feature-parent</artifactId>
-        <version>13.1.2</version>
-        <relativePath/>
+        <groupId>org.opendaylight.yangtools</groupId>
+        <artifactId>feature-parent</artifactId>
+        <version>13.0.6-SNAPSHOT</version>
+        <relativePath>../parent</relativePath>
     </parent>
 
-    <groupId>org.opendaylight.yangtools</groupId>
     <artifactId>odl-yangtools-util</artifactId>
-    <version>13.0.6-SNAPSHOT</version>
     <packaging>feature</packaging>
     <name>OpenDaylight :: Yangtools :: Utilities</name>
     <description>YANG Tools common concepts and utilities</description>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>org.opendaylight.yangtools</groupId>
-                <artifactId>yangtools-artifacts</artifactId>
-                <version>${project.version}</version>
-                <scope>import</scope>
-                <type>pom</type>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>tech.pantheon.triemap</groupId>
diff --git a/features/odl-yangtools-xpath-api/pom.xml b/features/odl-yangtools-xpath-api/pom.xml
index b35588d059..f3357a7226 100644
--- a/features/odl-yangtools-xpath-api/pom.xml
+++ b/features/odl-yangtools-xpath-api/pom.xml
@@ -10,30 +10,16 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>org.opendaylight.odlparent</groupId>
-        <artifactId>template-feature-parent</artifactId>
-        <version>13.1.2</version>
-        <relativePath/>
+        <groupId>org.opendaylight.yangtools</groupId>
+        <artifactId>feature-parent</artifactId>
+        <version>13.0.6-SNAPSHOT</version>
+        <relativePath>../parent</relativePath>
     </parent>
 
-    <groupId>org.opendaylight.yangtools</groupId>
     <artifactId>odl-yangtools-xpath-api</artifactId>
-    <version>13.0.6-SNAPSHOT</version>
     <packaging>feature</packaging>
     <name>OpenDaylight :: Yangtools :: XPath API</name>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>org.opendaylight.yangtools</groupId>
-                <artifactId>yangtools-artifacts</artifactId>
-                <version>13.0.6-SNAPSHOT</version>
-                <scope>import</scope>
-                <type>pom</type>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.yangtools</groupId>
diff --git a/features/odl-yangtools-xpath/pom.xml b/features/odl-yangtools-xpath/pom.xml
index 40e333b0d4..a9f99208e1 100644
--- a/features/odl-yangtools-xpath/pom.xml
+++ b/features/odl-yangtools-xpath/pom.xml
@@ -10,31 +10,17 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>org.opendaylight.odlparent</groupId>
-        <artifactId>template-feature-parent</artifactId>
-        <version>13.1.2</version>
-        <relativePath/>
+        <groupId>org.opendaylight.yangtools</groupId>
+        <artifactId>feature-parent</artifactId>
+        <version>13.0.6-SNAPSHOT</version>
+        <relativePath>../parent</relativePath>
     </parent>
 
-    <groupId>org.opendaylight.yangtools</groupId>
     <artifactId>odl-yangtools-xpath</artifactId>
-    <version>13.0.6-SNAPSHOT</version>
     <packaging>feature</packaging>
     <name>OpenDaylight :: Yangtools :: XPath support</name>
     <description>YANG XPath support</description>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>org.opendaylight.yangtools</groupId>
-                <artifactId>yangtools-artifacts</artifactId>
-                <version>${project.version}</version>
-                <scope>import</scope>
-                <type>pom</type>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.odlparent</groupId>
diff --git a/features/parent/pom.xml b/features/parent/pom.xml
new file mode 100644
index 0000000000..9ea1d2b754
--- /dev/null
+++ b/features/parent/pom.xml
@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Copyright (c) 2024 PANTHEON.tech, s.r.o. and others.  All rights reserved.
+
+ This program and the accompanying materials are made available under the
+ terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ and is available at http://www.eclipse.org/legal/epl-v10.html
+ -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <parent>
+        <groupId>org.opendaylight.odlparent</groupId>
+        <artifactId>template-feature-parent</artifactId>
+        <version>13.1.2</version>
+        <relativePath/>
+    </parent>
+
+    <groupId>org.opendaylight.yangtools</groupId>
+    <artifactId>feature-parent</artifactId>
+    <version>13.0.6-SNAPSHOT</version>
+    <packaging>pom</packaging>
+    <name>${project.artifactId}</name>
+    <description>Feature parent (based on template-feature-parent)</description>
+
+    <dependencyManagement>
+        <dependencies>
+            <dependency>
+                <groupId>org.opendaylight.yangtools</groupId>
+                <artifactId>yangtools-artifacts</artifactId>
+                <version>${project.version}</version>
+                <scope>import</scope>
+                <type>pom</type>
+            </dependency>
+        </dependencies>
+    </dependencyManagement>
+
+    <scm>
+        <connection>scm:git:ssh://git.opendaylight.org:29418/yangtools.git</connection>
+        <developerConnection>scm:git:ssh://git.opendaylight.org:29418/yangtools.git</developerConnection>
+        <tag>HEAD</tag>
+        <url>https://wiki.opendaylight.org/display/ODL/YANG+Tools</url>
+    </scm>
+</project>
diff --git a/features/pom.xml b/features/pom.xml
index f811f882f4..9d8a41ffaf 100644
--- a/features/pom.xml
+++ b/features/pom.xml
@@ -28,6 +28,8 @@
     </properties>
 
     <modules>
+        <module>parent</module>
+
         <!-- Stable features -->
         <module>odl-yangtools-codec</module>
         <module>odl-yangtools-common</module>
-- 
2.36.6