From 4216ac5e7807383568681fa6b09e49a26c33f7c5 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Sun, 10 Apr 2022 02:14:07 +0200 Subject: [PATCH] Improve SemVer.equals() Use instanceof pattern to simplify the method. Change-Id: If2f7cbdb6c6c0835eeb038a7ce5e993cddec8335 Signed-off-by: Robert Varga --- .../org/opendaylight/yangtools/concepts/SemVer.java | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/common/concepts/src/main/java/org/opendaylight/yangtools/concepts/SemVer.java b/common/concepts/src/main/java/org/opendaylight/yangtools/concepts/SemVer.java index 7290be85ae..eda29f7cc3 100644 --- a/common/concepts/src/main/java/org/opendaylight/yangtools/concepts/SemVer.java +++ b/common/concepts/src/main/java/org/opendaylight/yangtools/concepts/SemVer.java @@ -112,15 +112,8 @@ public final class SemVer implements Comparable, Serializable { @Override public boolean equals(final Object obj) { - if (this == obj) { - return true; - } - if (!(obj instanceof SemVer)) { - return false; - } - - final SemVer o = (SemVer) obj; - return major == o.major && minor == o.minor && patch == o.patch; + return this == obj || obj instanceof SemVer other && major == other.major && minor == other.minor + && patch == other.patch; } @Override -- 2.36.6