From 4d8d405cb27c07e48a4d308766dafb66b372c25c Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Tue, 12 Jan 2016 22:13:07 +0100 Subject: [PATCH] Simplify Utils.parseStatus() No need for a local variable, and use proper log formatting instead of string concat. Change-Id: Id5fd1dba61cf984a3aa08f4b2b7ee367ff24e307 Signed-off-by: Robert Varga --- .../yang/parser/stmt/rfc6020/Utils.java | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/Utils.java b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/Utils.java index 1d976c5aa0..3654785eb8 100644 --- a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/Utils.java +++ b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/Utils.java @@ -8,7 +8,6 @@ package org.opendaylight.yangtools.yang.parser.stmt.rfc6020; import static org.opendaylight.yangtools.yang.parser.spi.meta.StmtContextUtils.firstAttributeOf; - import com.google.common.base.CharMatcher; import com.google.common.base.Preconditions; import com.google.common.base.Splitter; @@ -319,23 +318,17 @@ public final class Utils { } public static Status parseStatus(final String value) { - - Status status = null; switch (value) { case "current": - status = Status.CURRENT; - break; + return Status.CURRENT; case "deprecated": - status = Status.DEPRECATED; - break; + return Status.DEPRECATED; case "obsolete": - status = Status.OBSOLETE; - break; + return Status.OBSOLETE; default: - LOG.warn("Invalid 'status' statement: " + value); + LOG.warn("Invalid 'status' statement: {}", value); + return null; } - - return status; } public static Date getLatestRevision(final Iterable> subStmts) { -- 2.36.6