From 88a74a9c6ff86c58f80455a8327acb235ab7a60f Mon Sep 17 00:00:00 2001
From: Robert Varga <robert.varga@pantheon.tech>
Date: Fri, 13 Nov 2020 23:05:42 +0100
Subject: [PATCH] Do not use @NonNullByDefault in ItemOrder

Using @NonNullByDefault limits usability, remove it again.

JIRA: YANGTOOLS-1170
Change-Id: I656c04203f48406142977fb6aaa2cab8bb435f78
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---
 .../org/opendaylight/yangtools/concepts/ItemOrder.java   | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/common/concepts/src/main/java/org/opendaylight/yangtools/concepts/ItemOrder.java b/common/concepts/src/main/java/org/opendaylight/yangtools/concepts/ItemOrder.java
index 03d2b0d3aa..072afc1a0d 100644
--- a/common/concepts/src/main/java/org/opendaylight/yangtools/concepts/ItemOrder.java
+++ b/common/concepts/src/main/java/org/opendaylight/yangtools/concepts/ItemOrder.java
@@ -11,7 +11,7 @@ import com.google.common.annotations.Beta;
 import java.util.Collection;
 import java.util.List;
 import java.util.Set;
-import org.eclipse.jdt.annotation.NonNullByDefault;
+import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.jdt.annotation.Nullable;
 
 /**
@@ -23,7 +23,6 @@ import org.eclipse.jdt.annotation.Nullable;
  * @param <T> Item order type
  */
 @Beta
-@NonNullByDefault
 public interface ItemOrder<T extends ItemOrder<T>> {
     /**
      * Items are ordered and their order is significant. A {@link List} is an example of a collection which conforms to
@@ -55,7 +54,7 @@ public interface ItemOrder<T extends ItemOrder<T>> {
          * {@link List#equals(Object)}.
          */
         @Override
-        boolean equals(@Nullable Object obj);
+        boolean equals(Object obj);
     }
 
     /**
@@ -92,7 +91,7 @@ public interface ItemOrder<T extends ItemOrder<T>> {
          * This contract is also exposed through {@link #itemOrder()}.
          */
         @Override
-        boolean equals(@Nullable Object obj);
+        boolean equals(Object obj);
     }
 
     /**
@@ -101,7 +100,7 @@ public interface ItemOrder<T extends ItemOrder<T>> {
      *
      * @return Item order class.
      */
-    Class<T> itemOrder();
+    @NonNull Class<T> itemOrder();
 
     /**
      * {@link ItemOrder} has impact on {@link #hashCode()}.
-- 
2.36.6