* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
-
package org.opendaylight.ovsdb.hwvtepsouthbound.transact;
-import com.google.common.base.Optional;
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
+import java.util.Optional;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import org.apache.commons.lang3.tuple.Pair;
-import org.opendaylight.controller.md.sal.binding.api.DataBroker;
-import org.opendaylight.controller.md.sal.binding.api.DataTreeModification;
-import org.opendaylight.controller.md.sal.binding.api.ReadWriteTransaction;
-import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType;
+import org.opendaylight.mdsal.binding.api.DataBroker;
+import org.opendaylight.mdsal.binding.api.DataTreeModification;
+import org.opendaylight.mdsal.binding.api.ReadWriteTransaction;
+import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
import org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionInstance;
import org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepDeviceInfo;
import org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepSouthboundUtil;
import org.opendaylight.ovsdb.lib.notation.UUID;
-import org.opendaylight.ovsdb.utils.mdsal.utils.ControllerMdsalUtils;
+import org.opendaylight.ovsdb.utils.mdsal.utils.MdsalUtils;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.IpAddress;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.EncapsulationTypeBase;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentation;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.hwvtep.physical._switch.attributes.TunnelsKey;
import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node;
import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.node.TerminationPoint;
+import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.node.TerminationPointKey;
import org.opendaylight.yangtools.yang.binding.Identifiable;
import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
import org.slf4j.Logger;
private final Collection<DataTreeModification<Node>> changes;
long transactionId = 0;
- public HwvtepOperationalState(DataBroker db, HwvtepConnectionInstance connectionInstance,
- Collection<DataTreeModification<Node>> changes) {
+ public HwvtepOperationalState(final DataBroker db, final HwvtepConnectionInstance connectionInstance,
+ final Collection<DataTreeModification<Node>> changes) {
this.connectionInstance = connectionInstance;
- this.deviceInfo = connectionInstance.getDeviceInfo();
+ deviceInfo = connectionInstance.getDeviceInfo();
this.db = db;
this.changes = changes;
- this.transaction = db.newReadWriteTransaction();
+ transaction = db.newReadWriteTransaction();
}
- public HwvtepOperationalState(HwvtepConnectionInstance connectionInstance) {
+ public HwvtepOperationalState(final HwvtepConnectionInstance connectionInstance) {
this.connectionInstance = connectionInstance;
- this.deviceInfo = connectionInstance.getDeviceInfo();
- this.db = connectionInstance.getDataBroker();
- this.changes = null;
+ deviceInfo = connectionInstance.getDeviceInfo();
+ db = connectionInstance.getDataBroker();
+ changes = null;
transaction = connectionInstance.getDataBroker().newReadWriteTransaction();
- Optional<Node> readNode = new ControllerMdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL,
+ Optional<Node> readNode = new MdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL,
connectionInstance.getInstanceIdentifier());
if (readNode.isPresent()) {
operationalNodes.put(connectionInstance.getInstanceIdentifier(), readNode.get());
operationalNodes.put(connectionInstance.getInstanceIdentifier(), globalOperNode);
HwvtepGlobalAugmentation globalAugmentation = globalOperNode.augmentation(HwvtepGlobalAugmentation.class);
if (globalAugmentation != null) {
- if (!HwvtepSouthboundUtil.isEmpty(globalAugmentation.getSwitches())) {
+ if (!HwvtepSouthboundUtil.isEmptyMap(globalAugmentation.getSwitches())) {
operationalNodes.put((InstanceIdentifier<Node>)
- globalAugmentation.getSwitches().get(0).getSwitchRef().getValue(), psNode);
+ globalAugmentation.getSwitches().values().iterator().next().getSwitchRef().getValue(), psNode);
}
}
}
if (nodeCreateOrUpdate != null) {
transaction = db.newReadWriteTransaction();
for (Entry<InstanceIdentifier<Node>, Node> entry: nodeCreateOrUpdate.entrySet()) {
- Optional<Node> readNode = new ControllerMdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL,
+ Optional<Node> readNode = new MdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL,
entry.getKey());
//add related globalNode or physicalSwitchNode to operationalNodes map
//for example, when creating physical port, logical switch is needed
PhysicalSwitchAugmentation psAugmentation =
readNode.get().augmentation(PhysicalSwitchAugmentation.class);
if (hgAugmentation != null && hgAugmentation.getSwitches() != null) {
- for (Switches pswitch : hgAugmentation.getSwitches()) {
+ for (Switches pswitch : hgAugmentation.getSwitches().values()) {
@SuppressWarnings("unchecked")
InstanceIdentifier<Node> psNodeIid =
(InstanceIdentifier<Node>) pswitch.getSwitchRef().getValue();
Optional<Node> psNode =
- new ControllerMdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL, psNodeIid);
+ new MdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL, psNodeIid);
if (psNode.isPresent()) {
operationalNodes.put(psNodeIid, psNode.get());
}
@SuppressWarnings("unchecked")
InstanceIdentifier<Node> hgNodeIid =
(InstanceIdentifier<Node>) psAugmentation.getManagedBy().getValue();
- Optional<Node> hgNode = new ControllerMdsalUtils(db).readOptional(
+ Optional<Node> hgNode = new MdsalUtils(db).readOptional(
LogicalDatastoreType.OPERATIONAL, hgNodeIid);
if (hgNode.isPresent()) {
operationalNodes.put(hgNodeIid, hgNode.get());
}
}
- public Optional<Node> getGlobalNode(InstanceIdentifier<?> iid) {
+ public Optional<Node> getGlobalNode(final InstanceIdentifier<?> iid) {
InstanceIdentifier<Node> nodeIid = iid.firstIdentifierOf(Node.class);
- return Optional.fromNullable(operationalNodes.get(nodeIid));
+ return Optional.ofNullable(operationalNodes.get(nodeIid));
}
- public Optional<HwvtepGlobalAugmentation> getHwvtepGlobalAugmentation(InstanceIdentifier<?> iid) {
- Preconditions.checkNotNull(iid);
- Optional<Node> nodeOptional = getGlobalNode(iid);
+ public Optional<HwvtepGlobalAugmentation> getHwvtepGlobalAugmentation(final InstanceIdentifier<?> iid) {
+ Optional<Node> nodeOptional = getGlobalNode(requireNonNull(iid));
if (nodeOptional.isPresent()) {
- return Optional.fromNullable(nodeOptional.get().augmentation(HwvtepGlobalAugmentation.class));
+ return Optional.ofNullable(nodeOptional.get().augmentation(HwvtepGlobalAugmentation.class));
}
- return Optional.absent();
+ return Optional.empty();
}
- public Optional<PhysicalSwitchAugmentation> getPhysicalSwitchAugmentation(InstanceIdentifier<?> iid) {
- Preconditions.checkNotNull(iid);
- Optional<Node> nodeOptional = getGlobalNode(iid);
+ public Optional<PhysicalSwitchAugmentation> getPhysicalSwitchAugmentation(final InstanceIdentifier<?> iid) {
+ Optional<Node> nodeOptional = getGlobalNode(requireNonNull(iid));
if (nodeOptional.isPresent()) {
- return Optional.fromNullable(nodeOptional.get().augmentation(PhysicalSwitchAugmentation.class));
+ return Optional.ofNullable(nodeOptional.get().augmentation(PhysicalSwitchAugmentation.class));
}
- return Optional.absent();
+ return Optional.empty();
}
- public Optional<List<TerminationPoint>> getTerminationPointList(InstanceIdentifier<?> iid) {
- Preconditions.checkNotNull(iid);
- Optional<Node> nodeOptional = getGlobalNode(iid);
+ public Optional<Map<TerminationPointKey, TerminationPoint>> getTerminationPointList(
+ final InstanceIdentifier<?> iid) {
+ Optional<Node> nodeOptional = getGlobalNode(requireNonNull(iid));
if (nodeOptional.isPresent() && nodeOptional.get().getTerminationPoint() != null) {
- return Optional.fromNullable(nodeOptional.get().getTerminationPoint());
+ return Optional.ofNullable(nodeOptional.get().getTerminationPoint());
}
- return Optional.absent();
+ return Optional.empty();
}
- public Optional<LogicalSwitches> getLogicalSwitches(InstanceIdentifier<?> iid,
- LogicalSwitchesKey logicalSwitchesKey) {
- Preconditions.checkNotNull(iid);
- Optional<HwvtepGlobalAugmentation> nodeOptional = getHwvtepGlobalAugmentation(iid);
+ public Optional<LogicalSwitches> getLogicalSwitches(final InstanceIdentifier<?> iid,
+ final LogicalSwitchesKey logicalSwitchesKey) {
+ Optional<HwvtepGlobalAugmentation> nodeOptional = getHwvtepGlobalAugmentation(requireNonNull(iid));
if (nodeOptional.isPresent()) {
- HwvtepGlobalAugmentation hgAugmentation = nodeOptional.get();
- List<LogicalSwitches> lswitchList = null;
- if (hgAugmentation != null) {
- lswitchList = hgAugmentation.getLogicalSwitches();
- }
- if (lswitchList != null) {
- for (LogicalSwitches lswitch: lswitchList) {
- if (lswitch.key().equals(logicalSwitchesKey)) {
- return Optional.fromNullable(lswitch);
- }
- }
+ LogicalSwitches lswitch = nodeOptional.get().nonnullLogicalSwitches().get(logicalSwitchesKey);
+ if (lswitch != null) {
+ return Optional.of(lswitch);
}
}
- return Optional.absent();
+ return Optional.empty();
}
- public Optional<LogicalSwitches> getLogicalSwitches(InstanceIdentifier<LogicalSwitches> iid) {
- return new ControllerMdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL, iid);
+ public Optional<LogicalSwitches> getLogicalSwitches(final InstanceIdentifier<LogicalSwitches> iid) {
+ return new MdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL, iid);
}
- public Optional<Tunnels> getTunnels(InstanceIdentifier<?> iid, TunnelsKey tunnelsKey) {
- Preconditions.checkNotNull(iid);
- Optional<PhysicalSwitchAugmentation> psOptional = getPhysicalSwitchAugmentation(iid);
+ public Optional<Tunnels> getTunnels(final InstanceIdentifier<?> iid, final TunnelsKey tunnelsKey) {
+ Optional<PhysicalSwitchAugmentation> psOptional = getPhysicalSwitchAugmentation(requireNonNull(iid));
if (psOptional.isPresent()) {
- PhysicalSwitchAugmentation psAugmentation = psOptional.get();
- List<Tunnels> tunnelList = null;
- if (psAugmentation != null) {
- tunnelList = psAugmentation.getTunnels();
- }
- if (tunnelList != null) {
- for (Tunnels tunnel: tunnelList) {
- if (tunnel.key().equals(tunnelsKey)) {
- return Optional.fromNullable(tunnel);
- }
- }
+ Tunnels tunnel = psOptional.get().nonnullTunnels().get(tunnelsKey);
+ if (tunnel != null) {
+ return Optional.of(tunnel);
}
}
- return Optional.absent();
+ return Optional.empty();
}
- public Optional<Tunnels> getTunnels(InstanceIdentifier<Tunnels> iid) {
- Optional<Tunnels> tunnels = new ControllerMdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL, iid);
+ public Optional<Tunnels> getTunnels(final InstanceIdentifier<Tunnels> iid) {
+ Optional<Tunnels> tunnels = new MdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL, iid);
return tunnels;
}
- public Optional<HwvtepPhysicalPortAugmentation> getPhysicalPortAugmentation(InstanceIdentifier<?> iid,
- HwvtepNodeName hwvtepNodeName) {
- Preconditions.checkNotNull(iid);
- Optional<List<TerminationPoint>> nodeOptional = getTerminationPointList(iid);
+ public Optional<HwvtepPhysicalPortAugmentation> getPhysicalPortAugmentation(final InstanceIdentifier<?> iid,
+ final HwvtepNodeName hwvtepNodeName) {
+ Optional<Map<TerminationPointKey, TerminationPoint>> nodeOptional =
+ getTerminationPointList(requireNonNull(iid));
if (nodeOptional.isPresent()) {
- List<TerminationPoint> tpList = nodeOptional.get();
- for (TerminationPoint tp : tpList) {
+ for (TerminationPoint tp : nodeOptional.get().values()) {
HwvtepPhysicalPortAugmentation hppAugmentation =
tp.augmentation(HwvtepPhysicalPortAugmentation.class);
if (hppAugmentation != null && hppAugmentation.getHwvtepNodeName().equals(hwvtepNodeName)) {
- return Optional.fromNullable(hppAugmentation);
+ return Optional.ofNullable(hppAugmentation);
}
}
}
- return Optional.absent();
+ return Optional.empty();
}
- public Optional<HwvtepPhysicalLocatorAugmentation> getPhysicalLocatorAugmentation(InstanceIdentifier<?> iid,
- IpAddress dstIp, Class<? extends EncapsulationTypeBase> encapType) {
- Preconditions.checkNotNull(iid);
- Optional<List<TerminationPoint>> nodeOptional = getTerminationPointList(iid);
+ public Optional<HwvtepPhysicalLocatorAugmentation> getPhysicalLocatorAugmentation(final InstanceIdentifier<?> iid,
+ final IpAddress dstIp, final EncapsulationTypeBase encapType) {
+ Optional<Map<TerminationPointKey, TerminationPoint>> nodeOptional =
+ getTerminationPointList(requireNonNull(iid));
if (nodeOptional.isPresent()) {
- List<TerminationPoint> tpList = nodeOptional.get();
- for (TerminationPoint tp : tpList) {
+ for (TerminationPoint tp : nodeOptional.get().values()) {
HwvtepPhysicalLocatorAugmentation hppAugmentation =
tp.augmentation(HwvtepPhysicalLocatorAugmentation.class);
if (hppAugmentation != null && hppAugmentation.getDstIp().equals(dstIp)
&& hppAugmentation.getEncapsulationType().equals(encapType)) {
- return Optional.fromNullable(hppAugmentation);
+ return Optional.ofNullable(hppAugmentation);
}
}
}
- return Optional.absent();
+ return Optional.empty();
}
public Optional<HwvtepPhysicalLocatorAugmentation>
- getPhysicalLocatorAugmentation(InstanceIdentifier<TerminationPoint> iid) {
+ getPhysicalLocatorAugmentation(final InstanceIdentifier<TerminationPoint> iid) {
Optional<TerminationPoint> tp =
- new ControllerMdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL, iid);
+ new MdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL, iid);
if (tp.isPresent()) {
- return Optional.fromNullable(tp.get().augmentation(HwvtepPhysicalLocatorAugmentation.class));
+ return Optional.ofNullable(tp.get().augmentation(HwvtepPhysicalLocatorAugmentation.class));
}
- return Optional.absent();
+ return Optional.empty();
}
- public Optional<LocalMcastMacs> getLocalMcastMacs(InstanceIdentifier<?> iid, LocalMcastMacsKey key) {
- Preconditions.checkNotNull(iid);
- Optional<HwvtepGlobalAugmentation> nodeOptional = getHwvtepGlobalAugmentation(iid);
+ public Optional<LocalMcastMacs> getLocalMcastMacs(final InstanceIdentifier<?> iid, final LocalMcastMacsKey key) {
+ Optional<HwvtepGlobalAugmentation> nodeOptional = getHwvtepGlobalAugmentation(requireNonNull(iid));
if (nodeOptional.isPresent()) {
- HwvtepGlobalAugmentation hgAugmentation = nodeOptional.get();
- List<LocalMcastMacs> macList = null;
- if (hgAugmentation != null) {
- macList = hgAugmentation.getLocalMcastMacs();
- }
- if (macList != null) {
- for (LocalMcastMacs mac: macList) {
- if (mac.key().equals(key)) {
- return Optional.fromNullable(mac);
- }
- }
+ LocalMcastMacs mac = nodeOptional.get().nonnullLocalMcastMacs().get(key);
+ if (mac != null) {
+ return Optional.of(mac);
}
}
- return Optional.absent();
+ return Optional.empty();
}
- public Optional<RemoteMcastMacs> getRemoteMcastMacs(InstanceIdentifier<?> iid, RemoteMcastMacsKey key) {
- Preconditions.checkNotNull(iid);
- Optional<HwvtepGlobalAugmentation> nodeOptional = getHwvtepGlobalAugmentation(iid);
+ public Optional<RemoteMcastMacs> getRemoteMcastMacs(final InstanceIdentifier<?> iid, final RemoteMcastMacsKey key) {
+ Optional<HwvtepGlobalAugmentation> nodeOptional = getHwvtepGlobalAugmentation(requireNonNull(iid));
if (nodeOptional.isPresent()) {
- HwvtepGlobalAugmentation hgAugmentation = nodeOptional.get();
- List<RemoteMcastMacs> macList = null;
- if (hgAugmentation != null) {
- macList = hgAugmentation.getRemoteMcastMacs();
- }
- if (macList != null) {
- for (RemoteMcastMacs mac: macList) {
- if (mac.key().equals(key)) {
- return Optional.fromNullable(mac);
- }
- }
+ RemoteMcastMacs mac = nodeOptional.get().nonnullRemoteMcastMacs().get(key);
+ if (mac != null) {
+ return Optional.of(mac);
}
}
- return Optional.absent();
+ return Optional.empty();
}
- public Optional<LocalUcastMacs> getLocalUcastMacs(InstanceIdentifier<?> iid, LocalUcastMacsKey key) {
- Preconditions.checkNotNull(iid);
- Optional<HwvtepGlobalAugmentation> nodeOptional = getHwvtepGlobalAugmentation(iid);
+ public Optional<LocalUcastMacs> getLocalUcastMacs(final InstanceIdentifier<?> iid, final LocalUcastMacsKey key) {
+ Optional<HwvtepGlobalAugmentation> nodeOptional = getHwvtepGlobalAugmentation(requireNonNull(iid));
if (nodeOptional.isPresent()) {
- HwvtepGlobalAugmentation hgAugmentation = nodeOptional.get();
- List<LocalUcastMacs> macList = null;
- if (hgAugmentation != null) {
- macList = hgAugmentation.getLocalUcastMacs();
- }
- if (macList != null) {
- for (LocalUcastMacs mac: macList) {
- if (mac.key().equals(key)) {
- return Optional.fromNullable(mac);
- }
- }
+ LocalUcastMacs mac = nodeOptional.get().nonnullLocalUcastMacs().get(key);
+ if (mac != null) {
+ return Optional.of(mac);
}
}
- return Optional.absent();
+ return Optional.empty();
}
- public Optional<RemoteUcastMacs> getRemoteUcastMacs(InstanceIdentifier<?> iid, RemoteUcastMacsKey key) {
- Preconditions.checkNotNull(iid);
- Optional<HwvtepGlobalAugmentation> nodeOptional = getHwvtepGlobalAugmentation(iid);
+ public Optional<RemoteUcastMacs> getRemoteUcastMacs(final InstanceIdentifier<?> iid, final RemoteUcastMacsKey key) {
+ Optional<HwvtepGlobalAugmentation> nodeOptional = getHwvtepGlobalAugmentation(requireNonNull(iid));
if (nodeOptional.isPresent()) {
- HwvtepGlobalAugmentation hgAugmentation = nodeOptional.get();
- List<RemoteUcastMacs> macList = null;
- if (hgAugmentation != null) {
- macList = hgAugmentation.getRemoteUcastMacs();
- }
- if (macList != null) {
- for (RemoteUcastMacs mac: macList) {
- if (mac.key().equals(key)) {
- return Optional.fromNullable(mac);
- }
- }
+ RemoteUcastMacs mac = nodeOptional.get().nonnullRemoteUcastMacs().get(key);
+ if (mac != null) {
+ return Optional.of(mac);
}
}
- return Optional.absent();
+ return Optional.empty();
}
public Optional<LogicalRouters> getLogicalRouters(final InstanceIdentifier<?> iid,
final LogicalRoutersKey logicalRoutersKey) {
- Preconditions.checkNotNull(iid);
- Optional<HwvtepGlobalAugmentation> nodeOptional = getHwvtepGlobalAugmentation(iid);
+ Optional<HwvtepGlobalAugmentation> nodeOptional = getHwvtepGlobalAugmentation(requireNonNull(iid));
if (nodeOptional.isPresent()) {
- HwvtepGlobalAugmentation hgAugmentation = nodeOptional.get();
- if (hgAugmentation != null && hgAugmentation.getLogicalRouters() != null) {
- for (LogicalRouters lrouter: hgAugmentation.getLogicalRouters()) {
- if (lrouter.key().equals(logicalRoutersKey)) {
- return Optional.fromNullable(lrouter);
- }
- }
+ LogicalRouters lrouter = nodeOptional.get().nonnullLogicalRouters().get(logicalRoutersKey);
+ if (lrouter != null) {
+ return Optional.of(lrouter);
}
}
- return Optional.absent();
+ return Optional.empty();
}
- public Optional<Acls> getAcls(InstanceIdentifier<Acls> iid) {
- Optional<Acls> acl = new ControllerMdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL, iid);
+ public Optional<Acls> getAcls(
final InstanceIdentifier<Acls> iid) {
+ Optional<Acls> acl = new MdsalUtils(db).readOptional(LogicalDatastoreType.OPERATIONAL, iid);
return acl;
}
return transaction;
}
- public void setPhysicalLocatorInFlight(InstanceIdentifier<TerminationPoint> iid,
- UUID uuid) {
+ public void setPhysicalLocatorInFlight(final InstanceIdentifier<TerminationPoint> iid,
+ final UUID uuid) {
inflightLocators.put(iid, uuid);
}
- public UUID getPhysicalLocatorInFlight(InstanceIdentifier<TerminationPoint> iid) {
+ public UUID getPhysicalLocatorInFlight(final InstanceIdentifier<TerminationPoint> iid) {
return inflightLocators.get(iid);
}
return deviceInfo;
}
- public void updateCurrentTxData(Class<? extends Identifiable> cls, InstanceIdentifier key, UUID uuid) {
+ public void updateCurrentTxData(final Class<? extends Identifiable> cls, final InstanceIdentifier key,
+ final UUID uuid) {
HwvtepSouthboundUtil.updateData(currentTxUUIDs, cls, key, uuid);
}
- public void updateCurrentTxDeleteData(Class<? extends Identifiable> cls, InstanceIdentifier key) {
+ public void updateCurrentTxDeleteData(final Class<? extends Identifiable> cls, final InstanceIdentifier key) {
HwvtepSouthboundUtil.updateData(currentTxDeletedKeys, cls, key, Boolean.TRUE);
}
- public UUID getUUIDFromCurrentTx(Class<? extends Identifiable> cls, InstanceIdentifier key) {
+ public UUID getUUIDFromCurrentTx(final Class<? extends Identifiable> cls, final InstanceIdentifier key) {
return HwvtepSouthboundUtil.getData(currentTxUUIDs, cls, key);
}
- public boolean isKeyPartOfCurrentTx(Class<? extends Identifiable> cls, InstanceIdentifier key) {
+ public boolean isKeyPartOfCurrentTx(final Class<? extends Identifiable> cls, final InstanceIdentifier key) {
return HwvtepSouthboundUtil.containsKey(currentTxUUIDs, cls, key);
}
- public Set<InstanceIdentifier> getDeletedKeysInCurrentTx(Class<? extends Identifiable> cls) {
+ public Set<InstanceIdentifier> getDeletedKeysInCurrentTx(final Class<? extends Identifiable> cls) {
if (currentTxDeletedKeys.containsKey(cls)) {
return currentTxDeletedKeys.get(cls).keySet();
}
- return Collections.EMPTY_SET;
+ return Collections.emptySet();
}
public List<? extends Identifiable> getUpdatedData(final InstanceIdentifier<Node> key,
result = modifiedData.get(key).getLeft().get(cls);
}
if (result == null) {
- result = Collections.EMPTY_LIST;
+ result = Collections.emptyList();
}
return result;
}
result = modifiedData.get(key).getRight().get(cls);
}
if (result == null) {
- result = Collections.EMPTY_LIST;
+ result = Collections.emptyList();
}
return result;
}
return inReconciliation;
}
- public void setInReconciliation(boolean inReconciliation) {
+ public void setInReconciliation(final boolean inReconciliation) {
this.inReconciliation = inReconciliation;
}
Code Review / ovsdb.git / blobdiff