Bump versions by x.(y+1).z

Change-Id: I66af62feedb35b5c46ff0831a624bbf99213fb71
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Bump upstreams

Adopt:
- controller-9.0.2
- aaa-0.19.3
- netconf-7.0.4

Change-Id: I76ebf57cb98543df2a35f45ee86368a11aa0cad0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netconf to 7.0.3

Pick up latest regression fixes from upstream.

Change-Id: I06cfffa8ab844956d173472210283dd1f744746d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-13.0.11
- infrautils-6.0.6
- yangtools-13.0.2
- mdsal-13.0.1
- controller-9.0.1
- aaa-0.19.2
- netconf-7.0.2

Change-Id: I1514f557c17dbb3a6cdaef738c8739f04cb5d661
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix inclusion/exclusion lists

Our previous patch has changed the semantics of the provided string.
Restore the previous behaviour.

JIRA: OVSDB-468
Change-Id: Ibfdb5c39e9357c285319e8cbd77680cfe36bece7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch static wiring from SoutboundProvider

The inclusion/exclusion lists are a natural part of
ReconciliationManager. Pass them there, so they can be easily picked up.

JIRA: OVSDB-468
Change-Id: Ib12873ca0cc5f8db71e5fa8b6fa58743914000cd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove SouthboundProvider.db

We have access to the properly-injected DataBroker, used that instead of
the static field.

Also fixes some cases where we access DTO properties multiple times.

JIRA: OVSDB-468
Change-Id: I328b59c8027e27512ae14d451b372c1a1b664608
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve thrown exception

We are hitting an missing node for some reason. Add its identity to the
message to ease debugging.

Change-Id: Ic8b14c1445434b9e82f1be07da6df3ebafe6631c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not read bridge node multiple times

We have guards against non-existing bridge nodes, but when they succeed
we throw away the data we have read. This can lead to theoretical TOCTOE
errors.

Fix this by only reading the bridge node once.

Change-Id: I5e224b350d3c4f5e05d1366fa8f4282b6834dba8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Simplify getBridgeNode()

Use simple returns instead of overwriting a local variable.

Change-Id: I886590ddcfc5b15c69a6f63953eaffdce5348dc8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add RTD configuration

Our build is broken, un-break it by adding required configuration.

Change-Id: If9f53323e7788d9099ad29efcc571b46cd7752b1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netconf to 7.0.1

Pick up fixes from upstream.

Change-Id: If407f1540592653e9e9d785d91c8e70f17492868
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings iin southbound-it

We have a few deprecation warnings here, fix them up.

Change-Id: I2b0e30bcb1a7520dd8d523dd086b18745e3ea553
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- yangtools-13.0.1
- mdsal-13.0.0
- controller-9.0.0
- aaa-0.19.1
- netconf-7.0.0

The test suite in southbound-impl is hacked together to not use
InstanceIdentifier mocking, reducing powermock exposure a bit.

Change-Id: Id4b5f1d8c11e57aee99f60c274061cb00489e87f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Turn TransactionInvokerImpl into a component

TransactionInvokerImpl is a really simplistic component, make it work
using its own lifecycle.

JIRA: OVSDB-468
Change-Id: I781f388a3edc47f4f16548dfaf12dcb2a9427ce5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate HwvtepSouthboundProvider to OSGi DS

This is a very simple component, migrate it over to OSGi DS, removing
the need for a blueprint.

JIRA: OVSDB-468
Change-Id: Ib48059afa9d3dbbf4ae015ca456bfaa290a91e57
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert SouthboundProvider into a component

Use Declarative Services to wire SouthboundProvider, which allows us to
ditch Blueprint and have much saner layout.

JIRA: OVSDB-468
Change-Id: Ie43b9e33865a4a643ae5baeccc56cea0b0a73fc5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert OvsdbConnectionService into a Component

This is a rather simple component, but it is was convoluted by previous
attempts to have blueprint auto-generated. Convert it to Declarative
Services and ditch blueprint.

Since we are using ICertificateManager, which is satisfied via Blueprint
by aaa-cert, we need to also suppress generation of requirements.

JIRA: OVSDB-468
Change-Id: I47a5acd22314601672a04f76bf0686fbfdc90b55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odparent-13.0.10
- infrautils-6.0.5
- yangtools-11.0.5
- mdsal-12.0.4
- controller-8.0.4
- aaa-0.18.4
- netconf-6.0.6

Change-Id: I16f7bd0d37919e83a6adade4d1a1952d3dfbeee2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b28efa094154e39c090312205f864dbd7cf4fe37)

Bump upstreams

Adopt:
- odlparent-13.0.7
- infrautils-6.0.4
- yangtools-11.0.4
- mdsal-12.0.3
- controller-8.0.3
- aaa-0.18.3
- netconf-6.0.5

Change-Id: I20ab3db168833178d97b78232080920741a9d117
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 5e23e907024ae9b24070de830c3e1be0bbbc8eeb)

Bump upstreams

Adopt
- yangtools-11.0.2
- mdsal-12.0.2
- controller-8.0.2
- aaa-0.18.2
- netconf-6.0.4

Change-Id: I78d3f655b1a8b572268ff8526c5f7ea5f826b0f4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit bf7e8f372a8a790a60c2a1dbe2cfb286fe607d05)

Bump versions by x.(y+1).z

Change-Id: Ibf31b37d1b121582a41c9b2743c513dceee0dd55
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Bump netconf to 6.0.3

Adopt latest fixes.

Change-Id: I152ee583683c1b16880932bfe6bac426726fcdff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix feature packaging

We have a number of upstream references which are not expressed
properly:
- the dependencies should be pulled through artifacts
- the features should use version ranges

This patch corrects all features to behave.

Change-Id: Id4a86ee365be5d7f41eead918679a067f812ddcd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odparent-13.0.4
- infrautils-6.0.2
- yangtools-11.0.1
- mdsal-12.0.1
- controller-8.0.1
- aaa-0.18.1
- netconf-6.0.2

Change-Id: I4640338c85d6f8da97b796016899c1051a8b11da
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix checkstyle

Upgraded checkstyle is finding new violations, fix them up.

Change-Id: Ib95acc8bc7d738b620ce69ad6b54a9a539ff4b9d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netconf to 6.0.1

Pick up latest fixes.

Change-Id: Ib6225845b69f279b593ee8f6b0b37e2c8f22ea8b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odparent-13.0.3
- infrautils-6.0.1
- yangtools-11.0.0
- mdsal-12.0.0
- controller-8.0.0
- aaa-0.18.0
- netconf-6.0.0

Change-Id: Ie013f9afc64e70381e9d012c826952645c9a0335
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate users of Optional.get()

Modernizer is flaggin callers, use better alternatives.

Change-Id: I79b3a5c64e28b2fd5a8de5b6010cfe7b1d38719b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 15b576cdf8f7abe67343053f8f6109070515dd6d)

Bump versions by x.(y+1).z

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Ida482b299cc13316f5a70beb3b782021265f3945

Bump upstreams

Adopt:
- aaa-0.17.7
- netconf-5.0.4

Change-Id: Idae897c55044e40e10100da5631c3f885cf934c7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-12.0.3
- infrautils-5.0.3
- yangtools-10.0.4
- mdsal-11.0.7
- controller-7.0.4
- aaa-0.17.6
- netconf-5.0.3

Change-Id: Iab75841e6fa00c09ebf31a3944e0f7a3280c7378
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert NettyBootstrapFactory into a Component

This is a rather simple component, split it into a service and inject
it as a service.

Change-Id: I1bd81387b959b3324b4685b419665dde9ce92165
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-12.0.2
- infrautils-5.0.2
- yangtools-10.0.3
- mdsal-11.0.6
- controller-7.0.3
- aaa-0.17.5
- netconf-5.0.2

Change-Id: Ib7666f0da293b565394c4b51d42dc26496d73a75
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up hwvtep commands

Do not use Blueprint, but rather proper karaf tooling to implement the
commands.

Change-Id: I41c90a7d0f4273a2c8771d79745ab27f72e65768
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove getHwvtepConnectionManager()

This method is not used anywhere, remove it.

Change-Id: I5a4b5d7723762fe62426838cf033d7c6fbd7018e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize BridgeConfigReconciliationTaskTest

Use BindingMap.of() and List.of() to create lists.

Change-Id: I808106fe25903123f2de69fc47bb14a76b83ff1f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up library/impl dependencies

We have a number of undeclared dependencies, make sure we mention them
so the build is not dependent on transitive dependencies.

Change-Id: Ie7852b8a11cc3079a4c8554e5e33a78d473e963e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Corrent aaa bump

The version bump went to 0.17.1 instead of 0.17.3, correct that.

Change-Id: If4d23d8c067ed08752b72215778deaf6173c5a1a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Adopt 2023.03 Argon upstreams

Adopt:
- odlparent-12.0.1
- infrautils-5.0.1
- yangtools-10.0.2
- mdsal-11.0.4
- controller-7.0.2
- aaa-0.17.3
- netconf-5.0.1

Change-Id: Iff5f19591e552a11fe6e21263b04658fe604cd96
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove dependency on serviceutils

This removes dependency on serviceutils' upgrade component, restoring
codeflows to work without it.

Change-Id: Idbe9e85c7b276768173237799c776f6c4000fa55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.(y+1).z

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I9f5a6c400b345e7bb2f08dec6057481b5761eca5

Bump MRI upstreams

Adopt the following versions:
- mdsal-10.0.2
- controller-6.0.2
- aaa-0.16.3
- netconf-4.0.2

Change-Id: Ib8987d0f71b53388d3b6826472fae3e03de8d2fe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt the following versions:
- odlparent-11.0.1
- infrautils-4.0.1
- yangtools-9.0.1
- mdsal-10.0.1
- controller-6.0.1
- aaa-0.16.1
- netconf-4.0.1

Change-Id: I53e13adfd55a3e0fd52312dcc0b20b1d6a17fc7d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams for 2022.09 Chlorine

Adopt the following versions:
- odlparent-11.0.0
- infrautils-4.0.0
- yangtools-9.0.0
- mdsal-10.0.0
- controller-6.0.0
- aaa-0.16.0
- netconf-4.0.0

Change-Id: I1ec2bc025dd5f6767ad6bf1c29dd3311cc3eae92
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use netconf-3.0.5

Pick up latest fixes from upstream.

Change-Id: I80e915aeb64c9fb2a8bc978529876223e9ffdc90
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstream versions

Adopt:
- yangtools-8.0.6
- mdsal-9.0.4
- controller-5.0.5
- aaa-0.15.5
- netconf-3.0.4

Change-Id: I8df25adf4e0b46d36ad59b509ab4d0b3d812d325
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 5c6f603bd15b51e5283d6fbdbdcde4dbcfa668a3)

Bump MRI upstreams

Adopt the following versions:
- odlparent-10.0.2
- infrautils-3.0.1
- yangtools-8.0.5
- mdsal-9.0.3
- controller-5.0.4
- aaa-0.15.4
- netconf-3.0.3

Change-Id: I2d6f7bb2ef0606bdab57bfd0c603b14f7e82ea8b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9a08779e7ea0a3a24769c4c723c59f47864a6586)

Bump upstreams

Adopt:
- controller-5.0.3
- aaa-0.15.3
- netconf-3.0.2

Change-Id: I516dfd49de3bc56390488d738653f88f4272f1d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit a0e22410b3cf5d176e72b51615e3ead405e90607)

Bump versions by x.(y+1).z

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Id865596fb804c841788fedce85df80f938b04179

Bump upstream versions

Adopt:
- yangtools-8.0.3
- mdsal-9.0.2
- controller-5.0.2
- aaa-0.15.2
- netconf-3.0.1

Change-Id: Ief33427f17decb196e3cdf5bc044271825f53ad4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Allow reflective access in UT

We have mucking around with internals, make sure we open them up from
java.base. We also need to switch to VarHandles to get at
Field.modifiers.

Change-Id: I111e8bd1e64d37c454e9935adce23743ac43fdaa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt the following versions:
- odlparent-10.0.0
- infrautils-3.0.0
- yangtools-8.0.2
- mdsal-9.0.1
- controller-5.0.1
- aaa-0.15.1
- netconf-3.0.0

Change-Id: I7dfe7fdbf88eb787a59e031e24559a9601fde878
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update MRI upstreams

Adopt:
- odlparent-9.0.13
- infrautils-2.0.13
- yangtools-7.0.14
- mdsal-8.0.11
- controller-4.0.10
- aaa-0.14.10
- netconf-2.0.14

Change-Id: I85322380ff5138362d7e554e7c6852b0a75c3f34
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e2f0568a71243ba4c2f2775bca94c816486f809b)

Bump netconf to 2.0.11

Pick up a fix for regression.

Change-Id: Icd2aa7c365a9b1a97471c3ea4390c2693e12f07c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netconf to 2.0.10

Pick up a fix for regression.

Change-Id: I7ee5af47247696109a2019bc83aba452c67dfa65
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update MRI upstreams

Adopt:
- controller-4.0.7
- aaa-0.14.7
- netconf-2.0.9

Change-Id: Ia5fe1fdbf002c93e0f7666c1ea71f0d047576610
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update MRI upstreams

Adopt:
- controller-4.0.6
- aaa-0.14.6
- netconf-2.0.8

Change-Id: Ib8e9f88fb04eb933429eb230378d61c0c41069cb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch powermock from util.servicehelper

We have static mocking here, rework it in terms of Mockito.

Change-Id: I2ee329b67fe0f4261337b009d4d36c84e77ecb71
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch powermock from util.config

We have static mocking here, rework it in terms of Mockito.

Change-Id: I66b5afd16e8fd60e8331d81cc8af8ee64922839c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not depend on ODL Blueprint

Use of odl:type=default is discouraged ditch its use in southbound-impl.

Change-Id: Id7344dd7b3a71f2a8fff06967ba86411c4d1a346
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inherit groupId/version from parent

Eclipse complains about no-op override, fix that.

Change-Id: I9de2332ae3f5dafe41054645eeff359ee02662f8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add @NonNull annotations

There are a few spots we can propagate @NonNull to eclipse null
warnings. Sprinkle them around.

Change-Id: I6cf449879cdadd5d0edfabe5c5f43e0cbab60e51
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor SouthboundConstants

This is not an interface, but rather a collections of various constants.
Refactor to a proper utility class and move non-shared constants to
their sole users.

Change-Id: Ibb21174ee18f92608ea2ac14f535558d609299fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update MRI upstreams

Adopt:
- odlparent-9.0.8
- infrautils-2.0.8
- yangtools-7.0.8
- mdsal-8.0.7
- controller-4.0.5
- aaa-0.14.5
- netconf-2.0.7

Change-Id: I362f3ccaad2af949ee5071813a1cb67f6528b601
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use blueprint-maven-plugin in southbound

blueprint-maven-plugin is unmaintained upstream. Generated wiring is
quite simple and should be converted to OSGi DS. As a first step capture
autowire.xml content so we know what we are dealing with.

Change-Id: I95c567c0907ad580a3639bc2365b1087f377db3c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use provided shell console

We should not be pulling in shell console, it is provided by the
framework.

Change-Id: Ic2f6f6b16efe30c5ff9942bc7343297a6ca3f770
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 359516f6b96326589b37324f713cf1fde2e25868)

Do not depend on ODL Blueprint

Use of odl:type=default is discouraged ditch its use in library.

Change-Id: I1b0dec76529e99da1dfd287a6d53365cfc5ca106
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use blueprint-maven-plugin in library

blueprint-maven-plugin is unmaintained upstream. Generated wiring is
quite simple and should be converted to OSGi DS. As a first step capture
autowire.xml content so we know what we are dealing with.

Change-Id: I355136ee1a5475184c3f52906e4e9b9df2f92fa1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.(y+1).z

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Idbf1338185b46e4e5604fed64d0b25e9ae33f53e

Bump upstream versions

Use netconf-2.0.5 et al.

Change-Id: Ie477e17f7fd81ba4f6fb19e0db8c5ed1fb660f16
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstream versions

Use netconf-2.0.3 et al.

Change-Id: I5f1ae765373c61b273399626aa28c28b57da1efb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstream versions

Use netconf-2.0.2 et al.

Change-Id: Ifd0ea1d66f2f3205c5d05bdb51d1eb976bf822da
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up unused dependencies

odlparent's infrastructure is reporting a number of unused declared
dependencies, clean them up.

Change-Id: Id00e8864e67b7ac36beed2a79184c19e88d0175f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netconf to 2.0.1

Pick up latest upstream fixes.

Change-Id: I162d9ebf4b2580103934a68ded8364fbf92a7e5c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt:
- odlparent-9.0.2
- infrautils-2.0.2
- mdsal-8.0.0
- controller-4.0.0
- aaa-0.14.0
- netconf-2.0.0

Change-Id: Ic3d73565a34717e2d03e19b5b892bae9c130eea5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use GuicedEE javax.inject

This artifact is a proper jar and a JPMS module, use it instead
of the ancient javax.inject zip.

Change-Id: I8996c1a7c02180786b14e9b0d395e4e104fb98b9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use osgi-core R7

Release 7 has changed the name of the artifact, update our references
to pick up R7 instead of R6.

Change-Id: I39d93e71e074c01a7d702d08b4d4b4d736dceebd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove ShardStatusMonitor

This class is not used anywhere. It used to be needed when DataBroker
was injected early, but nowdays it is brought up only after initial
convergence has been achieved.

Change-Id: I65424f782d6cf45afdbdf0ec020399cab648e014
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.1.1
- infrautils-1.9.6
- yangtools-6.0.5
- mdsal-7.0.6
- controller-3.0.7
- aaa-0.13.2
- netconf-1.13.1

Change-Id: I9b80b389033399bc06f2ddc8ff911fcf000629ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.(y+1).z

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I4f009fb6ad1befdf1e2c18e6cb76bc3c4de668b7

Bump netconf to 1.13.0

Adjust version for MRI-integrated NETCONF.

Change-Id: Ic1b7f1ffa8589ee1ded02c80482674ab00cdd46a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Adopt akka-2.6.x

Adopt following upstreams to enable akka-2.6.x:
- controller-3.0.6
- aaa-0.13.1

Change-Id: Ib57352cbd28389513ee607382a86a5f84b7e4964
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>

Use a version range for aaa/infrautils dependency

AAA is an MRI project, do not depend on a specific version of its
feature, but rather require a proper range. The same is true for
infrautils, hence fix those as well.

Change-Id: I907e4fde584597d8379a69e532955fb02e1bc43d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Depend on AAA 0.13.0 release

Reflect the fact upstream has a release, dropping the -SNAPSHOT
suffix.

Change-Id: I92382b328cda7dd7fb0cca6e71c15f0242695263
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstream versions

Adopt following upstreams:
- odlparent-8.1.0
- infrautils-1.9.5
- yangtools-6.0.4
- mdsal-7.0.5
- controller-3.0.5

Change-Id: I2712230c96d5c6320defddece50625d02505abf1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce powermock use in OvsdbManagersUpdateCommandTest

Do not overmock unrelated classes and use a @VisibleForTesting
method do ditch some of the powermock use.

Change-Id: I90c47897f9057a2a81d0016ce47d27d1f6ac2181
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup SouthboundIT

Use BindingMap to clean up use of deprecated methods.

Change-Id: Ib257c097a6d0e7e7a2888af4dcf7f14a06aaed1e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup warnings in southbound-utils

This changes SoutboundUtils.addBridge(), requiring proper maps
to be passed in. Internals are reworked to allow for more efficient
operation when no configs are passed in.

Change-Id: Ib80b682c7c4b5d0fd922376ec6a0989a8b5cff96
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Encapsulate HwvtepSouthboundUtil's executor

We do not want to leak this executor to prevent shenanigans. We really
just need a schedule() method.

Change-Id: Ida4004c82d1d99f51439ebbdf908f62d36bb6a25
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch blueplrint-maven-plugin from southbound-impl

The use of this plugin was a mis-step, we really want do deal with
OSGi using Declarative Services. As a first step, freeze all wiring
in the explicit blueprint.xml and put in FIXMES for near future.

Change-Id: Ib2cd99d1b0c4b1057adb6531a7005546be468a5c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate CLI on a proper management interface

We are currently wiring these through blueprint, which allows class
injection -- but this needs to be a proper interface.

Change-Id: I704f329bc6c8b75f01f5d7cd29471648c028f922
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not check DataBroker shards

Startup checks are not necessary, as DataBroker is only injected
once initial convergence has been reached.

Remove the checks and all their configuration binding, leaving only
manual Karaf commands. These will be refactored at a later point
in time.

Change-Id: I1ec8fbf47847c024e7a4e2bdceb867e0491f35c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup invalid constants

Constants should really be constant, make sure that is the case.

Change-Id: Idbaee1ff9ba0856bfab7a802e044897e57cd9bfc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use powermock in hwvtepsouthbound-impl

Replace reflection access with package @VisibleForTesting fields.

Change-Id: Ic900de4ae5efa8123e1c2ca377b442d39ab011ea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup warnings in hwvtepsouthbound-impl

Use BindingMap to reduce warnings about deprecated use of lists.

Change-Id: Ib47f8b3de614aae8e56af35533eb4934ba047c0b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix deprecation warnings is southbound-impl

Use BindingMap.Builder to replace ArrayList, which maintains
is almost a drop-in replacement. While we are in the area, also
fix duplicate invocations of SouthboundMapper.

Since the interactions take advantage of what builders provide,
also ditch a ton of mocking in favor of using provided builder
implementation.

Change-Id: I4bd4a86039b8ef3159091565be2581b9fe23aefc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate bridge constructor users

Add explicit conversion between XML and builders, so that we do not
get a legacy conversion warning.

Change-Id: I18b62c9af57e8af7680daf36ba16238b7af93400
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate isFoo() callers

isFoo() is changing to getFoo(), remove use of deprecated methods.

Change-Id: I8c5f115bf9d01e286dc1a98831f21005870411b9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix type safety hazards in TransactUtils

There quite a bit of casting going on here, make sure we express
ourselves more clearly.

Change-Id: I77e136fce7c517b6d7b632067e5e330f54a0b38d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>