Bump upstream versions

Adopt:
- yangtools-8.0.6
- mdsal-9.0.4
- controller-5.0.5
- aaa-0.15.5
- netconf-3.0.4

Change-Id: I8df25adf4e0b46d36ad59b509ab4d0b3d812d325
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 5c6f603bd15b51e5283d6fbdbdcde4dbcfa668a3)

Bump MRI upstreams

Adopt the following versions:
- odlparent-10.0.2
- infrautils-3.0.1
- yangtools-8.0.5
- mdsal-9.0.3
- controller-5.0.4
- aaa-0.15.4
- netconf-3.0.3

Change-Id: I2d6f7bb2ef0606bdab57bfd0c603b14f7e82ea8b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9a08779e7ea0a3a24769c4c723c59f47864a6586)

Bump upstreams

Adopt:
- controller-5.0.3
- aaa-0.15.3
- netconf-3.0.2

Change-Id: I516dfd49de3bc56390488d738653f88f4272f1d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit a0e22410b3cf5d176e72b51615e3ead405e90607)

Bump versions by x.(y+1).z

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Id865596fb804c841788fedce85df80f938b04179

Bump upstream versions

Adopt:
- yangtools-8.0.3
- mdsal-9.0.2
- controller-5.0.2
- aaa-0.15.2
- netconf-3.0.1

Change-Id: Ief33427f17decb196e3cdf5bc044271825f53ad4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Allow reflective access in UT

We have mucking around with internals, make sure we open them up from
java.base. We also need to switch to VarHandles to get at
Field.modifiers.

Change-Id: I111e8bd1e64d37c454e9935adce23743ac43fdaa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt the following versions:
- odlparent-10.0.0
- infrautils-3.0.0
- yangtools-8.0.2
- mdsal-9.0.1
- controller-5.0.1
- aaa-0.15.1
- netconf-3.0.0

Change-Id: I7dfe7fdbf88eb787a59e031e24559a9601fde878
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update MRI upstreams

Adopt:
- odlparent-9.0.13
- infrautils-2.0.13
- yangtools-7.0.14
- mdsal-8.0.11
- controller-4.0.10
- aaa-0.14.10
- netconf-2.0.14

Change-Id: I85322380ff5138362d7e554e7c6852b0a75c3f34
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e2f0568a71243ba4c2f2775bca94c816486f809b)

Bump netconf to 2.0.11

Pick up a fix for regression.

Change-Id: Icd2aa7c365a9b1a97471c3ea4390c2693e12f07c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netconf to 2.0.10

Pick up a fix for regression.

Change-Id: I7ee5af47247696109a2019bc83aba452c67dfa65
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update MRI upstreams

Adopt:
- controller-4.0.7
- aaa-0.14.7
- netconf-2.0.9

Change-Id: Ia5fe1fdbf002c93e0f7666c1ea71f0d047576610
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update MRI upstreams

Adopt:
- controller-4.0.6
- aaa-0.14.6
- netconf-2.0.8

Change-Id: Ib8e9f88fb04eb933429eb230378d61c0c41069cb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch powermock from util.servicehelper

We have static mocking here, rework it in terms of Mockito.

Change-Id: I2ee329b67fe0f4261337b009d4d36c84e77ecb71
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch powermock from util.config

We have static mocking here, rework it in terms of Mockito.

Change-Id: I66b5afd16e8fd60e8331d81cc8af8ee64922839c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not depend on ODL Blueprint

Use of odl:type=default is discouraged ditch its use in southbound-impl.

Change-Id: Id7344dd7b3a71f2a8fff06967ba86411c4d1a346
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inherit groupId/version from parent

Eclipse complains about no-op override, fix that.

Change-Id: I9de2332ae3f5dafe41054645eeff359ee02662f8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add @NonNull annotations

There are a few spots we can propagate @NonNull to eclipse null
warnings. Sprinkle them around.

Change-Id: I6cf449879cdadd5d0edfabe5c5f43e0cbab60e51
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor SouthboundConstants

This is not an interface, but rather a collections of various constants.
Refactor to a proper utility class and move non-shared constants to
their sole users.

Change-Id: Ibb21174ee18f92608ea2ac14f535558d609299fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update MRI upstreams

Adopt:
- odlparent-9.0.8
- infrautils-2.0.8
- yangtools-7.0.8
- mdsal-8.0.7
- controller-4.0.5
- aaa-0.14.5
- netconf-2.0.7

Change-Id: I362f3ccaad2af949ee5071813a1cb67f6528b601
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use blueprint-maven-plugin in southbound

blueprint-maven-plugin is unmaintained upstream. Generated wiring is
quite simple and should be converted to OSGi DS. As a first step capture
autowire.xml content so we know what we are dealing with.

Change-Id: I95c567c0907ad580a3639bc2365b1087f377db3c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use provided shell console

We should not be pulling in shell console, it is provided by the
framework.

Change-Id: Ic2f6f6b16efe30c5ff9942bc7343297a6ca3f770
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 359516f6b96326589b37324f713cf1fde2e25868)

Do not depend on ODL Blueprint

Use of odl:type=default is discouraged ditch its use in library.

Change-Id: I1b0dec76529e99da1dfd287a6d53365cfc5ca106
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use blueprint-maven-plugin in library

blueprint-maven-plugin is unmaintained upstream. Generated wiring is
quite simple and should be converted to OSGi DS. As a first step capture
autowire.xml content so we know what we are dealing with.

Change-Id: I355136ee1a5475184c3f52906e4e9b9df2f92fa1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.(y+1).z

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Idbf1338185b46e4e5604fed64d0b25e9ae33f53e

Bump upstream versions

Use netconf-2.0.5 et al.

Change-Id: Ie477e17f7fd81ba4f6fb19e0db8c5ed1fb660f16
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstream versions

Use netconf-2.0.3 et al.

Change-Id: I5f1ae765373c61b273399626aa28c28b57da1efb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstream versions

Use netconf-2.0.2 et al.

Change-Id: Ifd0ea1d66f2f3205c5d05bdb51d1eb976bf822da
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up unused dependencies

odlparent's infrastructure is reporting a number of unused declared
dependencies, clean them up.

Change-Id: Id00e8864e67b7ac36beed2a79184c19e88d0175f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netconf to 2.0.1

Pick up latest upstream fixes.

Change-Id: I162d9ebf4b2580103934a68ded8364fbf92a7e5c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt:
- odlparent-9.0.2
- infrautils-2.0.2
- mdsal-8.0.0
- controller-4.0.0
- aaa-0.14.0
- netconf-2.0.0

Change-Id: Ic3d73565a34717e2d03e19b5b892bae9c130eea5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use GuicedEE javax.inject

This artifact is a proper jar and a JPMS module, use it instead
of the ancient javax.inject zip.

Change-Id: I8996c1a7c02180786b14e9b0d395e4e104fb98b9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use osgi-core R7

Release 7 has changed the name of the artifact, update our references
to pick up R7 instead of R6.

Change-Id: I39d93e71e074c01a7d702d08b4d4b4d736dceebd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove ShardStatusMonitor

This class is not used anywhere. It used to be needed when DataBroker
was injected early, but nowdays it is brought up only after initial
convergence has been achieved.

Change-Id: I65424f782d6cf45afdbdf0ec020399cab648e014
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.1.1
- infrautils-1.9.6
- yangtools-6.0.5
- mdsal-7.0.6
- controller-3.0.7
- aaa-0.13.2
- netconf-1.13.1

Change-Id: I9b80b389033399bc06f2ddc8ff911fcf000629ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.(y+1).z

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I4f009fb6ad1befdf1e2c18e6cb76bc3c4de668b7

Bump netconf to 1.13.0

Adjust version for MRI-integrated NETCONF.

Change-Id: Ic1b7f1ffa8589ee1ded02c80482674ab00cdd46a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Adopt akka-2.6.x

Adopt following upstreams to enable akka-2.6.x:
- controller-3.0.6
- aaa-0.13.1

Change-Id: Ib57352cbd28389513ee607382a86a5f84b7e4964
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>

Use a version range for aaa/infrautils dependency

AAA is an MRI project, do not depend on a specific version of its
feature, but rather require a proper range. The same is true for
infrautils, hence fix those as well.

Change-Id: I907e4fde584597d8379a69e532955fb02e1bc43d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Depend on AAA 0.13.0 release

Reflect the fact upstream has a release, dropping the -SNAPSHOT
suffix.

Change-Id: I92382b328cda7dd7fb0cca6e71c15f0242695263
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstream versions

Adopt following upstreams:
- odlparent-8.1.0
- infrautils-1.9.5
- yangtools-6.0.4
- mdsal-7.0.5
- controller-3.0.5

Change-Id: I2712230c96d5c6320defddece50625d02505abf1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce powermock use in OvsdbManagersUpdateCommandTest

Do not overmock unrelated classes and use a @VisibleForTesting
method do ditch some of the powermock use.

Change-Id: I90c47897f9057a2a81d0016ce47d27d1f6ac2181
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup SouthboundIT

Use BindingMap to clean up use of deprecated methods.

Change-Id: Ib257c097a6d0e7e7a2888af4dcf7f14a06aaed1e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup warnings in southbound-utils

This changes SoutboundUtils.addBridge(), requiring proper maps
to be passed in. Internals are reworked to allow for more efficient
operation when no configs are passed in.

Change-Id: Ib80b682c7c4b5d0fd922376ec6a0989a8b5cff96
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Encapsulate HwvtepSouthboundUtil's executor

We do not want to leak this executor to prevent shenanigans. We really
just need a schedule() method.

Change-Id: Ida4004c82d1d99f51439ebbdf908f62d36bb6a25
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch blueplrint-maven-plugin from southbound-impl

The use of this plugin was a mis-step, we really want do deal with
OSGi using Declarative Services. As a first step, freeze all wiring
in the explicit blueprint.xml and put in FIXMES for near future.

Change-Id: Ib2cd99d1b0c4b1057adb6531a7005546be468a5c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate CLI on a proper management interface

We are currently wiring these through blueprint, which allows class
injection -- but this needs to be a proper interface.

Change-Id: I704f329bc6c8b75f01f5d7cd29471648c028f922
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not check DataBroker shards

Startup checks are not necessary, as DataBroker is only injected
once initial convergence has been reached.

Remove the checks and all their configuration binding, leaving only
manual Karaf commands. These will be refactored at a later point
in time.

Change-Id: I1ec8fbf47847c024e7a4e2bdceb867e0491f35c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup invalid constants

Constants should really be constant, make sure that is the case.

Change-Id: Idbaee1ff9ba0856bfab7a802e044897e57cd9bfc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use powermock in hwvtepsouthbound-impl

Replace reflection access with package @VisibleForTesting fields.

Change-Id: Ic900de4ae5efa8123e1c2ca377b442d39ab011ea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup warnings in hwvtepsouthbound-impl

Use BindingMap to reduce warnings about deprecated use of lists.

Change-Id: Ib47f8b3de614aae8e56af35533eb4934ba047c0b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix deprecation warnings is southbound-impl

Use BindingMap.Builder to replace ArrayList, which maintains
is almost a drop-in replacement. While we are in the area, also
fix duplicate invocations of SouthboundMapper.

Since the interactions take advantage of what builders provide,
also ditch a ton of mocking in favor of using provided builder
implementation.

Change-Id: I4bd4a86039b8ef3159091565be2581b9fe23aefc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate bridge constructor users

Add explicit conversion between XML and builders, so that we do not
get a legacy conversion warning.

Change-Id: I18b62c9af57e8af7680daf36ba16238b7af93400
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate isFoo() callers

isFoo() is changing to getFoo(), remove use of deprecated methods.

Change-Id: I8c5f115bf9d01e286dc1a98831f21005870411b9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix type safety hazards in TransactUtils

There quite a bit of casting going on here, make sure we express
ourselves more clearly.

Change-Id: I77e136fce7c517b6d7b632067e5e330f54a0b38d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.0.3
- infrautils-1.9.4
- yangtools-6.0.3
- mdsal-7.0.4
- controller-3.0.4

Change-Id: If314c4a19aad8d9d10c0619c8444c2d27d34ac8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.0.2
- infrautils-1.9.3
- yangtools-6.0.2
- mdsal-7.0.3
- controller-3.0.3

Change-Id: I052a9db42bb16ae96a997a24c47083d9ffcc74aa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump infrautils to 1.9.1

Pick up mbean fixes from upstream.

Change-Id: Iba5ef562fbc0f8737162a8b04384a573b12a0152
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to mdsal-7.0.1/controller-3.0.1

Pick up mdsal fixes and improvements.

Change-Id: I8881f00992eb910293c8ee50724b1bbfd9512077
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate to Objects.requireNonNull()

Fix up final violations reported by modernizer and flip it on. Also
turn a few obvious uses to the proper guards -- i.e. use the return
value of requireNonNull().

Change-Id: I7e3e814219a08357c5f4bc87e7b125173743379a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix use of raw Collections.EMPTY_{LIST,SET}

Modernizer is rightly pointing out this use of constant, which also
causes some raw type warnings. Fix that up.

Change-Id: I5749db43f6d3fa21821180409d83109a43ab34a6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams for Silicon

Adopt the following upstream versions:
- odlparent-8.0.0
- yangtools-6.0.0
- mdsal-7.0.0
- controller-3.0.0
- infrautils-1.9.0

Change-Id: Ibb020c42971e25aaf651bf00fd970e77b3fea142
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix a few raw type warnings

InstanceIdentifier should not be used raw, this fixes trivial
offenders.

Change-Id: I9eff9e23a2f95e40dde757d5980da26e3dd5bd81
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use uint types in SouthboundIT

There are a number of warnings here, use proper uint types, which
cleans up some of the funky dance we have had here.

Change-Id: I3474593e5d75769a9d2f92fa0552d499cf64277a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate to use Objects.requireNonNull

These users of Preconditions.checkNotNull() are pointer out by
modernizer, migrate them.

Change-Id: I198384e8fc62ed32dc7c2fbba63fb16789bfc993
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use uint types in southbound-impl

This is a mostly-straightforward migration to use proper unsigned
types. We also fix some use of lists where it is convenient.

Change-Id: I6d4199431ec6ba45a2958573e07e956b4697ad88
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix migration warnings

Remove use of deprecated methods by switch port to Uint16 and using
maps for arguments.

Change-Id: I8545d85b6842837993d357e584f3b95315bfb6a7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not override javax.inject version

The version is managed in parent pom, no need to specify it again.

Change-Id: I699d2fa48c4fd2da607b779de057de05a704a3a4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate users of addAugmentation()

Builders have a simplified addAugmentation() method, migrate last
two users to it.

Change-Id: I71d3efeb15b8df4a9eb47bf0236447903fb640cd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings in MdsalUtilsAsyncTest

We have unused suppressions and unnecessary use of Lists, fix those
up.

Change-Id: I52a1e4d66b4197e9e5efffb4dcf0abc90116fdd4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate SouthboundUtils to use Uint types

This is a leftover migration from Magnesium, propagate the change
into public API.

Change-Id: I22348dabd81e7ac74ca66a71f66349b96fe1713e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix a few warnings in SouthboundUtils

First pass on deprecation warnings, fixing most obvious/limited
cases.

Change-Id: I70a97b3b917a55fb680b44d7bceb93293902443e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make methods static

There is a number of methods which do not touch object state, hence
can be made static. Eliminate eclipse warnings by making them static.

Change-Id: I6a714df82867c2e0bc303affba6be47fa7da999a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI projects

This patch adopts:
- odlparent-7.0.6
- infrautils-1.8.1
- yangtools-5.0.6
- mdsal-6.0.5
- controller-2.0.4

Change-Id: I2ed5d7eb9b4bb4c8d500f7001924c586b1d3fda7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump conf.yaml versions to Silicon

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Ib0c12fe82d53aa042ea3f3d22e7847e4aa08a3fa

hwvtep disconnect command support

Description:
when the command is fired it flaps the connection to the tor. The usage
is as below ex:

hwvtep:disconnect -nodeid hwvtep://uuid/19277da8-f85c-4ac8-af1b-9cffda7ef73d

Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Change-Id: I6e51d4858eb8887ea91659e0171268be50e64f90
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>

Fix deprecation warnings around addAugmentation()

These are mostly trivial fixes to eliminate warnings reported around
addAugmentation() method.

Change-Id: Ie17450891ed2c75861249a6ccb3f178ca3a8890f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Local-ucast-macs not cleared from oper-topo DS.

Description:
Due to deviceInfo cache not populated during add, during local-ucast-mac
removal, this mac entry is missing causing not to delete from optopo on mac removal
from switch.

The onSuccess() which populate the cache is not called properly during
add resulting in this issue.

Change-Id: I9db66caee024daf254cba5b696ef697e6309f1bb
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>

Bump versions by x.(y+1).z for next dev cycle

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I9c511d75109bdbaac30702fa39d8aae3a3935361

Use released version of infrautils

infrautils-1.8.0 has been released, use released version instead
of snapshots.

Change-Id: I2cdb4fa9052850621411571695c9f103c76b422a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools/mdsal/controller

Adopt upstream versions:
- odlparent-7.0.5
- yangtools-5.0.5
- mdsal-6.0.4
- controller-2.0.3

Change-Id: I8c8be3249f6170b0c215f4fe06cd22fc327da2d8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add INFO.yaml for ovsdb

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I89d483ef4c5b9c669fb8a971e438085a79c635d4
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>

Change log level from ERROR to warn.

Description:
When a connection is termination by Peer, following log is logged at
error level causing to get captured in teardown making TC as failure.

Exception occurred while processing connection pipeline
io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: Connection reset by peer

Change the log level from ERROR to warn as this exception is expected
during connection teardown and not making TC to mark as fail for this.

JIRA : OVSDB-496

Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Change-Id: I82a585d4478f07e29f8b04600b7df95bb98c6d08
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>

Using MD-SAL .exists() API

Description:
Whenever we are performing read operations just to
check it's presence in DS, instead of doing such read,
we can make use of MD-SAL exist() API which provides better performance.

Enhanced INFO level Logging statements.

Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Change-Id: Ie81f1be19e60af5081780bf0d43419ab433b9d4e
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>

Eliminate Duplicate Controller MD-SAL code

With the MD-SAL migration done, there are now two almost identical
classes. Remove duplicate classes.

JIRA: OVSDB-495

Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Change-Id: Idc6dd7198fb99d5f97f056c84f20659734dd8094
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>

Clean up MRI feature references

We should be referring to MRI features through ranges, fix that up.

Change-Id: Idede2bd4ebfa6bc8cb06e966adb68d662d2033d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix NPE in disconnect path

We should not be touching instance identifier if the node does
not exist in connection manager. Fixes the following splat:

java.lang.NullPointerException: null
at org.opendaylight.ovsdb.southbound.OvsdbDataTreeChangeListener.disconnect(OvsdbDataTreeChangeListener.java:151) ~[bundleFile:?]
at org.opendaylight.ovsdb.southbound.OvsdbDataTreeChangeListener.onDataTreeChanged(OvsdbDataTreeChangeListener.java:103) ~[bundleFile:?]
at org.opendaylight.mdsal.binding.dom.adapter.BindingDOMDataTreeChangeListenerAdapter.onDataTreeChanged(BindingDOMDataTreeChangeListenerAdapter.java:37) ~[bundleFile:?]
at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.dataTreeChanged(DataTreeChangeListenerActor.java:83) [bundleFile:?]
at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.handleReceive(DataTreeChangeListenerActor.java:44) [bundleFile:?]

Change-Id: Ibabc7f5324742fce04bc6f02b54a1ead945b15cb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Avoid excessive ovsdb log statements

Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Change-Id: Ifd12522cc4891fb01cde5cb2de5b5333e690f841

Integrate controller-2.0.2

This bumps versions to the following:
- odlparent-7.0.3
- yangtools-5.0.3
- mdsal-6.0.2
- controller-2.0.2

Change-Id: Ic9021658c58aaa3d0d40a858a6272f5e5b1fcbe1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate controller-2.0.1

This bumps versions to the following:
- odlparent-7.0.2
- yangtools-5.0.2
- mdsal-6.0.1
- controller-2.0.1

Change-Id: I60bd9f78cde3f35e3b3c1d8a399e73c847b82f14
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Set version to Aluminium

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Iab07ad88b9a8bb114d50d28f263d71749be06e17

Update MRI projects for Aluminium

This bumps versions to the following:
- odlparent-7.0.1
- yangtools-5.0.1
- mdsal-6.0.0
- controller-2.0.0

These updates imply that an unkeyed list cannot be deleted by
setting it to empty its parent node and issuing a merge() of that
parent node. This is used only in two places -- hence we update
them.

We also get access to proper Map view of keyed lists, which makes
a number of operations faster, as we can just defer to a lookup
instead of iterating of the entire list.

Finally features and build system is updated to not leak
javax.annotation and upstream bundles into runtime.

Change-Id: I78207959d9f62d79af83f57c859f5fbd393077aa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

MD-SAL API integration

Migrate all code to use MD-SAL APIs from the mdsal project, not controller.
Also remove dependencies on org.opendaylight.controller where not appropriate.

JIRA: OVSDB-487

Change-Id: I5ed9e800420887bc6b453f23eb77bcd54d9c27a9
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>

Enhance the McastMacsRemoteUpdateCommand to get the uuid from the device if not present in cache

This review is to :
1. Enhance the McastMacsRemoteUpdateCommand to get the uuid from the device if not present in cache
2. Minor refactors on the MacsCommands

Signed-off-by: Chandra Shekar S <chandra.shekar.s@ericsson.com>
Change-Id: I73f6114cacfd86c59301f098f4338125c32dc65d

make sure ovsdb connected node appears in operds

if the conected node does not appear in oper ds
disconnect the node, upon reconnection it may succeed in getting into
operds.

Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Change-Id: I1091e0a1a644141467e6d4bda5a058af60110a62
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>

Fix delete of Logical_Switch for the "referential integrity violation" failure.

Currently the Logical_Switch delete is failing with "referential integrity violation" error as listed below
2020-04-13T05:27:36,854 | ERROR | hwvtep-waiting-job-0 | TransactInvokerImpl              | 403 - org.opendaylight.ovsdb.hwvtepsouthbound-impl - 1.11.0.SNAPSHOT | HWVTEP transaction operation failed referential integrity violation cannot delete Logical_Switch row 7392ce5a-1bf6-4951-a22e-740ac78aaa60 because of 9 remaining reference(s)
2020-04-13T05:27:36,855 | ERROR | hwvtep-waiting-job-0 | TransactInvokerImpl              | 403 - org.opendaylight.ovsdb.hwvtepsouthbound-impl - 1.11.0.SNAPSHOT | Failed transaction delete from Logical_Switchdelete from Ucast_Macs_Remotedelete from Ucast_Macs_Localdelete from Mcast_Macs_Remotedelete from Mcast_Macs_Local
2020-04-13T05:27:36,856 | ERROR | hwvtep-waiting-job-0 | TransactInvokerImpl              | 403 - org.opendaylight.ovsdb.hwvtepsouthbound-impl - 1.11.0.SNAPSHOT | Failed on second attempt too aborting the transaction org.opendaylight.ovsdb.hwvtepsouthbound.transact.LogicalSwitchRemoveCommand$1@575aaf7c
2020-04-13T05:27:36,857 | ERROR | hwvtep-waiting-job-0 | TransactInvokerImpl              | 403 - org.opendaylight.ovsdb.hwvtepsouthbound-impl - 1.11.0.SNAPSHOT | HWVTEP transaction operation failed referential integrity violation cannot delete Logical_Switch row 064cc69b-cce8-4f08-9478-9b82c6059cac because of 9 remaining reference(s)
2020-04-13T05:27:36,858 | ERROR | hwvtep-waiting-job-0 | TransactInvokerImpl              | 403 - org.opendaylight.ovsdb.hwvtepsouthbound-impl - 1.11.0.SNAPSHOT | Failed transaction delete from Logical_Switchdelete from Ucast_Macs_Remotedelete from Ucast_Macs_Localdelete from Mcast_Macs_Remotedelete from Mcast_Macs_Local
2020-04-13T05:27:36,858 | ERROR | hwvtep-waiting-job-0 | TransactInvokerImpl              | 403 - org.opendaylight.ovsdb.hwvtepsouthbound-impl - 1.11.0.SNAPSHOT | Failed on second attempt too aborting the transaction org.opendaylight.ovsdb.hwvtepsouthbound.transact.LogicalSwitchRemoveCommand$1@569e133b

The Logical_Switch reference will be present in other tables like Ucast_Macs_Remote, Pysical_Port and Ucast_Macs_Remote etc.
These should be deleted first when the Logical_Switch is going to be deleted.

Signed-off-by: Chandra Shekar S <chandra.shekar.s@ericsson.com>
Change-Id: Ic2b101368bd50f6494e357fa49ccf53e641a09a3

NPE Exception while processing Interfaces

Description: Its been observed that if the port is created first
followed by setting the external-ids, the termination points are
not updated properly with is external-ids.

Changes are done to cache the bridge Identifier and refer this cache
during interface-update is obtained for the port.

Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Change-Id: I8e55733bccfa8dae013dda985678514e1ceb98d5
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>

Enhance the use of cache in HwvtepDeviceInfo

This review is to enhace the HwvtepDeviceInfo to use the Cache.
It has the following changes.
1. Enhanced to include the incoming update objects in the cache.
2. Check in the cache before deleting.
3. Update the cache when the updates are successfully submitted to db.

Signed-off-by: Chandra Shekar S <chandra.shekar.s@ericsson.com>
Change-Id: I70a923f2b58077e780b53c457b05bb2545a87d4f

Hwvtep minor refactor to getPhysicalLocator

Signed-off-by: Chandra Shekar S <chandra.shekar.s@ericsson.com>
Change-Id: I41147c1e6549c430572390cf0eee5d2a975de63c

Retry mechanism for Hwvtep failed Transaction commands

Signed-off-by: Chandra Shekar S <chandra.shekar.s@ericsson.com>
Change-Id: Ic15829836a316e1f21a0481089ae119cb38e60d1

Avoid push the stale vlan to tor.

If the ls is not present on the tor, don't push the vlan for that ls

Signed-off-by: Chandra Shekar S <chandra.shekar.s@ericsson.com>
Change-Id: I2362f33eacac3a8cf39fe8d9f1668ce7477f31ad