Refactor a few renderer RPCs

[transportpce.git] / renderer / src / main / java / org / opendaylight / transportpce / renderer / rpcs / ServicePathImpl.java

diff --git a/renderer/src/main/java/org/opendaylight/transportpce/renderer/rpcs/ServicePathImpl.java b/renderer/src/main/java/org/opendaylight/transportpce/renderer/rpcs/ServicePathImpl.java
index 52da3b560c7933bd31768611df26cafc521203d7..0bea07169f949785cf7865dfd8d2efc33a864b8b 100644 (file)
--- a/renderer/src/main/java/org/opendaylight/transportpce/renderer/rpcs/ServicePathImpl.java
+++ b/renderer/src/main/java/org/opendaylight/transportpce/renderer/rpcs/ServicePathImpl.java
@@ -50,22 +50,23 @@ public class ServicePathImpl implements ServicePath {
 
     @Override
     public ListenableFuture<RpcResult<ServicePathOutput>> invoke(ServicePathInput input) {
-        if (input.getOperation() != null) {
-            if (input.getOperation().getIntValue() == 1) {
+        if (input.getOperation() == null) {
+            LOG.debug("A mandatory input argument is null");
+            return RpcResultBuilder
+                .success(new ServicePathOutputBuilder().setResult("Invalid operation").build())
+                .buildFuture();
+        }
+        return switch (input.getOperation()) {
+            case Create -> {
                 LOG.info("Create operation request received");
-                return RpcResultBuilder.success(
-                        this.deviceRendererService.setupServicePath(input, null))
-                        .buildFuture();
-            } else if (input.getOperation().getIntValue() == 2) {
+                yield RpcResultBuilder.success(this.deviceRendererService.setupServicePath(input, null))
+                    .buildFuture();
+            }
+            case Delete -> {
                 LOG.info("Delete operation request received");
-                return RpcResultBuilder
-                        .success(this.deviceRendererService.deleteServicePath(input))
-                        .buildFuture();
+                yield RpcResultBuilder.success(this.deviceRendererService.deleteServicePath(input))
+                    .buildFuture();
             }
-        }
-        return RpcResultBuilder
-            .success(new ServicePathOutputBuilder().setResult("Invalid operation").build())
-            .buildFuture();
+        };
     }
-
 }