@Override
public ListenableFuture<RpcResult<CreateOtsOmsOutput>> invoke(CreateOtsOmsInput input) {
- LOG.info("Request received to create oms and ots interfaces on {}: {}", input.getNodeId(), input
- .getLogicalConnectionPoint());
+ LOG.info("Request received to create oms and ots interfaces on {}: {}",
+ input.getNodeId(), input.getLogicalConnectionPoint());
try {
return RpcResultBuilder.success(deviceRendererService.createOtsOms(input)).buildFuture();
} catch (OpenRoadmInterfaceException e) {
- LOG.error("failed to send request to create oms and ots interfaces on {}: {}", input.getNodeId(),
- input.getLogicalConnectionPoint(),e);
+ LOG.error("failed to send request to create oms and ots interfaces on {}: {}",
+ input.getNodeId(), input.getLogicalConnectionPoint(),e);
}
return RpcResultBuilder.<CreateOtsOmsOutput>failed()
.withError(ErrorType.RPC, "to create oms and ots interfaces")
@Override
public ListenableFuture<RpcResult<OtnServicePathOutput>> invoke(OtnServicePathInput input) {
- if (input.getOperation() != null && input.getServiceFormat() != null && input.getServiceRate() != null) {
- String serviceType = ServiceTypes.getOtnServiceType(input.getServiceFormat(), input.getServiceRate());
- if (input.getOperation().getIntValue() == 1) {
+ if (input.getOperation() == null || input.getServiceFormat() == null || input.getServiceRate() == null) {
+ LOG.debug("A mandatory input argument is null");
+ return RpcResultBuilder
+ .success(new OtnServicePathOutputBuilder().setResult("Invalid operation").build())
+ .buildFuture();
+ }
+ String serviceType = ServiceTypes.getOtnServiceType(input.getServiceFormat(), input.getServiceRate());
+ return switch (input.getOperation()) {
+ case Create -> {
LOG.info("Create operation request received");
- return RpcResultBuilder.success(this.otnDeviceRendererService
- .setupOtnServicePath(input, serviceType)).buildFuture();
- } else if (input.getOperation().getIntValue() == 2) {
+ yield RpcResultBuilder.success(this.otnDeviceRendererService
+ .setupOtnServicePath(input, serviceType)).buildFuture();
+ }
+ case Delete -> {
LOG.info("Delete operation request received");
- return RpcResultBuilder.success(this.otnDeviceRendererService
- .deleteOtnServicePath(input, serviceType)).buildFuture();
+ yield RpcResultBuilder.success(this.otnDeviceRendererService
+ .deleteOtnServicePath(input, serviceType)).buildFuture();
}
- }
- return RpcResultBuilder
- .success(new OtnServicePathOutputBuilder().setResult("Invalid operation").build())
- .buildFuture();
+ };
}
-
}
@Override
public ListenableFuture<RpcResult<ServicePathOutput>> invoke(ServicePathInput input) {
- if (input.getOperation() != null) {
- if (input.getOperation().getIntValue() == 1) {
+ if (input.getOperation() == null) {
+ LOG.debug("A mandatory input argument is null");
+ return RpcResultBuilder
+ .success(new ServicePathOutputBuilder().setResult("Invalid operation").build())
+ .buildFuture();
+ }
+ return switch (input.getOperation()) {
+ case Create -> {
LOG.info("Create operation request received");
- return RpcResultBuilder.success(
- this.deviceRendererService.setupServicePath(input, null))
- .buildFuture();
- } else if (input.getOperation().getIntValue() == 2) {
+ yield RpcResultBuilder.success(this.deviceRendererService.setupServicePath(input, null))
+ .buildFuture();
+ }
+ case Delete -> {
LOG.info("Delete operation request received");
- return RpcResultBuilder
- .success(this.deviceRendererService.deleteServicePath(input))
- .buildFuture();
+ yield RpcResultBuilder.success(this.deviceRendererService.deleteServicePath(input))
+ .buildFuture();
}
- }
- return RpcResultBuilder
- .success(new ServicePathOutputBuilder().setResult("Invalid operation").build())
- .buildFuture();
+ };
}
-
}