Code Review / controller.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 6a91a83) | patch
Do not use NPE for consistency checks 70/100770/2
authorRobert Varga <robert.varga@pantheon.tech>
Sun, 24 Apr 2022 08:37:29 +0000 (10:37 +0200)
committerRobert Varga <nite@hq.sk>
Sun, 24 Apr 2022 12:12:31 +0000 (12:12 +0000)
commit0547216019464e12d4d541e4b1ea95c7cc67e998
treed4affce17a75c50ef5a3974021b4147dda429f78tree | snapshot
parent6a91a831077f6447de37553d89eea1da161851b9commit | diff
Do not use NPE for consistency checks

We are using Preconditions.checkNotNull() when guarding against illegal
state. Improve this by using verifyNotNull(), which results in
VerifyException, making the intent clearer.

Also migrate a verify(foo != null) to a proper verifyNotNull(), using
the resoluting value.

Change-Id: I2689852d396315714f126743b70469ceef75ce45
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 8ca42ed047eae6e0407f2cca661b3f51dba7e219)
opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/LocalReadOnlyProxyTransaction.java diff | blob | history
opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/LocalReadWriteProxyTransaction.java diff | blob | history
OpenDaylight controller