Bug 737 - Refactor config-persister: clean up exception handling and netconf client. 79/6179/5
authorTomas Olvecky <tolvecky@cisco.com>
Fri, 31 Jan 2014 13:51:08 +0000 (14:51 +0100)
committerEd Warnicke <eaw@cisco.com>
Thu, 24 Apr 2014 23:20:02 +0000 (23:20 +0000)
commit520e8295a417cb9d4263e83fdeb745cbf1c963c0
tree490b0458e4a7ea0df067749fe0d85f85b3f3166f
parent43d928c088073735a26848a3658715ebfb6f8674
Bug 737 - Refactor config-persister: clean up exception handling and netconf client.

Split ConfigPersisterNotificationHandler into registrator and listener, remove unnecessary
reference to NetconfClient.
Refactor ConfigPusher: each method now returns computational results instead of void. Avoid
unnecessary NetconfClient reference leak - close it after every use. Rename generic 'timeout'
to 'maxWaitForCapabilitiesMillis'. Avoid throwing and catching SAXException and IOException
as there is no recovery from them; keep only ConflictingVersionException.
ConfigPersisterActivator now actually uses the configurable timeout, the property is renamed
from 'pushTimeout' to 'maxWaitForCapabilitiesMillis'.

Change-Id: Idc9995b11dd2f19a90598c88eb7337d39d63fc27
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/ConfigPersisterNotificationHandler.java
opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/ConfigPusher.java
opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/osgi/ConfigPersisterActivator.java
opendaylight/netconf/netconf-client/src/main/java/org/opendaylight/controller/netconf/client/NetconfClient.java
opendaylight/netconf/netconf-it/src/test/java/org/opendaylight/controller/netconf/it/NetconfConfigPersisterITTest.java