Bug 4560: Improve config system logging for debuggability 85/28985/4
authorTom Pantelis <tpanteli@brocade.com>
Thu, 29 Oct 2015 19:20:38 +0000 (15:20 -0400)
committerTom Pantelis <tpanteli@brocade.com>
Sat, 31 Oct 2015 08:47:00 +0000 (04:47 -0400)
commit818f2e0fdb8706f95de5411f45c1dc7d30e93e33
tree0e3ee51136b45b60fb31df9e8b8007fb143f645b
parent558dd40387dda53d2a9f5d884a3ccb61442798b1
Bug 4560: Improve config system logging for debuggability

When a config push fails, most of the exceptions that are thrown are
unchecked (like IllegalArgumentEx) and they aren't explicitly caught
so they propagate to the top-level ConfigPersisterActivator thread and
got printed to syserr. So I added a catch and logged to error.

I also added context to the logged message which outputs the xml file
name to aid in debugging issues.

I also added info logging when a config push starts and when it
successfully completes to further aid in debugging issues.

Change-Id: I3db9dcad3cba0abd58c045bc1047e08d6f19ccd3
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/ConfigPusherImpl.java
opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/osgi/ConfigPersisterActivator.java
opendaylight/netconf/config-persister-impl/src/test/java/org/opendaylight/controller/netconf/persist/impl/osgi/ConfigPersisterTest.java