PingPongDataBroker extends from ForwardingObject which forwards toString to the
delegate which is the ConcurrentDOMDataBroker. Unfortunately this hides the fact
that it's actually the PingPongDataBroker and has lead to confusion. Similar with the
BindingDOMDataBrokerAdapter. So I implemented toString to appropriately to refect the
true identity and forwarding nature of the classes.
Change-Id: I58b931590ca41bdb90bad31f6fedfe71466787ea
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
public class BindingDOMDataBrokerAdapter extends AbstractForwardedDataBroker implements DataBroker, DataTreeChangeService {
public class BindingDOMDataBrokerAdapter extends AbstractForwardedDataBroker implements DataBroker, DataTreeChangeService {
- static final Factory<DataBroker> BUILDER_FACTORY = new BindingDOMAdapterBuilder.Factory<DataBroker>() {
-
- @Override
- public BindingDOMAdapterBuilder<DataBroker> newBuilder() {
- return new Builder();
- }
-
- };
+ static final Factory<DataBroker> BUILDER_FACTORY = () -> new Builder();
private final DataTreeChangeService treeChangeService;
public BindingDOMDataBrokerAdapter(final DOMDataBroker domDataBroker, final BindingToNormalizedNodeCodec codec) {
private final DataTreeChangeService treeChangeService;
public BindingDOMDataBrokerAdapter(final DOMDataBroker domDataBroker, final BindingToNormalizedNodeCodec codec) {
return new BindingDOMTransactionChainAdapter(getDelegate(), getCodec(), listener);
}
return new BindingDOMTransactionChainAdapter(getDelegate(), getCodec(), listener);
}
+ @Override
+ public String toString() {
+ return "BindingDOMDataBrokerAdapter for " + getDelegate();
+ }
+
private static class Builder extends BindingDOMAdapterBuilder<DataBroker> {
@Override
private static class Builder extends BindingDOMAdapterBuilder<DataBroker> {
@Override
/**
* ThreadLocal used to detect if the task completion thread is running the future listener Runnables.
*/
/**
* ThreadLocal used to detect if the task completion thread is running the future listener Runnables.
*/
- private static final ThreadLocal<Boolean> ON_TASK_COMPLETION_THREAD_TL = new ThreadLocal<Boolean>();
+ private static final ThreadLocal<Boolean> ON_TASK_COMPLETION_THREAD_TL = new ThreadLocal<>();
private final Executor listenerExecutor;
private final Executor listenerExecutor;
throw new IllegalArgumentException("Unsupported data store type: " + datastoreType);
}
}
throw new IllegalArgumentException("Unsupported data store type: " + datastoreType);
}
}
+
+ @Override
+ public String toString() {
+ return "Clustered ConcurrentDOMDataBroker";
+ }
throw new UnsupportedOperationException("Delegate " + delegate + " does not support required functionality");
}
throw new UnsupportedOperationException("Delegate " + delegate + " does not support required functionality");
}
+
+ @Override
+ public String toString() {
+ return "PingPongDataBroker backed by " + delegate;
+ }